andreacavalli/xserver-multidpi
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
5115c2c721
xserver-multidpi/randr
History
Aaron Plattner b6c7b9b2f3 randr: check rotated virtual size limits correctly 
Commit d1107918d4 introduced checks to
the RandR path that cause RRSetScreenConfig requests to fail if the
size is too large.  Unfortunately, when RandR 1.1 rotation is enabled
it compares the rotated screen dimensions to the unrotated limits,
which causes 90- and 270-degree rotation to fail unless your screen
happens to be square:

  X Error of failed request:  BadValue (integer parameter out of range for operation)
    Major opcode of failed request:  153 (RANDR)
    Minor opcode of failed request:  2 (RRSetScreenConfig)
    Value in failed request:  0x780
    Serial number of failed request:  14
    Current serial number in output stream:  14

Fix this by moving the check above the code that swaps the dimensions
based on the rotation.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
Tested-by: Robert Hooker <robert.hooker@canonical.com>
Tested-by: Kent Baxley <kent.baxley@canonical.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
2011-05-25 09:44:52 -06:00
..
Makefile.am Revert "randr: Add sprite position transforms" 2011-02-23 11:18:12 -08:00
randr.c randr: Add RRConstrainCursorHarder 2011-03-14 13:35:51 -04:00
randrstr.h randr: Add RRConstrainCursorHarder 2011-03-14 13:35:51 -04:00
rrcrtc.c randr: Add RRConstrainCursorHarder 2011-03-14 13:35:51 -04:00
rrdispatch.c include: add version_compare helper function 2011-05-13 09:41:50 +10:00
rrinfo.c Revert "randr: Add per-crtc pixmaps" 2011-02-23 11:17:42 -08:00
rrmode.c ProcRRCreateMode: fix use of uninitialised bytes valgrind error. 2011-02-14 09:12:59 +10:00
rroutput.c randr: set error numbers of resource types in RRExtenstionInit() (V2) 2010-09-29 14:41:53 -07:00
rrpointer.c Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
rrproperty.c Remove unnecessary parentheses around return values in functions 2010-06-10 06:42:42 -07:00
rrscreen.c randr: check rotated virtual size limits correctly 2011-05-25 09:44:52 -06:00
rrsdispatch.c Revert "randr: Hook up the new RandR 1.4 functionality" 2011-02-23 11:17:36 -08:00
rrtransform.c Revert "randr: Add sprite position transforms" 2011-02-23 11:18:12 -08:00
rrtransform.h Revert "randr: Add sprite position transforms" 2011-02-23 11:18:12 -08:00
rrxinerama.c Move each screen's root-window pointer into ScreenRec. 2010-06-03 14:03:23 -07:00