xserver-multidpi/hw/xfree86/int10
Stephan Schreiber 36c18bb81b int10: fix pci_device_read_rom usage
I noticed that the build-in int10 driver always reports
"Unable to retrieve all of segment 0x0C0000."
even though the entire BIOS data is retrieved with success.

The associated code is in hw/xfree86/int10/generic.c, in the function
xf86ExtendedInitInt10():

    if (pci_device_read_rom(pInt->dev, vbiosMem) < V_BIOS_SIZE) {
        xf86DrvMsg(screen, X_WARNING,
                   "Unable to retrieve all of segment 0x0C0000.\n");
    }

The function pci_device_read_rom() is from libpciaccess; its return
value is not a size but an error status code: 0 means success.
If pci_device_read_rom() returns 0 for success, the warning is generated.

The proposed patch corrects the evaluation of the return value of
pci_device_read_rom() and of the supplied BIOS size.

Debian bug#686153

Signed-off-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Keith Packard <keithp@keithp.com>
2012-10-04 13:06:02 -07:00
..
generic.c int10: fix pci_device_read_rom usage 2012-10-04 13:06:02 -07:00
helper_exec.c api: rework the X server driver API to avoid global arrays. 2012-06-05 13:22:18 +01:00
helper_mem.c api: rework the X server driver API to avoid global arrays. 2012-06-05 13:22:18 +01:00
INT10.HOWTO Merging XORG-CURRENT into trunk 2004-04-23 19:54:30 +00:00
Makefile.am Record some additional library dependencies in xf86 modules 2010-06-10 19:01:22 -07:00
stub.c Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
x86emu.c Remove libcwrapper usage from xorg server modules. The libcwrapper is only 2006-02-10 22:00:30 +00:00
xf86int10.c api: rework the X server driver API to avoid global arrays. 2012-06-05 13:22:18 +01:00
xf86int10.h api: rework the X server driver API to avoid global arrays. 2012-06-05 13:22:18 +01:00
xf86int10module.c Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xf86x86emu.c Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xf86x86emu.h Remove RCS tags. Fix Xprint makefile braindamage. 2006-07-21 17:56:00 -04:00