tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve error log messages.

Browse Source 
GitOrigin-RevId: f43f89acaeb84898b076a3929eed08e927c1c392
This commit is contained in:
levlam 2019-04-18 17:47:37 +03:00
parent c37d0d98dd
commit 044a3a6f14
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
td/telegram/MessagesManager.cpp
View File

@ -3353,7 +3353,8 @@ class GetChannelDifferenceQuery : public Td::ResultHandler {
void on_error(uint64 id, Status status) override { void on_error(uint64 id, Status status) override {
if (!td->messages_manager_->on_get_dialog_error(dialog_id_, status, "GetChannelDifferenceQuery")) { if (!td->messages_manager_->on_get_dialog_error(dialog_id_, status, "GetChannelDifferenceQuery")) {
LOG(ERROR) << "Receive updates.getChannelDifference error for " << dialog_id_ << ": " << status; LOG(ERROR) << "Receive updates.getChannelDifference error for " << dialog_id_ << " with pts " << pts_
<< " and limit " << limit_ << ": " << status;
} }
td->messages_manager_->on_get_channel_difference(dialog_id_, pts_, limit_, nullptr); td->messages_manager_->on_get_channel_difference(dialog_id_, pts_, limit_, nullptr);
} }
@ -9956,8 +9957,8 @@ FullMessageId MessagesManager::on_get_message(MessageInfo &&message_info, bool f
if (!from_update) { if (!from_update) {
LOG_IF(ERROR, message_id.get() <= d->last_new_message_id.get()) LOG_IF(ERROR, message_id.get() <= d->last_new_message_id.get())
<< "New " << message_id << " has id less than last_new_message_id = " << d->last_new_message_id; << "New " << message_id << " has id less than last_new_message_id = " << d->last_new_message_id;
LOG(ERROR) << "Ignore " << it->second << " received not through update from " << source << ": " LOG(ERROR) << "Ignore " << it->second << "/" << message_id << " received not through update from " << source
<< oneline(to_string(get_message_object(dialog_id, new_message.get()))); // TODO move to INFO << ": " << oneline(to_string(get_message_object(dialog_id, new_message.get()))); // TODO move to INFO
dump_debug_message_op(d, 3); // TODO remove dump_debug_message_op(d, 3); // TODO remove
if (dialog_id.get_type() == DialogType::Channel && have_input_peer(dialog_id, AccessRights::Read)) { if (dialog_id.get_type() == DialogType::Channel && have_input_peer(dialog_id, AccessRights::Read)) {
channel_get_difference_retry_timeout_.add_timeout_in(dialog_id.get(), 0.001); channel_get_difference_retry_timeout_.add_timeout_in(dialog_id.get(), 0.001);
@ -23341,7 +23342,7 @@ bool MessagesManager::update_message(Dialog *d, unique_ptr<Message> &old_message
if (old_message->contains_mention != new_message->contains_mention) { if (old_message->contains_mention != new_message->contains_mention) {
LOG_IF(ERROR, old_message->edit_date == 0) LOG_IF(ERROR, old_message->edit_date == 0)
<< message_id << " in " << dialog_id << " has changed contains_mention from " << old_message->contains_mention << message_id << " in " << dialog_id << " has changed contains_mention from " << old_message->contains_mention
<< " to " << new_message->contains_mention; << " to " << new_message->contains_mention << ", is_outgoing = " << old_message->is_outgoing;
// contains_mention flag shouldn't be changed, because the message will not be added to unread mention list // contains_mention flag shouldn't be changed, because the message will not be added to unread mention list
// and we are unable to show/hide message notification // and we are unable to show/hide message notification
// old_message->contains_mention = new_message->contains_mention; // old_message->contains_mention = new_message->contains_mention;