tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add various checks.

Browse Source
This commit is contained in:
levlam 2023-07-23 01:41:59 +03:00
parent 2f4b8ba8b3
commit 451c559539
5 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
td/telegram/ContactsManager.cpp
View File

@ -6990,6 +6990,7 @@ void ContactsManager::set_close_friends(vector<UserId> user_ids, Promise<Unit> &
void ContactsManager::on_set_close_friends(const vector<UserId> &user_ids, Promise<Unit> &&promise) {
FlatHashSet<UserId, UserIdHash> close_friend_user_ids;
for (auto &user_id : user_ids) {
CHECK(user_id.is_valid());
close_friend_user_ids.insert(user_id);
}
users_.foreach([&](const UserId &user_id, unique_ptr<User> &user) {

7
td/telegram/MessageContent.cpp
View File

@ -1866,6 +1866,9 @@ static void parse(unique_ptr<MessageContent> &content, ParserT &parser) {
PARSE_FLAG(m->via_mention);
END_PARSE_FLAGS();
parse(m->story_full_id, parser);
if (!m->story_full_id.is_valid()) {
is_bad = true;
}
content = std::move(m);
break;
}
@ -5017,11 +5020,11 @@ unique_ptr<MessageContent> get_message_content(Td *td, FormattedText message,
auto media = move_tl_object_as<telegram_api::messageMediaStory>(media_ptr);
auto dialog_id = DialogId(UserId(media->user_id_));
auto story_id = StoryId(media->id_);
if (!dialog_id.is_valid() || !story_id.is_valid()) {
auto story_full_id = StoryFullId(dialog_id, story_id);
if (!story_full_id.is_valid()) {
LOG(ERROR) << "Receive " << to_string(media);
break;
}
auto story_full_id = StoryFullId(dialog_id, story_id);
if (media->story_ != nullptr) {
auto actual_story_id = td->story_manager_->on_get_story(dialog_id, std::move(media->story_));
if (story_id != actual_story_id) {

2
td/telegram/MessagesManager.cpp
View File

@ -38223,6 +38223,7 @@ void MessagesManager::update_expected_channel_pts(DialogId dialog_id, int32 expe
if (expected_pts <= 0) {
return;
}
CHECK(dialog_id.is_valid());
auto &old_pts = expected_channel_pts_[dialog_id];
if (old_pts < expected_pts) {
old_pts = expected_pts;
@ -38233,6 +38234,7 @@ void MessagesManager::update_expected_channel_max_message_id(DialogId dialog_id,
if (expected_max_message_id == MessageId() || td_->auth_manager_->is_bot()) {
return;
}
CHECK(dialog_id.is_valid());
auto &old_max_message_id = expected_channel_max_message_id_[dialog_id];
if (old_max_message_id < expected_max_message_id) {
old_max_message_id = expected_max_message_id;

15
td/telegram/StoryManager.cpp
View File

@ -1038,6 +1038,7 @@ void StoryManager::on_story_expire_timeout(int64 story_global_id) {
LOG(INFO) << "Have expired " << story_full_id;
auto owner_dialog_id = story_full_id.get_dialog_id();
CHECK(owner_dialog_id.is_valid());
if (!is_story_owned(owner_dialog_id) && story->content_ != nullptr && !story->is_pinned_) {
// non-owned expired non-pinned stories are fully deleted
on_delete_story(story_full_id);
@ -1268,7 +1269,8 @@ StoryManager::ActiveStories *StoryManager::get_active_stories_force(DialogId own
return active_stories;
}
if (!G()->use_message_database() || failed_to_load_active_stories_.count(owner_dialog_id) > 0) {
if (!G()->use_message_database() || failed_to_load_active_stories_.count(owner_dialog_id) > 0 ||
!owner_dialog_id.is_valid()) {
return nullptr;
}
@ -1575,11 +1577,13 @@ void StoryManager::save_story_list(StoryListId story_list_id, string state, int3
StoryManager::StoryList &StoryManager::get_story_list(StoryListId story_list_id) {
CHECK(!td_->auth_manager_->is_bot());
CHECK(story_list_id.is_valid());
return story_lists_[story_list_id == StoryListId::archive()];
}
const StoryManager::StoryList &StoryManager::get_story_list(StoryListId story_list_id) const {
CHECK(!td_->auth_manager_->is_bot());
CHECK(story_list_id.is_valid());
return story_lists_[story_list_id == StoryListId::archive()];
}
@ -1594,7 +1598,6 @@ void StoryManager::update_story_list_sent_total_count(StoryListId story_list_id)
if (td_->auth_manager_->is_bot()) {
return;
}
CHECK(story_list_id.is_valid());
update_story_list_sent_total_count(story_list_id, get_story_list(story_list_id));
}
@ -2239,6 +2242,7 @@ void StoryManager::register_story(StoryFullId story_full_id, FullMessageId full_
if (td_->auth_manager_->is_bot()) {
return;
}
CHECK(story_full_id.is_valid());
LOG(INFO) << "Register " << story_full_id << " from " << full_message_id << " from " << source;
story_messages_[story_full_id].insert(full_message_id);
@ -2248,6 +2252,7 @@ void StoryManager::unregister_story(StoryFullId story_full_id, FullMessageId ful
if (td_->auth_manager_->is_bot()) {
return;
}
CHECK(story_full_id.is_valid());
LOG(INFO) << "Unregister " << story_full_id << " from " << full_message_id << " from " << source;
auto &message_ids = story_messages_[story_full_id];
auto is_deleted = message_ids.erase(full_message_id) > 0;
@ -2877,6 +2882,7 @@ DialogId StoryManager::on_get_user_stories(DialogId owner_dialog_id,
void StoryManager::on_update_active_stories(DialogId owner_dialog_id, StoryId max_read_story_id,
vector<StoryId> &&story_ids, Promise<Unit> &&promise, bool from_database) {
CHECK(owner_dialog_id.is_valid());
if (td::remove_if(story_ids, [&](StoryId story_id) {
if (!story_id.is_server()) {
return true;
@ -3209,9 +3215,7 @@ FileSourceId StoryManager::get_story_file_source_id(StoryFullId story_full_id) {
return FileSourceId();
}
auto dialog_id = story_full_id.get_dialog_id();
auto story_id = story_full_id.get_story_id();
if (!dialog_id.is_valid() || !story_id.is_valid()) {
if (!story_full_id.is_valid()) {
return FileSourceId();
}
@ -3774,6 +3778,7 @@ uint64 StoryManager::save_delete_story_on_server_log_event(StoryFullId story_ful
void StoryManager::delete_story_on_server(StoryFullId story_full_id, uint64 log_event_id, Promise<Unit> &&promise) {
LOG(INFO) << "Delete " << story_full_id << " from server";
CHECK(story_full_id.is_valid());
if (log_event_id == 0) {
log_event_id = save_delete_story_on_server_log_event(story_full_id);

4
td/telegram/WebPagesManager.cpp
View File

@ -546,11 +546,11 @@ WebPageId WebPagesManager::on_get_web_page(tl_object_ptr<telegram_api::WebPage>
auto attribute = telegram_api::move_object_as<telegram_api::webPageAttributeStory>(attribute_ptr);
auto dialog_id = DialogId(UserId(attribute->user_id_));
auto story_id = StoryId(attribute->id_);
if (!dialog_id.is_valid() || !story_id.is_valid()) {
auto story_full_id = StoryFullId(dialog_id, story_id);
if (!story_full_id.is_valid()) {
LOG(ERROR) << "Receive " << to_string(attribute);
break;
}
auto story_full_id = StoryFullId(dialog_id, story_id);
if (attribute->story_ != nullptr) {
auto actual_story_id = td_->story_manager_->on_get_story(dialog_id, std::move(attribute->story_));
if (story_id != actual_story_id) {