tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix and improve create_openssl_error.

Browse Source 
GitOrigin-RevId: 039a5da5f3b2f4aafbf60ca541699f3e47fbb6b5
This commit is contained in:
levlam 2018-08-28 02:06:56 +03:00
parent f9cbe247cd
commit 754252f220
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tdnet/td/net/SslStream.cpp
View File

@ -140,15 +140,19 @@ int verify_callback(int preverify_ok, X509_STORE_CTX *ctx) {
} }
Status create_openssl_error(int code, Slice message) { Status create_openssl_error(int code, Slice message) {
const int buf_size = 1 << 12; const int max_result_size = 1 << 12;
auto buf = StackAllocator::alloc(buf_size); auto result = StackAllocator::alloc(max_result_size);
StringBuilder sb(buf.as_slice()); StringBuilder sb(result.as_slice());
sb << message; sb << message;
while (unsigned long error_code = ERR_get_error()) { while (unsigned long error_code = ERR_get_error()) {
sb << "{" << error_code << ", " << ERR_error_string(error_code, nullptr) << "}"; char error_buf[1024];
ERR_error_string_n(error_code, error_buf, sizeof(error_buf));
Slice error(error_buf, std::strlen(error_buf));
LOG_IF(ERROR, ends_with(error, "internal error")) << "OpenSSL internal error: " << error;
sb << "{" << error << "}";
} }
LOG_IF(ERROR, sb.is_error()) << "OPENSSL error buffer overflow"; LOG_IF(ERROR, sb.is_error()) << "OpenSSL error buffer overflow";
return Status::Error(code, sb.as_cslice()); return Status::Error(code, sb.as_cslice());
} }