From 800660aec6e43ae57136024a82b8514432d1ac57 Mon Sep 17 00:00:00 2001
From: levlam <levlam@telegram.org>
Date: Mon, 21 Aug 2023 22:16:42 +0300
Subject: [PATCH] Update NotificationGroupInfo.is_key_changed_ only if needed.

---
 td/telegram/NotificationGroupInfo.cpp | 16 ++++++++--------
 td/telegram/NotificationGroupInfo.h   | 12 ++++++------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/td/telegram/NotificationGroupInfo.cpp b/td/telegram/NotificationGroupInfo.cpp
index aaf337b0c..439aa7f8a 100644
--- a/td/telegram/NotificationGroupInfo.cpp
+++ b/td/telegram/NotificationGroupInfo.cpp
@@ -21,9 +21,11 @@ bool NotificationGroupInfo::set_last_notification(int32 last_notification_date,
   if (last_notification_date_ != last_notification_date || last_notification_id_ != last_notification_id) {
     VLOG(notifications) << "Set " << group_id_ << " last notification to " << last_notification_id << " sent at "
                         << last_notification_date << " from " << source;
-    last_notification_date_ = last_notification_date;
+    if (last_notification_date_ != last_notification_date) {
+      last_notification_date_ = last_notification_date;
+      is_key_changed_ = true;
+    }
     last_notification_id_ = last_notification_id;
-    is_changed_ = true;
     return true;
   }
   return false;
@@ -43,7 +45,6 @@ bool NotificationGroupInfo::set_max_removed_notification_id(NotificationId max_r
   VLOG(notifications) << "Set max_removed_notification_id in " << group_id_ << " to " << max_removed_notification_id
                       << " from " << source;
   max_removed_notification_id_ = max_removed_notification_id;
-  is_changed_ = true;
 
   return true;
 }
@@ -56,7 +57,6 @@ void NotificationGroupInfo::drop_max_removed_notification_id() {
   VLOG(notifications) << "Drop max_removed_notification_id in " << group_id_;
   max_removed_message_id_ = MessageId();
   max_removed_notification_id_ = NotificationId();
-  is_changed_ = true;
 }
 
 bool NotificationGroupInfo::is_removed_notification(NotificationId notification_id, MessageId message_id) const {
@@ -81,15 +81,15 @@ void NotificationGroupInfo::try_reuse() {
   CHECK(last_notification_date_ == 0);
   if (!try_reuse_) {
     try_reuse_ = true;
-    is_changed_ = true;
+    is_key_changed_ = true;
   }
 }
 
 void NotificationGroupInfo::add_group_key_if_changed(vector<NotificationGroupKey> &group_keys, DialogId dialog_id) {
-  if (!is_changed_) {
+  if (!is_key_changed_) {
     return;
   }
-  is_changed_ = false;
+  is_key_changed_ = false;
 
   group_keys.emplace_back(group_id_, try_reuse_ ? DialogId() : dialog_id, last_notification_date_);
 }
@@ -98,7 +98,7 @@ NotificationGroupId NotificationGroupInfo::get_reused_group_id() {
   if (!try_reuse_) {
     return {};
   }
-  if (is_changed_) {
+  if (is_key_changed_) {
     LOG(ERROR) << "Failed to reuse changed " << group_id_;
     return {};
   }
diff --git a/td/telegram/NotificationGroupInfo.h b/td/telegram/NotificationGroupInfo.h
index eac83ccc4..81163da9a 100644
--- a/td/telegram/NotificationGroupInfo.h
+++ b/td/telegram/NotificationGroupInfo.h
@@ -16,20 +16,20 @@ namespace td {
 
 class NotificationGroupInfo {
   NotificationId max_removed_notification_id_;  // notification identifier, up to which all notifications are removed
-  MessageId max_removed_message_id_;  // message identifier, up to which all notifications are removed
-  bool is_changed_ = false;           // true, if the group needs to be saved to database
-  bool try_reuse_ = false;            // true, if the group needs to be deleted from database and tried to be reused
+  MessageId max_removed_message_id_;            // message identifier, up to which all notifications are removed
+  bool is_key_changed_ = false;                 // true, if the group needs to be saved to database
+  bool try_reuse_ = false;  // true, if the group needs to be deleted from database and tried to be reused
 
   friend StringBuilder &operator<<(StringBuilder &string_builder, const NotificationGroupInfo &group_info);
 
  public:
   NotificationGroupId group_id_;
-  int32 last_notification_date_ = 0;            // date of last notification in the group
-  NotificationId last_notification_id_;         // identifier of last notification in the group
+  int32 last_notification_date_ = 0;     // date of last notification in the group
+  NotificationId last_notification_id_;  // identifier of last notification in the group
 
   NotificationGroupInfo() = default;
 
-  explicit NotificationGroupInfo(NotificationGroupId group_id) : group_id_(group_id), is_changed_(true) {
+  explicit NotificationGroupInfo(NotificationGroupId group_id) : group_id_(group_id), is_key_changed_(true) {
   }
 
   bool is_active() const {