diff --git a/td/telegram/MessagesDb.cpp b/td/telegram/MessagesDb.cpp index 1c2c4d444..0b59e46b6 100644 --- a/td/telegram/MessagesDb.cpp +++ b/td/telegram/MessagesDb.cpp @@ -436,7 +436,7 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return Status::OK(); } - Result get_message(FullMessageId full_message_id) final { + Result get_message(FullMessageId full_message_id) final { auto dialog_id = full_message_id.get_dialog_id(); auto message_id = full_message_id.get_message_id(); CHECK(dialog_id.is_valid()); @@ -459,7 +459,7 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { if (!stmt.has_row()) { return Status::Error("Not found"); } - return BufferSlice(stmt.view_blob(0)); + return MessagesDbDialogMessage{BufferSlice(stmt.view_blob(0))}; } Result get_message_by_unique_message_id(ServerMessageId unique_message_id) final { @@ -478,7 +478,7 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return MessagesDbMessage{dialog_id, BufferSlice(get_message_by_unique_message_id_stmt_.view_blob(1))}; } - Result get_message_by_random_id(DialogId dialog_id, int64 random_id) final { + Result get_message_by_random_id(DialogId dialog_id, int64 random_id) final { SCOPE_EXIT { get_message_by_random_id_stmt_.reset(); }; @@ -488,11 +488,11 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { if (!get_message_by_random_id_stmt_.has_row()) { return Status::Error("Not found"); } - return BufferSlice(get_message_by_random_id_stmt_.view_blob(0)); + return MessagesDbDialogMessage{BufferSlice(get_message_by_random_id_stmt_.view_blob(0))}; } - Result get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, - MessageId last_message_id, int32 date) final { + Result get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, + MessageId last_message_id, int32 date) final { int64 left_message_id = first_message_id.get(); int64 right_message_id = last_message_id.get(); LOG_CHECK(left_message_id <= right_message_id) << first_message_id << " " << last_message_id; @@ -554,14 +554,14 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return Status::Error("Not found"); } - Result, int32>> get_expiring_messages(int32 expires_from, int32 expires_till, - int32 limit) final { + Result, int32>> get_expiring_messages(int32 expires_from, int32 expires_till, + int32 limit) final { SCOPE_EXIT { get_expiring_messages_stmt_.reset(); get_expiring_messages_helper_stmt_.reset(); }; - std::vector messages; + vector messages; // load messages if (expires_from <= expires_till) { get_expiring_messages_stmt_.bind_int32(1, expires_from).ensure(); @@ -589,7 +589,7 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return std::make_pair(std::move(messages), next_expires_till); } - Result> get_messages(MessagesDbMessagesQuery query) final { + Result> get_messages(MessagesDbMessagesQuery query) final { if (query.index_mask != 0) { return get_messages_from_index(query.dialog_id, query.from_message_id, query.index_mask, query.offset, query.limit); @@ -597,12 +597,13 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return get_messages_impl(get_messages_stmt_, query.dialog_id, query.from_message_id, query.offset, query.limit); } - Result> get_scheduled_messages(DialogId dialog_id, int32 limit) final { + Result> get_scheduled_messages(DialogId dialog_id, int32 limit) final { return get_messages_inner(get_scheduled_messages_stmt_, dialog_id, std::numeric_limits::max(), limit); } - Result> get_messages_from_notification_id(DialogId dialog_id, NotificationId from_notification_id, - int32 limit) final { + Result> get_messages_from_notification_id(DialogId dialog_id, + NotificationId from_notification_id, + int32 limit) final { auto &stmt = get_messages_from_notification_id_stmt_; SCOPE_EXIT { stmt.reset(); @@ -611,11 +612,11 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { stmt.bind_int32(2, from_notification_id.get()).ensure(); stmt.bind_int32(3, limit).ensure(); - std::vector result; + vector result; stmt.step().ensure(); while (stmt.has_row()) { auto data_slice = stmt.view_blob(0); - result.emplace_back(data_slice); + result.push_back(MessagesDbDialogMessage{BufferSlice(data_slice)}); auto message_id = stmt.view_int64(1); LOG(INFO) << "Load " << MessageId(message_id) << " in " << dialog_id << " from database"; stmt.step().ensure(); @@ -724,8 +725,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return std::move(result); } - Result> get_messages_from_index(DialogId dialog_id, MessageId from_message_id, - int32 index_mask, int32 offset, int32 limit) { + Result> get_messages_from_index(DialogId dialog_id, MessageId from_message_id, + int32 index_mask, int32 offset, int32 limit) { CHECK(index_mask != 0); LOG_CHECK(index_mask < (1 << MESSAGES_DB_INDEX_COUNT)) << tag("index_mask", index_mask); int index_i = -1; @@ -825,8 +826,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { SqliteStatement delete_scheduled_message_stmt_; SqliteStatement delete_scheduled_server_message_stmt_; - Result> get_messages_impl(GetMessagesStmt &stmt, DialogId dialog_id, - MessageId from_message_id, int32 offset, int32 limit) { + Result> get_messages_impl(GetMessagesStmt &stmt, DialogId dialog_id, + MessageId from_message_id, int32 offset, int32 limit) { LOG_CHECK(dialog_id.is_valid()) << dialog_id; CHECK(from_message_id.is_valid()); @@ -845,8 +846,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { auto right_message_id = message_id - 1; auto right_cnt = -offset; - std::vector left; - std::vector right; + vector left; + vector right; if (left_cnt != 0) { if (right_cnt == 1 && false) { @@ -877,8 +878,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return std::move(right); } - Result> get_messages_inner(SqliteStatement &stmt, DialogId dialog_id, int64 from_message_id, - int32 limit) { + Result> get_messages_inner(SqliteStatement &stmt, DialogId dialog_id, + int64 from_message_id, int32 limit) { SCOPE_EXIT { stmt.reset(); }; @@ -888,11 +889,11 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { LOG(INFO) << "Begin to load " << limit << " messages in " << dialog_id << " from " << MessageId(from_message_id) << " from database"; - std::vector result; + vector result; stmt.step().ensure(); while (stmt.has_row()) { auto data_slice = stmt.view_blob(0); - result.emplace_back(data_slice); + result.push_back(MessagesDbDialogMessage{BufferSlice(data_slice)}); auto message_id = stmt.view_int64(1); LOG(INFO) << "Loaded " << MessageId(message_id) << " in " << dialog_id << " from database"; stmt.step().ensure(); @@ -900,8 +901,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface { return std::move(result); } - static std::tuple get_message_info(const BufferSlice &message) { - LogEventParser message_date_parser(message.as_slice()); + static std::tuple get_message_info(const MessagesDbDialogMessage &message) { + LogEventParser message_date_parser(message.data.as_slice()); int32 flags; td::parse(flags, message_date_parser); int32 flags2 = 0; @@ -969,29 +970,29 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { send_closure_later(impl_, &Impl::delete_dialog_messages_from_user, dialog_id, sender_user_id, std::move(promise)); } - void get_message(FullMessageId full_message_id, Promise promise) final { + void get_message(FullMessageId full_message_id, Promise promise) final { send_closure_later(impl_, &Impl::get_message, full_message_id, std::move(promise)); } void get_message_by_unique_message_id(ServerMessageId unique_message_id, Promise promise) final { send_closure_later(impl_, &Impl::get_message_by_unique_message_id, unique_message_id, std::move(promise)); } - void get_message_by_random_id(DialogId dialog_id, int64 random_id, Promise promise) final { + void get_message_by_random_id(DialogId dialog_id, int64 random_id, Promise promise) final { send_closure_later(impl_, &Impl::get_message_by_random_id, dialog_id, random_id, std::move(promise)); } void get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, MessageId last_message_id, int32 date, - Promise promise) final { + Promise promise) final { send_closure_later(impl_, &Impl::get_dialog_message_by_date, dialog_id, first_message_id, last_message_id, date, std::move(promise)); } - void get_messages(MessagesDbMessagesQuery query, Promise> promise) final { + void get_messages(MessagesDbMessagesQuery query, Promise> promise) final { send_closure_later(impl_, &Impl::get_messages, std::move(query), std::move(promise)); } - void get_scheduled_messages(DialogId dialog_id, int32 limit, Promise> promise) final { + void get_scheduled_messages(DialogId dialog_id, int32 limit, Promise> promise) final { send_closure_later(impl_, &Impl::get_scheduled_messages, dialog_id, limit, std::move(promise)); } void get_messages_from_notification_id(DialogId dialog_id, NotificationId from_notification_id, int32 limit, - Promise> promise) final { + Promise> promise) final { send_closure_later(impl_, &Impl::get_messages_from_notification_id, dialog_id, from_notification_id, limit, std::move(promise)); } @@ -1002,7 +1003,7 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { send_closure_later(impl_, &Impl::get_messages_fts, std::move(query), std::move(promise)); } void get_expiring_messages(int32 expires_from, int32 expires_till, int32 limit, - Promise, int32>> promise) final { + Promise, int32>> promise) final { send_closure_later(impl_, &Impl::get_expiring_messages, expires_from, expires_till, limit, std::move(promise)); } @@ -1057,7 +1058,7 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { promise.set_result(sync_db_->delete_dialog_messages_from_user(dialog_id, sender_user_id)); } - void get_message(FullMessageId full_message_id, Promise promise) { + void get_message(FullMessageId full_message_id, Promise promise) { add_read_query(); promise.set_result(sync_db_->get_message(full_message_id)); } @@ -1065,26 +1066,26 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { add_read_query(); promise.set_result(sync_db_->get_message_by_unique_message_id(unique_message_id)); } - void get_message_by_random_id(DialogId dialog_id, int64 random_id, Promise promise) { + void get_message_by_random_id(DialogId dialog_id, int64 random_id, Promise promise) { add_read_query(); promise.set_result(sync_db_->get_message_by_random_id(dialog_id, random_id)); } void get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, MessageId last_message_id, - int32 date, Promise promise) { + int32 date, Promise promise) { add_read_query(); promise.set_result(sync_db_->get_dialog_message_by_date(dialog_id, first_message_id, last_message_id, date)); } - void get_messages(MessagesDbMessagesQuery query, Promise> promise) { + void get_messages(MessagesDbMessagesQuery query, Promise> promise) { add_read_query(); promise.set_result(sync_db_->get_messages(std::move(query))); } - void get_scheduled_messages(DialogId dialog_id, int32 limit, Promise> promise) { + void get_scheduled_messages(DialogId dialog_id, int32 limit, Promise> promise) { add_read_query(); promise.set_result(sync_db_->get_scheduled_messages(dialog_id, limit)); } void get_messages_from_notification_id(DialogId dialog_id, NotificationId from_notification_id, int32 limit, - Promise> promise) { + Promise> promise) { add_read_query(); promise.set_result(sync_db_->get_messages_from_notification_id(dialog_id, from_notification_id, limit)); } @@ -1097,7 +1098,7 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { promise.set_result(sync_db_->get_messages_fts(std::move(query))); } void get_expiring_messages(int32 expires_from, int32 expires_till, int32 limit, - Promise, int32>> promise) { + Promise, int32>> promise) { add_read_query(); promise.set_result(sync_db_->get_expiring_messages(expires_from, expires_till, limit)); } @@ -1123,8 +1124,8 @@ class MessagesDbAsync final : public MessagesDbAsyncInterface { static constexpr double MAX_PENDING_QUERIES_DELAY{0.01}; //NB: order is important, destructor of pending_writes_ will change pending_write_results_ - std::vector, Status>> pending_write_results_; - std::vector> pending_writes_; + vector, Status>> pending_write_results_; + vector> pending_writes_; double wakeup_at_ = 0; template void add_write_query(F &&f) { diff --git a/td/telegram/MessagesDb.h b/td/telegram/MessagesDb.h index 47fa54b24..e10967527 100644 --- a/td/telegram/MessagesDb.h +++ b/td/telegram/MessagesDb.h @@ -34,6 +34,10 @@ struct MessagesDbMessagesQuery { int32 limit{100}; }; +struct MessagesDbDialogMessage { + BufferSlice data; +}; + struct MessagesDbMessage { DialogId dialog_id; BufferSlice data; @@ -47,7 +51,7 @@ struct MessagesDbFtsQuery { int32 limit{100}; }; struct MessagesDbFtsResult { - std::vector messages; + vector messages; int64 next_search_id{1}; }; @@ -57,7 +61,7 @@ struct MessagesDbCallsQuery { int32 limit{100}; }; struct MessagesDbCallsResult { - std::vector messages; + vector messages; }; class MessagesDbSyncInterface { @@ -76,21 +80,21 @@ class MessagesDbSyncInterface { virtual Status delete_all_dialog_messages(DialogId dialog_id, MessageId from_message_id) = 0; virtual Status delete_dialog_messages_from_user(DialogId dialog_id, UserId sender_user_id) = 0; - virtual Result get_message(FullMessageId full_message_id) = 0; + virtual Result get_message(FullMessageId full_message_id) = 0; virtual Result get_message_by_unique_message_id(ServerMessageId unique_message_id) = 0; - virtual Result get_message_by_random_id(DialogId dialog_id, int64 random_id) = 0; - virtual Result get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, - MessageId last_message_id, int32 date) = 0; + virtual Result get_message_by_random_id(DialogId dialog_id, int64 random_id) = 0; + virtual Result get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, + MessageId last_message_id, int32 date) = 0; - virtual Result> get_messages(MessagesDbMessagesQuery query) = 0; - virtual Result> get_scheduled_messages(DialogId dialog_id, int32 limit) = 0; - virtual Result> get_messages_from_notification_id(DialogId dialog_id, - NotificationId from_notification_id, - int32 limit) = 0; + virtual Result> get_messages(MessagesDbMessagesQuery query) = 0; + virtual Result> get_scheduled_messages(DialogId dialog_id, int32 limit) = 0; + virtual Result> get_messages_from_notification_id(DialogId dialog_id, + NotificationId from_notification_id, + int32 limit) = 0; - virtual Result, int32>> get_expiring_messages(int32 expires_from, - int32 expires_till, - int32 limit) = 0; + virtual Result, int32>> get_expiring_messages(int32 expires_from, + int32 expires_till, + int32 limit) = 0; virtual Result get_calls(MessagesDbCallsQuery query) = 0; virtual Result get_messages_fts(MessagesDbFtsQuery query) = 0; @@ -125,23 +129,25 @@ class MessagesDbAsyncInterface { virtual void delete_all_dialog_messages(DialogId dialog_id, MessageId from_message_id, Promise<> promise) = 0; virtual void delete_dialog_messages_from_user(DialogId dialog_id, UserId sender_user_id, Promise<> promise) = 0; - virtual void get_message(FullMessageId full_message_id, Promise promise) = 0; + virtual void get_message(FullMessageId full_message_id, Promise promise) = 0; virtual void get_message_by_unique_message_id(ServerMessageId unique_message_id, Promise promise) = 0; - virtual void get_message_by_random_id(DialogId dialog_id, int64 random_id, Promise promise) = 0; + virtual void get_message_by_random_id(DialogId dialog_id, int64 random_id, + Promise promise) = 0; virtual void get_dialog_message_by_date(DialogId dialog_id, MessageId first_message_id, MessageId last_message_id, - int32 date, Promise promise) = 0; + int32 date, Promise promise) = 0; - virtual void get_messages(MessagesDbMessagesQuery query, Promise> promise) = 0; - virtual void get_scheduled_messages(DialogId dialog_id, int32 limit, Promise> promise) = 0; + virtual void get_messages(MessagesDbMessagesQuery query, Promise> promise) = 0; + virtual void get_scheduled_messages(DialogId dialog_id, int32 limit, + Promise> promise) = 0; virtual void get_messages_from_notification_id(DialogId dialog_id, NotificationId from_notification_id, int32 limit, - Promise> promise) = 0; + Promise> promise) = 0; virtual void get_calls(MessagesDbCallsQuery, Promise promise) = 0; virtual void get_messages_fts(MessagesDbFtsQuery query, Promise promise) = 0; virtual void get_expiring_messages(int32 expires_from, int32 expires_till, int32 limit, - Promise, int32>> promise) = 0; + Promise, int32>> promise) = 0; virtual void close(Promise<> promise) = 0; virtual void force_flush() = 0; diff --git a/td/telegram/MessagesManager.cpp b/td/telegram/MessagesManager.cpp index 1e6044e20..e4084cc95 100644 --- a/td/telegram/MessagesManager.cpp +++ b/td/telegram/MessagesManager.cpp @@ -19830,7 +19830,7 @@ void MessagesManager::open_dialog(Dialog *d) { d->is_has_scheduled_database_messages_checked = true; G()->td_db()->get_messages_db_async()->get_scheduled_messages( dialog_id, 1, - PromiseCreator::lambda([dialog_id, actor_id = actor_id(this)](std::vector messages) { + PromiseCreator::lambda([dialog_id, actor_id = actor_id(this)](vector messages) { if (messages.empty()) { send_closure(actor_id, &MessagesManager::set_dialog_has_scheduled_database_messages, dialog_id, false); } @@ -21187,7 +21187,7 @@ std::pair> MessagesManager::search_dialog_messages( << " and with limit " << limit; auto new_promise = PromiseCreator::lambda( [random_id, dialog_id, fixed_from_message_id, first_db_message_id, filter, offset, limit, - promise = std::move(promise)](Result> r_messages) mutable { + promise = std::move(promise)](Result> r_messages) mutable { send_closure(G()->messages_manager(), &MessagesManager::on_search_dialog_messages_db_result, random_id, dialog_id, fixed_from_message_id, first_db_message_id, filter, offset, limit, std::move(r_messages), std::move(promise)); @@ -21732,7 +21732,7 @@ MessageId MessagesManager::get_first_database_message_id_by_index(const Dialog * void MessagesManager::on_search_dialog_messages_db_result(int64 random_id, DialogId dialog_id, MessageId from_message_id, MessageId first_db_message_id, MessageSearchFilter filter, int32 offset, int32 limit, - Result> r_messages, + Result> r_messages, Promise<> promise) { if (G()->close_flag()) { return promise.set_error(Status::Error(500, "Request aborted")); @@ -21759,7 +21759,7 @@ void MessagesManager::on_search_dialog_messages_db_result(int64 random_id, Dialo res.reserve(messages.size()); for (auto &message : messages) { - auto m = on_get_message_from_database(d, dialog_id, message, false, "on_search_dialog_messages_db_result"); + auto m = on_get_message_from_database(d, message, false, "on_search_dialog_messages_db_result"); if (m != nullptr && first_db_message_id <= m->message_id) { if (filter == MessageSearchFilter::UnreadMention && !m->contains_unread_mention) { // skip already read by d->last_read_all_mentions_message_id mentions @@ -22043,7 +22043,7 @@ int64 MessagesManager::get_dialog_message_by_date(DialogId dialog_id, int32 date G()->td_db()->get_messages_db_async()->get_dialog_message_by_date( dialog_id, d->first_database_message_id, d->last_database_message_id, date, PromiseCreator::lambda([actor_id = actor_id(this), dialog_id, date, random_id, - promise = std::move(promise)](Result result) mutable { + promise = std::move(promise)](Result result) mutable { send_closure(actor_id, &MessagesManager::on_get_dialog_message_by_date_from_database, dialog_id, date, random_id, std::move(result), std::move(promise)); })); @@ -22071,15 +22071,15 @@ MessageId MessagesManager::find_message_by_date(const Message *m, int32 date) { } void MessagesManager::on_get_dialog_message_by_date_from_database(DialogId dialog_id, int32 date, int64 random_id, - Result result, Promise promise) { + Result result, + Promise promise) { if (G()->close_flag()) { return promise.set_error(Status::Error(500, "Request aborted")); } Dialog *d = get_dialog(dialog_id); CHECK(d != nullptr); if (result.is_ok()) { - Message *m = - on_get_message_from_database(d, dialog_id, result.ok(), false, "on_get_dialog_message_by_date_from_database"); + Message *m = on_get_message_from_database(d, result.ok(), false, "on_get_dialog_message_by_date_from_database"); if (m != nullptr) { auto message_id = find_message_by_date(d->messages.get(), date); if (!message_id.is_valid()) { @@ -22300,7 +22300,8 @@ unique_ptr MessagesManager::parse_message(DialogId dia void MessagesManager::on_get_history_from_database(DialogId dialog_id, MessageId from_message_id, MessageId old_last_database_message_id, int32 offset, int32 limit, - bool from_the_end, bool only_local, vector &&messages, + bool from_the_end, bool only_local, + vector &&messages, Promise &&promise) { CHECK(-limit < offset && offset <= 0); CHECK(offset < 0 || from_the_end); @@ -22364,7 +22365,7 @@ void MessagesManager::on_get_history_from_database(DialogId dialog_id, MessageId if (!d->first_database_message_id.is_valid() && !d->have_full_history) { break; } - auto message = parse_message(dialog_id, std::move(message_slice), false); + auto message = parse_message(dialog_id, message_slice.data, false); if (message == nullptr) { if (d->have_full_history) { d->have_full_history = false; @@ -22568,8 +22569,8 @@ void MessagesManager::get_history_from_the_end_impl(const Dialog *d, bool from_d db_query.limit = limit; G()->td_db()->get_messages_db_async()->get_messages( db_query, PromiseCreator::lambda([dialog_id, old_last_database_message_id = d->last_database_message_id, - only_local, limit, actor_id = actor_id(this), - promise = std::move(promise)](std::vector messages) mutable { + only_local, limit, actor_id = actor_id(this), promise = std::move(promise)]( + vector messages) mutable { send_closure(actor_id, &MessagesManager::on_get_history_from_database, dialog_id, MessageId::max(), old_last_database_message_id, 0, limit, true, only_local, std::move(messages), std::move(promise)); @@ -22626,7 +22627,7 @@ void MessagesManager::get_history_impl(const Dialog *d, MessageId from_message_i db_query, PromiseCreator::lambda([dialog_id, from_message_id, old_last_database_message_id = d->last_database_message_id, offset, limit, only_local, actor_id = actor_id(this), - promise = std::move(promise)](std::vector messages) mutable { + promise = std::move(promise)](vector messages) mutable { send_closure(actor_id, &MessagesManager::on_get_history_from_database, dialog_id, from_message_id, old_last_database_message_id, offset, limit, false, only_local, std::move(messages), std::move(promise)); @@ -22771,7 +22772,7 @@ void MessagesManager::load_dialog_scheduled_messages(DialogId dialog_id, bool fr if (queries.size() == 1) { G()->td_db()->get_messages_db_async()->get_scheduled_messages( dialog_id, 1000, - PromiseCreator::lambda([dialog_id, actor_id = actor_id(this)](std::vector messages) { + PromiseCreator::lambda([dialog_id, actor_id = actor_id(this)](vector messages) { send_closure(actor_id, &MessagesManager::on_get_scheduled_messages_from_database, dialog_id, std::move(messages)); })); @@ -22782,7 +22783,8 @@ void MessagesManager::load_dialog_scheduled_messages(DialogId dialog_id, bool fr } } -void MessagesManager::on_get_scheduled_messages_from_database(DialogId dialog_id, vector &&messages) { +void MessagesManager::on_get_scheduled_messages_from_database(DialogId dialog_id, + vector &&messages) { if (G()->close_flag()) { auto it = load_scheduled_messages_from_database_queries_.find(dialog_id); CHECK(it != load_scheduled_messages_from_database_queries_.end()); @@ -22804,7 +22806,7 @@ void MessagesManager::on_get_scheduled_messages_from_database(DialogId dialog_id Dependencies dependencies; vector added_message_ids; for (auto &message_slice : messages) { - auto message = parse_message(dialog_id, std::move(message_slice), true); + auto message = parse_message(dialog_id, message_slice.data, true); if (message == nullptr) { continue; } @@ -27505,8 +27507,7 @@ vector MessagesManager::get_message_notifications_from_database_fo << " messages with notifications from database in " << group_info.group_id << '/' << d->dialog_id; for (auto &message : messages) { - auto m = on_get_message_from_database(d, d->dialog_id, message, false, - "get_message_notifications_from_database_force"); + auto m = on_get_message_from_database(d, message, false, "get_message_notifications_from_database_force"); if (m == nullptr) { VLOG(notifications) << "Receive from database a broken message"; continue; @@ -27589,7 +27590,7 @@ vector MessagesManager::get_message_notifications_from_database_fo return res; } -Result> MessagesManager::do_get_message_notifications_from_database_force( +Result> MessagesManager::do_get_message_notifications_from_database_force( Dialog *d, bool from_mentions, NotificationId from_notification_id, MessageId from_message_id, int32 limit) { CHECK(G()->parameters().use_message_db); CHECK(!from_message_id.is_scheduled()); @@ -27709,7 +27710,7 @@ void MessagesManager::do_get_message_notifications_from_database(Dialog *d, bool auto dialog_id = d->dialog_id; auto new_promise = PromiseCreator::lambda([actor_id = actor_id(this), dialog_id, from_mentions, initial_from_notification_id, limit, - promise = std::move(promise)](Result> result) mutable { + promise = std::move(promise)](Result> result) mutable { send_closure(actor_id, &MessagesManager::on_get_message_notifications_from_database, dialog_id, from_mentions, initial_from_notification_id, limit, std::move(result), std::move(promise)); }); @@ -27736,7 +27737,8 @@ void MessagesManager::do_get_message_notifications_from_database(Dialog *d, bool void MessagesManager::on_get_message_notifications_from_database(DialogId dialog_id, bool from_mentions, NotificationId initial_from_notification_id, - int32 limit, Result> result, + int32 limit, + Result> result, Promise> promise) { if (G()->close_flag()) { result = Status::Error(500, "Request aborted"); @@ -27761,7 +27763,7 @@ void MessagesManager::on_get_message_notifications_from_database(DialogId dialog VLOG(notifications) << "Loaded " << messages.size() << " messages with notifications in " << group_info.group_id << '/' << dialog_id << " from database"; for (auto &message : messages) { - auto m = on_get_message_from_database(d, dialog_id, message, false, "on_get_message_notifications_from_database"); + auto m = on_get_message_from_database(d, message, false, "on_get_message_notifications_from_database"); if (m == nullptr) { VLOG(notifications) << "Receive from database a broken message"; continue; @@ -27883,11 +27885,11 @@ void MessagesManager::remove_message_notification(DialogId dialog_id, Notificati if (G()->parameters().use_message_db) { G()->td_db()->get_messages_db_async()->get_messages_from_notification_id( dialog_id, NotificationId(notification_id.get() + 1), 1, - PromiseCreator::lambda( - [dialog_id, from_mentions, notification_id, actor_id = actor_id(this)](vector result) { - send_closure(actor_id, &MessagesManager::do_remove_message_notification, dialog_id, from_mentions, - notification_id, std::move(result)); - })); + PromiseCreator::lambda([dialog_id, from_mentions, notification_id, + actor_id = actor_id(this)](vector result) { + send_closure(actor_id, &MessagesManager::do_remove_message_notification, dialog_id, from_mentions, + notification_id, std::move(result)); + })); } } @@ -27926,7 +27928,8 @@ void MessagesManager::remove_message_notifications_by_message_ids(DialogId dialo } void MessagesManager::do_remove_message_notification(DialogId dialog_id, bool from_mentions, - NotificationId notification_id, vector result) { + NotificationId notification_id, + vector result) { if (result.empty() || G()->close_flag()) { return; } @@ -27935,7 +27938,7 @@ void MessagesManager::do_remove_message_notification(DialogId dialog_id, bool fr Dialog *d = get_dialog(dialog_id); CHECK(d != nullptr); - auto m = on_get_message_from_database(d, dialog_id, result[0], false, "do_remove_message_notification"); + auto m = on_get_message_from_database(d, result[0], false, "do_remove_message_notification"); if (m != nullptr && m->notification_id == notification_id && is_from_mention_notification_group(d, m) == from_mentions && is_message_notification_active(d, m)) { remove_message_notification_id(d, m, false, false); @@ -32120,7 +32123,7 @@ MessagesManager::Message *MessagesManager::get_message_force(Dialog *d, MessageI if (r_value.is_error()) { return nullptr; } - return on_get_message_from_database(d, d->dialog_id, r_value.ok(), message_id.is_scheduled(), source); + return on_get_message_from_database(d, r_value.ok(), message_id.is_scheduled(), source); } MessagesManager::Message *MessagesManager::on_get_message_from_database(const MessagesDbMessage &message, @@ -32129,6 +32132,11 @@ MessagesManager::Message *MessagesManager::on_get_message_from_database(const Me is_scheduled, source); } +MessagesManager::Message *MessagesManager::on_get_message_from_database(Dialog *d, const MessagesDbDialogMessage &value, + bool is_scheduled, const char *source) { + return on_get_message_from_database(d, d->dialog_id, value.data, is_scheduled, source); +} + MessagesManager::Message *MessagesManager::on_get_message_from_database(Dialog *d, DialogId dialog_id, const BufferSlice &value, bool is_scheduled, const char *source) { @@ -32136,7 +32144,7 @@ MessagesManager::Message *MessagesManager::on_get_message_from_database(Dialog * return nullptr; } - auto m = parse_message(dialog_id, std::move(value), is_scheduled); + auto m = parse_message(dialog_id, value, is_scheduled); if (m == nullptr) { return nullptr; } @@ -34095,7 +34103,7 @@ MessageId MessagesManager::get_message_id_by_random_id(Dialog *d, int64 random_i auto r_value = G()->td_db()->get_messages_db_sync()->get_message_by_random_id(d->dialog_id, random_id); if (r_value.is_ok()) { debug_add_message_to_dialog_fail_reason_ = "not called"; - Message *m = on_get_message_from_database(d, d->dialog_id, r_value.ok(), false, "get_message_id_by_random_id"); + Message *m = on_get_message_from_database(d, r_value.ok(), false, "get_message_id_by_random_id"); if (m != nullptr) { LOG_CHECK(m->random_id == random_id) << random_id << " " << m->random_id << " " << d->random_id_to_message_id[random_id] << " " diff --git a/td/telegram/MessagesManager.h b/td/telegram/MessagesManager.h index 10d896c6f..3696cdb77 100644 --- a/td/telegram/MessagesManager.h +++ b/td/telegram/MessagesManager.h @@ -2077,7 +2077,7 @@ class MessagesManager final : public Actor { void on_get_history_from_database(DialogId dialog_id, MessageId from_message_id, MessageId old_last_database_message_id, int32 offset, int32 limit, - bool from_the_end, bool only_local, vector &&messages, + bool from_the_end, bool only_local, vector &&messages, Promise &&promise); void get_history_from_the_end(DialogId dialog_id, bool from_database, bool only_local, Promise &&promise); @@ -2098,7 +2098,7 @@ class MessagesManager final : public Actor { void load_dialog_scheduled_messages(DialogId dialog_id, bool from_database, int64 hash, Promise &&promise); - void on_get_scheduled_messages_from_database(DialogId dialog_id, vector &&messages); + void on_get_scheduled_messages_from_database(DialogId dialog_id, vector &&messages); static int32 get_random_y(MessageId message_id); @@ -2240,9 +2240,8 @@ class MessagesManager final : public Actor { vector get_message_notifications_from_database_force(Dialog *d, bool from_mentions, int32 limit); - Result> do_get_message_notifications_from_database_force(Dialog *d, bool from_mentions, - NotificationId from_notification_id, - MessageId from_message_id, int32 limit); + Result> do_get_message_notifications_from_database_force( + Dialog *d, bool from_mentions, NotificationId from_notification_id, MessageId from_message_id, int32 limit); void do_get_message_notifications_from_database(Dialog *d, bool from_mentions, NotificationId initial_from_notification_id, @@ -2251,11 +2250,11 @@ class MessagesManager final : public Actor { void on_get_message_notifications_from_database(DialogId dialog_id, bool from_mentions, NotificationId initial_from_notification_id, int32 limit, - Result> result, + Result> result, Promise> promise); void do_remove_message_notification(DialogId dialog_id, bool from_mentions, NotificationId notification_id, - vector result); + vector result); int32 get_dialog_pending_notification_count(const Dialog *d, bool from_mentions) const; @@ -2661,6 +2660,9 @@ class MessagesManager final : public Actor { Message *on_get_message_from_database(const MessagesDbMessage &message, bool is_scheduled, const char *source); + Message *on_get_message_from_database(Dialog *d, const MessagesDbDialogMessage &value, bool is_scheduled, + const char *source); + Message *on_get_message_from_database(Dialog *d, DialogId dialog_id, const BufferSlice &value, bool is_scheduled, const char *source); @@ -2668,7 +2670,7 @@ class MessagesManager final : public Actor { Promise &&promise); void on_get_dialog_message_by_date_from_database(DialogId dialog_id, int32 date, int64 random_id, - Result result, Promise promise); + Result result, Promise promise); std::pair get_dialog_mute_until(DialogId dialog_id, const Dialog *d) const; @@ -2760,7 +2762,8 @@ class MessagesManager final : public Actor { void on_search_dialog_messages_db_result(int64 random_id, DialogId dialog_id, MessageId from_message_id, MessageId first_db_message_id, MessageSearchFilter filter, int32 offset, - int32 limit, Result> r_messages, Promise<> promise); + int32 limit, Result> r_messages, + Promise<> promise); void on_messages_db_fts_result(Result result, string offset, int32 limit, int64 random_id, Promise<> &&promise);