tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add MessageReactions::are_consistent_with_list.

Browse Source
This commit is contained in:
levlam 2022-09-24 20:15:38 +03:00
parent 8e196d2570
commit c9f7603ad7
3 changed files with 39 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
td/telegram/MessageReaction.cpp
View File

@ -762,6 +762,41 @@ vector<string> MessageReactions::get_chosen_reactions() const {
return reaction_order;
}
bool MessageReactions::are_consistent_with_list(const string &reaction, FlatHashMap<string, vector<DialogId>> reactions,
int32 total_count) const {
auto are_consistent = [](const vector<DialogId> &lhs, const vector<DialogId> &rhs) {
size_t i = 0;
size_t max_i = td::min(lhs.size(), rhs.size());
while (i < max_i && lhs[i] == rhs[i]) {
i++;
}
return i == max_i;
};
if (reaction.empty()) {
// received list and total_count for all reactions
int32 old_total_count = 0;
for (const auto &message_reaction : reactions_) {
if (!are_consistent(reactions[message_reaction.get_reaction()],
message_reaction.get_recent_chooser_dialog_ids())) {
return false;
}
old_total_count += message_reaction.get_choose_count();
reactions.erase(message_reaction.get_reaction());
}
return old_total_count == total_count && reactions.empty();
}
// received list and total_count for a single reaction
const auto *message_reaction = get_reaction(reaction);
if (message_reaction == nullptr) {
return reactions.count(reaction) == 0 && total_count == 0;
} else {
return are_consistent(reactions[reaction], message_reaction->get_recent_chooser_dialog_ids()) &&
message_reaction->get_choose_count() == total_count;
}
}
bool MessageReactions::need_update_message_reactions(const MessageReactions *old_reactions,
const MessageReactions *new_reactions) {
if (old_reactions == nullptr) {

3
td/telegram/MessageReaction.h
View File

@ -166,6 +166,9 @@ struct MessageReactions {
vector<string> get_chosen_reactions() const;
bool are_consistent_with_list(const string &reaction, FlatHashMap<string, vector<DialogId>> reactions,
int32 total_count) const;
static bool need_update_message_reactions(const MessageReactions *old_reactions,
const MessageReactions *new_reactions);

33
td/telegram/MessagesManager.cpp
View File

@ -6726,40 +6726,9 @@ void MessagesManager::on_get_message_reaction_list(FullMessageId full_message_id
return;
}
auto are_consistent = [](const vector<DialogId> &lhs, const vector<DialogId> &rhs) {
size_t i = 0;
size_t max_i = td::min(lhs.size(), rhs.size());
while (i < max_i && lhs[i] == rhs[i]) {
i++;
}
return i == max_i;
};
// it's impossible to use received reactions to update message reactions, because there is no way to find,
// which reactions are chosen by the current user, so just reload message reactions for consistency
bool need_reload = false;
if (reaction.empty()) {
// received list and total_count for all reactions
int32 old_total_count = 0;
for (const auto &message_reaction : m->reactions->reactions_) {
need_reload |=
!are_consistent(reactions[message_reaction.get_reaction()], message_reaction.get_recent_chooser_dialog_ids());
old_total_count += message_reaction.get_choose_count();
reactions.erase(message_reaction.get_reaction());
}
need_reload |= old_total_count != total_count || !reactions.empty();
} else {
// received list and total_count for a single reaction
const auto *message_reaction = m->reactions->get_reaction(reaction);
if (message_reaction == nullptr) {
need_reload = reactions.count(reaction) != 0 || total_count > 0;
} else {
need_reload = !are_consistent(reactions[reaction], message_reaction->get_recent_chooser_dialog_ids()) ||
message_reaction->get_choose_count() != total_count;
}
}
if (!need_reload) {
if (m->reactions->are_consistent_with_list(reaction, std::move(reactions), total_count)) {
return;
}