tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Check that new messages received in the correct order in channelDifference.

Browse Source
This commit is contained in:
levlam 2021-07-31 08:17:51 +03:00
parent 09cab2b846
commit cbb496675d
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
td/telegram/MessagesManager.cpp
View File

@ -9306,7 +9306,7 @@ void MessagesManager::on_get_history(DialogId dialog_id, MessageId from_message_
return; return;
} }
{ if (messages.size() > 1) {
// check that messages are received in decreasing message_id order // check that messages are received in decreasing message_id order
MessageId cur_message_id = MessageId::max(); MessageId cur_message_id = MessageId::max();
for (const auto &message : messages) { for (const auto &message : messages) {
@ -35844,6 +35844,23 @@ void MessagesManager::on_get_channel_difference(
new_pts = request_pts + 1; new_pts = request_pts + 1;
} }
if (difference->new_messages_.size() > 1) {
// check that new messages are received in increasing message_id order
MessageId cur_message_id;
for (const auto &message : difference->new_messages_) {
auto message_id = get_message_id(message, false);
if (message_id <= cur_message_id) {
// TODO move to ERROR
LOG(FATAL) << "Receive " << cur_message_id << " after " << message_id << " in channelDifference of "
<< dialog_id << " with pts " << request_pts << " and limit " << request_limit << ": "
<< to_string(difference);
after_get_channel_difference(dialog_id, false);
return;
}
cur_message_id = message_id;
}
}
process_get_channel_difference_updates(dialog_id, new_pts, std::move(difference->new_messages_), process_get_channel_difference_updates(dialog_id, new_pts, std::move(difference->new_messages_),
std::move(difference->other_updates_)); std::move(difference->other_updates_));