A lot more minor improvements.

benchmark/bench_misc.cpp

@@ -105,7 +105,8 @@ BENCH(NewObj, "new struct, then delete") {
 
 #if !TD_THREAD_UNSUPPORTED
 BENCH(ThreadNew, "new struct, then delete in 2 threads") {
-  NewObjBench a, b;
+  NewObjBench a;
+  NewObjBench b;
   td::thread ta([&] { a.run(n / 2); });
   td::thread tb([&] { b.run(n - n / 2); });
   ta.join();

td/telegram/AuthManager.cpp

@@ -162,7 +162,7 @@ void AuthManager::check_bot_token(uint64 query_id, string bot_token) {
   }
 
   on_new_query(query_id);
-  bot_token_ = bot_token;
+  bot_token_ = std::move(bot_token);
   was_check_bot_token_ = true;
   start_net_query(NetQueryType::BotAuthentication,
                   G()->net_query_creator().create_unauth(
@@ -258,8 +258,8 @@ void AuthManager::set_phone_number(uint64 query_id, string phone_number,
 
   on_new_query(query_id);
 
-  start_net_query(NetQueryType::SendCode, G()->net_query_creator().create_unauth(
-                                              send_code_helper_.send_code(phone_number, settings, api_id_, api_hash_)));
+  start_net_query(NetQueryType::SendCode, G()->net_query_creator().create_unauth(send_code_helper_.send_code(
+                                              std::move(phone_number), settings, api_id_, api_hash_)));
 }
 
 void AuthManager::resend_authentication_code(uint64 query_id) {
@@ -425,8 +425,8 @@ void AuthManager::on_query_error(Status status) {
   on_query_error(id, std::move(status));
 }
 
-void AuthManager::on_query_error(uint64 id, Status status) {
-  send_closure(G()->td(), &Td::send_error, id, std::move(status));
+void AuthManager::on_query_error(uint64 query_id, Status status) {
+  send_closure(G()->td(), &Td::send_error, query_id, std::move(status));
 }
 
 void AuthManager::on_query_ok() {

td/telegram/AuthManager.h

@@ -126,15 +126,16 @@ class AuthManager final : public NetActor {
     TermsOfService terms_of_service_;
 
     DbState() = default;
+
     static DbState wait_code(int32 api_id, string api_hash, SendCodeHelper send_code_helper) {
-      DbState state(State::WaitCode, api_id, api_hash);
+      DbState state(State::WaitCode, api_id, std::move(api_hash));
       state.send_code_helper_ = std::move(send_code_helper);
       return state;
     }
 
     static DbState wait_qr_code_confirmation(int32 api_id, string api_hash, vector<UserId> other_user_ids,
                                              string login_token, double login_token_expires_at) {
-      DbState state(State::WaitQrCodeConfirmation, api_id, api_hash);
+      DbState state(State::WaitQrCodeConfirmation, api_id, std::move(api_hash));
       state.other_user_ids_ = std::move(other_user_ids);
       state.login_token_ = std::move(login_token);
       state.login_token_expires_at_ = login_token_expires_at;
@@ -142,14 +143,14 @@ class AuthManager final : public NetActor {
     }
 
     static DbState wait_password(int32 api_id, string api_hash, WaitPasswordState wait_password_state) {
-      DbState state(State::WaitPassword, api_id, api_hash);
+      DbState state(State::WaitPassword, api_id, std::move(api_hash));
       state.wait_password_state_ = std::move(wait_password_state);
       return state;
     }
 
     static DbState wait_registration(int32 api_id, string api_hash, SendCodeHelper send_code_helper,
                                      TermsOfService terms_of_service) {
-      DbState state(State::WaitRegistration, api_id, api_hash);
+      DbState state(State::WaitRegistration, api_id, std::move(api_hash));
       state.send_code_helper_ = std::move(send_code_helper);
       state.terms_of_service_ = std::move(terms_of_service);
       return state;
@@ -161,8 +162,8 @@ class AuthManager final : public NetActor {
     void parse(ParserT &parser);
 
    private:
-    DbState(State state, int32 api_id, string api_hash)
-        : state_(state), api_id_(api_id), api_hash_(api_hash), state_timestamp_(Timestamp::now()) {
+    DbState(State state, int32 api_id, string &&api_hash)
+        : state_(state), api_id_(api_id), api_hash_(std::move(api_hash)), state_timestamp_(Timestamp::now()) {
     }
   };
 
@@ -216,7 +217,6 @@ class AuthManager final : public NetActor {
 
   void on_new_query(uint64 query_id);
   void on_query_error(Status status);
-  void on_query_error(uint64 id, Status status);
   void on_query_ok();
   void start_net_query(NetQueryType net_query_type, NetQueryPtr net_query);
 
@@ -232,7 +232,7 @@ class AuthManager final : public NetActor {
   void on_get_password_result(NetQueryPtr &result);
   void on_request_password_recovery_result(NetQueryPtr &result);
   void on_check_password_recovery_code_result(NetQueryPtr &result);
-  void on_authentication_result(NetQueryPtr &result, bool expected_flag);
+  void on_authentication_result(NetQueryPtr &result, bool is_from_current_query);
   void on_log_out_result(NetQueryPtr &result);
   void on_delete_account_result(NetQueryPtr &result);
   void on_get_login_token(tl_object_ptr<telegram_api::auth_LoginToken> login_token);
@@ -242,7 +242,9 @@ class AuthManager final : public NetActor {
 
   void update_state(State new_state, bool force = false, bool should_save_state = true);
   tl_object_ptr<td_api::AuthorizationState> get_authorization_state_object(State authorization_state) const;
-  void send_ok(uint64 query_id);
+
+  static void send_ok(uint64 query_id);
+  static void on_query_error(uint64 query_id, Status status);
 
   void start_up() final;
   void tear_down() final;

td/telegram/BackgroundManager.cpp

@@ -453,7 +453,7 @@ void BackgroundManager::get_backgrounds(bool for_dark_theme,
 }
 
 Result<string> BackgroundManager::get_background_url(const string &name,
-                                                     td_api::object_ptr<td_api::BackgroundType> background_type) const {
+                                                     td_api::object_ptr<td_api::BackgroundType> background_type) {
   TRY_RESULT(type, BackgroundType::get_background_type(background_type.get()));
   auto url = PSTRING() << G()->shared_config().get_option_string("t_me_url", "https://t.me/") << "bg/";
   auto link = type.get_link();
@@ -526,7 +526,7 @@ std::pair<BackgroundId, BackgroundType> BackgroundManager::search_background(con
     if (queries.size() == 1) {
       LOG(INFO) << "Trying to load background " << slug << " from database";
       G()->td_db()->get_sqlite_pmc()->get(
-          get_background_name_database_key(slug), PromiseCreator::lambda([slug](string value) {
+          get_background_name_database_key(slug), PromiseCreator::lambda([slug](string value) mutable {
             send_closure(G()->background_manager(), &BackgroundManager::on_load_background_from_database,
                          std::move(slug), std::move(value));
           }));
@@ -563,7 +563,7 @@ void BackgroundManager::on_load_background_from_database(string name, string val
     } else {
       if (background.name != name) {
         LOG(ERROR) << "Expected background " << name << ", but received " << background.name;
-        name_to_background_id_.emplace(name, background.id);
+        name_to_background_id_.emplace(std::move(name), background.id);
       }
       add_background(background, false);
     }

td/telegram/BackgroundManager.h

@@ -36,8 +36,8 @@ class BackgroundManager final : public Actor {
 
   void get_backgrounds(bool for_dark_theme, Promise<td_api::object_ptr<td_api::backgrounds>> &&promise);
 
-  Result<string> get_background_url(const string &name,
-                                    td_api::object_ptr<td_api::BackgroundType> background_type) const;
+  static Result<string> get_background_url(const string &name,
+                                           td_api::object_ptr<td_api::BackgroundType> background_type);
 
   void reload_background(BackgroundId background_id, int64 access_hash, Promise<Unit> &&promise);
 

td/telegram/BackgroundType.cpp

@@ -222,7 +222,7 @@ bool BackgroundFill::is_dark() const {
              (fourth_color_ == -1 || (fourth_color_ & 0x808080) == 0);
     default:
       UNREACHABLE();
-      return 0;
+      return false;
   }
 }
 

td/telegram/CallActor.cpp

@@ -484,7 +484,7 @@ Status CallActor::do_update_call(telegram_api::phoneCall &call) {
       get_emojis_fingerprint(call_state_.key, is_outgoing_ ? dh_handshake_.get_g_b() : dh_handshake_.get_g_a());
 
   for (auto &connection : call.connections_) {
-    call_state_.connections.push_back(CallConnection(*connection));
+    call_state_.connections.emplace_back(*connection);
   }
   call_state_.protocol = CallProtocol(*call.protocol_);
   call_state_.allow_p2p = (call.flags_ & telegram_api::phoneCall::P2P_ALLOWED_MASK) != 0;

td/telegram/CallActor.h

@@ -70,7 +70,7 @@ struct CallState {
   enum class Type : int32 { Empty, Pending, ExchangingKey, Ready, HangingUp, Discarded, Error } type{Type::Empty};
 
   CallProtocol protocol;
-  std::vector<CallConnection> connections;
+  vector<CallConnection> connections;
   CallDiscardReason discard_reason{CallDiscardReason::Empty};
   bool is_created{false};
   bool is_received{false};

td/telegram/CallbackQueriesManager.cpp

@@ -79,7 +79,9 @@ class GetBotCallbackAnswerQuery final : public Td::ResultHandler {
       return on_error(id, result_ptr.move_as_error());
     }
 
-    td->callback_queries_manager_->on_get_callback_query_answer(result_ptr.move_as_ok(), std::move(promise_));
+    auto answer = result_ptr.move_as_ok();
+    bool show_alert = (answer->flags_ & telegram_api::messages_botCallbackAnswer::ALERT_MASK) != 0;
+    promise_.set_value(td_api::make_object<td_api::callbackQueryAnswer>(answer->message_, show_alert, answer->url_));
   }
 
   void on_error(uint64 id, Status status) final {
@@ -288,12 +290,4 @@ void CallbackQueriesManager::send_get_callback_answer_query(
       ->send(dialog_id, full_message_id.get_message_id(), payload, std::move(password));
 }
 
-void CallbackQueriesManager::on_get_callback_query_answer(
-    tl_object_ptr<telegram_api::messages_botCallbackAnswer> &&answer,
-    Promise<td_api::object_ptr<td_api::callbackQueryAnswer>> &&promise) {
-  CHECK(answer != nullptr);
-  bool show_alert = (answer->flags_ & BOT_CALLBACK_ANSWER_FLAG_NEED_SHOW_ALERT) != 0;
-  promise.set_value(td_api::make_object<td_api::callbackQueryAnswer>(answer->message_, show_alert, answer->url_));
-}
-
 }  // namespace td

td/telegram/CallbackQueriesManager.h

@@ -42,16 +42,13 @@ class CallbackQueriesManager {
   void send_callback_query(FullMessageId full_message_id, tl_object_ptr<td_api::CallbackQueryPayload> &&payload,
                            Promise<td_api::object_ptr<td_api::callbackQueryAnswer>> &&promise);
 
-  void on_get_callback_query_answer(tl_object_ptr<telegram_api::messages_botCallbackAnswer> &&answer,
-                                    Promise<td_api::object_ptr<td_api::callbackQueryAnswer>> &&promise);
-
  private:
   static constexpr int32 BOT_CALLBACK_ANSWER_FLAG_HAS_MESSAGE = 1 << 0;
   static constexpr int32 BOT_CALLBACK_ANSWER_FLAG_NEED_SHOW_ALERT = 1 << 1;
   static constexpr int32 BOT_CALLBACK_ANSWER_FLAG_HAS_URL = 1 << 2;
 
-  tl_object_ptr<td_api::CallbackQueryPayload> get_query_payload(int32 flags, BufferSlice &&data,
-                                                                string &&game_short_name);
+  static tl_object_ptr<td_api::CallbackQueryPayload> get_query_payload(int32 flags, BufferSlice &&data,
+                                                                       string &&game_short_name);
 
   void send_get_callback_answer_query(FullMessageId full_message_id,
                                       tl_object_ptr<td_api::CallbackQueryPayload> &&payload,

td/telegram/ClientActor.h

@@ -64,7 +64,7 @@ class ClientActor final : public Actor {
   /**
    * Destroys the ClientActor and the TDLib instance.
    */
-  ~ClientActor();
+  ~ClientActor() final;
 
   /**
    * Move constructor.

td/telegram/ConfigManager.cpp

@@ -379,7 +379,8 @@ ActorOwn<> get_simple_config_firebase_firestore(Promise<SimpleConfigResult> prom
                                 prefer_ipv6, std::move(get_config));
 }
 
-ActorOwn<> get_full_config(DcOption option, Promise<FullConfig> promise, ActorShared<> parent) {
+static ActorOwn<> get_full_config(DcOption option, Promise<tl_object_ptr<telegram_api::config>> promise,
+                                  ActorShared<> parent) {
   class SessionCallback final : public Session::Callback {
    public:
     SessionCallback(ActorShared<> parent, DcOption option) : parent_(std::move(parent)), option_(std::move(option)) {
@@ -496,7 +497,7 @@ ActorOwn<> get_full_config(DcOption option, Promise<FullConfig> promise, ActorSh
 
   class GetConfigActor final : public NetQueryCallback {
    public:
-    GetConfigActor(DcOption option, Promise<FullConfig> promise, ActorShared<> parent)
+    GetConfigActor(DcOption option, Promise<tl_object_ptr<telegram_api::config>> promise, ActorShared<> parent)
         : option_(std::move(option)), promise_(std::move(promise)), parent_(std::move(parent)) {
     }
 
@@ -542,11 +543,12 @@ ActorOwn<> get_full_config(DcOption option, Promise<FullConfig> promise, ActorSh
 
     DcOption option_;
     ActorOwn<Session> session_;
-    Promise<FullConfig> promise_;
+    Promise<tl_object_ptr<telegram_api::config>> promise_;
     ActorShared<> parent_;
   };
 
-  return ActorOwn<>(create_actor<GetConfigActor>("GetConfigActor", option, std::move(promise), std::move(parent)));
+  return ActorOwn<>(
+      create_actor<GetConfigActor>("GetConfigActor", std::move(option), std::move(promise), std::move(parent)));
 }
 
 class ConfigRecoverer final : public Actor {
@@ -556,7 +558,7 @@ class ConfigRecoverer final : public Actor {
   }
 
   void on_dc_options_update(DcOptions dc_options) {
-    dc_options_update_ = dc_options;
+    dc_options_update_ = std::move(dc_options);
     update_dc_options();
     loop();
   }
@@ -676,22 +678,22 @@ class ConfigRecoverer final : public Actor {
     }
   }
 
-  void on_full_config(Result<FullConfig> r_full_config, bool dummy) {
+  void on_full_config(Result<tl_object_ptr<telegram_api::config>> r_full_config, bool dummy) {
     full_config_query_.reset();
     if (r_full_config.is_ok()) {
       full_config_ = r_full_config.move_as_ok();
-      VLOG(config_recoverer) << "Got FullConfig " << to_string(full_config_);
+      VLOG(config_recoverer) << "Receive " << to_string(full_config_);
       full_config_expires_at_ = get_config_expire_time();
       send_closure(G()->connection_creator(), &ConnectionCreator::on_dc_options, DcOptions(full_config_->dc_options_));
     } else {
-      VLOG(config_recoverer) << "Get FullConfig error " << r_full_config.error();
-      full_config_ = FullConfig();
+      VLOG(config_recoverer) << "Failed to get config: " << r_full_config.error();
+      full_config_ = nullptr;
       full_config_expires_at_ = get_failed_config_expire_time();
     }
     loop();
   }
 
-  bool expect_blocking() const {
+  static bool expect_blocking() {
     return G()->shared_config().get_option_boolean("expect_blocking", true);
   }
 
@@ -729,7 +731,7 @@ class ConfigRecoverer final : public Actor {
 
   size_t date_option_i_{0};
 
-  FullConfig full_config_;
+  tl_object_ptr<telegram_api::config> full_config_;
   double full_config_expires_at_{0};
   ActorOwn<> full_config_query_;
 
@@ -760,6 +762,7 @@ class ConfigRecoverer final : public Actor {
   double max_connecting_delay() const {
     return expect_blocking() ? 5 : 20;
   }
+
   void loop() final {
     if (close_flag_) {
       return;
@@ -829,12 +832,13 @@ class ConfigRecoverer final : public Actor {
     if (need_full_config) {
       ref_cnt_++;
       VLOG(config_recoverer) << "Ask full config with dc_options_i_ = " << dc_options_i_;
-      full_config_query_ =
-          get_full_config(dc_options_.dc_options[dc_options_i_],
-                          PromiseCreator::lambda([actor_id = actor_id(this)](Result<FullConfig> r_full_config) {
-                            send_closure(actor_id, &ConfigRecoverer::on_full_config, std::move(r_full_config), false);
-                          }),
-                          actor_shared(this));
+      full_config_query_ = get_full_config(
+          dc_options_.dc_options[dc_options_i_],
+          PromiseCreator::lambda(
+              [actor_id = actor_id(this)](Result<tl_object_ptr<telegram_api::config>> r_full_config) {
+                send_closure(actor_id, &ConfigRecoverer::on_full_config, std::move(r_full_config), false);
+              }),
+          actor_shared(this));
       dc_options_i_ = (dc_options_i_ + 1) % dc_options_.dc_options.size();
     }
 
@@ -1282,7 +1286,7 @@ void ConfigManager::on_result(NetQueryPtr res) {
   }
 }
 
-void ConfigManager::save_dc_options_update(DcOptions dc_options) {
+void ConfigManager::save_dc_options_update(const DcOptions &dc_options) {
   if (dc_options.dc_options.empty()) {
     G()->td_db()->get_binlog_pmc()->erase("dc_options_update");
     return;

td/telegram/ConfigManager.h

@@ -78,10 +78,6 @@ class HttpDate {
   static Result<int32> parse_http_date(std::string slice);
 };
 
-using FullConfig = tl_object_ptr<telegram_api::config>;
-
-ActorOwn<> get_full_config(DcId dc_id, IPAddress ip_address, Promise<FullConfig> promise);
-
 class ConfigRecoverer;
 class ConfigManager final : public NetQueryCallback {
  public:
@@ -155,7 +151,7 @@ class ConfigManager final : public NetQueryCallback {
 
   static Timestamp load_config_expire_time();
   static void save_config_expire(Timestamp timestamp);
-  static void save_dc_options_update(DcOptions dc_options);
+  static void save_dc_options_update(const DcOptions &dc_options);
   static DcOptions load_dc_options_update();
 
   ActorShared<> create_reference();

td/telegram/ConfigShared.cpp

@@ -23,7 +23,7 @@ void ConfigShared::set_callback(unique_ptr<Callback> callback) {
     return;
   }
 
-  for (auto key_value : config_pmc_->get_all()) {
+  for (const auto &key_value : config_pmc_->get_all()) {
     on_option_updated(key_value.first);
   }
 }

td/telegram/ContactsManager.cpp

@@ -580,7 +580,7 @@ class ImportContactsQuery final : public Td::ResultHandler {
         return promise_.set_error(Status::Error(429, "Too Many Requests: retry after 3600"));
       }
 
-      int64 total_size = static_cast<int64>(input_contacts_.size());
+      auto total_size = static_cast<int64>(input_contacts_.size());
       vector<tl_object_ptr<telegram_api::inputPhoneContact>> contacts;
       contacts.reserve(ptr->retry_contacts_.size());
       for (auto &client_id : ptr->retry_contacts_) {
@@ -588,7 +588,7 @@ class ImportContactsQuery final : public Td::ResultHandler {
           LOG(ERROR) << "Wrong client_id " << client_id << " returned";
           continue;
         }
-        size_t i = static_cast<size_t>(client_id);
+        auto i = static_cast<size_t>(client_id);
         contacts.push_back(input_contacts_[i].get_input_phone_contact(client_id));
       }
 
@@ -2271,7 +2271,8 @@ class EditChannelAdminQuery final : public Td::ResultHandler {
   explicit EditChannelAdminQuery(Promise<Unit> &&promise) : promise_(std::move(promise)) {
   }
 
-  void send(ChannelId channel_id, tl_object_ptr<telegram_api::InputUser> &&input_user, DialogParticipantStatus status) {
+  void send(ChannelId channel_id, tl_object_ptr<telegram_api::InputUser> &&input_user,
+            const DialogParticipantStatus &status) {
     channel_id_ = channel_id;
     auto input_channel = td->contacts_manager_->get_input_channel(channel_id);
     CHECK(input_channel != nullptr);
@@ -2306,7 +2307,8 @@ class EditChannelBannedQuery final : public Td::ResultHandler {
   explicit EditChannelBannedQuery(Promise<Unit> &&promise) : promise_(std::move(promise)) {
   }
 
-  void send(ChannelId channel_id, tl_object_ptr<telegram_api::InputPeer> &&input_peer, DialogParticipantStatus status) {
+  void send(ChannelId channel_id, tl_object_ptr<telegram_api::InputPeer> &&input_peer,
+            const DialogParticipantStatus &status) {
     channel_id_ = channel_id;
     auto input_channel = td->contacts_manager_->get_input_channel(channel_id);
     CHECK(input_channel != nullptr);
@@ -2685,7 +2687,7 @@ class GetUserPhotosQuery final : public Td::ResultHandler {
       auto photos = move_tl_object_as<telegram_api::photos_photos>(ptr);
 
       td->contacts_manager_->on_get_users(std::move(photos->users_), "GetUserPhotosQuery");
-      int32 photos_size = narrow_cast<int32>(photos->photos_.size());
+      auto photos_size = narrow_cast<int32>(photos->photos_.size());
       td->contacts_manager_->on_get_user_photos(user_id_, offset_, limit_, photos_size, std::move(photos->photos_));
     } else {
       CHECK(constructor_id == telegram_api::photos_photosSlice::ID);
@@ -2924,7 +2926,7 @@ class GetChannelParticipantsQuery final : public Td::ResultHandler {
       : promise_(std::move(promise)) {
   }
 
-  void send(ChannelId channel_id, ChannelParticipantsFilter filter, int32 offset, int32 limit) {
+  void send(ChannelId channel_id, const ChannelParticipantsFilter &filter, int32 offset, int32 limit) {
     auto input_channel = td->contacts_manager_->get_input_channel(channel_id);
     if (input_channel == nullptr) {
       return promise_.set_error(Status::Error(400, "Supergroup not found"));
@@ -5181,7 +5183,7 @@ td_api::object_ptr<td_api::session> ContactsManager::convert_authorization_objec
       authorization->country_, authorization->region_);
 }
 
-void ContactsManager::confirm_qr_code_authentication(string link,
+void ContactsManager::confirm_qr_code_authentication(const string &link,
                                                      Promise<td_api::object_ptr<td_api::session>> &&promise) {
   Slice prefix("tg://login?token=");
   if (!begins_with(to_lower(link), prefix)) {
@@ -5372,7 +5374,7 @@ std::pair<vector<UserId>, vector<int32>> ContactsManager::import_contacts(const
   return {};
 }
 
-void ContactsManager::remove_contacts(vector<UserId> user_ids, Promise<Unit> &&promise) {
+void ContactsManager::remove_contacts(const vector<UserId> &user_ids, Promise<Unit> &&promise) {
   LOG(INFO) << "Delete contacts: " << format::as_array(user_ids);
   if (!are_contacts_loaded_) {
     load_contacts(std::move(promise));
@@ -5586,7 +5588,7 @@ std::pair<vector<UserId>, vector<int32>> ContactsManager::change_imported_contac
   std::pair<vector<size_t>, vector<Contact>> to_add;
   for (auto &new_contact : different_new_contacts) {
     to_add.first.push_back(new_contact.second);
-    to_add.second.push_back(std::move(new_contact.first));
+    to_add.second.push_back(new_contact.first);
   }
 
   if (to_add.first.empty() && to_delete.empty()) {
@@ -6670,16 +6672,16 @@ void ContactsManager::send_get_channel_message_stats_query(
       ->send(dialog_id.get_channel_id(), full_message_id.get_message_id(), is_dark, dc_id);
 }
 
-void ContactsManager::load_statistics_graph(DialogId dialog_id, const string &token, int64 x,
+void ContactsManager::load_statistics_graph(DialogId dialog_id, string token, int64 x,
                                             Promise<td_api::object_ptr<td_api::StatisticalGraph>> &&promise) {
-  auto dc_id_promise = PromiseCreator::lambda(
-      [actor_id = actor_id(this), token, x, promise = std::move(promise)](Result<DcId> r_dc_id) mutable {
-        if (r_dc_id.is_error()) {
-          return promise.set_error(r_dc_id.move_as_error());
-        }
-        send_closure(actor_id, &ContactsManager::send_load_async_graph_query, r_dc_id.move_as_ok(), std::move(token), x,
-                     std::move(promise));
-      });
+  auto dc_id_promise = PromiseCreator::lambda([actor_id = actor_id(this), token = std::move(token), x,
+                                               promise = std::move(promise)](Result<DcId> r_dc_id) mutable {
+    if (r_dc_id.is_error()) {
+      return promise.set_error(r_dc_id.move_as_error());
+    }
+    send_closure(actor_id, &ContactsManager::send_load_async_graph_query, r_dc_id.move_as_ok(), std::move(token), x,
+                 std::move(promise));
+  });
   get_channel_statistics_dc_id(dialog_id, false, std::move(dc_id_promise));
 }
 
@@ -6810,8 +6812,8 @@ void ContactsManager::add_chat_participant(ChatId chat_id, UserId user_id, int32
   td_->create_handler<AddChatUserQuery>(std::move(promise))->send(chat_id, std::move(input_user), forward_limit);
 }
 
-void ContactsManager::add_channel_participant(ChannelId channel_id, UserId user_id, Promise<Unit> &&promise,
-                                              DialogParticipantStatus old_status) {
+void ContactsManager::add_channel_participant(ChannelId channel_id, UserId user_id,
+                                              const DialogParticipantStatus &old_status, Promise<Unit> &&promise) {
   if (td_->auth_manager_->is_bot()) {
     return promise.set_error(Status::Error(400, "Bots can't add new chat members"));
   }
@@ -6985,8 +6987,8 @@ void ContactsManager::set_channel_participant_status_impl(ChannelId channel_id,
     if (participant_dialog_id.get_type() != DialogType::User) {
       return promise.set_error(Status::Error(400, "Can't promote chats to chat administrators"));
     }
-    return promote_channel_participant(channel_id, participant_dialog_id.get_user_id(), std::move(status),
-                                       std::move(old_status), std::move(promise));
+    return promote_channel_participant(channel_id, participant_dialog_id.get_user_id(), status, old_status,
+                                       std::move(promise));
   } else if (need_restrict) {
     return restrict_channel_participant(channel_id, participant_dialog_id, std::move(status), std::move(old_status),
                                         std::move(promise));
@@ -6995,13 +6997,13 @@ void ContactsManager::set_channel_participant_status_impl(ChannelId channel_id,
     if (participant_dialog_id.get_type() != DialogType::User) {
       return promise.set_error(Status::Error(400, "Can't add chats as chat members"));
     }
-    return add_channel_participant(channel_id, participant_dialog_id.get_user_id(), std::move(promise),
-                                   std::move(old_status));
+    return add_channel_participant(channel_id, participant_dialog_id.get_user_id(), old_status, std::move(promise));
   }
 }
 
-void ContactsManager::promote_channel_participant(ChannelId channel_id, UserId user_id, DialogParticipantStatus status,
-                                                  DialogParticipantStatus old_status, Promise<Unit> &&promise) {
+void ContactsManager::promote_channel_participant(ChannelId channel_id, UserId user_id,
+                                                  const DialogParticipantStatus &status,
+                                                  const DialogParticipantStatus &old_status, Promise<Unit> &&promise) {
   LOG(INFO) << "Promote " << user_id << " in " << channel_id << " from " << old_status << " to " << status;
   const Channel *c = get_channel(channel_id);
   CHECK(c != nullptr);
@@ -7458,8 +7460,8 @@ void ContactsManager::delete_chat_participant(ChatId chat_id, UserId user_id, bo
 }
 
 void ContactsManager::restrict_channel_participant(ChannelId channel_id, DialogId participant_dialog_id,
-                                                   DialogParticipantStatus status, DialogParticipantStatus old_status,
-                                                   Promise<Unit> &&promise) {
+                                                   DialogParticipantStatus &&status,
+                                                   DialogParticipantStatus &&old_status, Promise<Unit> &&promise) {
   TRY_STATUS_PROMISE(promise, G()->close_status());
 
   LOG(INFO) << "Restrict " << participant_dialog_id << " in " << channel_id << " from " << old_status << " to "
@@ -7520,22 +7522,23 @@ void ContactsManager::restrict_channel_participant(ChannelId channel_id, DialogI
   if (old_status.is_member() && !status.is_member() && !status.is_banned()) {
     // we can't make participant Left without kicking it first
     auto on_result_promise = PromiseCreator::lambda([actor_id = actor_id(this), channel_id, participant_dialog_id,
-                                                     status, promise = std::move(promise)](Result<> result) mutable {
+                                                     status = std::move(status),
+                                                     promise = std::move(promise)](Result<> result) mutable {
       if (result.is_error()) {
         return promise.set_error(result.move_as_error());
       }
 
-      create_actor<SleepActor>("RestrictChannelParticipantSleepActor", 1.0,
-                               PromiseCreator::lambda([actor_id, channel_id, participant_dialog_id, status,
-                                                       promise = std::move(promise)](Result<> result) mutable {
-                                 if (result.is_error()) {
-                                   return promise.set_error(result.move_as_error());
-                                 }
+      create_actor<SleepActor>(
+          "RestrictChannelParticipantSleepActor", 1.0,
+          PromiseCreator::lambda([actor_id, channel_id, participant_dialog_id, status = std::move(status),
+                                  promise = std::move(promise)](Result<> result) mutable {
+            if (result.is_error()) {
+              return promise.set_error(result.move_as_error());
+            }
 
-                                 send_closure(actor_id, &ContactsManager::restrict_channel_participant, channel_id,
-                                              participant_dialog_id, status, DialogParticipantStatus::Banned(0),
-                                              std::move(promise));
-                               }))
+            send_closure(actor_id, &ContactsManager::restrict_channel_participant, channel_id, participant_dialog_id,
+                         std::move(status), DialogParticipantStatus::Banned(0), std::move(promise));
+          }))
           .release();
     });
 
@@ -7605,7 +7608,7 @@ vector<DialogId> ContactsManager::get_dialog_ids(vector<tl_object_ptr<telegram_a
 }
 
 vector<DialogId> ContactsManager::get_created_public_dialogs(PublicDialogType type, Promise<Unit> &&promise) {
-  int32 index = static_cast<int32>(type);
+  auto index = static_cast<int32>(type);
   if (created_public_channels_inited_[index]) {
     promise.set_value(Unit());
     return transform(created_public_channels_[index], [&](ChannelId channel_id) {
@@ -7621,7 +7624,7 @@ vector<DialogId> ContactsManager::get_created_public_dialogs(PublicDialogType ty
 
 void ContactsManager::on_get_created_public_channels(PublicDialogType type,
                                                      vector<tl_object_ptr<telegram_api::Chat>> &&chats) {
-  int32 index = static_cast<int32>(type);
+  auto index = static_cast<int32>(type);
   created_public_channels_[index] = get_channel_ids(std::move(chats), "on_get_created_public_channels");
   created_public_channels_inited_[index] = true;
 }
@@ -9626,7 +9629,7 @@ ContactsManager::ChannelFull *ContactsManager::get_channel_full_force(ChannelId
   return get_channel_full(channel_id, only_local, source);
 }
 
-void ContactsManager::for_each_secret_chat_with_user(UserId user_id, std::function<void(SecretChatId)> f) {
+void ContactsManager::for_each_secret_chat_with_user(UserId user_id, const std::function<void(SecretChatId)> &f) {
   auto it = secret_chats_with_user_.find(user_id);
   if (it != secret_chats_with_user_.end()) {
     for (auto secret_chat_id : it->second) {
@@ -10208,7 +10211,7 @@ void ContactsManager::on_get_user_full(tl_object_ptr<telegram_api::userFull> &&u
 
 void ContactsManager::on_get_user_photos(UserId user_id, int32 offset, int32 limit, int32 total_count,
                                          vector<tl_object_ptr<telegram_api::Photo>> photos) {
-  int32 photo_count = narrow_cast<int32>(photos.size());
+  auto photo_count = narrow_cast<int32>(photos.size());
   int32 min_total_count = (offset >= 0 && photo_count > 0 ? offset : 0) + photo_count;
   if (total_count < min_total_count) {
     LOG(ERROR) << "Wrong photos total_count " << total_count << ". Receive " << photo_count << " photos with offset "
@@ -10737,7 +10740,7 @@ void ContactsManager::on_get_chat_full_failed(ChatId chat_id) {
     return;
   }
 
-  LOG(INFO) << "Failed to get " << chat_id;
+  LOG(INFO) << "Failed to get full " << chat_id;
 }
 
 void ContactsManager::on_get_channel_full_failed(ChannelId channel_id) {
@@ -10745,7 +10748,7 @@ void ContactsManager::on_get_channel_full_failed(ChannelId channel_id) {
     return;
   }
 
-  LOG(INFO) << "Failed to get " << channel_id;
+  LOG(INFO) << "Failed to get full " << channel_id;
   auto channel_full = get_channel_full(channel_id, true, "on_get_channel_full");
   if (channel_full != nullptr) {
     channel_full->repair_request_version = 0;
@@ -10869,8 +10872,8 @@ void ContactsManager::do_update_user_photo(User *u, UserId user_id,
   do_update_user_photo(u, user_id, std::move(new_photo), true, source);
 }
 
-void ContactsManager::do_update_user_photo(User *u, UserId user_id, ProfilePhoto new_photo, bool invalidate_photo_cache,
-                                           const char *source) {
+void ContactsManager::do_update_user_photo(User *u, UserId user_id, ProfilePhoto &&new_photo,
+                                           bool invalidate_photo_cache, const char *source) {
   u->is_photo_inited = true;
   if (new_photo != u->photo) {
     LOG_IF(ERROR, u->access_hash == -1 && new_photo.small_file_id.is_valid())
@@ -11148,7 +11151,7 @@ void ContactsManager::on_update_user_need_phone_number_privacy_exception(UserId
 }
 
 void ContactsManager::on_update_user_full_need_phone_number_privacy_exception(
-    UserFull *user_full, UserId user_id, bool need_phone_number_privacy_exception) {
+    UserFull *user_full, UserId user_id, bool need_phone_number_privacy_exception) const {
   CHECK(user_full != nullptr);
   if (need_phone_number_privacy_exception) {
     const User *u = get_user(user_id);
@@ -11993,8 +11996,8 @@ void ContactsManager::speculative_add_channel_participant_count(ChannelId channe
 }
 
 void ContactsManager::speculative_add_channel_user(ChannelId channel_id, UserId user_id,
-                                                   DialogParticipantStatus new_status,
-                                                   DialogParticipantStatus old_status) {
+                                                   const DialogParticipantStatus &new_status,
+                                                   const DialogParticipantStatus &old_status) {
   auto c = get_channel_force(channel_id);
   // channel full must be loaded before c->participant_count is updated, because on_load_channel_full_from_database
   // must copy the initial c->participant_count before it is speculatibely updated
@@ -12799,7 +12802,7 @@ void ContactsManager::on_update_chat_status(Chat *c, ChatId chat_id, DialogParti
     bool need_reload_group_call = c->status.can_manage_calls() != status.can_manage_calls();
     bool need_drop_invite_link = c->status.can_manage_invite_links() && !status.can_manage_invite_links();
 
-    c->status = status;
+    c->status = std::move(status);
 
     if (c->status.is_left()) {
       c->participant_count = 0;
@@ -13376,7 +13379,7 @@ void ContactsManager::on_update_channel_default_permissions(ChannelId channel_id
 }
 
 void ContactsManager::send_update_chat_member(DialogId dialog_id, UserId agent_user_id, int32 date,
-                                              DialogInviteLink invite_link,
+                                              const DialogInviteLink &invite_link,
                                               const DialogParticipant &old_dialog_participant,
                                               const DialogParticipant &new_dialog_participant) {
   CHECK(td_->auth_manager_->is_bot());
@@ -14621,8 +14624,8 @@ void ContactsManager::add_dialog_participant(DialogId dialog_id, UserId user_id,
     case DialogType::Chat:
       return add_chat_participant(dialog_id.get_chat_id(), user_id, forward_limit, std::move(promise));
     case DialogType::Channel:
-      return add_channel_participant(dialog_id.get_channel_id(), user_id, std::move(promise),
-                                     DialogParticipantStatus::Left());
+      return add_channel_participant(dialog_id.get_channel_id(), user_id, DialogParticipantStatus::Left(),
+                                     std::move(promise));
     case DialogType::SecretChat:
       return promise.set_error(Status::Error(400, "Can't add members to a secret chat"));
     case DialogType::None:
@@ -15091,7 +15094,7 @@ void ContactsManager::get_channel_participants(ChannelId channel_id,
         }
       });
   td_->create_handler<GetChannelParticipantsQuery>(std::move(get_channel_participants_promise))
-      ->send(channel_id, std::move(participants_filter), offset, limit);
+      ->send(channel_id, participants_filter, offset, limit);
 }
 
 vector<DialogAdministrator> ContactsManager::get_dialog_administrators(DialogId dialog_id, int left_tries,
@@ -15150,12 +15153,13 @@ string ContactsManager::get_dialog_administrators_database_key(DialogId dialog_i
 void ContactsManager::load_dialog_administrators(DialogId dialog_id, Promise<Unit> &&promise) {
   if (G()->parameters().use_chat_info_db) {
     LOG(INFO) << "Load administrators of " << dialog_id << " from database";
-    G()->td_db()->get_sqlite_pmc()->get(
-        get_dialog_administrators_database_key(dialog_id),
-        PromiseCreator::lambda([dialog_id, promise = std::move(promise)](string value) mutable {
-          send_closure(G()->contacts_manager(), &ContactsManager::on_load_dialog_administrators_from_database,
-                       dialog_id, std::move(value), std::move(promise));
-        }));
+    G()->td_db()->get_sqlite_pmc()->get(get_dialog_administrators_database_key(dialog_id),
+                                        PromiseCreator::lambda([actor_id = actor_id(this), dialog_id,
+                                                                promise = std::move(promise)](string value) mutable {
+                                          send_closure(actor_id,
+                                                       &ContactsManager::on_load_dialog_administrators_from_database,
+                                                       dialog_id, std::move(value), std::move(promise));
+                                        }));
   } else {
     promise.set_value(Unit());
   }
@@ -15650,7 +15654,7 @@ void ContactsManager::on_chat_update(telegram_api::channelForbidden &channel, co
   on_update_channel_status(c, channel_id, DialogParticipantStatus::Banned(unban_date));
   // on_update_channel_username(c, channel_id, "");  // don't know if channel username is empty, so don't update it
   tl_object_ptr<telegram_api::chatBannedRights> banned_rights;  // == nullptr
-  on_update_channel_default_permissions(c, channel_id, get_restricted_rights(banned_rights));
+  on_update_channel_default_permissions(c, channel_id, get_restricted_rights(std::move(banned_rights)));
   td_->messages_manager_->on_update_dialog_group_call(DialogId(channel_id), false, false, "receive channelForbidden");
 
   bool sign_messages = false;
@@ -15943,7 +15947,7 @@ tl_object_ptr<td_api::supergroup> ContactsManager::get_supergroup_object(Channel
   return get_supergroup_object(channel_id, get_channel(channel_id));
 }
 
-tl_object_ptr<td_api::supergroup> ContactsManager::get_supergroup_object(ChannelId channel_id, const Channel *c) const {
+tl_object_ptr<td_api::supergroup> ContactsManager::get_supergroup_object(ChannelId channel_id, const Channel *c) {
   if (c == nullptr) {
     return nullptr;
   }

td/telegram/ContactsManager.h

@@ -111,7 +111,7 @@ class ContactsManager final : public Actor {
 
   bool is_update_about_username_change_received(UserId user_id) const;
 
-  void for_each_secret_chat_with_user(UserId user_id, std::function<void(SecretChatId)> f);
+  void for_each_secret_chat_with_user(UserId user_id, const std::function<void(SecretChatId)> &f);
 
   string get_user_username(UserId user_id) const;
   string get_channel_username(ChannelId channel_id) const;
@@ -278,14 +278,14 @@ class ContactsManager final : public Actor {
   static td_api::object_ptr<td_api::session> convert_authorization_object(
       tl_object_ptr<telegram_api::authorization> &&authorization);
 
-  void confirm_qr_code_authentication(string link, Promise<td_api::object_ptr<td_api::session>> &&promise);
+  void confirm_qr_code_authentication(const string &link, Promise<td_api::object_ptr<td_api::session>> &&promise);
 
   void get_active_sessions(Promise<tl_object_ptr<td_api::sessions>> &&promise) const;
   void terminate_session(int64 session_id, Promise<Unit> &&promise) const;
   void terminate_all_other_sessions(Promise<Unit> &&promise) const;
 
   void get_connected_websites(Promise<tl_object_ptr<td_api::connectedWebsites>> &&promise) const;
-  void disconnect_website(int64 authorizations_id, Promise<Unit> &&promise) const;
+  void disconnect_website(int64 website_id, Promise<Unit> &&promise) const;
   void disconnect_all_websites(Promise<Unit> &&promise) const;
 
   void add_contact(Contact contact, bool share_phone_number, Promise<Unit> &&promise);
@@ -295,7 +295,7 @@ class ContactsManager final : public Actor {
 
   std::pair<int32, vector<UserId>> search_contacts(const string &query, int32 limit, Promise<Unit> &&promise);
 
-  void remove_contacts(vector<UserId> user_ids, Promise<Unit> &&promise);
+  void remove_contacts(const vector<UserId> &user_ids, Promise<Unit> &&promise);
 
   void remove_contacts_by_phone_number(vector<string> user_phone_numbers, vector<UserId> user_ids,
                                        Promise<Unit> &&promise);
@@ -367,7 +367,7 @@ class ContactsManager final : public Actor {
   void get_channel_message_statistics(FullMessageId full_message_id, bool is_dark,
                                       Promise<td_api::object_ptr<td_api::messageStatistics>> &&promise);
 
-  void load_statistics_graph(DialogId dialog_id, const string &token, int64 x,
+  void load_statistics_graph(DialogId dialog_id, string token, int64 x,
                              Promise<td_api::object_ptr<td_api::StatisticalGraph>> &&promise);
 
   struct CanTransferOwnershipResult {
@@ -476,7 +476,7 @@ class ContactsManager final : public Actor {
   FileSourceId get_chat_full_file_source_id(ChatId chat_id);
   void reload_chat_full(ChatId chat_id, Promise<Unit> &&promise);
 
-  int32 get_chat_participant_count(ChatId channel_id) const;
+  int32 get_chat_participant_count(ChatId chat_id) const;
   bool get_chat_is_active(ChatId chat_id) const;
   ChannelId get_chat_migrated_to_channel_id(ChatId chat_id) const;
   DialogParticipantStatus get_chat_status(ChatId chat_id) const;
@@ -487,7 +487,7 @@ class ContactsManager final : public Actor {
   bool have_min_channel(ChannelId channel_id) const;
   bool have_channel_force(ChannelId channel_id);
   bool get_channel(ChannelId channel_id, int left_tries, Promise<Unit> &&promise);
-  void reload_channel(ChannelId chnanel_id, Promise<Unit> &&promise);
+  void reload_channel(ChannelId channel_id, Promise<Unit> &&promise);
   void load_channel_full(ChannelId channel_id, bool force, Promise<Unit> &&promise, const char *source);
   FileSourceId get_channel_full_file_source_id(ChannelId channel_id);
   void reload_channel_full(ChannelId channel_id, Promise<Unit> &&promise, const char *source);
@@ -581,7 +581,7 @@ class ContactsManager final : public Actor {
 
   static tl_object_ptr<td_api::StatisticalGraph> convert_stats_graph(tl_object_ptr<telegram_api::StatsGraph> obj);
 
-  static double get_percentage_value(double new_value, double old_value);
+  static double get_percentage_value(double part, double total);
 
   static tl_object_ptr<td_api::statisticalValue> convert_stats_absolute_value(
       const tl_object_ptr<telegram_api::statsAbsValueAndPrev> &obj);
@@ -1162,7 +1162,7 @@ class ContactsManager final : public Actor {
   static bool is_valid_username(const string &username);
 
   void on_update_user_name(User *u, UserId user_id, string &&first_name, string &&last_name, string &&username);
-  void on_update_user_phone_number(User *u, UserId user_id, string &&phone_number);
+  static void on_update_user_phone_number(User *u, UserId user_id, string &&phone_number);
   void on_update_user_photo(User *u, UserId user_id, tl_object_ptr<telegram_api::UserProfilePhoto> &&photo,
                             const char *source);
   void on_update_user_is_contact(User *u, UserId user_id, bool is_contact, bool is_mutual_contact);
@@ -1171,7 +1171,7 @@ class ContactsManager final : public Actor {
 
   void do_update_user_photo(User *u, UserId user_id, tl_object_ptr<telegram_api::UserProfilePhoto> &&photo,
                             const char *source);
-  void do_update_user_photo(User *u, UserId user_id, ProfilePhoto new_photo, bool invalidate_photo_cache,
+  void do_update_user_photo(User *u, UserId user_id, ProfilePhoto &&new_photo, bool invalidate_photo_cache,
                             const char *source);
 
   void upload_profile_photo(FileId file_id, bool is_animation, double main_frame_timestamp, Promise<Unit> &&promise,
@@ -1182,12 +1182,12 @@ class ContactsManager final : public Actor {
 
   void register_user_photo(User *u, UserId user_id, const Photo &photo);
 
-  void on_update_user_full_is_blocked(UserFull *user_full, UserId user_id, bool is_blocked);
-  void on_update_user_full_common_chat_count(UserFull *user_full, UserId user_id, int32 common_chat_count);
-  void on_update_user_full_commands(UserFull *user_full, UserId user_id,
-                                    vector<tl_object_ptr<telegram_api::botCommand>> &&bot_commands);
+  static void on_update_user_full_is_blocked(UserFull *user_full, UserId user_id, bool is_blocked);
+  static void on_update_user_full_common_chat_count(UserFull *user_full, UserId user_id, int32 common_chat_count);
+  static void on_update_user_full_commands(UserFull *user_full, UserId user_id,
+                                           vector<tl_object_ptr<telegram_api::botCommand>> &&bot_commands);
   void on_update_user_full_need_phone_number_privacy_exception(UserFull *user_full, UserId user_id,
-                                                               bool need_phone_number_privacy_exception);
+                                                               bool need_phone_number_privacy_exception) const;
 
   void add_profile_photo_to_cache(UserId user_id, Photo &&photo);
   bool delete_profile_photo_from_cache(UserId user_id, int64 profile_photo_id, bool send_updates);
@@ -1195,13 +1195,14 @@ class ContactsManager final : public Actor {
   void drop_user_full(UserId user_id);
 
   void on_update_chat_status(Chat *c, ChatId chat_id, DialogParticipantStatus status);
-  void on_update_chat_default_permissions(Chat *c, ChatId chat_id, RestrictedRights default_permissions, int32 version);
+  static void on_update_chat_default_permissions(Chat *c, ChatId chat_id, RestrictedRights default_permissions,
+                                                 int32 version);
   void on_update_chat_participant_count(Chat *c, ChatId chat_id, int32 participant_count, int32 version,
                                         const string &debug_str);
   void on_update_chat_photo(Chat *c, ChatId chat_id, tl_object_ptr<telegram_api::ChatPhoto> &&chat_photo_ptr);
-  void on_update_chat_title(Chat *c, ChatId chat_id, string &&title);
-  void on_update_chat_active(Chat *c, ChatId chat_id, bool is_active);
-  void on_update_chat_migrated_to_channel_id(Chat *c, ChatId chat_id, ChannelId migrated_to_channel_id);
+  static void on_update_chat_title(Chat *c, ChatId chat_id, string &&title);
+  static void on_update_chat_active(Chat *c, ChatId chat_id, bool is_active);
+  static void on_update_chat_migrated_to_channel_id(Chat *c, ChatId chat_id, ChannelId migrated_to_channel_id);
 
   void on_update_chat_full_photo(ChatFull *chat_full, ChatId chat_id, Photo photo);
   bool on_update_chat_full_participants_short(ChatFull *chat_full, ChatId chat_id, int32 version);
@@ -1212,10 +1213,11 @@ class ContactsManager final : public Actor {
 
   void on_update_channel_photo(Channel *c, ChannelId channel_id,
                                tl_object_ptr<telegram_api::ChatPhoto> &&chat_photo_ptr);
-  void on_update_channel_title(Channel *c, ChannelId channel_id, string &&title);
+  static void on_update_channel_title(Channel *c, ChannelId channel_id, string &&title);
   void on_update_channel_username(Channel *c, ChannelId channel_id, string &&username);
   void on_update_channel_status(Channel *c, ChannelId channel_id, DialogParticipantStatus &&status);
-  void on_update_channel_default_permissions(Channel *c, ChannelId channel_id, RestrictedRights default_permissions);
+  static void on_update_channel_default_permissions(Channel *c, ChannelId channel_id,
+                                                    RestrictedRights default_permissions);
 
   void on_update_channel_bot_user_ids(ChannelId channel_id, vector<UserId> &&bot_user_ids);
 
@@ -1227,9 +1229,10 @@ class ContactsManager final : public Actor {
   void on_update_channel_full_location(ChannelFull *channel_full, ChannelId channel_id, const DialogLocation &location);
   void on_update_channel_full_slow_mode_delay(ChannelFull *channel_full, ChannelId channel_id, int32 slow_mode_delay,
                                               int32 slow_mode_next_send_date);
-  void on_update_channel_full_slow_mode_next_send_date(ChannelFull *channel_full, int32 slow_mode_next_send_date);
-  void on_update_channel_full_bot_user_ids(ChannelFull *channel_full, ChannelId channel_id,
-                                           vector<UserId> &&bot_user_ids);
+  static void on_update_channel_full_slow_mode_next_send_date(ChannelFull *channel_full,
+                                                              int32 slow_mode_next_send_date);
+  static void on_update_channel_full_bot_user_ids(ChannelFull *channel_full, ChannelId channel_id,
+                                                  vector<UserId> &&bot_user_ids);
 
   void on_channel_status_changed(const Channel *c, ChannelId channel_id, const DialogParticipantStatus &old_status,
                                  const DialogParticipantStatus &new_status);
@@ -1243,15 +1246,15 @@ class ContactsManager final : public Actor {
 
   void speculative_add_channel_participant_count(ChannelId channel_id, int32 delta_participant_count, bool by_me);
 
-  void speculative_add_channel_user(ChannelId channel_id, UserId user_id, DialogParticipantStatus new_status,
-                                    DialogParticipantStatus old_status);
+  void speculative_add_channel_user(ChannelId channel_id, UserId user_id, const DialogParticipantStatus &new_status,
+                                    const DialogParticipantStatus &old_status);
 
   void drop_chat_photos(ChatId chat_id, bool is_empty, bool drop_chat_full_photo, const char *source);
   void drop_chat_full(ChatId chat_id);
 
   void drop_channel_photos(ChannelId channel_id, bool is_empty, bool drop_channel_full_photo, const char *source);
 
-  void do_invalidate_channel_full(ChannelFull *channel_full, bool need_drop_slow_mode_delay);
+  static void do_invalidate_channel_full(ChannelFull *channel_full, bool need_drop_slow_mode_delay);
 
   void update_user_online_member_count(User *u);
   void update_chat_online_member_count(const ChatFull *chat_full, ChatId chat_id, bool is_from_server);
@@ -1331,7 +1334,7 @@ class ContactsManager final : public Actor {
   void update_channel_full(ChannelFull *channel_full, ChannelId channel_id, const char *source,
                            bool from_database = false);
 
-  bool is_chat_full_outdated(const ChatFull *chat_full, const Chat *c, ChatId chat_id);
+  static bool is_chat_full_outdated(const ChatFull *chat_full, const Chat *c, ChatId chat_id);
 
   bool is_user_contact(const User *u, UserId user_id, bool is_mutual) const;
 
@@ -1360,8 +1363,8 @@ class ContactsManager final : public Actor {
   void on_clear_imported_contacts(vector<Contact> &&contacts, vector<size_t> contacts_unique_id,
                                   std::pair<vector<size_t>, vector<Contact>> &&to_add, Promise<Unit> &&promise);
 
-  void send_update_chat_member(DialogId dialog_id, UserId agent_user_id, int32 date, DialogInviteLink invite_link,
-                               const DialogParticipant &old_dialog_participant,
+  void send_update_chat_member(DialogId dialog_id, UserId agent_user_id, int32 date,
+                               const DialogInviteLink &invite_link, const DialogParticipant &old_dialog_participant,
                                const DialogParticipant &new_dialog_participant);
 
   static vector<td_api::object_ptr<td_api::chatNearby>> get_chats_nearby_object(
@@ -1395,8 +1398,8 @@ class ContactsManager final : public Actor {
 
   void add_chat_participant(ChatId chat_id, UserId user_id, int32 forward_limit, Promise<Unit> &&promise);
 
-  void add_channel_participant(ChannelId channel_id, UserId user_id, Promise<Unit> &&promise,
-                               DialogParticipantStatus old_status);
+  void add_channel_participant(ChannelId channel_id, UserId user_id, const DialogParticipantStatus &old_status,
+                               Promise<Unit> &&promise);
 
   void add_channel_participants(ChannelId channel_id, const vector<UserId> &user_ids, Promise<Unit> &&promise);
 
@@ -1461,7 +1464,7 @@ class ContactsManager final : public Actor {
 
   static td_api::object_ptr<td_api::updateSupergroup> get_update_unknown_supergroup_object(ChannelId channel_id);
 
-  tl_object_ptr<td_api::supergroup> get_supergroup_object(ChannelId channel_id, const Channel *c) const;
+  static tl_object_ptr<td_api::supergroup> get_supergroup_object(ChannelId channel_id, const Channel *c);
 
   tl_object_ptr<td_api::supergroupFullInfo> get_supergroup_full_info_object(const ChannelFull *channel_full,
                                                                             ChannelId channel_id) const;
@@ -1514,11 +1517,11 @@ class ContactsManager final : public Actor {
                                            DialogParticipantStatus status, DialogParticipantStatus old_status,
                                            Promise<Unit> &&promise);
 
-  void promote_channel_participant(ChannelId channel_id, UserId user_id, DialogParticipantStatus status,
-                                   DialogParticipantStatus old_status, Promise<Unit> &&promise);
+  void promote_channel_participant(ChannelId channel_id, UserId user_id, const DialogParticipantStatus &status,
+                                   const DialogParticipantStatus &old_status, Promise<Unit> &&promise);
 
   void restrict_channel_participant(ChannelId channel_id, DialogId participant_dialog_id,
-                                    DialogParticipantStatus status, DialogParticipantStatus old_status,
+                                    DialogParticipantStatus &&status, DialogParticipantStatus &&old_status,
                                     Promise<Unit> &&promise);
 
   void transfer_channel_ownership(ChannelId channel_id, UserId user_id,

td/telegram/CountryInfoManager.cpp

@@ -214,9 +214,9 @@ void CountryInfoManager::do_get_phone_number_info(string phone_number_prefix, st
                     }));
 }
 
-td_api::object_ptr<td_api::phoneNumberInfo> CountryInfoManager::get_phone_number_info_sync(string language_code,
+td_api::object_ptr<td_api::phoneNumberInfo> CountryInfoManager::get_phone_number_info_sync(const string &language_code,
                                                                                            string phone_number_prefix) {
-  td::remove_if(phone_number_prefix, [](char c) { return c < '0' || c > '9'; });
+  td::remove_if(phone_number_prefix, [](char c) { return !is_digit(c); });
   if (phone_number_prefix.empty()) {
     return td_api::make_object<td_api::phoneNumberInfo>(nullptr, string(), string());
   }
@@ -401,7 +401,7 @@ void CountryInfoManager::on_get_country_list_impl(const string &language_code,
         info.country_code = std::move(c->iso2_);
         info.default_name = std::move(c->default_name_);
         info.name = std::move(c->name_);
-        info.is_hidden = std::move(c->hidden_);
+        info.is_hidden = c->hidden_;
         for (auto &code : c->country_codes_) {
           auto r_calling_code = to_integer_safe<int32>(code->country_code_);
           if (r_calling_code.is_error() || r_calling_code.ok() <= 0) {

td/telegram/CountryInfoManager.h

@@ -34,7 +34,7 @@ class CountryInfoManager final : public Actor {
   void get_phone_number_info(string phone_number_prefix,
                              Promise<td_api::object_ptr<td_api::phoneNumberInfo>> &&promise);
 
-  static td_api::object_ptr<td_api::phoneNumberInfo> get_phone_number_info_sync(string language_code,
+  static td_api::object_ptr<td_api::phoneNumberInfo> get_phone_number_info_sync(const string &language_code,
                                                                                 string phone_number_prefix);
 
   CountryInfoManager(const CountryInfoManager &) = delete;

td/telegram/DeviceTokenManager.cpp

@@ -129,7 +129,7 @@ StringBuilder &operator<<(StringBuilder &string_builder, const DeviceTokenManage
 }
 
 void DeviceTokenManager::register_device(tl_object_ptr<td_api::DeviceToken> device_token_ptr,
-                                         vector<UserId> other_user_ids,
+                                         const vector<UserId> &other_user_ids,
                                          Promise<td_api::object_ptr<td_api::pushReceiverId>> promise) {
   CHECK(device_token_ptr != nullptr);
   TokenType token_type;
@@ -259,7 +259,7 @@ void DeviceTokenManager::register_device(tl_object_ptr<td_api::DeviceToken> devi
   if (encrypt != info.encrypt) {
     if (encrypt) {
       constexpr size_t ENCRYPTION_KEY_LENGTH = 256;
-      constexpr int64 MIN_ENCRYPTION_KEY_ID = static_cast<int64>(10000000000000ll);
+      constexpr auto MIN_ENCRYPTION_KEY_ID = static_cast<int64>(10000000000000ll);
       info.encryption_key.resize(ENCRYPTION_KEY_LENGTH);
       while (true) {
         Random::secure_bytes(info.encryption_key);

td/telegram/DeviceTokenManager.h

@@ -26,7 +26,7 @@ class DeviceTokenManager final : public NetQueryCallback {
  public:
   explicit DeviceTokenManager(ActorShared<> parent) : parent_(std::move(parent)) {
   }
-  void register_device(tl_object_ptr<td_api::DeviceToken> device_token_ptr, vector<UserId> other_user_ids,
+  void register_device(tl_object_ptr<td_api::DeviceToken> device_token_ptr, const vector<UserId> &other_user_ids,
                        Promise<td_api::object_ptr<td_api::pushReceiverId>> promise);
 
   void reregister_device();

td/telegram/DhCache.cpp

@@ -27,7 +27,7 @@ int DhCache::is_good_prime(Slice prime_str) const {
   if (value == "bad") {
     return 0;
   }
-  CHECK(value == "");
+  CHECK(value.empty());
   return -1;
 }
 

td/telegram/DialogAction.cpp

@@ -46,7 +46,7 @@ void DialogAction::init(Type type, string emoji) {
   }
 }
 
-void DialogAction::init(Type type, int32 message_id, string emoji, string data) {
+void DialogAction::init(Type type, int32 message_id, string emoji, const string &data) {
   if (ServerMessageId(message_id).is_valid() && is_valid_emoji(emoji) && check_utf8(data)) {
     type_ = type;
     progress_ = message_id;
@@ -199,7 +199,7 @@ DialogAction::DialogAction(telegram_api::object_ptr<telegram_api::SendMessageAct
     case telegram_api::sendMessageEmojiInteraction::ID: {
       auto emoji_interaction_action = move_tl_object_as<telegram_api::sendMessageEmojiInteraction>(action);
       init(Type::ClickingAnimatedEmoji, emoji_interaction_action->msg_id_,
-           std::move(emoji_interaction_action->emoticon_), std::move(emoji_interaction_action->interaction_->data_));
+           std::move(emoji_interaction_action->emoticon_), emoji_interaction_action->interaction_->data_);
       break;
     }
     default:

td/telegram/DialogAction.h

@@ -49,7 +49,7 @@ class DialogAction {
 
   void init(Type type, string emoji);
 
-  void init(Type type, int32 message_id, string emoji, string data);
+  void init(Type type, int32 message_id, string emoji, const string &data);
 
   static bool is_valid_emoji(string &emoji);
 

td/telegram/DialogParticipant.cpp

@@ -458,7 +458,7 @@ DialogParticipantStatus get_dialog_participant_status(const tl_object_ptr<td_api
 }
 
 DialogParticipantStatus get_dialog_participant_status(bool can_be_edited,
-                                                      const tl_object_ptr<telegram_api::chatAdminRights> &admin_rights,
+                                                      tl_object_ptr<telegram_api::chatAdminRights> &&admin_rights,
                                                       string rank) {
   bool can_change_info = (admin_rights->flags_ & telegram_api::chatAdminRights::CHANGE_INFO_MASK) != 0;
   bool can_post_messages = (admin_rights->flags_ & telegram_api::chatAdminRights::POST_MESSAGES_MASK) != 0;
@@ -480,8 +480,8 @@ DialogParticipantStatus get_dialog_participant_status(bool can_be_edited,
                                                 can_pin_messages, can_promote_members, can_manage_calls);
 }
 
-DialogParticipantStatus get_dialog_participant_status(
-    bool is_member, const tl_object_ptr<telegram_api::chatBannedRights> &banned_rights) {
+DialogParticipantStatus get_dialog_participant_status(bool is_member,
+                                                      tl_object_ptr<telegram_api::chatBannedRights> &&banned_rights) {
   bool can_view_messages = (banned_rights->flags_ & telegram_api::chatBannedRights::VIEW_MESSAGES_MASK) == 0;
   if (!can_view_messages) {
     return DialogParticipantStatus::Banned(banned_rights->until_date_);
@@ -616,7 +616,7 @@ StringBuilder &operator<<(StringBuilder &string_builder, const RestrictedRights
   return string_builder;
 }
 
-RestrictedRights get_restricted_rights(const tl_object_ptr<telegram_api::chatBannedRights> &banned_rights) {
+RestrictedRights get_restricted_rights(tl_object_ptr<telegram_api::chatBannedRights> &&banned_rights) {
   if (banned_rights == nullptr) {
     return RestrictedRights(false, false, false, false, false, false, false, false, false, false, false);
   }
@@ -657,14 +657,14 @@ RestrictedRights get_restricted_rights(const td_api::object_ptr<td_api::chatPerm
 
 DialogParticipant::DialogParticipant(DialogId dialog_id, UserId inviter_user_id, int32 joined_date,
                                      DialogParticipantStatus status)
-    : dialog_id(dialog_id), inviter_user_id(inviter_user_id), joined_date(joined_date), status(status) {
+    : dialog_id(dialog_id), inviter_user_id(inviter_user_id), joined_date(joined_date), status(std::move(status)) {
   if (!inviter_user_id.is_valid() && inviter_user_id != UserId()) {
     LOG(ERROR) << "Receive inviter " << inviter_user_id;
-    inviter_user_id = UserId();
+    this->inviter_user_id = UserId();
   }
   if (joined_date < 0) {
     LOG(ERROR) << "Receive date " << joined_date;
-    joined_date = 0;
+    this->joined_date = 0;
   }
 }
 

td/telegram/DialogParticipant.h

@@ -397,7 +397,7 @@ struct DialogParticipant {
 
   DialogParticipant() = default;
 
-  DialogParticipant(DialogId user_id, UserId inviter_user_id, int32 joined_date, DialogParticipantStatus status);
+  DialogParticipant(DialogId dialog_id, UserId inviter_user_id, int32 joined_date, DialogParticipantStatus status);
 
   DialogParticipant(tl_object_ptr<telegram_api::ChatParticipant> &&participant_ptr, int32 chat_creation_date,
                     bool is_creator);
@@ -508,13 +508,13 @@ DialogParticipantsFilter get_dialog_participants_filter(const tl_object_ptr<td_a
 DialogParticipantStatus get_dialog_participant_status(const tl_object_ptr<td_api::ChatMemberStatus> &status);
 
 DialogParticipantStatus get_dialog_participant_status(bool can_be_edited,
-                                                      const tl_object_ptr<telegram_api::chatAdminRights> &admin_rights,
+                                                      tl_object_ptr<telegram_api::chatAdminRights> &&admin_rights,
                                                       string rank);
 
-DialogParticipantStatus get_dialog_participant_status(
-    bool is_member, const tl_object_ptr<telegram_api::chatBannedRights> &banned_rights);
+DialogParticipantStatus get_dialog_participant_status(bool is_member,
+                                                      tl_object_ptr<telegram_api::chatBannedRights> &&banned_rights);
 
-RestrictedRights get_restricted_rights(const tl_object_ptr<telegram_api::chatBannedRights> &banned_rights);
+RestrictedRights get_restricted_rights(tl_object_ptr<telegram_api::chatBannedRights> &&banned_rights);
 
 RestrictedRights get_restricted_rights(const td_api::object_ptr<td_api::chatPermissions> &permissions);
 

td/telegram/DocumentsManager.cpp

@@ -573,7 +573,7 @@ SecretInputMedia DocumentsManager::get_secret_input_media(FileId document_file_i
     return SecretInputMedia{};
   }
   vector<tl_object_ptr<secret_api::DocumentAttribute>> attributes;
-  if (document->file_name.size()) {
+  if (!document->file_name.empty()) {
     attributes.push_back(make_tl_object<secret_api::documentAttributeFilename>(document->file_name));
   }
   return SecretInputMedia{
@@ -604,7 +604,7 @@ tl_object_ptr<telegram_api::InputMedia> DocumentsManager::get_input_media(
     CHECK(document != nullptr);
 
     vector<tl_object_ptr<telegram_api::DocumentAttribute>> attributes;
-    if (document->file_name.size()) {
+    if (!document->file_name.empty()) {
       attributes.push_back(make_tl_object<telegram_api::documentAttributeFilename>(document->file_name));
     }
     int32 flags = 0;

td/telegram/FileReferenceManager.h

@@ -54,7 +54,8 @@ class FileReferenceManager final : public Actor {
 
   using NodeId = FileId;
   void repair_file_reference(NodeId node_id, Promise<> promise);
-  void reload_photo(PhotoSizeSource source, Promise<Unit> promise);
+
+  static void reload_photo(PhotoSizeSource source, Promise<Unit> promise);
 
   bool add_file_source(NodeId node_id, FileSourceId file_source_id);
 

td/telegram/Global.h

@@ -369,7 +369,7 @@ class Global final : public ActorContext {
   void set_dh_config(std::shared_ptr<DhConfig> new_dh_config) {
 #if !TD_HAVE_ATOMIC_SHARED_PTR
     std::lock_guard<std::mutex> guard(dh_config_mutex_);
-    dh_config_ = new_dh_config;
+    dh_config_ = std::move(new_dh_config);
 #else
     atomic_store(&dh_config_, std::move(new_dh_config));
 #endif

td/telegram/GroupCallManager.cpp

@@ -1749,6 +1749,7 @@ void GroupCallManager::on_update_group_call_participants(
           });
       td_->create_handler<GetGroupCallParticipantQuery>(std::move(query_promise))
           ->send(input_group_call_id, std::move(input_peers), {});
+      return;
     }
   }
 
@@ -1961,8 +1962,9 @@ void GroupCallManager::on_sync_group_call_participants(InputGroupCallId input_gr
   }
 }
 
-GroupCallParticipantOrder GroupCallManager::get_real_participant_order(
-    bool can_self_unmute, const GroupCallParticipant &participant, const GroupCallParticipants *participants) const {
+GroupCallParticipantOrder GroupCallManager::get_real_participant_order(bool can_self_unmute,
+                                                                       const GroupCallParticipant &participant,
+                                                                       const GroupCallParticipants *participants) {
   auto real_order = participant.get_real_order(can_self_unmute, participants->joined_date_asc, false);
   if (real_order >= participants->min_order) {
     return real_order;
@@ -4091,7 +4093,7 @@ InputGroupCallId GroupCallManager::update_group_call(const tl_object_ptr<telegra
       auto group_call = static_cast<const telegram_api::groupCall *>(group_call_ptr.get());
       input_group_call_id = InputGroupCallId(group_call->id_, group_call->access_hash_);
       call.is_active = true;
-      call.title = std::move(group_call->title_);
+      call.title = group_call->title_;
       call.start_subscribed = group_call->schedule_start_subscribed_;
       call.mute_new_participants = group_call->join_muted_;
       call.joined_date_asc = group_call->join_date_asc_;
@@ -4465,8 +4467,10 @@ void GroupCallManager::remove_recent_group_call_speaker(InputGroupCallId input_g
 void GroupCallManager::on_group_call_recent_speakers_updated(const GroupCall *group_call,
                                                              GroupCallRecentSpeakers *recent_speakers) {
   if (group_call == nullptr || !group_call->is_inited || recent_speakers->is_changed) {
-    LOG(INFO) << "Don't need to send update of recent speakers in " << group_call->group_call_id << " from "
-              << group_call->dialog_id;
+    if (group_call != nullptr) {
+      LOG(INFO) << "Don't need to send update of recent speakers in " << group_call->group_call_id << " from "
+                << group_call->dialog_id;
+    }
     return;
   }
 
@@ -4662,12 +4666,12 @@ vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> GroupCallManager::get
 }
 
 tl_object_ptr<td_api::groupCall> GroupCallManager::get_group_call_object(
-    const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) const {
+    const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) {
   CHECK(group_call != nullptr);
   CHECK(group_call->is_inited);
 
   int32 scheduled_start_date = group_call->scheduled_start_date;
-  bool is_active = scheduled_start_date == 0 ? group_call->is_active : 0;
+  bool is_active = scheduled_start_date == 0 ? group_call->is_active : false;
   bool is_joined = group_call->is_joined && !group_call->is_being_left;
   bool start_subscribed = get_group_call_start_subscribed(group_call);
   bool is_my_video_enabled = get_group_call_is_my_video_enabled(group_call);
@@ -4688,7 +4692,7 @@ tl_object_ptr<td_api::groupCall> GroupCallManager::get_group_call_object(
 }
 
 tl_object_ptr<td_api::updateGroupCall> GroupCallManager::get_update_group_call_object(
-    const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) const {
+    const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) {
   return td_api::make_object<td_api::updateGroupCall>(get_group_call_object(group_call, std::move(recent_speakers)));
 }
 

td/telegram/GroupCallManager.h

@@ -233,8 +233,9 @@ class GroupCallManager final : public Actor {
   void on_sync_group_call_participants(InputGroupCallId input_group_call_id,
                                        Result<tl_object_ptr<telegram_api::phone_groupCall>> &&result);
 
-  GroupCallParticipantOrder get_real_participant_order(bool can_self_unmute, const GroupCallParticipant &participant,
-                                                       const GroupCallParticipants *participants) const;
+  static GroupCallParticipantOrder get_real_participant_order(bool can_self_unmute,
+                                                              const GroupCallParticipant &participant,
+                                                              const GroupCallParticipants *participants);
 
   void process_my_group_call_participant(InputGroupCallId input_group_call_id, GroupCallParticipant &&participant);
 
@@ -242,8 +243,8 @@ class GroupCallManager final : public Actor {
                                        vector<tl_object_ptr<telegram_api::groupCallParticipant>> &&participants,
                                        int32 version, const string &offset, bool is_load, bool is_sync);
 
-  bool update_group_call_participant_can_be_muted(bool can_manage, const GroupCallParticipants *participants,
-                                                  GroupCallParticipant &participant);
+  static bool update_group_call_participant_can_be_muted(bool can_manage, const GroupCallParticipants *participants,
+                                                         GroupCallParticipant &participant);
 
   void update_group_call_participants_can_be_muted(InputGroupCallId input_group_call_id, bool can_manage,
                                                    GroupCallParticipants *participants);
@@ -358,11 +359,11 @@ class GroupCallManager final : public Actor {
   vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> get_recent_speakers(const GroupCall *group_call,
                                                                                  bool for_update);
 
-  tl_object_ptr<td_api::updateGroupCall> get_update_group_call_object(
-      const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) const;
+  static tl_object_ptr<td_api::updateGroupCall> get_update_group_call_object(
+      const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers);
 
-  tl_object_ptr<td_api::groupCall> get_group_call_object(
-      const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers) const;
+  static tl_object_ptr<td_api::groupCall> get_group_call_object(
+      const GroupCall *group_call, vector<td_api::object_ptr<td_api::groupCallRecentSpeaker>> recent_speakers);
 
   tl_object_ptr<td_api::updateGroupCallParticipant> get_update_group_call_participant_object(
       GroupCallId group_call_id, const GroupCallParticipant &participant);

td/telegram/GroupCallParticipant.cpp

@@ -20,7 +20,7 @@ GroupCallParticipant::GroupCallParticipant(const tl_object_ptr<telegram_api::gro
                                            int32 call_version) {
   CHECK(participant != nullptr);
   dialog_id = DialogId(participant->peer_);
-  about = std::move(participant->about_);
+  about = participant->about_;
   audio_source = participant->source_;
   server_is_muted_by_themselves = participant->can_self_unmute_;
   server_is_muted_by_admin = participant->muted_ && !participant->can_self_unmute_;

td/telegram/InlineQueriesManager.cpp

@@ -487,7 +487,11 @@ void InlineQueriesManager::answer_inline_query(int64 inline_query_id, bool is_pe
         if (first_name.empty()) {
           return promise.set_error(Status::Error(400, "Field \"first_name\" must be non-empty"));
         }
-        title = last_name.empty() ? first_name : first_name + " " + last_name;
+        if (last_name.empty()) {
+          title = std::move(first_name);
+        } else {
+          title = PSTRING() << first_name << ' ' << last_name;
+        }
         description = std::move(phone_number);
         thumbnail_url = std::move(contact->thumbnail_url_);
         if (!thumbnail_url.empty()) {
@@ -1459,7 +1463,7 @@ void InlineQueriesManager::on_get_inline_query_results(DialogId dialog_id, UserI
         if (result->type_ == "article") {
           auto article = make_tl_object<td_api::inlineQueryResultArticle>();
           article->id_ = std::move(result->id_);
-          article->url_ = get_web_document_url(std::move(result->content_));
+          article->url_ = get_web_document_url(result->content_);
           if (result->url_.empty()) {
             article->hide_url_ = true;
           } else {

td/telegram/JsonValue.cpp

@@ -220,7 +220,7 @@ int32 get_json_value_int(telegram_api::object_ptr<telegram_api::JSONValue> &&jso
 string get_json_value_string(telegram_api::object_ptr<telegram_api::JSONValue> &&json_value, Slice name) {
   CHECK(json_value != nullptr);
   if (json_value->get_id() == telegram_api::jsonString::ID) {
-    return std::move(static_cast<const telegram_api::jsonString *>(json_value.get())->value_);
+    return std::move(static_cast<telegram_api::jsonString *>(json_value.get())->value_);
   }
   LOG(ERROR) << "Expected String as " << name << ", but found " << to_string(json_value);
   return string();

td/telegram/LanguagePackManager.cpp

@@ -170,7 +170,7 @@ static string load_database_language_base_language_code(SqliteKeyValue *kv) {
   return kv->get("!base_language_code");
 }
 
-LanguagePackManager::LanguageDatabase *LanguagePackManager::add_language_database(const string &path) {
+LanguagePackManager::LanguageDatabase *LanguagePackManager::add_language_database(string path) {
   auto it = language_databases_.find(path);
   if (it != language_databases_.end()) {
     return it->second.get();
@@ -395,11 +395,11 @@ void LanguagePackManager::on_language_pack_version_changed(bool is_base, int32 n
 
   LOG(INFO) << (is_base ? "Base" : "Main") << " language pack " << language_code << " vesrion has changed to "
             << new_version;
-  send_language_get_difference_query(language, language_code, version, Auto());
+  send_language_get_difference_query(language, std::move(language_code), version, Auto());
 }
 
-void LanguagePackManager::send_language_get_difference_query(Language *language, const string &language_code,
-                                                             int32 version, Promise<Unit> &&promise) {
+void LanguagePackManager::send_language_get_difference_query(Language *language, string language_code, int32 version,
+                                                             Promise<Unit> &&promise) {
   std::lock_guard<std::mutex> lock(language->mutex_);
   language->get_difference_queries_.push_back(std::move(promise));
   if (language->has_get_difference_query_) {
@@ -1179,7 +1179,7 @@ void LanguagePackManager::synchronize_language_pack(string language_code, Promis
   if (version == -1) {
     version = 0;
   }
-  send_language_get_difference_query(language, language_code, version, std::move(promise));
+  send_language_get_difference_query(language, std::move(language_code), version, std::move(promise));
 }
 
 static td_api::object_ptr<td_api::LanguagePackStringValue> copy_language_pack_string_value(
@@ -1294,7 +1294,7 @@ bool LanguagePackManager::is_valid_key(Slice key) {
 }
 
 void LanguagePackManager::save_strings_to_database(SqliteKeyValue *kv, int32 new_version, bool new_is_full,
-                                                   int32 new_key_count, vector<std::pair<string, string>> strings) {
+                                                   int32 new_key_count, vector<std::pair<string, string>> &&strings) {
   LOG(DEBUG) << "Save to database a language pack with new version " << new_version << " and " << strings.size()
              << " new strings";
   if (new_version == -1 && strings.empty()) {
@@ -1314,7 +1314,7 @@ void LanguagePackManager::save_strings_to_database(SqliteKeyValue *kv, int32 new
   }
 
   kv->begin_write_transaction().ensure();
-  for (auto str : strings) {
+  for (const auto &str : strings) {
     if (!is_valid_key(str.first)) {
       LOG(ERROR) << "Have invalid key \"" << str.first << '"';
       continue;
@@ -1339,7 +1339,7 @@ void LanguagePackManager::save_strings_to_database(SqliteKeyValue *kv, int32 new
 }
 
 void LanguagePackManager::on_get_language_pack_strings(
-    string language_pack, string language_code, int32 version, bool is_diff, vector<string> keys,
+    string language_pack, string language_code, int32 version, bool is_diff, vector<string> &&keys,
     vector<tl_object_ptr<telegram_api::LangPackString>> results,
     Promise<td_api::object_ptr<td_api::languagePackStrings>> promise) {
   Language *language = get_language(database_, language_pack, language_code);
@@ -1370,7 +1370,7 @@ void LanguagePackManager::on_get_language_pack_strings(
         CHECK(result != nullptr);
         switch (result->get_id()) {
           case telegram_api::langPackString::ID: {
-            auto str = static_cast<telegram_api::langPackString *>(result.get());
+            auto str = telegram_api::move_object_as<telegram_api::langPackString>(result);
             auto it = language->ordinary_strings_.find(str->key_);
             if (it == language->ordinary_strings_.end()) {
               key_count_delta++;
@@ -1383,11 +1383,11 @@ void LanguagePackManager::on_get_language_pack_strings(
             if (is_diff) {
               strings.push_back(get_language_pack_string_object(*it));
             }
-            database_strings.emplace_back(str->key_, PSTRING() << '1' << it->second);
+            database_strings.emplace_back(std::move(str->key_), PSTRING() << '1' << it->second);
             break;
           }
           case telegram_api::langPackStringPluralized::ID: {
-            auto str = static_cast<const telegram_api::langPackStringPluralized *>(result.get());
+            auto str = telegram_api::move_object_as<telegram_api::langPackStringPluralized>(result);
             PluralizedString value{std::move(str->zero_value_), std::move(str->one_value_),
                                    std::move(str->two_value_),  std::move(str->few_value_),
                                    std::move(str->many_value_), std::move(str->other_value_)};
@@ -1404,20 +1404,21 @@ void LanguagePackManager::on_get_language_pack_strings(
               strings.push_back(get_language_pack_string_object(*it));
             }
             database_strings.emplace_back(
-                str->key_, PSTRING() << '2' << it->second.zero_value_ << '\x00' << it->second.one_value_ << '\x00'
-                                     << it->second.two_value_ << '\x00' << it->second.few_value_ << '\x00'
-                                     << it->second.many_value_ << '\x00' << it->second.other_value_);
+                std::move(str->key_), PSTRING()
+                                          << '2' << it->second.zero_value_ << '\x00' << it->second.one_value_ << '\x00'
+                                          << it->second.two_value_ << '\x00' << it->second.few_value_ << '\x00'
+                                          << it->second.many_value_ << '\x00' << it->second.other_value_);
             break;
           }
           case telegram_api::langPackStringDeleted::ID: {
-            auto str = static_cast<const telegram_api::langPackStringDeleted *>(result.get());
+            auto str = telegram_api::move_object_as<telegram_api::langPackStringDeleted>(result);
             key_count_delta -= static_cast<int32>(language->ordinary_strings_.erase(str->key_));
             key_count_delta -= static_cast<int32>(language->pluralized_strings_.erase(str->key_));
-            language->deleted_strings_.insert(std::move(str->key_));
+            language->deleted_strings_.insert(str->key_);
             if (is_diff) {
               strings.push_back(get_language_pack_string_object(str->key_));
             }
-            database_strings.emplace_back(str->key_, "3");
+            database_strings.emplace_back(std::move(str->key_), "3");
             break;
           }
           default:
@@ -1426,7 +1427,7 @@ void LanguagePackManager::on_get_language_pack_strings(
         }
       }
       if (!language->is_full_) {
-        for (auto &key : keys) {
+        for (const auto &key : keys) {
           if (!language_has_string_unsafe(language, key)) {
             LOG(ERROR) << "Doesn't receive key " << key << " from server";
             language->deleted_strings_.insert(key);
@@ -1822,7 +1823,7 @@ void LanguagePackManager::delete_language(string language_code, Promise<Unit> &&
   }
 }
 
-Status LanguagePackManager::do_delete_language(string language_code) {
+Status LanguagePackManager::do_delete_language(const string &language_code) {
   add_language(database_, language_pack_, language_code);
 
   std::lock_guard<std::mutex> packs_lock(database_->mutex_);

td/telegram/LanguagePackManager.h

@@ -108,7 +108,7 @@ class LanguagePackManager final : public NetQueryCallback {
   static std::mutex language_database_mutex_;
   static std::unordered_map<string, unique_ptr<LanguageDatabase>> language_databases_;
 
-  static LanguageDatabase *add_language_database(const string &path);
+  static LanguageDatabase *add_language_database(string path);
 
   static Language *get_language(LanguageDatabase *database, const string &language_pack, const string &language_code);
   static Language *get_language(LanguagePack *language_pack, const string &language_code);
@@ -160,25 +160,25 @@ class LanguagePackManager final : public NetQueryCallback {
   static bool is_valid_key(Slice key);
 
   void save_strings_to_database(SqliteKeyValue *kv, int32 new_version, bool new_is_full, int32 new_key_count,
-                                vector<std::pair<string, string>> strings);
+                                vector<std::pair<string, string>> &&strings);
 
   void load_empty_language_pack(const string &language_code);
 
   void on_get_language_pack_strings(string language_pack, string language_code, int32 version, bool is_diff,
-                                    vector<string> keys, vector<tl_object_ptr<telegram_api::LangPackString>> results,
+                                    vector<string> &&keys, vector<tl_object_ptr<telegram_api::LangPackString>> results,
                                     Promise<td_api::object_ptr<td_api::languagePackStrings>> promise);
 
   void on_get_all_language_pack_strings(string language_pack, string language_code,
                                         Result<td_api::object_ptr<td_api::languagePackStrings>> r_strings);
 
-  void send_language_get_difference_query(Language *language, const string &language_code, int32 version,
+  void send_language_get_difference_query(Language *language, string language_code, int32 version,
                                           Promise<Unit> &&promise);
 
   void on_failed_get_difference(string language_pack, string language_code, Status error);
 
   void on_get_language_info(const string &language_pack, td_api::languagePackInfo *language_pack_info);
 
-  void save_server_language_pack_infos(LanguagePack *pack);
+  static void save_server_language_pack_infos(LanguagePack *pack);
 
   void on_get_languages(vector<tl_object_ptr<telegram_api::langPackLanguage>> languages, string language_pack,
                         bool only_local, Promise<td_api::object_ptr<td_api::localizationTargetInfo>> promise);
@@ -186,7 +186,7 @@ class LanguagePackManager final : public NetQueryCallback {
   void on_get_language(tl_object_ptr<telegram_api::langPackLanguage> lang_pack_language, string language_pack,
                        string language_code, Promise<td_api::object_ptr<td_api::languagePackInfo>> promise);
 
-  Status do_delete_language(string language_code);
+  Status do_delete_language(const string &language_code);
 
   void on_result(NetQueryPtr query) final;
 

td/telegram/LinkManager.cpp

@@ -77,7 +77,7 @@ static string get_url_query_hash(bool is_tg, const HttpUrlQuery &url_query) {
       // /joinchat/<link>
       return path[1];
     }
-    if (path.size() >= 1 && path[0].size() >= 2 && (path[0][0] == ' ' || path[0][0] == '+')) {
+    if (!path.empty() && path[0].size() >= 2 && (path[0][0] == ' ' || path[0][0] == '+')) {
       // /+<link>
       return path[0].substr(1);
     }
@@ -811,7 +811,7 @@ unique_ptr<LinkManager::InternalLink> LinkManager::parse_tg_link_query(Slice que
   } else if (path.size() == 1 && path[0] == "passport") {
     // passport?bot_id=<bot_user_id>&scope=<scope>&public_key=<public_key>&nonce=<nonce>
     return get_internal_link_passport(query, url_query.args_);
-  } else if (path.size() >= 1 && path[0] == "settings") {
+  } else if (!path.empty() && path[0] == "settings") {
     if (path.size() == 2 && path[1] == "change_number") {
       // settings/change_number
       return td::make_unique<InternalLinkChangePhoneNumber>();

td/telegram/Location.h

@@ -34,7 +34,7 @@ class Location {
 
   void init(double latitude, double longitude, double horizontal_accuracy, int64 access_hash);
 
-  double fix_accuracy(double accuracy);
+  static double fix_accuracy(double accuracy);
 
  public:
   Location() = default;

td/telegram/MessageEntity.cpp

@@ -1595,7 +1595,7 @@ static void fix_entity_offsets(Slice text, vector<MessageEntity> &entities) {
     auto entity_begin = entity.offset;
     auto entity_end = entity.offset + entity.length;
 
-    int32 pos = static_cast<int32>(ptr - begin);
+    auto pos = static_cast<int32>(ptr - begin);
     if (entity_begin == pos) {
       cnt--;
       entity.offset = utf16_pos;
@@ -3631,7 +3631,7 @@ static Result<string> clean_input_string_with_entities(const string &text, vecto
           utf16_offset += 1 + (c >= 0xf0);  // >= 4 bytes in symbol => surrogate pair
         }
         if (c == 0xe2 && pos + 2 < text_size) {
-          unsigned char next = static_cast<unsigned char>(text[pos + 1]);
+          auto next = static_cast<unsigned char>(text[pos + 1]);
           if (next == 0x80) {
             next = static_cast<unsigned char>(text[pos + 2]);
             if (0xa8 <= next && next <= 0xae) {
@@ -3642,7 +3642,7 @@ static Result<string> clean_input_string_with_entities(const string &text, vecto
           }
         }
         if (c == 0xcc && pos + 1 < text_size) {
-          unsigned char next = static_cast<unsigned char>(text[pos + 1]);
+          auto next = static_cast<unsigned char>(text[pos + 1]);
           // remove vertical lines
           if (next == 0xb3 || next == 0xbf || next == 0x8a) {
             pos++;
@@ -4010,7 +4010,7 @@ Status fix_formatted_text(string &text, vector<MessageEntity> &entities, bool al
       first_non_whitespaces_pos++;
     }
     if (first_non_whitespaces_pos > 0) {
-      int32 offset = narrow_cast<int32>(first_non_whitespaces_pos);
+      auto offset = narrow_cast<int32>(first_non_whitespaces_pos);
       text = result.substr(first_non_whitespaces_pos);
       for (auto &entity : entities) {
         entity.offset -= offset;

td/telegram/MessagesDb.cpp

@@ -902,8 +902,8 @@ class MessagesDbImpl final : public MessagesDbSyncInterface {
     return std::move(right);
   }
 
-  Result<vector<MessagesDbDialogMessage>> get_messages_inner(SqliteStatement &stmt, DialogId dialog_id,
-                                                             int64 from_message_id, int32 limit) {
+  static Result<vector<MessagesDbDialogMessage>> get_messages_inner(SqliteStatement &stmt, DialogId dialog_id,
+                                                                    int64 from_message_id, int32 limit) {
     SCOPE_EXIT {
       stmt.reset();
     };

td/telegram/MessagesManager.cpp

@@ -150,7 +150,7 @@ class UpdateDialogFiltersOrderQuery final : public Td::ResultHandler {
   explicit UpdateDialogFiltersOrderQuery(Promise<Unit> &&promise) : promise_(std::move(promise)) {
   }
 
-  void send(vector<DialogFilterId> dialog_filter_ids) {
+  void send(const vector<DialogFilterId> &dialog_filter_ids) {
     send_query(G()->net_query_creator().create(telegram_api::messages_updateDialogFiltersOrder(
         transform(dialog_filter_ids, [](auto dialog_filter_id) { return dialog_filter_id.get(); }))));
   }
@@ -495,7 +495,7 @@ class GetChannelMessagesQuery final : public Td::ResultHandler {
           }
         }
       }
-      td->messages_manager_->on_get_empty_messages(DialogId(channel_id_), std::move(empty_message_ids));
+      td->messages_manager_->on_get_empty_messages(DialogId(channel_id_), empty_message_ids);
     }
     td->messages_manager_->get_channel_difference_if_needed(
         DialogId(channel_id_), std::move(info),
@@ -1528,7 +1528,7 @@ class SaveDraftMessageQuery final : public Td::ResultHandler {
       if (draft_message->input_message_text.disable_web_page_preview) {
         flags |= MessagesManager::SEND_MESSAGE_FLAG_DISABLE_WEB_PAGE_PREVIEW;
       }
-      if (draft_message->input_message_text.text.entities.size()) {
+      if (!draft_message->input_message_text.text.entities.empty()) {
         flags |= MessagesManager::SEND_MESSAGE_FLAG_HAS_ENTITIES;
       }
     }
@@ -9119,9 +9119,9 @@ void MessagesManager::after_get_difference() {
   }
 }
 
-void MessagesManager::on_get_empty_messages(DialogId dialog_id, vector<MessageId> empty_message_ids) {
+void MessagesManager::on_get_empty_messages(DialogId dialog_id, const vector<MessageId> &empty_message_ids) {
   if (!empty_message_ids.empty()) {
-    delete_dialog_messages(dialog_id, std::move(empty_message_ids), true, true, "on_get_empty_messages");
+    delete_dialog_messages(dialog_id, empty_message_ids, true, true, "on_get_empty_messages");
   }
 }
 
@@ -10139,7 +10139,7 @@ bool MessagesManager::can_get_message_statistics(DialogId dialog_id, const Messa
   return td_->contacts_manager_->can_get_channel_message_statistics(dialog_id);
 }
 
-bool MessagesManager::can_delete_channel_message(DialogParticipantStatus status, const Message *m, bool is_bot) {
+bool MessagesManager::can_delete_channel_message(const DialogParticipantStatus &status, const Message *m, bool is_bot) {
   if (m == nullptr) {
     return true;
   }
@@ -16035,7 +16035,7 @@ void MessagesManager::reload_pinned_dialogs(DialogListId dialog_list_id, Promise
   }
 }
 
-double MessagesManager::get_dialog_filters_cache_time() const {
+double MessagesManager::get_dialog_filters_cache_time() {
   return DIALOG_FILTERS_CACHE_TIME * 0.0001 * Random::fast(9000, 11000);
 }
 
@@ -16618,7 +16618,7 @@ void MessagesManager::on_get_common_dialogs(UserId user_id, int64 offset_chat_id
       td_->contacts_manager_->on_update_user_common_chat_count(user_id, total_count);
     }
 
-    result.push_back(DialogId());
+    result.emplace_back();
   }
   common_dialogs.total_count = total_count;
 }
@@ -17279,15 +17279,15 @@ void MessagesManager::on_get_message_viewers(DialogId dialog_id, vector<UserId>
 void MessagesManager::get_dialog_info_full(DialogId dialog_id, Promise<Unit> &&promise, const char *source) {
   switch (dialog_id.get_type()) {
     case DialogType::User:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::load_user_full, dialog_id.get_user_id(), false,
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::load_user_full, dialog_id.get_user_id(), false,
                          std::move(promise), source);
       return;
     case DialogType::Chat:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::load_chat_full, dialog_id.get_chat_id(), false,
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::load_chat_full, dialog_id.get_chat_id(), false,
                          std::move(promise), source);
       return;
     case DialogType::Channel:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::load_channel_full, dialog_id.get_channel_id(),
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::load_channel_full, dialog_id.get_channel_id(),
                          false, std::move(promise), source);
       return;
     case DialogType::SecretChat:
@@ -17306,15 +17306,15 @@ void MessagesManager::reload_dialog_info_full(DialogId dialog_id) {
 
   switch (dialog_id.get_type()) {
     case DialogType::User:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::reload_user_full, dialog_id.get_user_id());
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::reload_user_full, dialog_id.get_user_id());
       return;
     case DialogType::Chat:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::reload_chat_full, dialog_id.get_chat_id(),
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::reload_chat_full, dialog_id.get_chat_id(),
                          Promise<Unit>());
       return;
     case DialogType::Channel:
-      send_closure_later(G()->contacts_manager(), &ContactsManager::reload_channel_full, dialog_id.get_channel_id(),
-                         Promise<Unit>(), "reload_dialog_info_full");
+      send_closure_later(td_->contacts_manager_actor_, &ContactsManager::reload_channel_full,
+                         dialog_id.get_channel_id(), Promise<Unit>(), "reload_dialog_info_full");
       return;
     case DialogType::SecretChat:
       return;
@@ -18159,7 +18159,7 @@ void MessagesManager::reorder_dialog_filters_on_server(vector<DialogFilterId> di
     send_closure(actor_id, &MessagesManager::on_reorder_dialog_filters, std::move(dialog_filter_ids),
                  result.is_error() ? result.move_as_error() : Status::OK());
   });
-  td_->create_handler<UpdateDialogFiltersOrderQuery>(std::move(promise))->send(std::move(dialog_filter_ids));
+  td_->create_handler<UpdateDialogFiltersOrderQuery>(std::move(promise))->send(dialog_filter_ids);
 }
 
 void MessagesManager::on_reorder_dialog_filters(vector<DialogFilterId> dialog_filter_ids, Status result) {
@@ -19878,7 +19878,7 @@ void MessagesManager::open_dialog(Dialog *d) {
       d->is_has_scheduled_database_messages_checked = true;
       G()->td_db()->get_messages_db_async()->get_scheduled_messages(
           dialog_id, 1,
-          PromiseCreator::lambda([dialog_id, actor_id = actor_id(this)](vector<MessagesDbDialogMessage> messages) {
+          PromiseCreator::lambda([actor_id = actor_id(this), dialog_id](vector<MessagesDbDialogMessage> messages) {
             if (messages.empty()) {
               send_closure(actor_id, &MessagesManager::set_dialog_has_scheduled_database_messages, dialog_id, false);
             }
@@ -20612,7 +20612,7 @@ tl_object_ptr<td_api::messages> MessagesManager::get_dialog_history(DialogId dia
     }
   }
 
-  if (messages.size()) {
+  if (!messages.empty()) {
     // maybe need some messages
     CHECK(offset == 0);
     preload_newer_messages(d, MessageId(messages[0]->id_));
@@ -21799,7 +21799,7 @@ void MessagesManager::on_search_dialog_messages_db_result(int64 random_id, Dialo
   }
 
   auto &message_count = d->message_count_by_index[message_search_filter_index(filter)];
-  int32 result_size = narrow_cast<int32>(res.size());
+  auto result_size = narrow_cast<int32>(res.size());
   bool from_the_end =
       from_message_id == MessageId::max() || (offset < 0 && (result_size == 0 || res[0] < from_message_id));
   if ((message_count != -1 && message_count < result_size) ||
@@ -21843,7 +21843,7 @@ td_api::object_ptr<td_api::foundMessages> MessagesManager::get_found_messages_ob
 }
 
 MessagesManager::FoundMessages MessagesManager::offline_search_messages(DialogId dialog_id, const string &query,
-                                                                        const string &offset, int32 limit,
+                                                                        string offset, int32 limit,
                                                                         MessageSearchFilter filter, int64 &random_id,
                                                                         Promise<> &&promise) {
   if (!G()->parameters().use_message_db) {
@@ -21897,8 +21897,9 @@ MessagesManager::FoundMessages MessagesManager::offline_search_messages(DialogId
   found_fts_messages_[random_id];  // reserve place for result
 
   G()->td_db()->get_messages_db_async()->get_messages_fts(
-      std::move(fts_query), PromiseCreator::lambda([random_id, offset, limit, promise = std::move(promise)](
-                                                       Result<MessagesDbFtsResult> fts_result) mutable {
+      std::move(fts_query),
+      PromiseCreator::lambda([random_id, offset = std::move(offset), limit,
+                              promise = std::move(promise)](Result<MessagesDbFtsResult> fts_result) mutable {
         send_closure(G()->messages_manager(), &MessagesManager::on_messages_db_fts_result, std::move(fts_result),
                      std::move(offset), limit, random_id, std::move(promise));
       }));
@@ -21925,7 +21926,7 @@ void MessagesManager::on_messages_db_fts_result(Result<MessagesDbFtsResult> resu
   for (auto &message : fts_result.messages) {
     auto m = on_get_message_from_database(message, false, "on_messages_db_fts_result");
     if (m != nullptr) {
-      res.push_back(FullMessageId(message.dialog_id, m->message_id));
+      res.emplace_back(message.dialog_id, m->message_id);
     }
   }
 
@@ -21959,7 +21960,7 @@ void MessagesManager::on_messages_db_calls_result(Result<MessagesDbCallsResult>
     auto m = on_get_message_from_database(message, false, "on_messages_db_calls_result");
 
     if (m != nullptr && first_db_message_id <= m->message_id) {
-      res.push_back(FullMessageId(message.dialog_id, m->message_id));
+      res.emplace_back(message.dialog_id, m->message_id);
     }
   }
   it->second.first = calls_db_state_.message_count_by_index[call_message_search_filter_index(filter)];
@@ -23327,7 +23328,7 @@ Status MessagesManager::can_send_message(DialogId dialog_id) const {
   return Status::OK();
 }
 
-MessageId MessagesManager::get_persistent_message_id(const Dialog *d, MessageId message_id) const {
+MessageId MessagesManager::get_persistent_message_id(const Dialog *d, MessageId message_id) {
   if (!message_id.is_valid() && !message_id.is_valid_scheduled()) {
     return MessageId();
   }
@@ -25692,18 +25693,14 @@ void MessagesManager::update_message_max_reply_media_timestamp(const Dialog *d,
     return;
   }
 
-  auto new_max_reply_media_timestamp = m->max_reply_media_timestamp;
-  if (!m->reply_to_message_id.is_valid()) {
-    new_max_reply_media_timestamp = -1;
-  } else {
+  auto new_max_reply_media_timestamp = -1;
+  if (m->reply_to_message_id.is_valid()) {
     auto replied_m = get_message(d, m->reply_to_message_id);
     if (replied_m != nullptr) {
       new_max_reply_media_timestamp = get_message_own_max_media_timestamp(replied_m);
-    } else if (d->deleted_message_ids.count(m->reply_to_message_id) ||
-               m->reply_to_message_id <= d->last_clear_history_message_id ||
-               m->reply_to_message_id <= d->max_unavailable_message_id) {
-      new_max_reply_media_timestamp = -1;
-    } else {
+    } else if (!d->deleted_message_ids.count(m->reply_to_message_id) &&
+               m->reply_to_message_id > d->last_clear_history_message_id &&
+               m->reply_to_message_id > d->max_unavailable_message_id) {
       // replied message isn't deleted and isn't loaded yet
       return;
     }
@@ -28885,7 +28882,7 @@ void MessagesManager::send_update_chat_has_scheduled_messages(Dialog *d, bool fr
 }
 
 void MessagesManager::send_update_user_chat_action(DialogId dialog_id, MessageId top_thread_message_id, UserId user_id,
-                                                   DialogAction action) {
+                                                   const DialogAction &action) {
   if (td_->auth_manager_->is_bot()) {
     return;
   }
@@ -31934,7 +31931,7 @@ tl_object_ptr<td_api::ChatEventAction> MessagesManager::get_chat_event_action_ob
     }
     case telegram_api::channelAdminLogEventActionParticipantMute::ID: {
       auto action = move_tl_object_as<telegram_api::channelAdminLogEventActionParticipantMute>(action_ptr);
-      GroupCallParticipant participant(std::move(action->participant_), 0);
+      GroupCallParticipant participant(action->participant_, 0);
       if (!participant.is_valid()) {
         return nullptr;
       }
@@ -31943,7 +31940,7 @@ tl_object_ptr<td_api::ChatEventAction> MessagesManager::get_chat_event_action_ob
     }
     case telegram_api::channelAdminLogEventActionParticipantUnmute::ID: {
       auto action = move_tl_object_as<telegram_api::channelAdminLogEventActionParticipantUnmute>(action_ptr);
-      GroupCallParticipant participant(std::move(action->participant_), 0);
+      GroupCallParticipant participant(action->participant_, 0);
       if (!participant.is_valid()) {
         return nullptr;
       }
@@ -31952,7 +31949,7 @@ tl_object_ptr<td_api::ChatEventAction> MessagesManager::get_chat_event_action_ob
     }
     case telegram_api::channelAdminLogEventActionParticipantVolume::ID: {
       auto action = move_tl_object_as<telegram_api::channelAdminLogEventActionParticipantVolume>(action_ptr);
-      GroupCallParticipant participant(std::move(action->participant_), 0);
+      GroupCallParticipant participant(action->participant_, 0);
       if (!participant.is_valid()) {
         return nullptr;
       }
@@ -35456,7 +35453,7 @@ unique_ptr<MessagesManager::Dialog> MessagesManager::parse_dialog(DialogId dialo
   return d;
 }
 
-MessagesManager::Dialog *MessagesManager::on_load_dialog_from_database(DialogId dialog_id, const BufferSlice &value,
+MessagesManager::Dialog *MessagesManager::on_load_dialog_from_database(DialogId dialog_id, BufferSlice &&value,
                                                                        const char *source) {
   CHECK(G()->parameters().use_message_db);
 
@@ -35555,17 +35552,17 @@ bool MessagesManager::has_dialogs_from_folder(const DialogList &list, const Dial
   return false;
 }
 
-bool MessagesManager::is_dialog_in_list(const Dialog *d, DialogListId dialog_list_id) const {
+bool MessagesManager::is_dialog_in_list(const Dialog *d, DialogListId dialog_list_id) {
   return td::contains(d->dialog_list_ids, dialog_list_id);
 }
 
-void MessagesManager::add_dialog_to_list(Dialog *d, DialogListId dialog_list_id) const {
+void MessagesManager::add_dialog_to_list(Dialog *d, DialogListId dialog_list_id) {
   LOG(INFO) << "Add " << d->dialog_id << " to " << dialog_list_id;
   CHECK(!is_dialog_in_list(d, dialog_list_id));
   d->dialog_list_ids.push_back(dialog_list_id);
 }
 
-void MessagesManager::remove_dialog_from_list(Dialog *d, DialogListId dialog_list_id) const {
+void MessagesManager::remove_dialog_from_list(Dialog *d, DialogListId dialog_list_id) {
   LOG(INFO) << "Remove " << d->dialog_id << " from " << dialog_list_id;
   bool is_removed = td::remove(d->dialog_list_ids, dialog_list_id);
   CHECK(is_removed);
@@ -35702,7 +35699,7 @@ MessagesManager::get_dialog_positions(const Dialog *d) const {
   return positions;
 }
 
-vector<DialogListId> MessagesManager::get_dialog_list_ids(const Dialog *d) const {
+vector<DialogListId> MessagesManager::get_dialog_list_ids(const Dialog *d) {
   return d->dialog_list_ids;
 }
 

td/telegram/MessagesManager.h

@@ -180,7 +180,7 @@ class MessagesManager final : public Actor {
 
   bool have_input_peer(DialogId dialog_id, AccessRights access_rights) const;
 
-  void on_get_empty_messages(DialogId dialog_id, vector<MessageId> empty_message_ids);
+  void on_get_empty_messages(DialogId dialog_id, const vector<MessageId> &empty_message_ids);
 
   struct MessagesInfo {
     vector<tl_object_ptr<telegram_api::Message>> messages;
@@ -520,7 +520,7 @@ class MessagesManager final : public Actor {
 
   void load_dialogs(vector<DialogId> dialog_ids, Promise<vector<DialogId>> &&promise);
 
-  void load_dialog_filter(DialogFilterId dialog_id, bool force, Promise<Unit> &&promise);
+  void load_dialog_filter(DialogFilterId dialog_filter_id, bool force, Promise<Unit> &&promise);
 
   void get_recommended_dialog_filters(Promise<td_api::object_ptr<td_api::recommendedChatFilters>> &&promise);
 
@@ -705,7 +705,7 @@ class MessagesManager final : public Actor {
   td_api::object_ptr<td_api::foundMessages> get_found_messages_object(const FoundMessages &found_messages,
                                                                       const char *source);
 
-  FoundMessages offline_search_messages(DialogId dialog_id, const string &query, const string &offset, int32 limit,
+  FoundMessages offline_search_messages(DialogId dialog_id, const string &query, string offset, int32 limit,
                                         MessageSearchFilter filter, int64 &random_id, Promise<> &&promise);
 
   std::pair<int32, vector<FullMessageId>> search_messages(FolderId folder_id, bool ignore_folder_id,
@@ -984,7 +984,7 @@ class MessagesManager final : public Actor {
         , sender_name(std::move(sender_name))
         , from_dialog_id(from_dialog_id)
         , from_message_id(from_message_id)
-        , psa_type(psa_type)
+        , psa_type(std::move(psa_type))
         , is_imported(is_imported) {
     }
 
@@ -1160,8 +1160,8 @@ class MessagesManager final : public Actor {
     int32 server_unread_count = 0;
     int32 local_unread_count = 0;
     int32 unread_mention_count = 0;
-    MessageId last_read_inbox_message_id;
     int32 last_read_inbox_message_date = 0;  // secret chats only
+    MessageId last_read_inbox_message_id;
     MessageId last_read_outbox_message_id;
     MessageId last_pinned_message_id;
     MessageId reply_markup_message_id;
@@ -1186,11 +1186,13 @@ class MessagesManager final : public Actor {
     MessageId
         max_unavailable_message_id;  // maximum unavailable message identifier for dialogs with cleared/unavailable history
 
+    int32 distance = -1;  // distance to the peer
+
     int32 last_clear_history_date = 0;
     MessageId last_clear_history_message_id;
     int64 order = DEFAULT_ORDER;
-    int32 delete_last_message_date = 0;
     MessageId deleted_last_message_id;
+    int32 delete_last_message_date = 0;
     int32 pending_last_message_date = 0;
     MessageId pending_last_message_id;
     MessageId max_notification_message_id;
@@ -1209,8 +1211,6 @@ class MessagesManager final : public Actor {
     NotificationId new_secret_chat_notification_id;  // secret chats only
     MessageId pinned_message_notification_message_id;
 
-    int32 distance = -1;  // distance to the peer
-
     bool has_contact_registered_message = false;
 
     bool is_last_message_deleted_locally = false;
@@ -1264,10 +1264,13 @@ class MessagesManager final : public Actor {
     bool has_unload_timeout = false;
     bool is_channel_difference_finished = false;
 
+    bool suffix_load_done_ = false;
+    bool suffix_load_has_query_ = false;
+
     int32 pts = 0;                                                 // for channels only
     int32 pending_read_channel_inbox_pts = 0;                      // for channels only
-    MessageId pending_read_channel_inbox_max_message_id;           // for channels only
     int32 pending_read_channel_inbox_server_unread_count = 0;      // for channels only
+    MessageId pending_read_channel_inbox_max_message_id;           // for channels only
     std::unordered_map<int64, MessageId> random_id_to_message_id;  // for secret chats only
 
     MessageId last_assigned_message_id;  // identifier of the last local or yet unsent message, assigned after
@@ -1298,8 +1301,6 @@ class MessagesManager final : public Actor {
                                               // [suffix_load_first_message_id_, last_message_id] are loaded
     MessageId suffix_load_query_message_id_;
     std::vector<std::pair<Promise<>, std::function<bool(const Message *)>>> suffix_load_queries_;
-    bool suffix_load_done_ = false;
-    bool suffix_load_has_query_ = false;
 
     std::unordered_map<MessageId, int64, MessageIdHash> pending_viewed_live_locations;  // message_id -> task_id
     std::unordered_set<MessageId, MessageIdHash> pending_viewed_message_ids;
@@ -1815,7 +1816,7 @@ class MessagesManager final : public Actor {
                                bool was_uploaded, bool was_thumbnail_uploaded, string file_reference,
                                int32 scheduled_date, uint64 generation, Result<int32> &&result);
 
-  MessageId get_persistent_message_id(const Dialog *d, MessageId message_id) const;
+  static MessageId get_persistent_message_id(const Dialog *d, MessageId message_id);
 
   static FullMessageId get_replied_message_id(DialogId dialog_id, const Message *m);
 
@@ -1914,18 +1915,18 @@ class MessagesManager final : public Actor {
 
   void on_yet_unsent_media_queue_updated(DialogId dialog_id);
 
-  void save_send_bot_start_message_log_event(UserId bot_user_id, DialogId dialog_id, const string &parameter,
-                                             const Message *m);
+  static void save_send_bot_start_message_log_event(UserId bot_user_id, DialogId dialog_id, const string &parameter,
+                                                    const Message *m);
 
   void do_send_bot_start_message(UserId bot_user_id, DialogId dialog_id, const string &parameter, const Message *m);
 
-  void save_send_inline_query_result_message_log_event(DialogId dialog_id, const Message *m, int64 query_id,
-                                                       const string &result_id);
+  static void save_send_inline_query_result_message_log_event(DialogId dialog_id, const Message *m, int64 query_id,
+                                                              const string &result_id);
 
   void do_send_inline_query_result_message(DialogId dialog_id, const Message *m, int64 query_id,
                                            const string &result_id);
 
-  uint64 save_send_screenshot_taken_notification_message_log_event(DialogId dialog_id, const Message *m);
+  static uint64 save_send_screenshot_taken_notification_message_log_event(DialogId dialog_id, const Message *m);
 
   void do_send_screenshot_taken_notification_message(DialogId dialog_id, const Message *m, uint64 log_event_id);
 
@@ -1939,7 +1940,7 @@ class MessagesManager final : public Actor {
 
   bool can_get_message_statistics(DialogId dialog_id, const Message *m) const;
 
-  static bool can_delete_channel_message(DialogParticipantStatus status, const Message *m, bool is_bot);
+  static bool can_delete_channel_message(const DialogParticipantStatus &status, const Message *m, bool is_bot);
 
   bool can_delete_message(DialogId dialog_id, const Message *m) const;
 
@@ -2121,7 +2122,7 @@ class MessagesManager final : public Actor {
 
   void on_dialog_updated(DialogId dialog_id, const char *source);
 
-  BufferSlice get_dialog_database_value(const Dialog *d);
+  static BufferSlice get_dialog_database_value(const Dialog *d);
 
   void save_dialog_to_database(DialogId dialog_id);
 
@@ -2204,9 +2205,9 @@ class MessagesManager final : public Actor {
 
   void do_delete_message_log_event(const DeleteMessageLogEvent &log_event) const;
 
-  void attach_message_to_previous(Dialog *d, MessageId message_id, const char *source);
+  static void attach_message_to_previous(Dialog *d, MessageId message_id, const char *source);
 
-  void attach_message_to_next(Dialog *d, MessageId message_id, const char *source);
+  static void attach_message_to_next(Dialog *d, MessageId message_id, const char *source);
 
   bool update_message(Dialog *d, Message *old_message, unique_ptr<Message> new_message, bool *need_update_dialog_pos,
                       bool is_message_in_dialog);
@@ -2245,7 +2246,7 @@ class MessagesManager final : public Actor {
 
   vector<Notification> get_message_notifications_from_database_force(Dialog *d, bool from_mentions, int32 limit);
 
-  Result<vector<MessagesDbDialogMessage>> do_get_message_notifications_from_database_force(
+  static Result<vector<MessagesDbDialogMessage>> do_get_message_notifications_from_database_force(
       Dialog *d, bool from_mentions, NotificationId from_notification_id, MessageId from_message_id, int32 limit);
 
   void do_get_message_notifications_from_database(Dialog *d, bool from_mentions,
@@ -2339,7 +2340,7 @@ class MessagesManager final : public Actor {
   void send_update_chat_has_scheduled_messages(Dialog *d, bool from_deletion);
 
   void send_update_user_chat_action(DialogId dialog_id, MessageId top_thread_message_id, UserId user_id,
-                                    DialogAction action);
+                                    const DialogAction &action);
 
   void repair_dialog_action_bar(Dialog *d, const char *source);
 
@@ -2385,7 +2386,7 @@ class MessagesManager final : public Actor {
 
   td_api::object_ptr<td_api::updateUnreadChatCount> get_update_unread_chat_count_object(const DialogList &list) const;
 
-  void save_unread_chat_count(const DialogList &list);
+  static void save_unread_chat_count(const DialogList &list);
 
   void set_dialog_last_read_inbox_message_id(Dialog *d, MessageId message_id, int32 server_unread_count,
                                              int32 local_unread_count, bool force_update, const char *source);
@@ -2466,7 +2467,8 @@ class MessagesManager final : public Actor {
 
   static string get_notification_settings_scope_database_key(NotificationSettingsScope scope);
 
-  void save_scope_notification_settings(NotificationSettingsScope scope, const ScopeNotificationSettings &new_settings);
+  static void save_scope_notification_settings(NotificationSettingsScope scope,
+                                               const ScopeNotificationSettings &new_settings);
 
   bool update_dialog_notification_settings(DialogId dialog_id, DialogNotificationSettings *current_settings,
                                            const DialogNotificationSettings &new_settings);
@@ -2531,7 +2533,7 @@ class MessagesManager final : public Actor {
 
   Dialog *get_dialog_force(DialogId dialog_id, const char *source = "get_dialog_force");
 
-  Dialog *on_load_dialog_from_database(DialogId dialog_id, const BufferSlice &value, const char *source);
+  Dialog *on_load_dialog_from_database(DialogId dialog_id, BufferSlice &&value, const char *source);
 
   void on_get_dialogs_from_database(FolderId folder_id, int32 limit, DialogDbGetDialogsResult &&dialogs,
                                     Promise<Unit> &&promise);
@@ -2544,7 +2546,7 @@ class MessagesManager final : public Actor {
 
   void reload_pinned_dialogs(DialogListId dialog_list_id, Promise<Unit> &&promise);
 
-  double get_dialog_filters_cache_time() const;
+  static double get_dialog_filters_cache_time();
 
   void schedule_dialog_filters_reload(double timeout);
 
@@ -2614,11 +2616,11 @@ class MessagesManager final : public Actor {
 
   bool has_dialogs_from_folder(const DialogList &list, const DialogFolder &folder) const;
 
-  bool is_dialog_in_list(const Dialog *d, DialogListId dialog_list_id) const;
+  static bool is_dialog_in_list(const Dialog *d, DialogListId dialog_list_id);
 
-  void add_dialog_to_list(Dialog *d, DialogListId dialog_list_id) const;
+  static void add_dialog_to_list(Dialog *d, DialogListId dialog_list_id);
 
-  void remove_dialog_from_list(Dialog *d, DialogListId dialog_list_id) const;
+  static void remove_dialog_from_list(Dialog *d, DialogListId dialog_list_id);
 
   bool need_dialog_in_filter(const Dialog *d, const DialogFilter *filter) const;
 
@@ -2631,7 +2633,8 @@ class MessagesManager final : public Actor {
 
   std::unordered_map<DialogListId, DialogPositionInList, DialogListIdHash> get_dialog_positions(const Dialog *d) const;
 
-  vector<DialogListId> get_dialog_list_ids(const Dialog *d) const;
+  static vector<DialogListId> get_dialog_list_ids(const Dialog *d);
+
   DialogListView get_dialog_lists(const Dialog *d);
 
   DialogList &add_dialog_list(DialogListId dialog_list_id);
@@ -3031,50 +3034,54 @@ class MessagesManager final : public Actor {
 
   static void add_message_dependencies(Dependencies &dependencies, const Message *m);
 
-  void save_send_message_log_event(DialogId dialog_id, const Message *m);
+  static void save_send_message_log_event(DialogId dialog_id, const Message *m);
 
-  uint64 save_toggle_dialog_report_spam_state_on_server_log_event(DialogId dialog_id, bool is_spam_dialog);
+  static uint64 save_toggle_dialog_report_spam_state_on_server_log_event(DialogId dialog_id, bool is_spam_dialog);
 
-  uint64 save_delete_messages_from_server_log_event(DialogId dialog_id, const vector<MessageId> &message_ids,
-                                                    bool revoke);
+  static uint64 save_delete_messages_from_server_log_event(DialogId dialog_id, const vector<MessageId> &message_ids,
+                                                           bool revoke);
 
-  uint64 save_delete_scheduled_messages_from_server_log_event(DialogId dialog_id, const vector<MessageId> &message_ids);
+  static uint64 save_delete_scheduled_messages_from_server_log_event(DialogId dialog_id,
+                                                                     const vector<MessageId> &message_ids);
 
-  uint64 save_delete_dialog_history_from_server_log_event(DialogId dialog_id, MessageId max_message_id,
-                                                          bool remove_from_dialog_list, bool revoke);
+  static uint64 save_delete_dialog_history_from_server_log_event(DialogId dialog_id, MessageId max_message_id,
+                                                                 bool remove_from_dialog_list, bool revoke);
 
-  uint64 save_delete_all_call_messages_from_server_log_event(bool revoke);
+  static uint64 save_delete_all_call_messages_from_server_log_event(bool revoke);
 
-  uint64 save_block_message_sender_from_replies_on_server_log_event(MessageId message_id, bool delete_message,
-                                                                    bool delete_all_messages, bool report_spam);
+  static uint64 save_block_message_sender_from_replies_on_server_log_event(MessageId message_id, bool delete_message,
+                                                                           bool delete_all_messages, bool report_spam);
 
-  uint64 save_delete_all_channel_messages_from_user_on_server_log_event(ChannelId channel_id, UserId user_id);
+  static uint64 save_delete_all_channel_messages_from_user_on_server_log_event(ChannelId channel_id, UserId user_id);
 
-  uint64 save_read_all_dialog_mentions_on_server_log_event(DialogId dialog_id);
+  static uint64 save_read_all_dialog_mentions_on_server_log_event(DialogId dialog_id);
 
-  uint64 save_toggle_dialog_is_pinned_on_server_log_event(DialogId dialog_id, bool is_pinned);
+  static uint64 save_toggle_dialog_is_pinned_on_server_log_event(DialogId dialog_id, bool is_pinned);
 
-  uint64 save_reorder_pinned_dialogs_on_server_log_event(FolderId folder_id, const vector<DialogId> &dialog_ids);
+  static uint64 save_reorder_pinned_dialogs_on_server_log_event(FolderId folder_id, const vector<DialogId> &dialog_ids);
 
-  uint64 save_toggle_dialog_is_marked_as_unread_on_server_log_event(DialogId dialog_id, bool is_marked_as_unread);
+  static uint64 save_toggle_dialog_is_marked_as_unread_on_server_log_event(DialogId dialog_id,
+                                                                           bool is_marked_as_unread);
 
-  uint64 save_toggle_dialog_is_blocked_on_server_log_event(DialogId dialog_id, bool is_blocked);
+  static uint64 save_toggle_dialog_is_blocked_on_server_log_event(DialogId dialog_id, bool is_blocked);
 
-  uint64 save_read_message_contents_on_server_log_event(DialogId dialog_id, const vector<MessageId> &message_ids);
+  static uint64 save_read_message_contents_on_server_log_event(DialogId dialog_id,
+                                                               const vector<MessageId> &message_ids);
 
-  uint64 save_update_scope_notification_settings_on_server_log_event(NotificationSettingsScope scope);
+  static uint64 save_update_scope_notification_settings_on_server_log_event(NotificationSettingsScope scope);
 
-  uint64 save_reset_all_notification_settings_on_server_log_event();
+  static uint64 save_reset_all_notification_settings_on_server_log_event();
 
-  uint64 save_get_dialog_from_server_log_event(DialogId dialog_id);
+  static uint64 save_get_dialog_from_server_log_event(DialogId dialog_id);
 
-  uint64 save_forward_messages_log_event(DialogId to_dialog_id, DialogId from_dialog_id,
-                                         const vector<Message *> &messages, const vector<MessageId> &message_ids);
+  static uint64 save_forward_messages_log_event(DialogId to_dialog_id, DialogId from_dialog_id,
+                                                const vector<Message *> &messages,
+                                                const vector<MessageId> &message_ids);
 
-  uint64 save_unpin_all_dialog_messages_on_server_log_event(DialogId dialog_id);
+  static uint64 save_unpin_all_dialog_messages_on_server_log_event(DialogId dialog_id);
 
   void suffix_load_loop(Dialog *d);
-  void suffix_load_update_first_message_id(Dialog *d);
+  static void suffix_load_update_first_message_id(Dialog *d);
   void suffix_load_query_ready(DialogId dialog_id);
   void suffix_load_add_query(Dialog *d, std::pair<Promise<>, std::function<bool(const Message *)>> query);
   void suffix_load_till_date(Dialog *d, int32 date, Promise<> promise);
@@ -3310,7 +3317,10 @@ class MessagesManager final : public Actor {
     double start_time;
 
     ActiveDialogAction(MessageId top_thread_message_id, UserId user_id, DialogAction action, double start_time)
-        : top_thread_message_id(top_thread_message_id), user_id(user_id), action(action), start_time(start_time) {
+        : top_thread_message_id(top_thread_message_id)
+        , user_id(user_id)
+        , action(std::move(action))
+        , start_time(start_time) {
     }
   };
 

td/telegram/NotificationManager.cpp

@@ -237,7 +237,7 @@ void NotificationManager::init() {
   last_loaded_notification_group_key_.last_notification_date = std::numeric_limits<int32>::max();
   if (max_notification_group_count_ != 0) {
     int32 loaded_groups = 0;
-    int32 needed_groups = static_cast<int32>(max_notification_group_count_);
+    auto needed_groups = static_cast<int32>(max_notification_group_count_);
     do {
       loaded_groups += load_message_notification_groups_from_database(needed_groups, false);
     } while (loaded_groups < needed_groups && last_loaded_notification_group_key_.last_notification_date != 0);
@@ -1765,7 +1765,7 @@ void NotificationManager::on_notifications_removed(
 
 void NotificationManager::remove_added_notifications_from_pending_updates(
     NotificationGroupId group_id,
-    std::function<bool(const td_api::object_ptr<td_api::notification> &notification)> is_removed) {
+    const std::function<bool(const td_api::object_ptr<td_api::notification> &notification)> &is_removed) {
   auto it = pending_updates_.find(group_id.get());
   if (it == pending_updates_.end()) {
     return;

td/telegram/NotificationManager.h

@@ -111,7 +111,7 @@ class NotificationManager final : public Actor {
 
   void process_push_notification(string payload, Promise<Unit> &&user_promise);
 
-  static Result<int64> get_push_receiver_id(string push);
+  static Result<int64> get_push_receiver_id(string payload);
 
   static Result<string> decrypt_push(int64 encryption_key_id, string encryption_key, string push);  // public for tests
 
@@ -290,7 +290,7 @@ class NotificationManager final : public Actor {
 
   void remove_added_notifications_from_pending_updates(
       NotificationGroupId group_id,
-      std::function<bool(const td_api::object_ptr<td_api::notification> &notification)> is_removed);
+      const std::function<bool(const td_api::object_ptr<td_api::notification> &notification)> &is_removed);
 
   void flush_pending_updates(int32 group_id, const char *source);
 

td/telegram/PasswordManager.cpp

@@ -656,7 +656,7 @@ Result<PasswordManager::PasswordInputSettings> PasswordManager::get_password_inp
       new_password_hash = new_hash.move_as_ok();
       new_algo = make_tl_object<telegram_api::passwordKdfAlgoSHA256SHA256PBKDF2HMACSHA512iter100000SHA256ModPow>(
           std::move(new_client_salt), BufferSlice(state.server_salt), state.srp_g, BufferSlice(state.srp_p));
-      new_hint = std::move(update_settings.new_hint);
+      new_hint = update_settings.new_hint;
       if (have_secret) {
         update_secure_secret = true;
       }

td/telegram/Payments.cpp

@@ -1228,7 +1228,7 @@ void send_payment_form(Td *td, FullMessageId full_message_id, int64 payment_form
       if (!clean_input_string(credentials_id)) {
         return promise.set_error(Status::Error(400, "Credentials identifier must be encoded in UTF-8"));
       }
-      auto temp_password_state = td->password_manager_->get_actor_unsafe()->get_temp_password_state_sync();
+      auto temp_password_state = PasswordManager::get_temp_password_state_sync();
       if (!temp_password_state.has_temp_password) {
         return promise.set_error(Status::Error(400, "Temporary password required to use saved credentials"));
       }

td/telegram/PhoneNumberManager.h

@@ -47,7 +47,7 @@ class PhoneNumberManager final : public NetActor {
 
   void on_new_query(uint64 query_id);
   void on_query_error(Status status);
-  void on_query_error(uint64 id, Status status);
+  static void on_query_error(uint64 id, Status status);
   void on_query_ok();
   void start_net_query(NetQueryType net_query_type, NetQueryPtr net_query);
 

td/telegram/Photo.cpp

@@ -430,8 +430,8 @@ Variant<PhotoSize, string> get_photo_size(FileManager *file_manager, PhotoSizeSo
     source.thumbnail().thumbnail_type = res.type;
   }
 
-  res.file_id =
-      register_photo(file_manager, source, id, access_hash, file_reference, owner_dialog_id, res.size, dc_id, format);
+  res.file_id = register_photo(file_manager, source, id, access_hash, std::move(file_reference), owner_dialog_id,
+                               res.size, dc_id, format);
 
   if (!content.empty()) {
     file_manager->set_content(res.file_id, std::move(content));
@@ -463,8 +463,8 @@ AnimationSize get_animation_size(FileManager *file_manager, PhotoSizeSource sour
     source.thumbnail().thumbnail_type = res.type;
   }
 
-  res.file_id = register_photo(file_manager, source, id, access_hash, file_reference, owner_dialog_id, res.size, dc_id,
-                               PhotoFormat::Mpeg4);
+  res.file_id = register_photo(file_manager, source, id, access_hash, std::move(file_reference), owner_dialog_id,
+                               res.size, dc_id, PhotoFormat::Mpeg4);
   return res;
 }
 

td/telegram/PhotoSizeSource.cpp

@@ -150,7 +150,7 @@ string PhotoSizeSource::get_unique_name(int64 photo_id) const {
       UNREACHABLE();
       break;
   }
-  return 0;
+  return string();
 }
 
 static bool operator==(const PhotoSizeSource::Legacy &lhs, const PhotoSizeSource::Legacy &rhs) {

td/telegram/PollManager.cpp

@@ -616,7 +616,6 @@ PollId PollManager::create_poll(string &&question, vector<string> &&options, boo
   CHECK(is_local_poll_id(poll_id));
   bool is_inserted = polls_.emplace(poll_id, std::move(poll)).second;
   CHECK(is_inserted);
-  LOG(INFO) << "Created " << poll_id << " with question \"" << oneline(poll->question) << '"';
   return poll_id;
 }
 
@@ -978,7 +977,7 @@ void PollManager::get_poll_voters(PollId poll_id, FullMessageId full_message_id,
 
   auto query_promise =
       PromiseCreator::lambda([actor_id = actor_id(this), poll_id, option_id, offset = voters.next_offset,
-                              limit](Result<tl_object_ptr<telegram_api::messages_votesList>> &&result) {
+                              limit](Result<tl_object_ptr<telegram_api::messages_votesList>> &&result) mutable {
         send_closure(actor_id, &PollManager::on_get_poll_voters, poll_id, option_id, std::move(offset), limit,
                      std::move(result));
       });

td/telegram/PollManager.h

@@ -165,7 +165,7 @@ class PollManager final : public Actor {
 
   static string get_poll_database_key(PollId poll_id);
 
-  void save_poll(const Poll *poll, PollId poll_id);
+  static void save_poll(const Poll *poll, PollId poll_id);
 
   void on_load_poll_from_database(PollId poll_id, string value);
 

td/telegram/RecentDialogList.cpp

@@ -259,7 +259,7 @@ std::pair<int32, vector<DialogId>> RecentDialogList::get_dialogs(int32 limit, Pr
   update_dialogs();
 
   CHECK(limit >= 0);
-  int32 total_count = narrow_cast<int32>(dialog_ids_.size());
+  auto total_count = narrow_cast<int32>(dialog_ids_.size());
   return {total_count, vector<DialogId>(dialog_ids_.begin(), dialog_ids_.begin() + min(limit, total_count))};
 }
 

td/telegram/SecretChatActor.cpp

@@ -132,8 +132,10 @@ void SecretChatActor::on_result_resendable(NetQueryPtr net_query, Promise<NetQue
         return on_read_history(std::move(net_query));
       case static_cast<uint8>(QueryType::Ignore):
         return Status::OK();
+      default:
+        UNREACHABLE();
+        return Status::OK();
     }
-    UNREACHABLE();
   }());
 
   loop();
@@ -963,8 +965,8 @@ Status SecretChatActor::do_inbound_message_decrypted_unchecked(unique_ptr<log_ev
       auto *action_resend =
           static_cast<secret_api::decryptedMessageActionResend *>(decrypted_message_service->action_.get());
 
-      uint32 start_seq_no = static_cast<uint32>(action_resend->start_seq_no_ / 2);
-      uint32 finish_seq_no = static_cast<uint32>(action_resend->end_seq_no_ / 2);
+      auto start_seq_no = static_cast<uint32>(action_resend->start_seq_no_ / 2);
+      auto finish_seq_no = static_cast<uint32>(action_resend->end_seq_no_ / 2);
       if (start_seq_no + MAX_RESEND_COUNT < finish_seq_no) {
         message->promise.set_value(Unit());
         return Status::Error(PSLICE() << "Won't resend more than " << MAX_RESEND_COUNT << " messages");
@@ -1976,29 +1978,36 @@ void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionSetMe
   context_->secret_chat_db()->set_value(config_state_);
   send_update_secret_chat();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionReadMessages &read_messages) {
   // TODO
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionDeleteMessages &delete_messages) {
   // Corresponding log event won't be deleted before promise returned by add_changes is set.
   on_delete_messages(delete_messages.random_ids_).ensure();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionScreenshotMessages &screenshot) {
-  // noting to do
+  // nothing to do
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionFlushHistory &flush_history) {
   on_flush_history(pfs_state_.message_id).ensure();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionResend &resend) {
   if (seq_no_state_.resend_end_seq_no < resend.end_seq_no_ / 2) {  // replay protection
     seq_no_state_.resend_end_seq_no = resend.end_seq_no_ / 2;
     on_seq_no_state_changed();
   }
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionNotifyLayer &notify_layer) {
   config_state_.my_layer = notify_layer.layer_;
   context_->secret_chat_db()->set_value(config_state_);
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionTyping &typing) {
   // noop
 }
@@ -2009,23 +2018,29 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionSetM
   send_update_secret_chat();
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionReadMessages &read_messages) {
   // TODO
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionDeleteMessages &delete_messages) {
   return on_delete_messages(delete_messages.random_ids_);
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionScreenshotMessages &screenshot) {
   // TODO
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionFlushHistory &screenshot) {
   return on_flush_history(pfs_state_.message_id);
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionResend &resend) {
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionNotifyLayer &notify_layer) {
   if (notify_layer.layer_ > config_state_.his_layer) {
     config_state_.his_layer = notify_layer.layer_;
@@ -2034,6 +2049,7 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionNoti
   }
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionTyping &typing) {
   // noop
   return Status::OK();
@@ -2045,16 +2061,19 @@ void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionReque
   pfs_state_.state = PfsState::WaitRequestResponse;
   on_pfs_state_changed();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionAcceptKey &accept_key) {
   CHECK(pfs_state_.state == PfsState::WaitSendAccept || pfs_state_.state == PfsState::SendAccept);
   pfs_state_.state = PfsState::WaitAcceptResponse;
   pfs_state_.handshake = mtproto::DhHandshake();
   on_pfs_state_changed();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionAbortKey &abort_key) {
   // TODO
   LOG(FATAL) << "TODO";
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionCommitKey &commit_key) {
   CHECK(pfs_state_.state == PfsState::WaitSendCommit || pfs_state_.state == PfsState::SendCommit);
 
@@ -2069,11 +2088,11 @@ void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionCommi
 
   on_pfs_state_changed();
 }
+
 void SecretChatActor::on_outbound_action(secret_api::decryptedMessageActionNoop &noop) {
   // noop
 }
 
-// decryptedMessageActionRequestKey#f3c9611b exchange_id:long g_a:bytes = DecryptedMessageAction;
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionRequestKey &request_key) {
   if (pfs_state_.state == PfsState::WaitRequestResponse || pfs_state_.state == PfsState::SendRequest) {
     if (pfs_state_.exchange_id > request_key.exchange_id_) {
@@ -2112,7 +2131,6 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionRequ
   return Status::OK();
 }
 
-// decryptedMessageActionAcceptKey#6fe1735b exchange_id:long g_b:bytes key_fingerprint:long = DecryptedMessageAction;
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionAcceptKey &accept_key) {
   if (pfs_state_.state != PfsState::WaitRequestResponse) {
     return Status::Error("AcceptKey: unexpected");
@@ -2136,6 +2154,7 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionAcce
   on_pfs_state_changed();
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionAbortKey &abort_key) {
   if (pfs_state_.exchange_id != abort_key.exchange_id_) {
     LOG(INFO) << "AbortKey: exchange_id mismatch: " << tag("my exchange_id", pfs_state_.exchange_id)
@@ -2151,6 +2170,7 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionAbor
   on_pfs_state_changed();
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionCommitKey &commit_key) {
   if (pfs_state_.state != PfsState::WaitAcceptResponse) {
     return Status::Error("CommitKey: unexpected");
@@ -2174,6 +2194,7 @@ Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionComm
   on_pfs_state_changed();
   return Status::OK();
 }
+
 Status SecretChatActor::on_inbound_action(secret_api::decryptedMessageActionNoop &noop) {
   // noop
   return Status::OK();
@@ -2224,7 +2245,6 @@ void SecretChatActor::on_outbound_action(secret_api::DecryptedMessageAction &act
   downcast_call(action, [&](auto &obj) { this->on_outbound_action(obj); });
 }
 
-// decryptedMessageActionRequestKey#f3c9611b exchange_id:long g_a:bytes = DecryptedMessageAction;
 void SecretChatActor::request_new_key() {
   CHECK(!auth_state_.dh_config.empty());
 

td/telegram/SecretChatActor.h

@@ -645,7 +645,7 @@ class SecretChatActor final : public NetQueryCallback {
   Status save_common_info(T &update);
 
   int32 current_layer() const {
-    int32 layer = static_cast<int32>(SecretChatLayer::Current);
+    auto layer = static_cast<int32>(SecretChatLayer::Current);
     if (config_state_.his_layer < layer) {
       layer = config_state_.his_layer;
     }

td/telegram/SecretChatsManager.cpp

@@ -169,7 +169,7 @@ void SecretChatsManager::on_update_chat(tl_object_ptr<telegram_api::updateEncryp
     return;
   }
   bool chat_requested = update->chat_->get_id() == telegram_api::encryptedChatRequested::ID;
-  pending_chat_updates_.push_back({Timestamp::in(chat_requested ? 1 : 0), std::move(update)});
+  pending_chat_updates_.emplace_back(Timestamp::in(chat_requested ? 1 : 0), std::move(update));
   flush_pending_chat_updates();
 }
 

td/telegram/SecureManager.cpp

@@ -104,11 +104,11 @@ class SetSecureValue final : public NetQueryCallback {
     void on_upload_ok(FileId file_id, tl_object_ptr<telegram_api::InputFile> input_file) final;
     void on_upload_encrypted_ok(FileId file_id, tl_object_ptr<telegram_api::InputEncryptedFile> input_file) final;
     void on_upload_secure_ok(FileId file_id, tl_object_ptr<telegram_api::InputSecureFile> input_file) final;
-    void on_upload_error(FileId file_id, Status status) final;
+    void on_upload_error(FileId file_id, Status error) final;
   };
 
   void on_upload_ok(FileId file_id, tl_object_ptr<telegram_api::InputSecureFile> input_file, uint32 upload_generation);
-  void on_upload_error(FileId file_id, Status status, uint32 upload_generation);
+  void on_upload_error(FileId file_id, Status error, uint32 upload_generation);
 
   void on_error(Status error);
 
@@ -125,7 +125,7 @@ class SetSecureValue final : public NetQueryCallback {
   void cancel_upload();
   void start_upload_all();
   void start_upload(FileManager *file_manager, FileId &file_id, SecureInputFile &info);
-  void merge(FileManager *file_manager, FileId file_id, EncryptedSecureFile &encrypted_file);
+  static void merge(FileManager *file_manager, FileId file_id, EncryptedSecureFile &encrypted_file);
 };
 
 class SetSecureValueErrorsQuery final : public Td::ResultHandler {
@@ -285,7 +285,7 @@ void GetAllSecureValues::loop() {
 
   auto secure_values = transform(r_secure_values.move_as_ok(),
                                  [](SecureValueWithCredentials &&value) { return std::move(value.value); });
-  promise_.set_value(get_passport_elements_object(file_manager, std::move(secure_values)));
+  promise_.set_value(get_passport_elements_object(file_manager, secure_values));
   stop();
 }
 
@@ -959,7 +959,7 @@ void SecureManager::get_passport_authorization_form(UserId bot_user_id, string s
   form.bot_user_id = bot_user_id;
   form.scope = scope;
   form.public_key = public_key;
-  form.nonce = nonce;
+  form.nonce = std::move(nonce);
   auto new_promise = PromiseCreator::lambda(
       [actor_id = actor_id(this), authorization_form_id, promise = std::move(promise)](
           Result<telegram_api::object_ptr<telegram_api::account_authorizationForm>> r_authorization_form) mutable {
@@ -1100,7 +1100,7 @@ void SecureManager::on_get_passport_authorization_form_secret(int32 authorizatio
       on_get_secure_value(r_secure_value.ok());
 
       auto secure_value = r_secure_value.move_as_ok();
-      auto r_passport_element = get_passport_element_object(file_manager, std::move(secure_value.value));
+      auto r_passport_element = get_passport_element_object(file_manager, secure_value.value);
       if (r_passport_element.is_error()) {
         LOG(ERROR) << "Failed to get passport element object: " << r_passport_element.error();
         break;

td/telegram/SecureManager.h

@@ -39,9 +39,13 @@ class SecureManager final : public NetQueryCallback {
   explicit SecureManager(ActorShared<> parent);
 
   void get_secure_value(std::string password, SecureValueType type, Promise<TdApiSecureValue> promise);
+
   void get_all_secure_values(std::string password, Promise<TdApiSecureValues> promise);
+
   void set_secure_value(string password, SecureValue secure_value, Promise<TdApiSecureValue> promise);
+
   void delete_secure_value(SecureValueType type, Promise<Unit> promise);
+
   void set_secure_value_errors(Td *td, tl_object_ptr<telegram_api::InputUser> input_user,
                                vector<tl_object_ptr<td_api::inputPassportElementError>> errors, Promise<Unit> promise);
 

td/telegram/SecureStorage.cpp

@@ -208,7 +208,7 @@ Secret Secret::create_new() {
   auto secret_slice = ::td::as_slice(secret);
   Random::secure_bytes(secret_slice);
   auto checksum_diff = secret_checksum(secret_slice);
-  uint8 new_byte = static_cast<uint8>((static_cast<uint32>(secret_slice.ubegin()[0]) + checksum_diff) % 255);
+  auto new_byte = static_cast<uint8>((static_cast<uint32>(secret_slice.ubegin()[0]) + checksum_diff) % 255);
   secret_slice.ubegin()[0] = new_byte;
   return create(secret_slice).move_as_ok();
 }
@@ -364,7 +364,7 @@ Result<BufferSlice> decrypt_value(const Secret &secret, const ValueHash &hash, S
   return std::move(decrypted_value);
 }
 
-Result<ValueHash> encrypt_file(const Secret &secret, std::string src, std::string dest) {
+Result<ValueHash> encrypt_file(const Secret &secret, const string &src, const string &dest) {
   TRY_RESULT(src_file, FileFd::open(src, FileFd::Flags::Read));
   TRY_RESULT(dest_file, FileFd::open(dest, FileFd::Flags::Truncate | FileFd::Flags::Write | FileFd::Create));
   TRY_RESULT(src_file_size, src_file.get_size());
@@ -382,7 +382,7 @@ Result<ValueHash> encrypt_file(const Secret &secret, std::string src, std::strin
   return std::move(hash);
 }
 
-Status decrypt_file(const Secret &secret, const ValueHash &hash, std::string src, std::string dest) {
+Status decrypt_file(const Secret &secret, const ValueHash &hash, const string &src, const string &dest) {
   TRY_RESULT(src_file, FileFd::open(src, FileFd::Flags::Read));
   TRY_RESULT(dest_file, FileFd::open(dest, FileFd::Flags::Truncate | FileFd::Flags::Write | FileFd::Create));
   TRY_RESULT(src_file_size, src_file.get_size());

td/telegram/SecureStorage.h

@@ -184,10 +184,12 @@ struct EncryptedValue {
 };
 
 Result<EncryptedValue> encrypt_value(const Secret &secret, Slice data);
-Result<ValueHash> encrypt_file(const Secret &secret, std::string src, std::string dest);
 
 Result<BufferSlice> decrypt_value(const Secret &secret, const ValueHash &hash, Slice data);
-Status decrypt_file(const Secret &secret, const ValueHash &hash, std::string src, std::string dest);
+
+Result<ValueHash> encrypt_file(const Secret &secret, const string &src, const string &dest);
+
+Status decrypt_file(const Secret &secret, const ValueHash &hash, const string &src, const string &dest);
 
 }  // namespace secure_storage
 }  // namespace td

td/telegram/SecureValue.cpp

@@ -847,8 +847,7 @@ static Status check_document_number(string &number) {
 }
 
 static Result<DatedFile> get_secure_file(FileManager *file_manager, td_api::object_ptr<td_api::InputFile> &&file) {
-  TRY_RESULT(file_id,
-             file_manager->get_input_file_id(FileType::Secure, std::move(file), DialogId(), false, false, false, true));
+  TRY_RESULT(file_id, file_manager->get_input_file_id(FileType::Secure, file, DialogId(), false, false, false, true));
   DatedFile result;
   result.file_id = file_id;
   result.date = G()->unix_time();
@@ -1293,7 +1292,7 @@ static EncryptedSecureFile encrypt_secure_file(FileManager *file_manager, const
 
 static vector<EncryptedSecureFile> encrypt_secure_files(FileManager *file_manager,
                                                         const secure_storage::Secret &master_secret,
-                                                        vector<DatedFile> files, string &to_hash) {
+                                                        const vector<DatedFile> &files, string &to_hash) {
   return transform(
       files, [&](auto dated_file) { return encrypt_secure_file(file_manager, master_secret, dated_file, to_hash); });
   /*

td/telegram/SendCodeHelper.cpp

@@ -53,9 +53,9 @@ telegram_api::object_ptr<telegram_api::codeSettings> SendCodeHelper::get_input_c
                                                                false /*ignored*/);
 }
 
-telegram_api::auth_sendCode SendCodeHelper::send_code(Slice phone_number, const Settings &settings, int32 api_id,
+telegram_api::auth_sendCode SendCodeHelper::send_code(string phone_number, const Settings &settings, int32 api_id,
                                                       const string &api_hash) {
-  phone_number_ = phone_number.str();
+  phone_number_ = std::move(phone_number);
   return telegram_api::auth_sendCode(phone_number_, api_id, api_hash, get_input_code_settings(settings));
 }
 
@@ -86,11 +86,11 @@ SendCodeHelper::AuthenticationCodeInfo SendCodeHelper::get_authentication_code_i
 
   switch (code_type_ptr->get_id()) {
     case telegram_api::auth_codeTypeSms::ID:
-      return {AuthenticationCodeInfo::Type::Sms, 0, ""};
+      return {AuthenticationCodeInfo::Type::Sms, 0, string()};
     case telegram_api::auth_codeTypeCall::ID:
-      return {AuthenticationCodeInfo::Type::Call, 0, ""};
+      return {AuthenticationCodeInfo::Type::Call, 0, string()};
     case telegram_api::auth_codeTypeFlashCall::ID:
-      return {AuthenticationCodeInfo::Type::FlashCall, 0, ""};
+      return {AuthenticationCodeInfo::Type::FlashCall, 0, string()};
     default:
       UNREACHABLE();
       return AuthenticationCodeInfo();

td/telegram/SendCodeHelper.h

@@ -25,7 +25,7 @@ class SendCodeHelper {
 
   using Settings = td_api::object_ptr<td_api::phoneNumberAuthenticationSettings>;
 
-  telegram_api::auth_sendCode send_code(Slice phone_number, const Settings &settings, int32 api_id,
+  telegram_api::auth_sendCode send_code(string phone_number, const Settings &settings, int32 api_id,
                                         const string &api_hash);
 
   telegram_api::account_sendChangePhoneCode send_change_phone_code(Slice phone_number, const Settings &settings);

td/telegram/StickersManager.cpp

@@ -624,7 +624,7 @@ class ReorderStickerSetsQuery final : public Td::ResultHandler {
   bool is_masks_;
 
  public:
-  void send(bool is_masks, vector<StickerSetId> sticker_set_ids) {
+  void send(bool is_masks, const vector<StickerSetId> &sticker_set_ids) {
     is_masks_ = is_masks;
     int32 flags = 0;
     if (is_masks) {
@@ -833,7 +833,7 @@ class UninstallStickerSetQuery final : public Td::ResultHandler {
 
 class ReadFeaturedStickerSetsQuery final : public Td::ResultHandler {
  public:
-  void send(vector<StickerSetId> sticker_set_ids) {
+  void send(const vector<StickerSetId> &sticker_set_ids) {
     LOG(INFO) << "Read trending sticker sets " << format::as_array(sticker_set_ids);
     send_query(G()->net_query_creator().create(
         telegram_api::messages_readFeaturedStickers(StickersManager::convert_sticker_set_ids(sticker_set_ids))));
@@ -2340,11 +2340,11 @@ void StickersManager::add_sticker_thumbnail(Sticker *s, PhotoSize thumbnail) {
     return;
   }
   if (thumbnail.type == 'm') {
-    s->m_thumbnail = thumbnail;
+    s->m_thumbnail = std::move(thumbnail);
     return;
   }
   if (thumbnail.type == 's' || thumbnail.type == 't') {
-    s->s_thumbnail = thumbnail;
+    s->s_thumbnail = std::move(thumbnail);
     return;
   }
   LOG(ERROR) << "Receive sticker thumbnail of unsupported type " << thumbnail.type;
@@ -2364,7 +2364,7 @@ void StickersManager::create_sticker(FileId file_id, string minithumbnail, Photo
   if (!td_->auth_manager_->is_bot()) {
     s->minithumbnail = std::move(minithumbnail);
   }
-  add_sticker_thumbnail(s.get(), thumbnail);
+  add_sticker_thumbnail(s.get(), std::move(thumbnail));
   if (sticker != nullptr) {
     s->set_id = on_get_input_sticker_set(file_id, std::move(sticker->stickerset_), load_data_multipromise_ptr);
     s->alt = std::move(sticker->alt_);
@@ -4343,15 +4343,15 @@ void StickersManager::schedule_update_animated_emoji_clicked(const StickerSet *s
 
   auto now = Time::now();
   auto start_time = max(now, next_update_animated_emoji_clicked_time_);
-  for (size_t i = 0; i < clicks.size(); i++) {
-    auto index = clicks[i].first;
+  for (const auto &click : clicks) {
+    auto index = click.first;
     auto sticker_id = sticker_ids[index];
     if (!sticker_id.is_valid()) {
       LOG(INFO) << "Failed to find sticker for " << emoji << " with index " << index;
       return;
     }
     create_actor<SleepActor>(
-        "SendUpdateAnimatedEmojiClicked", start_time + clicks[i].second - now,
+        "SendUpdateAnimatedEmojiClicked", start_time + click.second - now,
         PromiseCreator::lambda([actor_id = actor_id(this), full_message_id, sticker_id](Result<Unit> result) {
           send_closure(actor_id, &StickersManager::send_update_animated_emoji_clicked, full_message_id, sticker_id);
         }))
@@ -5482,7 +5482,7 @@ void StickersManager::on_new_stickers_uploaded(int64 random_id, Result<Unit> res
 
   td_->create_handler<CreateNewStickerSetQuery>(std::move(pending_new_sticker_set->promise))
       ->send(std::move(input_user), pending_new_sticker_set->title, pending_new_sticker_set->short_name, is_masks,
-             is_animated, std::move(input_stickers), std::move(pending_new_sticker_set->software));
+             is_animated, std::move(input_stickers), pending_new_sticker_set->software);
 }
 
 void StickersManager::add_sticker_to_set(UserId user_id, string &short_name,

td/telegram/StickersManager.h

@@ -173,7 +173,7 @@ class StickersManager final : public Actor {
 
   FileId upload_sticker_file(UserId user_id, tl_object_ptr<td_api::InputSticker> &&sticker, Promise<Unit> &&promise);
 
-  void get_suggested_sticker_set_name(string short_name, Promise<string> &&promise);
+  void get_suggested_sticker_set_name(string title, Promise<string> &&promise);
 
   enum class CheckStickerSetNameResult : uint8 { Ok, Invalid, Occupied };
   void check_sticker_set_name(const string &name, Promise<CheckStickerSetNameResult> &&promise);
@@ -282,7 +282,7 @@ class StickersManager final : public Actor {
   void on_uploaded_sticker_file(FileId file_id, tl_object_ptr<telegram_api::MessageMedia> media,
                                 Promise<Unit> &&promise);
 
-  void on_find_stickers_success(const string &emoji, tl_object_ptr<telegram_api::messages_Stickers> &&sticker_sets);
+  void on_find_stickers_success(const string &emoji, tl_object_ptr<telegram_api::messages_Stickers> &&stickers);
 
   void on_find_stickers_fail(const string &emoji, Status &&error);
 

td/telegram/StickersManager.hpp

@@ -165,7 +165,7 @@ void StickersManager::store_sticker_set(const StickerSet *sticker_set, bool with
       store(sticker_set->minithumbnail, storer);
     }
 
-    uint32 stored_sticker_count = narrow_cast<uint32>(is_full ? sticker_set->sticker_ids.size() : stickers_limit);
+    auto stored_sticker_count = narrow_cast<uint32>(is_full ? sticker_set->sticker_ids.size() : stickers_limit);
     store(stored_sticker_count, storer);
     for (uint32 i = 0; i < stored_sticker_count; i++) {
       auto sticker_id = sticker_set->sticker_ids[i];

td/telegram/StorageManager.cpp

@@ -65,7 +65,7 @@ void StorageManager::get_storage_stats(bool need_all_files, int32 dialog_limit,
   if (is_closed_) {
     return promise.set_error(Global::request_aborted_error());
   }
-  if (pending_storage_stats_.size() != 0) {
+  if (!pending_storage_stats_.empty()) {
     if (stats_dialog_limit_ == dialog_limit && need_all_files == stats_need_all_files_) {
       pending_storage_stats_.emplace_back(std::move(promise));
       return;
@@ -118,12 +118,12 @@ void StorageManager::run_gc(FileGcParameters parameters, bool return_deleted_fil
 
   bool split_by_owner_dialog_id = !parameters.owner_dialog_ids.empty() ||
                                   !parameters.exclude_owner_dialog_ids.empty() || parameters.dialog_limit != 0;
-  get_storage_stats(true /*need_all_files*/, split_by_owner_dialog_id,
-                    PromiseCreator::lambda(
-                        [actor_id = actor_id(this), parameters = std::move(parameters)](Result<FileStats> file_stats) {
-                          send_closure(actor_id, &StorageManager::on_all_files, std::move(parameters),
-                                       std::move(file_stats));
-                        }));
+  get_storage_stats(
+      true /*need_all_files*/, split_by_owner_dialog_id,
+      PromiseCreator::lambda(
+          [actor_id = actor_id(this), parameters = std::move(parameters)](Result<FileStats> file_stats) mutable {
+            send_closure(actor_id, &StorageManager::on_all_files, std::move(parameters), std::move(file_stats));
+          }));
 
   //NB: get_storage_stats will cancel all garbage collection queries, so promise needs to be added after the call
   pending_run_gc_[return_deleted_file_statistics].push_back(std::move(promise));

td/telegram/StorageManager.h

@@ -24,7 +24,7 @@ namespace td {
 struct DatabaseStats {
   string debug;
   DatabaseStats() = default;
-  explicit DatabaseStats(string debug) : debug(debug) {
+  explicit DatabaseStats(string debug) : debug(std::move(debug)) {
   }
   tl_object_ptr<td_api::databaseStatistics> get_database_statistics_object() const;
 };
@@ -64,7 +64,7 @@ class StorageManager final : public Actor {
   void on_file_stats(Result<FileStats> r_file_stats, uint32 generation);
   void create_stats_worker();
   void update_fast_stats(const FileStats &stats);
-  void send_stats(FileStats &&stats, int32 dialog_limit, std::vector<Promise<FileStats>> &&promises);
+  static void send_stats(FileStats &&stats, int32 dialog_limit, std::vector<Promise<FileStats>> &&promises);
 
   void save_fast_stat();
   void load_fast_stat();

td/telegram/SuggestedAction.cpp

@@ -142,8 +142,7 @@ void update_suggested_actions(vector<SuggestedAction> &suggested_actions,
   }
   CHECK(!added_actions.empty() || !removed_actions.empty());
   suggested_actions = std::move(new_suggested_actions);
-  send_closure(G()->td(), &Td::send_update,
-               get_update_suggested_actions_object(std::move(added_actions), std::move(removed_actions)));
+  send_closure(G()->td(), &Td::send_update, get_update_suggested_actions_object(added_actions, removed_actions));
 }
 
 void remove_suggested_action(vector<SuggestedAction> &suggested_actions, SuggestedAction suggested_action) {

td/telegram/Td.cpp

@@ -801,8 +801,8 @@ class LoadChatsRequest final : public RequestActor<> {
     // 1 for database + 1 for server request + 1 for server request at the end + 1 for return + 1 just in case
     set_tries(5);
 
-    if (limit > 100) {
-      limit = 100;
+    if (limit_ > 100) {
+      limit_ = 100;
     }
   }
 };
@@ -2826,10 +2826,11 @@ void Td::on_get_terms_of_service(Result<std::pair<int32, TermsOfService>> result
   if (result.is_error()) {
     expires_in = Random::fast(10, 60);
   } else {
-    pending_terms_of_service_ = std::move(result.ok().second);
+    auto terms = result.move_as_ok();
+    pending_terms_of_service_ = std::move(terms.second);
     auto update = get_update_terms_of_service_object();
     if (update == nullptr) {
-      expires_in = min(max(result.ok().first, G()->unix_time() + 3600) - G()->unix_time(), 86400);
+      expires_in = min(max(terms.first, G()->unix_time() + 3600) - G()->unix_time(), 86400);
     } else {
       send_update(std::move(update));
     }
@@ -4091,7 +4092,7 @@ void Td::init_file_manager() {
     }
 
     void reload_photo(PhotoSizeSource source, Promise<Unit> promise) final {
-      send_closure(G()->file_reference_manager(), &FileReferenceManager::reload_photo, source, std::move(promise));
+      FileReferenceManager::reload_photo(std::move(source), std::move(promise));
     }
 
     ActorShared<> create_reference() final {
@@ -4530,7 +4531,7 @@ void Td::on_request(uint64 id, td_api::checkAuthenticationBotToken &request) {
 void Td::on_request(uint64 id, td_api::confirmQrCodeAuthentication &request) {
   CLEAN_INPUT_STRING(request.link_);
   CREATE_REQUEST_PROMISE();
-  contacts_manager_->confirm_qr_code_authentication(std::move(request.link_), std::move(promise));
+  contacts_manager_->confirm_qr_code_authentication(request.link_, std::move(promise));
 }
 
 void Td::on_request(uint64 id, const td_api::getCurrentState &request) {
@@ -4624,7 +4625,7 @@ void Td::on_request(uint64 id, td_api::checkRecoveryEmailAddressCode &request) {
   CHECK_IS_USER();
   CLEAN_INPUT_STRING(request.code_);
   CREATE_REQUEST_PROMISE();
-  send_closure(password_manager_, &PasswordManager::check_recovery_email_address_code, request.code_,
+  send_closure(password_manager_, &PasswordManager::check_recovery_email_address_code, std::move(request.code_),
                std::move(promise));
 }
 
@@ -5533,7 +5534,7 @@ void Td::on_request(uint64 id, td_api::editInlineMessageText &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  messages_manager_->edit_inline_message_text(std::move(request.inline_message_id_), std::move(request.reply_markup_),
+  messages_manager_->edit_inline_message_text(request.inline_message_id_, std::move(request.reply_markup_),
                                               std::move(request.input_message_content_), std::move(promise));
 }
 
@@ -5541,16 +5542,16 @@ void Td::on_request(uint64 id, td_api::editInlineMessageLiveLocation &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  messages_manager_->edit_inline_message_live_location(
-      std::move(request.inline_message_id_), std::move(request.reply_markup_), std::move(request.location_),
-      request.heading_, request.proximity_alert_radius_, std::move(promise));
+  messages_manager_->edit_inline_message_live_location(request.inline_message_id_, std::move(request.reply_markup_),
+                                                       std::move(request.location_), request.heading_,
+                                                       request.proximity_alert_radius_, std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::editInlineMessageMedia &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  messages_manager_->edit_inline_message_media(std::move(request.inline_message_id_), std::move(request.reply_markup_),
+  messages_manager_->edit_inline_message_media(request.inline_message_id_, std::move(request.reply_markup_),
                                                std::move(request.input_message_content_), std::move(promise));
 }
 
@@ -5558,17 +5559,16 @@ void Td::on_request(uint64 id, td_api::editInlineMessageCaption &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  messages_manager_->edit_inline_message_caption(std::move(request.inline_message_id_),
-                                                 std::move(request.reply_markup_), std::move(request.caption_),
-                                                 std::move(promise));
+  messages_manager_->edit_inline_message_caption(request.inline_message_id_, std::move(request.reply_markup_),
+                                                 std::move(request.caption_), std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::editInlineMessageReplyMarkup &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  messages_manager_->edit_inline_message_reply_markup(std::move(request.inline_message_id_),
-                                                      std::move(request.reply_markup_), std::move(promise));
+  messages_manager_->edit_inline_message_reply_markup(request.inline_message_id_, std::move(request.reply_markup_),
+                                                      std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::editMessageSchedulingState &request) {
@@ -5589,8 +5589,8 @@ void Td::on_request(uint64 id, td_api::setInlineGameScore &request) {
   CHECK_IS_BOT();
   CLEAN_INPUT_STRING(request.inline_message_id_);
   CREATE_OK_REQUEST_PROMISE();
-  game_manager_->set_inline_game_score(std::move(request.inline_message_id_), request.edit_message_,
-                                       UserId(request.user_id_), request.score_, request.force_, std::move(promise));
+  game_manager_->set_inline_game_score(request.inline_message_id_, request.edit_message_, UserId(request.user_id_),
+                                       request.score_, request.force_, std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::getGameHighScores &request) {
@@ -6202,8 +6202,8 @@ void Td::on_request(uint64 id, const td_api::leaveChat &request) {
     }
   }
   contacts_manager_->set_dialog_participant_status(
-      dialog_id, td_api::make_object<td_api::messageSenderUser>(contacts_manager_->get_my_id().get()),
-      std::move(new_status), std::move(promise));
+      dialog_id, td_api::make_object<td_api::messageSenderUser>(contacts_manager_->get_my_id().get()), new_status,
+      std::move(promise));
 }
 
 void Td::on_request(uint64 id, const td_api::addChatMember &request) {
@@ -6222,8 +6222,8 @@ void Td::on_request(uint64 id, const td_api::addChatMembers &request) {
 
 void Td::on_request(uint64 id, td_api::setChatMemberStatus &request) {
   CREATE_OK_REQUEST_PROMISE();
-  contacts_manager_->set_dialog_participant_status(DialogId(request.chat_id_), std::move(request.member_id_),
-                                                   request.status_, std::move(promise));
+  contacts_manager_->set_dialog_participant_status(DialogId(request.chat_id_), request.member_id_, request.status_,
+                                                   std::move(promise));
 }
 
 void Td::on_request(uint64 id, const td_api::banChatMember &request) {
@@ -6256,8 +6256,7 @@ void Td::on_request(uint64 id, td_api::transferChatOwnership &request) {
 
 void Td::on_request(uint64 id, td_api::getChatMember &request) {
   CREATE_REQUEST_PROMISE();
-  contacts_manager_->get_dialog_participant(DialogId(request.chat_id_), std::move(request.member_id_),
-                                            std::move(promise));
+  contacts_manager_->get_dialog_participant(DialogId(request.chat_id_), request.member_id_, std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::searchChatMembers &request) {
@@ -7044,7 +7043,8 @@ void Td::on_request(uint64 id, td_api::getStatisticalGraph &request) {
   CHECK_IS_USER();
   CLEAN_INPUT_STRING(request.token_);
   CREATE_REQUEST_PROMISE();
-  contacts_manager_->load_statistics_graph(DialogId(request.chat_id_), request.token_, request.x_, std::move(promise));
+  contacts_manager_->load_statistics_graph(DialogId(request.chat_id_), std::move(request.token_), request.x_,
+                                           std::move(promise));
 }
 
 void Td::on_request(uint64 id, td_api::setChatNotificationSettings &request) {
@@ -7763,8 +7763,8 @@ void Td::on_request(uint64 id, td_api::sendEmailAddressVerificationCode &request
   CHECK_IS_USER();
   CLEAN_INPUT_STRING(request.email_address_);
   CREATE_REQUEST_PROMISE();
-  send_closure(password_manager_, &PasswordManager::send_email_address_verification_code, request.email_address_,
-               std::move(promise));
+  send_closure(password_manager_, &PasswordManager::send_email_address_verification_code,
+               std::move(request.email_address_), std::move(promise));
 }
 
 void Td::on_request(uint64 id, const td_api::resendEmailAddressVerificationCode &request) {
@@ -7777,7 +7777,7 @@ void Td::on_request(uint64 id, td_api::checkEmailAddressVerificationCode &reques
   CHECK_IS_USER();
   CLEAN_INPUT_STRING(request.code_);
   CREATE_OK_REQUEST_PROMISE();
-  send_closure(password_manager_, &PasswordManager::check_email_address_verification_code, request.code_,
+  send_closure(password_manager_, &PasswordManager::check_email_address_verification_code, std::move(request.code_),
                std::move(promise));
 }
 
@@ -8266,7 +8266,8 @@ td_api::object_ptr<td_api::Object> Td::do_static_request(const td_api::getLangua
 
 td_api::object_ptr<td_api::Object> Td::do_static_request(const td_api::getPhoneNumberInfoSync &request) {
   // don't check language_code/phone number UTF-8 correctness
-  return CountryInfoManager::get_phone_number_info_sync(request.language_code_, request.phone_number_prefix_);
+  return CountryInfoManager::get_phone_number_info_sync(request.language_code_,
+                                                        std::move(request.phone_number_prefix_));
 }
 
 td_api::object_ptr<td_api::Object> Td::do_static_request(const td_api::getPushReceiverId &request) {

td/telegram/Td.h

@@ -328,7 +328,7 @@ class Td final : public Actor {
 
   void on_get_terms_of_service(Result<std::pair<int32, TermsOfService>> result, bool dummy);
 
-  void on_get_promo_data(Result<telegram_api::object_ptr<telegram_api::help_PromoData>> result, bool dummy);
+  void on_get_promo_data(Result<telegram_api::object_ptr<telegram_api::help_PromoData>> r_promo_data, bool dummy);
 
   template <class T>
   friend class RequestActor;        // uses send_result/send_error
@@ -346,7 +346,7 @@ class Td final : public Actor {
 
   void on_config_option_updated(const string &name);
 
-  void send(NetQueryPtr &&query);
+  static void send(NetQueryPtr &&query);
 
   class OnRequest;
 

td/telegram/TdDb.cpp

@@ -52,7 +52,7 @@ std::string get_sqlite_path(const TdParameters &parameters) {
 
 Result<TdDb::EncryptionInfo> check_encryption(string path) {
   Binlog binlog;
-  auto status = binlog.init(path, Binlog::Callback());
+  auto status = binlog.init(std::move(path), Binlog::Callback());
   if (status.is_error() && status.code() != Binlog::Error::WrongPassword) {
     LOG(WARNING) << "Failed to check binlog: " << status;
     return Status::Error(400, status.message());
@@ -281,7 +281,7 @@ void TdDb::do_close(Promise<> on_finished, bool destroy_flag) {
   lock.set_value(Unit());
 }
 
-Status TdDb::init_sqlite(int32 scheduler_id, const TdParameters &parameters, DbKey key, DbKey old_key,
+Status TdDb::init_sqlite(int32 scheduler_id, const TdParameters &parameters, const DbKey &key, const DbKey &old_key,
                          BinlogKeyValue<Binlog> &binlog_pmc) {
   CHECK(!parameters.use_message_db || parameters.use_chat_info_db);
   CHECK(!parameters.use_chat_info_db || parameters.use_file_db);
@@ -489,7 +489,7 @@ Status TdDb::destroy(const TdParameters &parameters) {
   return Status::OK();
 }
 
-void TdDb::with_db_path(std::function<void(CSlice)> callback) {
+void TdDb::with_db_path(const std::function<void(CSlice)> &callback) {
   SqliteDb::with_db_path(sqlite_path(), callback);
   callback(binlog_path());
 }

td/telegram/TdDb.h

@@ -97,7 +97,7 @@ class TdDb {
 
   void change_key(DbKey key, Promise<> promise);
 
-  void with_db_path(std::function<void(CSlice)> callback);
+  void with_db_path(const std::function<void(CSlice)> &callback);
 
   Result<string> get_stats();
 
@@ -121,7 +121,7 @@ class TdDb {
   std::shared_ptr<ConcurrentBinlog> binlog_;
 
   Status init(int32 scheduler_id, const TdParameters &parameters, DbKey key, Events &events);
-  Status init_sqlite(int32 scheduler_id, const TdParameters &parameters, DbKey key, DbKey old_key,
+  Status init_sqlite(int32 scheduler_id, const TdParameters &parameters, const DbKey &key, const DbKey &old_key,
                      BinlogKeyValue<Binlog> &binlog_pmc);
 
   void do_close(Promise<> on_finished, bool destroy_flag);

td/telegram/TermsOfService.cpp

@@ -65,9 +65,9 @@ class AcceptTermsOfServiceQuery final : public Td::ResultHandler {
   explicit AcceptTermsOfServiceQuery(Promise<Unit> &&promise) : promise_(std::move(promise)) {
   }
 
-  void send(string terms_of_service_id) {
+  void send(const string &terms_of_service_id) {
     send_query(G()->net_query_creator().create(telegram_api::help_acceptTermsOfService(
-        telegram_api::make_object<telegram_api::dataJSON>(std::move(terms_of_service_id)))));
+        telegram_api::make_object<telegram_api::dataJSON>(terms_of_service_id))));
   }
 
   void on_result(uint64 id, BufferSlice packet) final {
@@ -116,7 +116,7 @@ void get_terms_of_service(Td *td, Promise<std::pair<int32, TermsOfService>> prom
 }
 
 void accept_terms_of_service(Td *td, string &&terms_of_service_id, Promise<Unit> &&promise) {
-  td->create_handler<AcceptTermsOfServiceQuery>(std::move(promise))->send(std::move(terms_of_service_id));
+  td->create_handler<AcceptTermsOfServiceQuery>(std::move(promise))->send(terms_of_service_id);
 }
 
 }  // namespace td

td/telegram/UpdatesManager.cpp

@@ -1878,28 +1878,28 @@ void UpdatesManager::process_updates(vector<tl_object_ptr<telegram_api::Update>>
   }
   if (force_apply) {
     for (auto &update : updates) {
-      if (update != nullptr && is_pts_update(update.get())) {
-        auto constructor_id = update->get_id();
-        if (constructor_id == telegram_api::updateWebPage::ID) {
-          auto update_web_page = move_tl_object_as<telegram_api::updateWebPage>(update);
-          td_->web_pages_manager_->on_get_web_page(std::move(update_web_page->webpage_), DialogId());
-          continue;
+      if (update != nullptr) {
+        if (is_pts_update(update.get())) {
+          auto constructor_id = update->get_id();
+          if (constructor_id == telegram_api::updateWebPage::ID) {
+            auto update_web_page = move_tl_object_as<telegram_api::updateWebPage>(update);
+            td_->web_pages_manager_->on_get_web_page(std::move(update_web_page->webpage_), DialogId());
+            continue;
+          }
+
+          CHECK(constructor_id != telegram_api::updateFolderPeers::ID);
+
+          if (constructor_id == telegram_api::updateReadHistoryInbox::ID) {
+            static_cast<telegram_api::updateReadHistoryInbox *>(update.get())->still_unread_count_ = -1;
+          }
+
+          process_pts_update(std::move(update));
+        } else if (is_qts_update(update.get())) {
+          process_qts_update(std::move(update), 0, mpas.get_promise());
+        } else if (update->get_id() == telegram_api::updateChannelTooLong::ID) {
+          td_->messages_manager_->on_update_channel_too_long(
+              move_tl_object_as<telegram_api::updateChannelTooLong>(update), true);
         }
-
-        CHECK(constructor_id != telegram_api::updateFolderPeers::ID);
-
-        if (constructor_id == telegram_api::updateReadHistoryInbox::ID) {
-          static_cast<telegram_api::updateReadHistoryInbox *>(update.get())->still_unread_count_ = -1;
-        }
-
-        process_pts_update(std::move(update));
-      }
-      if (update != nullptr && is_qts_update(update.get())) {
-        process_qts_update(std::move(update), 0, mpas.get_promise());
-      }
-      if (update != nullptr && update->get_id() == telegram_api::updateChannelTooLong::ID) {
-        td_->messages_manager_->on_update_channel_too_long(
-            move_tl_object_as<telegram_api::updateChannelTooLong>(update), true);
       }
     }
   }
@@ -2101,8 +2101,7 @@ void UpdatesManager::process_qts_update(tl_object_ptr<telegram_api::Update> &&up
     }
     case telegram_api::updateBotStopped::ID: {
       auto update = move_tl_object_as<telegram_api::updateBotStopped>(update_ptr);
-      td_->contacts_manager_->on_update_bot_stopped(UserId(update->user_id_), update->date_,
-                                                    std::move(update->stopped_));
+      td_->contacts_manager_->on_update_bot_stopped(UserId(update->user_id_), update->date_, update->stopped_);
       add_qts(qts).set_value(Unit());
       break;
     }

td/telegram/WebPageBlock.cpp

@@ -2228,7 +2228,7 @@ unique_ptr<WebPageBlock> get_web_page_block(Td *td, tl_object_ptr<telegram_api::
     }
     case telegram_api::pageBlockMap::ID: {
       auto page_block = move_tl_object_as<telegram_api::pageBlockMap>(page_block_ptr);
-      Location location(std::move(page_block->geo_));
+      Location location(page_block->geo_);
       auto zoom = page_block->zoom_;
       Dimensions dimensions = get_dimensions(page_block->w_, page_block->h_, "pageBlockMap");
       if (location.empty()) {

td/telegram/WebPagesManager.cpp

@@ -1055,18 +1055,19 @@ void WebPagesManager::get_web_page_by_url(const string &url, Promise<WebPageId>
   load_web_page_by_url(url, std::move(promise));
 }
 
-void WebPagesManager::load_web_page_by_url(const string &url, Promise<WebPageId> &&promise) {
+void WebPagesManager::load_web_page_by_url(string url, Promise<WebPageId> &&promise) {
   if (!G()->parameters().use_message_db) {
     return reload_web_page_by_url(url, std::move(promise));
   }
 
   LOG(INFO) << "Load \"" << url << '"';
-  G()->td_db()->get_sqlite_pmc()->get(
-      get_web_page_url_database_key(url),
-      PromiseCreator::lambda([actor_id = actor_id(this), url, promise = std::move(promise)](string value) mutable {
-        send_closure(actor_id, &WebPagesManager::on_load_web_page_id_by_url_from_database, std::move(url),
-                     std::move(value), std::move(promise));
-      }));
+  auto key = get_web_page_url_database_key(url);
+  G()->td_db()->get_sqlite_pmc()->get(key, PromiseCreator::lambda([actor_id = actor_id(this), url = std::move(url),
+                                                                   promise = std::move(promise)](string value) mutable {
+                                        send_closure(actor_id,
+                                                     &WebPagesManager::on_load_web_page_id_by_url_from_database,
+                                                     std::move(url), std::move(value), std::move(promise));
+                                      }));
 }
 
 void WebPagesManager::on_load_web_page_id_by_url_from_database(string url, string value, Promise<WebPageId> &&promise) {

td/telegram/WebPagesManager.h

@@ -162,7 +162,7 @@ class WebPagesManager final : public Actor {
 
   static string get_web_page_url_database_key(const string &url);
 
-  void load_web_page_by_url(const string &url, Promise<WebPageId> &&promise);
+  void load_web_page_by_url(string url, Promise<WebPageId> &&promise);
 
   void on_load_web_page_id_by_url_from_database(string url, string value, Promise<WebPageId> &&promise);
 

td/telegram/cli.cpp

@@ -216,7 +216,7 @@ class CliClient final : public Actor {
       , get_chat_list_(get_chat_list)
       , disable_network_(disable_network)
       , api_id_(api_id)
-      , api_hash_(api_hash) {
+      , api_hash_(std::move(api_hash)) {
   }
 
   static void quit_instance() {
@@ -563,7 +563,7 @@ class CliClient final : public Actor {
       return it->second;
     }
     auto result = to_integer<int64>(str);
-    int64 shift = static_cast<int64>(-1000000000000ll);
+    auto shift = static_cast<int64>(-1000000000000ll);
     if (result <= shift) {
       return shift - result;
     }
@@ -573,7 +573,7 @@ class CliClient final : public Actor {
   static int32 as_secret_chat_id(Slice str) {
     str = trim(str);
     auto result = to_integer<int64>(str);
-    int64 shift = static_cast<int64>(-2000000000000ll);
+    auto shift = static_cast<int64>(-2000000000000ll);
     if (result <= shift + std::numeric_limits<int32>::max()) {
       return static_cast<int32>(result - shift);
     }
@@ -598,7 +598,8 @@ class CliClient final : public Actor {
 
   static td_api::object_ptr<td_api::InputFile> as_generated_file(string original_path, string conversion,
                                                                  int32 expected_size = 0) {
-    return td_api::make_object<td_api::inputFileGenerated>(trim(original_path), trim(conversion), expected_size);
+    return td_api::make_object<td_api::inputFileGenerated>(trim(std::move(original_path)), trim(std::move(conversion)),
+                                                           expected_size);
   }
 
   static td_api::object_ptr<td_api::InputFile> as_input_file(string str) {
@@ -645,7 +646,8 @@ class CliClient final : public Actor {
     return to_integer<int32>(trim(std::move(str)));
   }
 
-  static td_api::object_ptr<td_api::location> as_location(string latitude, string longitude, string accuracy = "") {
+  static td_api::object_ptr<td_api::location> as_location(const string &latitude, const string &longitude,
+                                                          const string &accuracy) {
     if (trim(latitude).empty() && trim(longitude).empty()) {
       return nullptr;
     }
@@ -836,6 +838,8 @@ class CliClient final : public Actor {
       case td_api::updateConnectionState::ID:
         LOG(WARNING) << result_str;
         break;
+      default:
+        break;
     }
   }
 
@@ -1027,7 +1031,7 @@ class CliClient final : public Actor {
 #endif
 
   static td_api::object_ptr<td_api::formattedText> as_formatted_text(
-      string text, vector<td_api::object_ptr<td_api::textEntity>> entities = {}) {
+      const string &text, vector<td_api::object_ptr<td_api::textEntity>> entities = {}) {
     if (entities.empty() && !text.empty()) {
       auto parsed_text = execute(
           td_api::make_object<td_api::parseTextEntities>(text, td_api::make_object<td_api::textParseModeMarkdown>(2)));
@@ -1039,7 +1043,7 @@ class CliClient final : public Actor {
   }
 
   static td_api::object_ptr<td_api::formattedText> as_caption(
-      string caption, vector<td_api::object_ptr<td_api::textEntity>> entities = {}) {
+      const string &caption, vector<td_api::object_ptr<td_api::textEntity>> entities = {}) {
     return as_formatted_text(caption, std::move(entities));
   }
 
@@ -1198,7 +1202,7 @@ class CliClient final : public Actor {
   }
 
   static td_api::object_ptr<td_api::SupergroupMembersFilter> get_supergroup_members_filter(MutableSlice filter,
-                                                                                           string query,
+                                                                                           const string &query,
                                                                                            Slice message_thread_id) {
     filter = trim(filter);
     to_lower_inplace(filter);
@@ -1434,8 +1438,9 @@ class CliClient final : public Actor {
     return transform(full_split(types, get_delimiter(types)), [](Slice str) { return as_passport_element_type(str); });
   }
 
-  static td_api::object_ptr<td_api::InputPassportElement> as_input_passport_element(string passport_element_type,
-                                                                                    string arg, bool with_selfie) {
+  static td_api::object_ptr<td_api::InputPassportElement> as_input_passport_element(const string &passport_element_type,
+                                                                                    const string &arg,
+                                                                                    bool with_selfie) {
     vector<td_api::object_ptr<td_api::InputFile>> input_files;
     td_api::object_ptr<td_api::InputFile> selfie;
     if (!arg.empty()) {
@@ -1445,7 +1450,7 @@ class CliClient final : public Actor {
         selfie = as_input_file(files.back());
         files.pop_back();
       }
-      for (auto file : files) {
+      for (const auto &file : files) {
         input_files.push_back(as_input_file(file));
       }
     }
@@ -1484,7 +1489,7 @@ class CliClient final : public Actor {
                                                                std::move(input_files)));
       }
     } else if (passport_element_type == "internal_passport" || passport_element_type == "ip") {
-      if (input_files.size() >= 1) {
+      if (!input_files.empty()) {
         auto front_side = std::move(input_files[0]);
         input_files.erase(input_files.begin());
         return td_api::make_object<td_api::inputPassportElementInternalPassport>(
@@ -1590,7 +1595,7 @@ class CliClient final : public Actor {
     }
   }
 
-  static int32 get_log_tag_verbosity_level(string name) {
+  static int32 get_log_tag_verbosity_level(const string &name) {
     auto level = ClientActor::execute(td_api::make_object<td_api::getLogTagVerbosityLevel>(name));
     if (level->get_id() == td_api::error::ID) {
       return -1;
@@ -1825,7 +1830,7 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::setPassportElement>(
           as_input_passport_element(passport_element_type, arg, op == "spes"), password));
     } else if (op == "dpe") {
-      string passport_element_type = args;
+      string passport_element_type = std::move(args);
       send_request(td_api::make_object<td_api::deletePassportElement>(as_passport_element_type(passport_element_type)));
     } else if (op == "ppn") {
       send_request(td_api::make_object<td_api::processPushNotification>(args));
@@ -1945,7 +1950,7 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::addContact>(
           td_api::make_object<td_api::contact>(string(), first_name, last_name, string(), as_user_id(user_id)), false));
     } else if (op == "spn") {
-      string user_id = args;
+      string user_id = std::move(args);
       send_request(td_api::make_object<td_api::sharePhoneNumber>(as_user_id(user_id)));
     } else if (op == "ImportContacts" || op == "cic") {
       vector<string> contacts_str = full_split(args, ';');
@@ -2007,7 +2012,7 @@ class CliClient final : public Actor {
                                                                  offset, as_limit(limit), op == "ghl"));
       }
     } else if (op == "gcsm") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::getChatScheduledMessages>(as_chat_id(chat_id)));
     } else if (op == "gmpf") {
       string chat_id;
@@ -2136,10 +2141,10 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::getLanguagePackString>(language_database_path, language_pack,
                                                                       language_code, key));
     } else if (op == "synclp") {
-      string language_code = args;
+      string language_code = std::move(args);
       send_request(td_api::make_object<td_api::synchronizeLanguagePack>(language_code));
     } else if (op == "acslp") {
-      string language_code = args;
+      string language_code = std::move(args);
       send_request(td_api::make_object<td_api::addCustomServerLanguagePack>(language_code));
     } else if (op == "sclp") {
       string language_code;
@@ -2374,24 +2379,24 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::optimizeStorage>());
     } else if (op == "clean_photos") {
       std::vector<td_api::object_ptr<td_api::FileType>> types;
-      types.push_back(td_api::make_object<td_api::fileTypePhoto>());
+      types.emplace_back(td_api::make_object<td_api::fileTypePhoto>());
       send_request(td_api::make_object<td_api::optimizeStorage>(0, 0, 0, 0, std::move(types), as_chat_ids(""),
                                                                 as_chat_ids(""), true, 20));
     } else if (op == "clean_storage") {
       std::vector<td_api::object_ptr<td_api::FileType>> types;
-      types.push_back(td_api::make_object<td_api::fileTypeThumbnail>());
-      types.push_back(td_api::make_object<td_api::fileTypeProfilePhoto>());
-      types.push_back(td_api::make_object<td_api::fileTypePhoto>());
-      types.push_back(td_api::make_object<td_api::fileTypeVoiceNote>());
-      types.push_back(td_api::make_object<td_api::fileTypeVideo>());
-      types.push_back(td_api::make_object<td_api::fileTypeDocument>());
-      types.push_back(td_api::make_object<td_api::fileTypeSecret>());
-      types.push_back(td_api::make_object<td_api::fileTypeUnknown>());
-      types.push_back(td_api::make_object<td_api::fileTypeSticker>());
-      types.push_back(td_api::make_object<td_api::fileTypeAudio>());
-      types.push_back(td_api::make_object<td_api::fileTypeAnimation>());
-      types.push_back(td_api::make_object<td_api::fileTypeVideoNote>());
-      types.push_back(td_api::make_object<td_api::fileTypeSecure>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeThumbnail>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeProfilePhoto>());
+      types.emplace_back(td_api::make_object<td_api::fileTypePhoto>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeVoiceNote>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeVideo>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeDocument>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeSecret>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeUnknown>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeSticker>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeAudio>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeAnimation>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeVideoNote>());
+      types.emplace_back(td_api::make_object<td_api::fileTypeSecure>());
       send_request(td_api::make_object<td_api::optimizeStorage>(0, -1, -1, 0, std::move(types), as_chat_ids(args),
                                                                 as_chat_ids(""), true, 20));
     } else if (op == "network") {
@@ -2433,10 +2438,10 @@ class CliClient final : public Actor {
       get_args(args, chat_id, category);
       send_request(td_api::make_object<td_api::removeTopChat>(get_top_chat_category(category), as_chat_id(chat_id)));
     } else if (op == "gsssn") {
-      string title = args;
+      string title = std::move(args);
       send_request(td_api::make_object<td_api::getSuggestedStickerSetName>(title));
     } else if (op == "cssn") {
-      string name = args;
+      string name = std::move(args);
       send_request(td_api::make_object<td_api::checkStickerSetName>(name));
     } else if (op == "usf" || op == "usfa") {
       td_api::object_ptr<td_api::InputSticker> input_sticker;
@@ -2453,7 +2458,7 @@ class CliClient final : public Actor {
       get_args(args, title, name, stickers);
       auto input_stickers =
           transform(full_split(stickers, get_delimiter(stickers)),
-                    [op](string sticker) -> td_api::object_ptr<td_api::InputSticker> {
+                    [op](const string &sticker) -> td_api::object_ptr<td_api::InputSticker> {
                       if (op == "cnssa") {
                         return td_api::make_object<td_api::inputStickerAnimated>(as_input_file(sticker), "😀");
                       } else {
@@ -2546,7 +2551,7 @@ class CliClient final : public Actor {
       get_args(args, chat_id, member_id);
       send_request(td_api::make_object<td_api::getChatMember>(as_chat_id(chat_id), as_message_sender(member_id)));
     } else if (op == "GetChatAdministrators") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::getChatAdministrators>(as_chat_id(chat_id)));
     } else if (op == "GetSupergroupAdministrators" || op == "GetSupergroupBanned" || op == "GetSupergroupBots" ||
                op == "GetSupergroupContacts" || op == "GetSupergroupMembers" || op == "GetSupergroupRestricted" ||
@@ -2602,7 +2607,7 @@ class CliClient final : public Actor {
       get_args(args, chat_id, message_id);
       send_request(td_api::make_object<td_api::getMessageViewers>(as_chat_id(chat_id), as_message_id(message_id)));
     } else if (op == "gcpm") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::getChatPinnedMessage>(as_chat_id(chat_id)));
     } else if (op == "gms") {
       string chat_id;
@@ -2664,8 +2669,8 @@ class CliClient final : public Actor {
       int32 scale;
       string chat_id;
       get_args(args, latitude, longitude, zoom, width, height, scale, chat_id);
-      send_request(td_api::make_object<td_api::getMapThumbnailFile>(as_location(latitude, longitude), zoom, width,
-                                                                    height, scale, as_chat_id(chat_id)));
+      send_request(td_api::make_object<td_api::getMapThumbnailFile>(as_location(latitude, longitude, string()), zoom,
+                                                                    width, height, scale, as_chat_id(chat_id)));
     } else if (op == "df" || op == "DownloadFile" || op == "dff" || op == "dfs") {
       string file_id;
       int32 priority;
@@ -2712,7 +2717,7 @@ class CliClient final : public Actor {
     } else if (op == "cuf") {
       send_request(td_api::make_object<td_api::cancelUploadFile>(as_file_id(args)));
     } else if (op == "delf" || op == "DeleteFile") {
-      string file_id = args;
+      string file_id = std::move(args);
       send_request(td_api::make_object<td_api::deleteFile>(as_file_id(file_id)));
     } else if (op == "dm" || op == "dmr") {
       string chat_id;
@@ -2842,7 +2847,7 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::toggleGroupCallScreenSharingIsPaused>(as_group_call_id(group_call_id),
                                                                                      is_paused));
     } else if (op == "egcss") {
-      string group_call_id = args;
+      string group_call_id = std::move(args);
       send_request(td_api::make_object<td_api::endGroupCallScreenSharing>(as_group_call_id(group_call_id)));
     } else if (op == "sgct") {
       string chat_id;
@@ -2894,7 +2899,7 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::startGroupCallRecording>(as_group_call_id(chat_id), title, record_video,
                                                                         use_portrait_orientation));
     } else if (op == "egcr") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::endGroupCallRecording>(as_group_call_id(chat_id)));
     } else if (op == "tgcpim") {
       string group_call_id;
@@ -2928,7 +2933,7 @@ class CliClient final : public Actor {
     } else if (op == "dgc") {
       send_request(td_api::make_object<td_api::discardGroupCall>(as_group_call_id(args)));
     } else if (op == "rpcil") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::replacePrimaryChatInviteLink>(as_chat_id(chat_id)));
     } else if (op == "ccilt") {
       string chat_id;
@@ -2950,7 +2955,7 @@ class CliClient final : public Actor {
       get_args(args, chat_id, invite_link);
       send_request(td_api::make_object<td_api::revokeChatInviteLink>(as_chat_id(chat_id), invite_link));
     } else if (op == "gcilc") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::getChatInviteLinkCounts>(as_chat_id(chat_id)));
     } else if (op == "gcil") {
       string chat_id;
@@ -3035,21 +3040,21 @@ class CliClient final : public Actor {
       test_get_json_string(td_api::make_object<td_api::jsonValueString>("aba\200caba"));
 
       auto inner_array = td_api::make_object<td_api::jsonValueArray>();
-      inner_array->values_.push_back(td_api::make_object<td_api::jsonValueBoolean>(false));
+      inner_array->values_.emplace_back(td_api::make_object<td_api::jsonValueBoolean>(false));
       auto array = td_api::make_object<td_api::jsonValueArray>();
-      array->values_.push_back(nullptr);
-      array->values_.push_back(std::move(inner_array));
-      array->values_.push_back(td_api::make_object<td_api::jsonValueNull>());
-      array->values_.push_back(td_api::make_object<td_api::jsonValueNumber>(-1));
+      array->values_.emplace_back(nullptr);
+      array->values_.emplace_back(std::move(inner_array));
+      array->values_.emplace_back(td_api::make_object<td_api::jsonValueNull>());
+      array->values_.emplace_back(td_api::make_object<td_api::jsonValueNumber>(-1));
       test_get_json_string(std::move(array));
 
       auto object = td_api::make_object<td_api::jsonValueObject>();
-      object->members_.push_back(
+      object->members_.emplace_back(
           td_api::make_object<td_api::jsonObjectMember>("", td_api::make_object<td_api::jsonValueString>("test")));
-      object->members_.push_back(td_api::make_object<td_api::jsonObjectMember>("a", nullptr));
-      object->members_.push_back(td_api::make_object<td_api::jsonObjectMember>("\x80", nullptr));
-      object->members_.push_back(nullptr);
-      object->members_.push_back(
+      object->members_.emplace_back(td_api::make_object<td_api::jsonObjectMember>("a", nullptr));
+      object->members_.emplace_back(td_api::make_object<td_api::jsonObjectMember>("\x80", nullptr));
+      object->members_.emplace_back(nullptr);
+      object->members_.emplace_back(
           td_api::make_object<td_api::jsonObjectMember>("a", td_api::make_object<td_api::jsonValueNull>()));
       test_get_json_string(std::move(object));
     } else if (op == "gac") {
@@ -3159,9 +3164,9 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::searchSecretMessages>(as_chat_id(chat_id), query.query, offset,
                                                                      query.limit, as_search_messages_filter(filter)));
     } else if (op == "ssd") {
-      schedule_date_ = args;
+      schedule_date_ = std::move(args);
     } else if (op == "smti") {
-      message_thread_id_ = args;
+      message_thread_id_ = std::move(args);
     } else if (op == "sm" || op == "sms" || op == "smr" || op == "smf") {
       string chat_id;
       string reply_to_message_id;
@@ -3332,8 +3337,8 @@ class CliClient final : public Actor {
       string bot_id;
       string query;
       get_args(args, bot_id, query);
-      send_request(td_api::make_object<td_api::getInlineQueryResults>(as_user_id(bot_id), 0, as_location("1.1", "2.2"),
-                                                                      query, ""));
+      send_request(td_api::make_object<td_api::getInlineQueryResults>(as_user_id(bot_id), 0,
+                                                                      as_location("1.1", "2.2", ""), query, ""));
     } else if (op == "siqr" || op == "siqrh") {
       string chat_id;
       int64 query_id;
@@ -3688,8 +3693,8 @@ class CliClient final : public Actor {
       send_request(td_api::make_object<td_api::createNewSupergroupChat>(args, false, "Description", nullptr, false));
     } else if (op == "cnsgcloc") {
       send_request(td_api::make_object<td_api::createNewSupergroupChat>(
-          args, false, "Description", td_api::make_object<td_api::chatLocation>(as_location("40.0", "60.0"), "address"),
-          false));
+          args, false, "Description",
+          td_api::make_object<td_api::chatLocation>(as_location("40.0", "60.0", ""), "address"), false));
     } else if (op == "cnsgcimport") {
       send_request(td_api::make_object<td_api::createNewSupergroupChat>(args, false, "Description", nullptr, true));
     } else if (op == "UpgradeBasicGroupChatToSupergroupChat") {
@@ -3726,10 +3731,10 @@ class CliClient final : public Actor {
       get_args(args, supergroup_id, force);
       send_request(td_api::make_object<td_api::createSupergroupChat>(as_supergroup_id(supergroup_id), force));
     } else if (op == "gcltac") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::getChatListsToAddChat>(as_chat_id(chat_id)));
     } else if (op == "actl" || op == "actla" || begins_with(op, "actl-")) {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::addChatToList>(as_chat_id(chat_id), as_chat_list(op)));
     } else if (op == "gcf") {
       send_request(td_api::make_object<td_api::getChatFilter>(as_chat_filter_id(args)));
@@ -3760,7 +3765,7 @@ class CliClient final : public Actor {
       get_args(args, chat_id, title);
       send_request(td_api::make_object<td_api::setChatTitle>(as_chat_id(chat_id), title));
     } else if (op == "scpe") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::setChatPhoto>(as_chat_id(chat_id), nullptr));
     } else if (op == "scpp") {
       string chat_id;
@@ -4006,7 +4011,8 @@ class CliClient final : public Actor {
       string longitude;
       get_args(args, chat_id, latitude, longitude);
       send_request(td_api::make_object<td_api::setChatLocation>(
-          as_chat_id(chat_id), td_api::make_object<td_api::chatLocation>(as_location(latitude, longitude), "address")));
+          as_chat_id(chat_id),
+          td_api::make_object<td_api::chatLocation>(as_location(latitude, longitude, string()), "address")));
     } else if (op == "scsmd") {
       string chat_id;
       int32 slow_mode_delay;
@@ -4024,7 +4030,7 @@ class CliClient final : public Actor {
       get_args(args, chat_id, message_id);
       send_request(td_api::make_object<td_api::unpinChatMessage>(as_chat_id(chat_id), as_message_id(message_id)));
     } else if (op == "uacm") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::unpinAllChatMessages>(as_chat_id(chat_id)));
     } else if (op == "grib") {
       send_request(td_api::make_object<td_api::getRecentInlineBots>());
@@ -4044,12 +4050,12 @@ class CliClient final : public Actor {
       string latitude;
       string longitude;
       get_args(args, latitude, longitude);
-      send_request(td_api::make_object<td_api::searchChatsNearby>(as_location(latitude, longitude)));
+      send_request(td_api::make_object<td_api::searchChatsNearby>(as_location(latitude, longitude, string())));
     } else if (op == "sloc") {
       string latitude;
       string longitude;
       get_args(args, latitude, longitude);
-      send_request(td_api::make_object<td_api::setLocation>(as_location(latitude, longitude)));
+      send_request(td_api::make_object<td_api::setLocation>(as_location(latitude, longitude, string())));
     } else if (op == "sco") {
       SearchQuery query;
       get_args(args, query);
@@ -4109,16 +4115,16 @@ class CliClient final : public Actor {
       send_request(
           td_api::make_object<td_api::clickAnimatedEmojiMessage>(as_chat_id(chat_id), as_message_id(message_id)));
     } else if (op == "gilt") {
-      string link = args;
+      string link = std::move(args);
       send_request(td_api::make_object<td_api::getInternalLinkType>(link));
     } else if (op == "geli") {
-      string link = args;
+      string link = std::move(args);
       send_request(td_api::make_object<td_api::getExternalLinkInfo>(link));
     } else if (op == "gel" || op == "gelw") {
-      string link = args;
+      string link = std::move(args);
       send_request(td_api::make_object<td_api::getExternalLink>(link, op == "gelw"));
     } else if (op == "racm") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::readAllChatMentions>(as_chat_id(chat_id)));
     } else if (op == "tre") {
       send_request(td_api::make_object<td_api::testReturnError>(
@@ -4169,7 +4175,7 @@ class CliClient final : public Actor {
       get_args(args, group_id, max_notification_id);
       send_request(td_api::make_object<td_api::removeNotificationGroup>(group_id, max_notification_id));
     } else if (op == "rcab") {
-      string chat_id = args;
+      string chat_id = std::move(args);
       send_request(td_api::make_object<td_api::removeChatActionBar>(as_chat_id(chat_id)));
     } else if (op == "rc") {
       string chat_id;
@@ -4348,7 +4354,7 @@ class CliClient final : public Actor {
         execute(std::move(request));
       }
     } else if (op == "gltvl" || op == "gltvle" || op == "gtag") {
-      string tag = args;
+      string tag = std::move(args);
       auto request = td_api::make_object<td_api::getLogTagVerbosityLevel>(tag);
       if (op == "gltvl") {
         send_request(std::move(request));

td/telegram/files/FileBitmask.cpp

@@ -106,11 +106,11 @@ int64 Bitmask::get_total_size(int64 part_size, int64 file_size) const {
 
 bool Bitmask::get(int64 offset_part) const {
   if (offset_part < 0) {
-    return 0;
+    return false;
   }
   auto index = narrow_cast<size_t>(offset_part / 8);
   if (index >= data_.size()) {
-    return 0;
+    return false;
   }
   return (static_cast<uint8>(data_[index]) & (1 << static_cast<int>(offset_part % 8))) != 0;
 }
@@ -148,7 +148,7 @@ int64 Bitmask::size() const {
 }
 
 StringBuilder &operator<<(StringBuilder &sb, const Bitmask &mask) {
-  bool prev = 0;
+  bool prev = false;
   int32 cnt = 0;
   for (int64 i = 0; i <= mask.size(); i++) {
     bool cur = mask.get(i);

td/telegram/files/FileDownloader.cpp

@@ -446,7 +446,7 @@ Result<FileLoader::CheckInfo> FileDownloader::check_loop(int64 checked_prefix_si
         }
         end_offset = ready_prefix_size;
       }
-      size_t size = narrow_cast<size_t>(end_offset - begin_offset);
+      auto size = narrow_cast<size_t>(end_offset - begin_offset);
       auto slice = BufferSlice(size);
       TRY_STATUS(acquire_fd());
       TRY_RESULT(read_size, fd_.pread(slice.as_slice(), begin_offset));

td/telegram/files/FileDownloader.h

@@ -28,8 +28,8 @@ class FileDownloader final : public FileLoader {
   class Callback : public FileLoader::Callback {
    public:
     virtual void on_start_download() = 0;
-    virtual void on_partial_download(const PartialLocalFileLocation &partial_local, int64 ready_size, int64 size) = 0;
-    virtual void on_ok(const FullLocalFileLocation &full_local, int64 size, bool is_new) = 0;
+    virtual void on_partial_download(PartialLocalFileLocation partial_local, int64 ready_size, int64 size) = 0;
+    virtual void on_ok(FullLocalFileLocation full_local, int64 size, bool is_new) = 0;
     virtual void on_error(Status status) = 0;
   };
 

td/telegram/files/FileFromBytes.cpp

@@ -18,8 +18,8 @@ FileFromBytes::FileFromBytes(FileType type, BufferSlice bytes, string name, uniq
 }
 
 void FileFromBytes::wakeup() {
-  int64 size = narrow_cast<int64>(bytes_.size());
-  auto r_result = save_file_bytes(type_, std::move(bytes_), std::move(name_));
+  auto size = narrow_cast<int64>(bytes_.size());
+  auto r_result = save_file_bytes(type_, std::move(bytes_), name_);
   if (r_result.is_error()) {
     callback_->on_error(r_result.move_as_error());
   } else {

td/telegram/files/FileGcWorker.cpp

@@ -55,7 +55,7 @@ void FileGcWorker::run_gc(const FileGcParameters &parameters, std::vector<FullFi
     }
     for (int32 i = 0; i < MAX_FILE_TYPE; i++) {
       auto main_file_type = narrow_cast<size_t>(get_main_file_type(static_cast<FileType>(i)));
-      if (immune_types[main_file_type] == false) {
+      if (!immune_types[main_file_type]) {
         immune_types[i] = false;
       }
     }

td/telegram/files/FileGenerateManager.cpp

@@ -99,7 +99,7 @@ class FileDownloadGenerateActor final : public FileGenerateActor {
                   if (file_view.has_local_location()) {
                     auto location = file_view.local_location();
                     location.file_type_ = file_type;
-                    callback->on_ok(location);
+                    callback->on_ok(std::move(location));
                   } else {
                     LOG(ERROR) << "Expected to have local location";
                     callback->on_error(Status::Error(500, "Unknown"));

td/telegram/files/FileGenerateManager.h

@@ -26,8 +26,8 @@ class FileGenerateCallback {
   FileGenerateCallback &operator=(const FileGenerateCallback &) = delete;
   virtual ~FileGenerateCallback() = default;
 
-  virtual void on_partial_generate(const PartialLocalFileLocation &partial_local, int32 expected_size) = 0;
-  virtual void on_ok(const FullLocalFileLocation &local) = 0;
+  virtual void on_partial_generate(PartialLocalFileLocation partial_local, int32 expected_size) = 0;
+  virtual void on_ok(FullLocalFileLocation local) = 0;
   virtual void on_error(Status error) = 0;
 };
 

td/telegram/files/FileHashUploader.h

@@ -27,7 +27,8 @@ class FileHashUploader final : public FileLoaderActor {
     Callback(const Callback &) = delete;
     Callback &operator=(const Callback &) = delete;
     virtual ~Callback() = default;
-    virtual void on_ok(const FullRemoteFileLocation &locatioin) = 0;
+
+    virtual void on_ok(FullRemoteFileLocation location) = 0;
     virtual void on_error(Status status) = 0;
   };
 

td/telegram/files/FileLoadManager.cpp

@@ -192,14 +192,15 @@ void FileLoadManager::on_start_download() {
   }
 }
 
-void FileLoadManager::on_partial_download(const PartialLocalFileLocation &partial_local, int64 ready_size, int64 size) {
+void FileLoadManager::on_partial_download(PartialLocalFileLocation partial_local, int64 ready_size, int64 size) {
   auto node_id = get_link_token();
   auto node = nodes_container_.get(node_id);
   if (node == nullptr) {
     return;
   }
   if (!stop_flag_) {
-    send_closure(callback_, &Callback::on_partial_download, node->query_id_, partial_local, ready_size, size);
+    send_closure(callback_, &Callback::on_partial_download, node->query_id_, std::move(partial_local), ready_size,
+                 size);
   }
 }
 
@@ -214,51 +215,51 @@ void FileLoadManager::on_hash(string hash) {
   }
 }
 
-void FileLoadManager::on_partial_upload(const PartialRemoteFileLocation &partial_remote, int64 ready_size) {
+void FileLoadManager::on_partial_upload(PartialRemoteFileLocation partial_remote, int64 ready_size) {
   auto node_id = get_link_token();
   auto node = nodes_container_.get(node_id);
   if (node == nullptr) {
     return;
   }
   if (!stop_flag_) {
-    send_closure(callback_, &Callback::on_partial_upload, node->query_id_, partial_remote, ready_size);
+    send_closure(callback_, &Callback::on_partial_upload, node->query_id_, std::move(partial_remote), ready_size);
   }
 }
 
-void FileLoadManager::on_ok_download(const FullLocalFileLocation &local, int64 size, bool is_new) {
+void FileLoadManager::on_ok_download(FullLocalFileLocation local, int64 size, bool is_new) {
   auto node_id = get_link_token();
   auto node = nodes_container_.get(node_id);
   if (node == nullptr) {
     return;
   }
   if (!stop_flag_) {
-    send_closure(callback_, &Callback::on_download_ok, node->query_id_, local, size, is_new);
+    send_closure(callback_, &Callback::on_download_ok, node->query_id_, std::move(local), size, is_new);
   }
   close_node(node_id);
   loop();
 }
 
-void FileLoadManager::on_ok_upload(FileType file_type, const PartialRemoteFileLocation &remote, int64 size) {
+void FileLoadManager::on_ok_upload(FileType file_type, PartialRemoteFileLocation remote, int64 size) {
   auto node_id = get_link_token();
   auto node = nodes_container_.get(node_id);
   if (node == nullptr) {
     return;
   }
   if (!stop_flag_) {
-    send_closure(callback_, &Callback::on_upload_ok, node->query_id_, file_type, remote, size);
+    send_closure(callback_, &Callback::on_upload_ok, node->query_id_, file_type, std::move(remote), size);
   }
   close_node(node_id);
   loop();
 }
 
-void FileLoadManager::on_ok_upload_full(const FullRemoteFileLocation &remote) {
+void FileLoadManager::on_ok_upload_full(FullRemoteFileLocation remote) {
   auto node_id = get_link_token();
   auto node = nodes_container_.get(node_id);
   if (node == nullptr) {
     return;
   }
   if (!stop_flag_) {
-    send_closure(callback_, &Callback::on_upload_full_ok, node->query_id_, remote);
+    send_closure(callback_, &Callback::on_upload_full_ok, node->query_id_, std::move(remote));
   }
   close_node(node_id);
   loop();

td/telegram/files/FileLoadManager.h

@@ -33,17 +33,18 @@ class FileLoadManager final : public Actor {
   class Callback : public Actor {
    public:
     virtual void on_start_download(QueryId id) = 0;
-    virtual void on_partial_download(QueryId id, const PartialLocalFileLocation &partial_local, int64 ready_size,
+    virtual void on_partial_download(QueryId id, PartialLocalFileLocation partial_local, int64 ready_size,
                                      int64 size) = 0;
-    virtual void on_partial_upload(QueryId id, const PartialRemoteFileLocation &partial_remote, int64 ready_size) = 0;
+    virtual void on_partial_upload(QueryId id, PartialRemoteFileLocation partial_remote, int64 ready_size) = 0;
     virtual void on_hash(QueryId id, string hash) = 0;
-    virtual void on_upload_ok(QueryId id, FileType file_type, const PartialRemoteFileLocation &remtoe, int64 size) = 0;
-    virtual void on_upload_full_ok(QueryId id, const FullRemoteFileLocation &remote) = 0;
-    virtual void on_download_ok(QueryId id, const FullLocalFileLocation &local, int64 size, bool is_new) = 0;
+    virtual void on_upload_ok(QueryId id, FileType file_type, PartialRemoteFileLocation remtoe, int64 size) = 0;
+    virtual void on_upload_full_ok(QueryId id, FullRemoteFileLocation remote) = 0;
+    virtual void on_download_ok(QueryId id, FullLocalFileLocation local, int64 size, bool is_new) = 0;
     virtual void on_error(QueryId id, Status status) = 0;
   };
 
   explicit FileLoadManager(ActorShared<Callback> callback, ActorShared<> parent);
+
   void download(QueryId id, const FullRemoteFileLocation &remote_location, const LocalFileLocation &local, int64 size,
                 string name, const FileEncryptionKey &encryption_key, bool search_file, int64 offset, int64 limit,
                 int8 priority);
@@ -55,6 +56,7 @@ class FileLoadManager final : public Actor {
   void cancel(QueryId id);
   void update_local_file_location(QueryId id, const LocalFileLocation &local);
   void update_downloaded_part(QueryId id, int64 offset, int64 limit);
+
   void get_content(const FullLocalFileLocation &local_location, Promise<BufferSlice> promise);
 
  private:
@@ -84,12 +86,12 @@ class FileLoadManager final : public Actor {
   ActorOwn<ResourceManager> &get_download_resource_manager(bool is_small, DcId dc_id);
 
   void on_start_download();
-  void on_partial_download(const PartialLocalFileLocation &partial_local, int64 ready_size, int64 size);
-  void on_partial_upload(const PartialRemoteFileLocation &partial_remote, int64 ready_size);
+  void on_partial_download(PartialLocalFileLocation partial_local, int64 ready_size, int64 size);
+  void on_partial_upload(PartialRemoteFileLocation partial_remote, int64 ready_size);
   void on_hash(string hash);
-  void on_ok_download(const FullLocalFileLocation &local, int64 size, bool is_new);
-  void on_ok_upload(FileType file_type, const PartialRemoteFileLocation &remote, int64 size);
-  void on_ok_upload_full(const FullRemoteFileLocation &remote);
+  void on_ok_download(FullLocalFileLocation local, int64 size, bool is_new);
+  void on_ok_upload(FileType file_type, PartialRemoteFileLocation remote, int64 size);
+  void on_ok_upload_full(FullRemoteFileLocation remote);
   void on_error(Status status);
   void on_error_impl(NodeId node_id, Status status);
 
@@ -104,11 +106,11 @@ class FileLoadManager final : public Actor {
     void on_start_download() final {
       send_closure(actor_id_, &FileLoadManager::on_start_download);
     }
-    void on_partial_download(const PartialLocalFileLocation &partial_local, int64 ready_size, int64 size) final {
-      send_closure(actor_id_, &FileLoadManager::on_partial_download, partial_local, ready_size, size);
+    void on_partial_download(PartialLocalFileLocation partial_local, int64 ready_size, int64 size) final {
+      send_closure(actor_id_, &FileLoadManager::on_partial_download, std::move(partial_local), ready_size, size);
     }
-    void on_ok(const FullLocalFileLocation &full_local, int64 size, bool is_new) final {
-      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_download, full_local, size, is_new);
+    void on_ok(FullLocalFileLocation full_local, int64 size, bool is_new) final {
+      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_download, std::move(full_local), size, is_new);
     }
     void on_error(Status status) final {
       send_closure(std::move(actor_id_), &FileLoadManager::on_error, std::move(status));
@@ -126,11 +128,11 @@ class FileLoadManager final : public Actor {
     void on_hash(string hash) final {
       send_closure(actor_id_, &FileLoadManager::on_hash, std::move(hash));
     }
-    void on_partial_upload(const PartialRemoteFileLocation &partial_remote, int64 ready_size) final {
-      send_closure(actor_id_, &FileLoadManager::on_partial_upload, partial_remote, ready_size);
+    void on_partial_upload(PartialRemoteFileLocation partial_remote, int64 ready_size) final {
+      send_closure(actor_id_, &FileLoadManager::on_partial_upload, std::move(partial_remote), ready_size);
     }
-    void on_ok(FileType file_type, const PartialRemoteFileLocation &partial_remote, int64 size) final {
-      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_upload, file_type, partial_remote, size);
+    void on_ok(FileType file_type, PartialRemoteFileLocation partial_remote, int64 size) final {
+      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_upload, file_type, std::move(partial_remote), size);
     }
     void on_error(Status status) final {
       send_closure(std::move(actor_id_), &FileLoadManager::on_error, std::move(status));
@@ -144,8 +146,8 @@ class FileLoadManager final : public Actor {
    private:
     ActorShared<FileLoadManager> actor_id_;
 
-    void on_ok(const FullRemoteFileLocation &remote) final {
-      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_upload_full, remote);
+    void on_ok(FullRemoteFileLocation remote) final {
+      send_closure(std::move(actor_id_), &FileLoadManager::on_ok_upload_full, std::move(remote));
     }
     void on_error(Status status) final {
       send_closure(std::move(actor_id_), &FileLoadManager::on_error, std::move(status));

td/telegram/files/FileLocation.h

@@ -630,9 +630,9 @@ class RemoteFileLocation {
 
   RemoteFileLocation() : variant_{EmptyRemoteFileLocation{}} {
   }
-  explicit RemoteFileLocation(const FullRemoteFileLocation &full) : variant_(full) {
+  explicit RemoteFileLocation(FullRemoteFileLocation full) : variant_(std::move(full)) {
   }
-  explicit RemoteFileLocation(const PartialRemoteFileLocation &partial) : variant_(partial) {
+  explicit RemoteFileLocation(PartialRemoteFileLocation partial) : variant_(std::move(partial)) {
   }
 
  private:
@@ -771,13 +771,15 @@ struct PartialLocalFileLocationPtr {
   PartialLocalFileLocationPtr() : location_(make_unique<PartialLocalFileLocation>()) {
   }
   explicit PartialLocalFileLocationPtr(PartialLocalFileLocation location)
-      : location_(make_unique<PartialLocalFileLocation>(location)) {
+      : location_(make_unique<PartialLocalFileLocation>(std::move(location))) {
   }
   PartialLocalFileLocationPtr(const PartialLocalFileLocationPtr &other)
       : location_(make_unique<PartialLocalFileLocation>(*other.location_)) {
   }
   PartialLocalFileLocationPtr &operator=(const PartialLocalFileLocationPtr &other) {
-    *location_ = *other.location_;
+    if (this != &other) {
+      *location_ = *other.location_;
+    }
     return *this;
   }
   PartialLocalFileLocationPtr(PartialLocalFileLocationPtr &&other) noexcept
@@ -839,9 +841,10 @@ class LocalFileLocation {
 
   LocalFileLocation() : variant_{EmptyLocalFileLocation()} {
   }
-  explicit LocalFileLocation(const PartialLocalFileLocation &partial) : variant_(PartialLocalFileLocationPtr(partial)) {
+  explicit LocalFileLocation(PartialLocalFileLocation partial)
+      : variant_(PartialLocalFileLocationPtr(std::move(partial))) {
   }
-  explicit LocalFileLocation(const FullLocalFileLocation &full) : variant_(full) {
+  explicit LocalFileLocation(FullLocalFileLocation full) : variant_(std::move(full)) {
   }
   LocalFileLocation(FileType file_type, string path, uint64 mtime_nsec)
       : variant_(FullLocalFileLocation{file_type, std::move(path), mtime_nsec}) {

td/telegram/files/FileManager.cpp

@@ -270,7 +270,7 @@ void FileNode::delete_partial_remote_location() {
   }
 }
 
-void FileNode::set_partial_remote_location(const PartialRemoteFileLocation &remote, int64 ready_size) {
+void FileNode::set_partial_remote_location(PartialRemoteFileLocation remote, int64 ready_size) {
   if (remote_.is_full_alive) {
     VLOG(update_file) << "File " << main_file_id_ << " remote is still alive, so there is NO reason to update partial";
     return;
@@ -293,7 +293,7 @@ void FileNode::set_partial_remote_location(const PartialRemoteFileLocation &remo
   }
 
   VLOG(update_file) << "File " << main_file_id_ << " partial location has changed to " << remote;
-  remote_.partial = make_unique<PartialRemoteFileLocation>(remote);
+  remote_.partial = make_unique<PartialRemoteFileLocation>(std::move(remote));
   on_changed();
 }
 
@@ -1036,7 +1036,7 @@ bool FileManager::try_fix_partial_local_location(FileNodePtr node) {
   partial.ready_bitmask_ = new_mask.encode();
 
   auto ready_size = new_mask.get_total_size(partial.part_size_, node->size_);
-  node->set_local_location(LocalFileLocation(partial), ready_size, -1, -1);
+  node->set_local_location(LocalFileLocation(std::move(partial)), ready_size, -1, -1);
   LOG(INFO) << "   ok: increase part_size " << old_part_size << "->" << new_part_size;
   return true;
 }
@@ -1109,17 +1109,17 @@ Result<FileId> FileManager::register_local(FullLocalFileLocation location, Dialo
                        skip_file_size_checks);
 }
 
-FileId FileManager::register_remote(const FullRemoteFileLocation &location, FileLocationSource file_location_source,
+FileId FileManager::register_remote(FullRemoteFileLocation location, FileLocationSource file_location_source,
                                     DialogId owner_dialog_id, int64 size, int64 expected_size, string remote_name) {
   FileData data;
-  data.remote_ = RemoteFileLocation(location);
+  auto url = location.get_url();
+  data.remote_ = RemoteFileLocation(std::move(location));
   data.owner_dialog_id_ = owner_dialog_id;
   data.size_ = size;
   data.expected_size_ = expected_size;
   data.remote_name_ = std::move(remote_name);
 
   auto file_id = register_file(std::move(data), file_location_source, "register_remote", false).move_as_ok();
-  auto url = location.get_url();
   if (!url.empty()) {
     auto file_node = get_file_node(file_id);
     CHECK(file_node);
@@ -1273,8 +1273,8 @@ Result<FileId> FileManager::register_file(FileData &&data, FileLocationSource fi
 // 1 -- choose y
 // 2 -- choose any
 static int merge_choose_local_location(const LocalFileLocation &x, const LocalFileLocation &y) {
-  int32 x_type = static_cast<int32>(x.type());
-  int32 y_type = static_cast<int32>(y.type());
+  auto x_type = static_cast<int32>(x.type());
+  auto y_type = static_cast<int32>(y.type());
   if (x_type != y_type) {
     return x_type < y_type;
   }
@@ -2382,7 +2382,7 @@ class FileManager::ForceUploadActor final : public Actor {
     void on_upload_error(FileId file_id, Status error) final {
       send_closure(std::move(callback_), &ForceUploadActor::on_upload_error, std::move(error));
     }
-    ~UploadCallback() {
+    ~UploadCallback() final {
       if (callback_.empty()) {
         return;
       }
@@ -2594,7 +2594,7 @@ bool FileManager::delete_partial_remote_location(FileId file_id) {
   return true;
 }
 
-void FileManager::delete_file_reference(FileId file_id, string file_reference) {
+void FileManager::delete_file_reference(FileId file_id, Slice file_reference) {
   VLOG(file_references) << "Delete file reference of file " << file_id << " "
                         << tag("reference_base64", base64_encode(file_reference));
   auto node = get_sync_file_node(file_id);
@@ -2697,11 +2697,12 @@ void FileManager::run_generate(FileNodePtr node) {
                   public:
                    Callback(ActorId<FileManager> actor, QueryId id) : actor_(std::move(actor)), query_id_(id) {
                    }
-                   void on_partial_generate(const PartialLocalFileLocation &partial_local, int32 expected_size) final {
-                     send_closure(actor_, &FileManager::on_partial_generate, query_id_, partial_local, expected_size);
+                   void on_partial_generate(PartialLocalFileLocation partial_local, int32 expected_size) final {
+                     send_closure(actor_, &FileManager::on_partial_generate, query_id_, std::move(partial_local),
+                                  expected_size);
                    }
-                   void on_ok(const FullLocalFileLocation &local) final {
-                     send_closure(actor_, &FileManager::on_generate_ok, query_id_, local);
+                   void on_ok(FullLocalFileLocation local) final {
+                     send_closure(actor_, &FileManager::on_generate_ok, query_id_, std::move(local));
                    }
                    void on_error(Status error) final {
                      send_closure(actor_, &FileManager::on_error, query_id_, std::move(error));
@@ -2972,12 +2973,12 @@ td_api::object_ptr<td_api::file> FileManager::get_file_object(FileId file_id, bo
   string persistent_file_id = file_view.get_persistent_file_id();
   string unique_file_id = file_view.get_unique_file_id();
   bool is_uploading_completed = !persistent_file_id.empty();
-  int32 size = narrow_cast<int32>(file_view.size());
-  int32 expected_size = narrow_cast<int32>(file_view.expected_size());
-  int32 download_offset = narrow_cast<int32>(file_view.download_offset());
-  int32 local_prefix_size = narrow_cast<int32>(file_view.local_prefix_size());
-  int32 local_total_size = narrow_cast<int32>(file_view.local_total_size());
-  int32 remote_size = narrow_cast<int32>(file_view.remote_size());
+  auto size = narrow_cast<int32>(file_view.size());
+  auto expected_size = narrow_cast<int32>(file_view.expected_size());
+  auto download_offset = narrow_cast<int32>(file_view.download_offset());
+  auto local_prefix_size = narrow_cast<int32>(file_view.local_prefix_size());
+  auto local_total_size = narrow_cast<int32>(file_view.local_total_size());
+  auto remote_size = narrow_cast<int32>(file_view.remote_size());
   string path = file_view.path();
   bool can_be_downloaded = file_view.can_download_from_server() || file_view.can_generate();
   bool can_be_deleted = file_view.can_delete();
@@ -3189,8 +3190,8 @@ Result<FileId> FileManager::get_map_thumbnail_file_id(Location location, int32 z
   const double PI = 3.14159265358979323846;
   double sin_latitude = std::sin(location.get_latitude() * PI / 180);
   int32 size = 256 * (1 << zoom);
-  int32 x = static_cast<int32>((location.get_longitude() + 180) / 360 * size);
-  int32 y = static_cast<int32>((0.5 - std::log((1 + sin_latitude) / (1 - sin_latitude)) / (4 * PI)) * size);
+  auto x = static_cast<int32>((location.get_longitude() + 180) / 360 * size);
+  auto y = static_cast<int32>((0.5 - std::log((1 + sin_latitude) / (1 - sin_latitude)) / (4 * PI)) * size);
   x = clamp(x, 0, size - 1);  // just in case
   y = clamp(y, 0, size - 1);  // just in case
 
@@ -3352,7 +3353,7 @@ FileId FileManager::next_file_id() {
 }
 
 FileManager::FileNodeId FileManager::next_file_node_id() {
-  FileNodeId res = static_cast<FileNodeId>(file_nodes_.size());
+  auto res = static_cast<FileNodeId>(file_nodes_.size());
   file_nodes_.emplace_back(nullptr);
   return res;
 }
@@ -3379,7 +3380,7 @@ void FileManager::on_start_download(QueryId query_id) {
   file_node->is_download_started_ = true;
 }
 
-void FileManager::on_partial_download(QueryId query_id, const PartialLocalFileLocation &partial_local, int64 ready_size,
+void FileManager::on_partial_download(QueryId query_id, PartialLocalFileLocation partial_local, int64 ready_size,
                                       int64 size) {
   if (is_closed_) {
     return;
@@ -3405,7 +3406,7 @@ void FileManager::on_partial_download(QueryId query_id, const PartialLocalFileLo
       file_node->set_size(size);
     }
   }
-  file_node->set_local_location(LocalFileLocation(partial_local), ready_size, -1, -1 /* TODO */);
+  file_node->set_local_location(LocalFileLocation(std::move(partial_local)), ready_size, -1, -1 /* TODO */);
   try_flush_node(file_node, "on_partial_download");
 }
 
@@ -3431,8 +3432,7 @@ void FileManager::on_hash(QueryId query_id, string hash) {
   file_node->encryption_key_.set_value_hash(secure_storage::ValueHash::create(hash).move_as_ok());
 }
 
-void FileManager::on_partial_upload(QueryId query_id, const PartialRemoteFileLocation &partial_remote,
-                                    int64 ready_size) {
+void FileManager::on_partial_upload(QueryId query_id, PartialRemoteFileLocation partial_remote, int64 ready_size) {
   if (is_closed_) {
     return;
   }
@@ -3451,11 +3451,11 @@ void FileManager::on_partial_upload(QueryId query_id, const PartialRemoteFileLoc
     return;
   }
 
-  file_node->set_partial_remote_location(partial_remote, ready_size);
+  file_node->set_partial_remote_location(std::move(partial_remote), ready_size);
   try_flush_node(file_node, "on_partial_upload");
 }
 
-void FileManager::on_download_ok(QueryId query_id, const FullLocalFileLocation &local, int64 size, bool is_new) {
+void FileManager::on_download_ok(QueryId query_id, FullLocalFileLocation local, int64 size, bool is_new) {
   if (is_closed_) {
     return;
   }
@@ -3465,7 +3465,7 @@ void FileManager::on_download_ok(QueryId query_id, const FullLocalFileLocation &
   std::tie(query, was_active) = finish_query(query_id);
   auto file_id = query.file_id_;
   LOG(INFO) << "ON DOWNLOAD OK of " << (is_new ? "new" : "checked") << " file " << file_id << " of size " << size;
-  auto r_new_file_id = register_local(local, DialogId(), size, false, false, true);
+  auto r_new_file_id = register_local(std::move(local), DialogId(), size, false, false, true);
   Status status = Status::OK();
   if (r_new_file_id.is_error()) {
     status = Status::Error(PSLICE() << "Can't register local file after download: " << r_new_file_id.error().message());
@@ -3484,7 +3484,7 @@ void FileManager::on_download_ok(QueryId query_id, const FullLocalFileLocation &
   }
 }
 
-void FileManager::on_upload_ok(QueryId query_id, FileType file_type, const PartialRemoteFileLocation &partial_remote,
+void FileManager::on_upload_ok(QueryId query_id, FileType file_type, PartialRemoteFileLocation partial_remote,
                                int64 size) {
   if (is_closed_) {
     return;
@@ -3561,19 +3561,18 @@ void FileManager::on_upload_ok(QueryId query_id, FileType file_type, const Parti
   }
 }
 
-void FileManager::on_upload_full_ok(QueryId query_id, const FullRemoteFileLocation &remote) {
+void FileManager::on_upload_full_ok(QueryId query_id, FullRemoteFileLocation remote) {
   if (is_closed_) {
     return;
   }
 
   auto file_id = finish_query(query_id).first.file_id_;
   LOG(INFO) << "ON UPLOAD FULL OK for file " << file_id;
-  auto new_file_id = register_remote(remote, FileLocationSource::FromServer, DialogId(), 0, 0, "");
+  auto new_file_id = register_remote(std::move(remote), FileLocationSource::FromServer, DialogId(), 0, 0, "");
   LOG_STATUS(merge(new_file_id, file_id));
 }
 
-void FileManager::on_partial_generate(QueryId query_id, const PartialLocalFileLocation &partial_local,
-                                      int32 expected_size) {
+void FileManager::on_partial_generate(QueryId query_id, PartialLocalFileLocation partial_local, int32 expected_size) {
   if (is_closed_) {
     return;
   }
@@ -3603,13 +3602,13 @@ void FileManager::on_partial_generate(QueryId query_id, const PartialLocalFileLo
   }
   if (file_node->upload_id_ != 0) {
     send_closure(file_load_manager_, &FileLoadManager::update_local_file_location, file_node->upload_id_,
-                 LocalFileLocation(partial_local));
+                 LocalFileLocation(std::move(partial_local)));
   }
 
   try_flush_node(file_node, "on_partial_generate");
 }
 
-void FileManager::on_generate_ok(QueryId query_id, const FullLocalFileLocation &local) {
+void FileManager::on_generate_ok(QueryId query_id, FullLocalFileLocation local) {
   if (is_closed_) {
     return;
   }
@@ -3653,7 +3652,7 @@ void FileManager::on_generate_ok(QueryId query_id, const FullLocalFileLocation &
   if (was_active) {
     if (old_upload_id != 0 && old_upload_id == file_node->upload_id_) {
       send_closure(file_load_manager_, &FileLoadManager::update_local_file_location, file_node->upload_id_,
-                   LocalFileLocation(local));
+                   LocalFileLocation(std::move(local)));
     }
   }
 }

td/telegram/files/FileManager.h

@@ -88,7 +88,7 @@ class FileNode {
                           int64 ready_prefix_size);
   void set_new_remote_location(NewRemoteFileLocation remote);
   void delete_partial_remote_location();
-  void set_partial_remote_location(const PartialRemoteFileLocation &remote, int64 ready_size);
+  void set_partial_remote_location(PartialRemoteFileLocation remote, int64 ready_size);
 
   bool delete_file_reference(Slice file_reference);
   void set_generate_location(unique_ptr<FullGenerateFileLocation> &&generate);
@@ -98,7 +98,7 @@ class FileNode {
   void set_url(string url);
   void set_owner_dialog_id(DialogId owner_id);
   void set_encryption_key(FileEncryptionKey key);
-  void set_upload_pause(FileId file_id);
+  void set_upload_pause(FileId upload_pause);
 
   void set_download_priority(int8 priority);
   void set_upload_priority(int8 priority);
@@ -419,7 +419,7 @@ class FileManager final : public FileLoadManager::Callback {
   Result<FileId> register_local(FullLocalFileLocation location, DialogId owner_dialog_id, int64 size,
                                 bool get_by_hash = false, bool force = false,
                                 bool skip_file_size_checks = false) TD_WARN_UNUSED_RESULT;
-  FileId register_remote(const FullRemoteFileLocation &location, FileLocationSource file_location_source,
+  FileId register_remote(FullRemoteFileLocation location, FileLocationSource file_location_source,
                          DialogId owner_dialog_id, int64 size, int64 expected_size,
                          string remote_name) TD_WARN_UNUSED_RESULT;
   Result<FileId> register_generate(FileType file_type, FileLocationSource file_location_source, string original_path,
@@ -448,7 +448,7 @@ class FileManager final : public FileLoadManager::Callback {
                      int32 new_priority, uint64 upload_order, bool force = false, bool prefer_small = false);
   void cancel_upload(FileId file_id);
   bool delete_partial_remote_location(FileId file_id);
-  void delete_file_reference(FileId file_id, std::string file_reference);
+  void delete_file_reference(FileId file_id, Slice file_reference);
   void get_content(FileId file_id, Promise<BufferSlice> promise);
 
   Result<string> get_suggested_file_name(FileId file_id, const string &directory);
@@ -468,7 +468,7 @@ class FileManager final : public FileLoadManager::Callback {
   td_api::object_ptr<td_api::file> get_file_object(FileId file_id, bool with_main_file_id = true);
   vector<int32> get_file_ids_object(const vector<FileId> &file_ids, bool with_main_file_id = true);
 
-  Result<FileId> get_input_thumbnail_file_id(const tl_object_ptr<td_api::InputFile> &thumb_input_file,
+  Result<FileId> get_input_thumbnail_file_id(const tl_object_ptr<td_api::InputFile> &thumbnail_input_file,
                                              DialogId owner_dialog_id, bool is_encrypted) TD_WARN_UNUSED_RESULT;
   Result<FileId> get_input_file_id(FileType type, const tl_object_ptr<td_api::InputFile> &file,
                                    DialogId owner_dialog_id, bool allow_zero, bool is_encrypted,
@@ -599,7 +599,7 @@ class FileManager final : public FileLoadManager::Callback {
   FileId register_pmc_file_data(FileData &&data);
 
   Status check_local_location(FileNodePtr node);
-  bool try_fix_partial_local_location(FileNodePtr node);
+  static bool try_fix_partial_local_location(FileNodePtr node);
   Status check_local_location(FullLocalFileLocation &location, int64 &size, bool skip_file_size_checks);
   void try_flush_node_full(FileNodePtr node, bool new_remote, bool new_local, bool new_generate, FileDbId other_pmc_id);
   void try_flush_node(FileNodePtr node, const char *source);
@@ -614,7 +614,7 @@ class FileManager final : public FileLoadManager::Callback {
   Result<FileId> from_persistent_id_v3(Slice binary, FileType file_type);
   Result<FileId> from_persistent_id_v23(Slice binary, FileType file_type, int32 version);
 
-  string fix_file_extension(Slice file_name, Slice file_type, Slice file_extension);
+  static string fix_file_extension(Slice file_name, Slice file_type, Slice file_extension);
   string get_file_name(FileType file_type, Slice path);
 
   ConstFileNodePtr get_file_node(FileId file_id) const {
@@ -638,20 +638,19 @@ class FileManager final : public FileLoadManager::Callback {
   void run_generate(FileNodePtr node);
 
   void on_start_download(QueryId query_id) final;
-  void on_partial_download(QueryId query_id, const PartialLocalFileLocation &partial_local, int64 ready_size,
+  void on_partial_download(QueryId query_id, PartialLocalFileLocation partial_local, int64 ready_size,
                            int64 size) final;
   void on_hash(QueryId query_id, string hash) final;
-  void on_partial_upload(QueryId query_id, const PartialRemoteFileLocation &partial_remote, int64 ready_size) final;
-  void on_download_ok(QueryId query_id, const FullLocalFileLocation &local, int64 size, bool is_new) final;
-  void on_upload_ok(QueryId query_id, FileType file_type, const PartialRemoteFileLocation &partial_remote,
-                    int64 size) final;
-  void on_upload_full_ok(QueryId query_id, const FullRemoteFileLocation &remote) final;
+  void on_partial_upload(QueryId query_id, PartialRemoteFileLocation partial_remote, int64 ready_size) final;
+  void on_download_ok(QueryId query_id, FullLocalFileLocation local, int64 size, bool is_new) final;
+  void on_upload_ok(QueryId query_id, FileType file_type, PartialRemoteFileLocation partial_remote, int64 size) final;
+  void on_upload_full_ok(QueryId query_id, FullRemoteFileLocation remote) final;
   void on_error(QueryId query_id, Status status) final;
 
   void on_error_impl(FileNodePtr node, Query::Type type, bool was_active, Status status);
 
-  void on_partial_generate(QueryId, const PartialLocalFileLocation &partial_local, int32 expected_size);
-  void on_generate_ok(QueryId, const FullLocalFileLocation &local);
+  void on_partial_generate(QueryId, PartialLocalFileLocation partial_local, int32 expected_size);
+  void on_generate_ok(QueryId, FullLocalFileLocation local);
 
   std::pair<Query, bool> finish_query(QueryId query_id);
 

td/telegram/files/FileStats.cpp

@@ -137,7 +137,7 @@ td_api::object_ptr<td_api::storageStatisticsByChat> FileStats::get_storage_stati
   auto stats = make_tl_object<td_api::storageStatisticsByChat>(dialog_id.get(), 0, 0, Auto());
   FileStats::StatByType aggregated_stats;
   for (int32 i = 0; i < MAX_FILE_TYPE; i++) {
-    size_t file_type = narrow_cast<size_t>(get_main_file_type(static_cast<FileType>(i)));
+    auto file_type = narrow_cast<size_t>(get_main_file_type(static_cast<FileType>(i)));
     aggregated_stats[file_type].size += stat_by_type_[i].size;
     aggregated_stats[file_type].cnt += stat_by_type_[i].cnt;
   }
@@ -150,7 +150,7 @@ td_api::object_ptr<td_api::storageStatisticsByChat> FileStats::get_storage_stati
       continue;
     }
 
-    FileType file_type = static_cast<FileType>(i);
+    auto file_type = static_cast<FileType>(i);
     stats->size_ += size;
     stats->count_ += cnt;
     stats->by_file_type_.push_back(

td/telegram/files/FileUploader.h

@@ -24,8 +24,8 @@ class FileUploader final : public FileLoader {
   class Callback : public FileLoader::Callback {
    public:
     virtual void on_hash(string hash) = 0;
-    virtual void on_partial_upload(const PartialRemoteFileLocation &partial_remote, int64 ready_size) = 0;
-    virtual void on_ok(FileType file_type, const PartialRemoteFileLocation &partial_remote, int64 size) = 0;
+    virtual void on_partial_upload(PartialRemoteFileLocation partial_remote, int64 ready_size) = 0;
+    virtual void on_ok(FileType file_type, PartialRemoteFileLocation partial_remote, int64 size) = 0;
     virtual void on_error(Status status) = 0;
   };
 

td/telegram/files/PartsManager.cpp

@@ -537,8 +537,8 @@ int64 PartsManager::get_unchecked_ready_prefix_size() {
 }
 
 Part PartsManager::get_part(int id) const {
-  int64 offset = narrow_cast<int64>(part_size_) * id;
-  int64 size = narrow_cast<int64>(part_size_);
+  auto size = narrow_cast<int64>(part_size_);
+  auto offset = size * id;
   auto total_size = unknown_size_flag_ ? max_size_ : get_size();
   if (total_size < offset) {
     size = 0;

td/telegram/files/PartsManager.h

@@ -93,8 +93,9 @@ class PartsManager {
                            const std::vector<int> &ready_parts) TD_WARN_UNUSED_RESULT;
   Status init_no_size(size_t part_size, const std::vector<int> &ready_parts) TD_WARN_UNUSED_RESULT;
 
+  static Part get_empty_part();
+
   Part get_part(int id) const;
-  Part get_empty_part();
   void on_part_start(int32 id);
   void update_first_empty_part();
   void update_first_not_ready_part();

td/telegram/misc.cpp

@@ -74,7 +74,7 @@ bool clean_input_string(string &str) {
   size_t str_size = str.size();
   size_t new_size = 0;
   for (size_t pos = 0; pos < str_size; pos++) {
-    unsigned char c = static_cast<unsigned char>(str[pos]);
+    auto c = static_cast<unsigned char>(str[pos]);
     switch (c) {
       // remove control characters
       case 0:
@@ -118,7 +118,7 @@ bool clean_input_string(string &str) {
       default:
         // remove \xe2\x80[\xa8-\xae]
         if (c == 0xe2 && pos + 2 < str_size) {
-          unsigned char next = static_cast<unsigned char>(str[pos + 1]);
+          auto next = static_cast<unsigned char>(str[pos + 1]);
           if (next == 0x80) {
             next = static_cast<unsigned char>(str[pos + 2]);
             if (0xa8 <= next && next <= 0xae) {
@@ -129,7 +129,7 @@ bool clean_input_string(string &str) {
         }
         // remove vertical lines \xcc[\xb3\xbf\x8a]
         if (c == 0xcc && pos + 1 < str_size) {
-          unsigned char next = static_cast<unsigned char>(str[pos + 1]);
+          auto next = static_cast<unsigned char>(str[pos + 1]);
           if (next == 0xb3 || next == 0xbf || next == 0x8a) {
             pos++;
             break;

td/telegram/net/ConnectionCreator.cpp

@@ -672,7 +672,7 @@ Result<mtproto::TransportType> ConnectionCreator::get_transport_type(const Proxy
   if (G()->is_test_dc()) {
     int_dc_id += 10000;
   }
-  int16 raw_dc_id = narrow_cast<int16>(info.option->is_media_only() ? -int_dc_id : int_dc_id);
+  auto raw_dc_id = narrow_cast<int16>(info.option->is_media_only() ? -int_dc_id : int_dc_id);
 
   if (proxy.use_mtproto_proxy()) {
     return mtproto::TransportType{mtproto::TransportType::ObfuscatedTcp, raw_dc_id, proxy.secret()};
@@ -736,7 +736,7 @@ Result<SocketFd> ConnectionCreator::find_connection(const Proxy &proxy, const IP
 
 ActorOwn<> ConnectionCreator::prepare_connection(IPAddress ip_address, SocketFd socket_fd, const Proxy &proxy,
                                                  const IPAddress &mtproto_ip_address,
-                                                 mtproto::TransportType transport_type, Slice actor_name_prefix,
+                                                 const mtproto::TransportType &transport_type, Slice actor_name_prefix,
                                                  Slice debug_str,
                                                  unique_ptr<mtproto::RawConnection::StatsCallback> stats_callback,
                                                  ActorShared<> parent, bool use_connection_token,
@@ -934,13 +934,13 @@ void ConnectionCreator::client_loop(ClientInfo &client) {
       client.checking_connections++;
     }
 
-    auto promise = PromiseCreator::lambda(
-        [actor_id = actor_id(this), check_mode, transport_type = extra.transport_type, hash = client.hash,
-         debug_str = extra.debug_str,
-         network_generation = network_generation_](Result<ConnectionData> r_connection_data) mutable {
-          send_closure(std::move(actor_id), &ConnectionCreator::client_create_raw_connection,
-                       std::move(r_connection_data), check_mode, transport_type, hash, debug_str, network_generation);
-        });
+    auto promise = PromiseCreator::lambda([actor_id = actor_id(this), check_mode, transport_type = extra.transport_type,
+                                           hash = client.hash, debug_str = extra.debug_str,
+                                           network_generation =
+                                               network_generation_](Result<ConnectionData> r_connection_data) mutable {
+      send_closure(std::move(actor_id), &ConnectionCreator::client_create_raw_connection, std::move(r_connection_data),
+                   check_mode, std::move(transport_type), hash, std::move(debug_str), network_generation);
+    });
 
     auto stats_callback =
         td::make_unique<detail::StatsCallback>(client.is_media ? media_net_stats_callback_ : common_net_stats_callback_,
@@ -1060,17 +1060,16 @@ void ConnectionCreator::on_dc_options(DcOptions new_dc_options) {
 }
 
 void ConnectionCreator::on_dc_update(DcId dc_id, string ip_port, Promise<> promise) {
-  promise.set_result([&]() -> Result<> {
-    if (!dc_id.is_exact()) {
-      return Status::Error("Invalid dc_id");
-    }
-    IPAddress ip_address;
-    TRY_STATUS(ip_address.init_host_port(ip_port));
-    DcOptions options;
-    options.dc_options.emplace_back(dc_id, ip_address);
-    send_closure(G()->config_manager(), &ConfigManager::on_dc_options_update, std::move(options));
-    return Unit();
-  }());
+  if (!dc_id.is_exact()) {
+    return promise.set_error(Status::Error("Invalid dc_id"));
+  }
+
+  IPAddress ip_address;
+  TRY_STATUS_PROMISE(promise, ip_address.init_host_port(ip_port));
+  DcOptions options;
+  options.dc_options.emplace_back(dc_id, ip_address);
+  send_closure(G()->config_manager(), &ConfigManager::on_dc_options_update, std::move(options));
+  promise.set_value(Unit());
 }
 
 void ConnectionCreator::update_mtproto_header(const Proxy &proxy) {
@@ -1129,13 +1128,13 @@ void ConnectionCreator::start_up() {
 
   for (auto &info : proxy_info) {
     if (begins_with(info.first, "_used")) {
-      int32 proxy_id = to_integer_safe<int32>(Slice(info.first).substr(5)).move_as_ok();
-      int32 last_used = to_integer_safe<int32>(info.second).move_as_ok();
+      auto proxy_id = to_integer_safe<int32>(Slice(info.first).substr(5)).move_as_ok();
+      auto last_used = to_integer_safe<int32>(info.second).move_as_ok();
       proxy_last_used_date_[proxy_id] = last_used;
       proxy_last_used_saved_date_[proxy_id] = last_used;
     } else {
       LOG_CHECK(!ends_with(info.first, "_max_id")) << info.first;
-      int32 proxy_id = info.first == "" ? 1 : to_integer_safe<int32>(info.first).move_as_ok();
+      auto proxy_id = info.first.empty() ? static_cast<int32>(1) : to_integer_safe<int32>(info.first).move_as_ok();
       CHECK(proxies_.count(proxy_id) == 0);
       log_event_parse(proxies_[proxy_id], info.second).ensure();
       if (proxies_[proxy_id].type() == Proxy::Type::None) {

td/telegram/net/ConnectionCreator.h

@@ -89,8 +89,9 @@ class ConnectionCreator final : public NetQueryCallback {
   static DcOptions get_default_dc_options(bool is_test);
 
   static ActorOwn<> prepare_connection(IPAddress ip_address, SocketFd socket_fd, const Proxy &proxy,
-                                       const IPAddress &mtproto_ip_address, mtproto::TransportType transport_type,
-                                       Slice actor_name_prefix, Slice debug_str,
+                                       const IPAddress &mtproto_ip_address,
+                                       const mtproto::TransportType &transport_type, Slice actor_name_prefix,
+                                       Slice debug_str,
                                        unique_ptr<mtproto::RawConnection::StatsCallback> stats_callback,
                                        ActorShared<> parent, bool use_connection_token,
                                        Promise<ConnectionData> promise);

td/telegram/net/DcAuthManager.cpp

@@ -93,7 +93,7 @@ DcAuthManager::DcInfo *DcAuthManager::find_dc(int32 dc_id) {
 }
 
 void DcAuthManager::update_auth_key_state() {
-  int32 dc_id = narrow_cast<int32>(get_link_token());
+  auto dc_id = narrow_cast<int32>(get_link_token());
   auto &dc = get_dc(dc_id);
   dc.auth_key_state = dc.shared_auth_data->get_auth_key_state();
   VLOG(dc) << "Update " << dc_id << " auth key state from " << dc.auth_key_state << " to " << dc.auth_key_state;
@@ -102,7 +102,7 @@ void DcAuthManager::update_auth_key_state() {
 }
 
 void DcAuthManager::on_result(NetQueryPtr result) {
-  int32 dc_id = narrow_cast<int32>(get_link_token());
+  auto dc_id = narrow_cast<int32>(get_link_token());
   auto &dc = get_dc(dc_id);
   CHECK(dc.wait_id == result->id());
   dc.wait_id = std::numeric_limits<decltype(dc.wait_id)>::max();

td/telegram/net/MtprotoHeader.h

@@ -33,7 +33,7 @@ class MtprotoHeader {
   }
 
   void set_proxy(Proxy proxy) {
-    options_.proxy = proxy;
+    options_.proxy = std::move(proxy);
     default_header_ = gen_header(options_, false);
   }
 
@@ -42,7 +42,7 @@ class MtprotoHeader {
       return false;
     }
 
-    options_.parameters = parameters;
+    options_.parameters = std::move(parameters);
     default_header_ = gen_header(options_, false);
     return true;
   }