tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add experiment_old_postponed_pts_updates_behavior option

Browse Source
This commit is contained in:
Andrea Cavalli 2021-01-07 13:08:07 +01:00
parent 2f28ed3bba
commit e0bcdab68f
4 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
td/telegram/Logging.cpp
View File

@ -56,7 +56,7 @@ static const std::map<Slice, int *> log_tags{
ADD_TAG(file_loader), ADD_TAG(mtproto), ADD_TAG(raw_mtproto), ADD_TAG(fd),
ADD_TAG(actor), ADD_TAG(sqlite), ADD_TAG(notifications), ADD_TAG(get_difference),
ADD_TAG(file_gc), ADD_TAG(config_recoverer), ADD_TAG(dns_resolver), ADD_TAG(file_references),
ADD_TAG(messages), ADD_TAG(postponed_pts_update)};
ADD_TAG(messages), ADD_TAG(postponed_pts_update), ADD_TAG(add_pending_update)};
#undef ADD_TAG
Status Logging::set_current_stream(td_api::object_ptr<td_api::LogStream> stream) {

16
td/telegram/MessagesManager.cpp
View File

@ -52,7 +52,7 @@
#include "td/telegram/UpdatesManager.h"
#include "td/telegram/Version.h"
#include "td/telegram/WebPageId.h"
#include "td/telegram/Td.h" // for VERBOSITY_NAME(messages) and VERBOSITY_NAME(postponed_pts_update)
#include "td/telegram/Td.h" // for VERBOSITY_NAME(messages, postponed_pts_update and add_pending_update)
#include "td/actor/PromiseFuture.h"
#include "td/actor/SleepActor.h"
@ -666,6 +666,7 @@ class UnpinAllMessagesQuery : public Td::ResultHandler {
affected_history->pts_, affected_history->pts_count_,
std::move(promise), "unpin all messages");
} else {
VLOG(add_pending_update) << "Calling add_pending_update (1)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_history->pts_,
affected_history->pts_count_, false, std::move(promise),
"unpin all messages");
@ -1571,6 +1572,7 @@ class ReadMessagesContentsQuery : public Td::ResultHandler {
CHECK(affected_messages->get_id() == telegram_api::messages_affectedMessages::ID);
if (affected_messages->pts_count_ > 0) {
VLOG(add_pending_update) << "Calling add_pending_update (2)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_messages->pts_,
affected_messages->pts_count_, false, Promise<Unit>(),
"read messages content query");
@ -1789,6 +1791,7 @@ class ReadHistoryQuery : public Td::ResultHandler {
LOG(INFO) << "Receive result for ReadHistoryQuery: " << to_string(affected_messages);
if (affected_messages->pts_count_ > 0) {
VLOG(add_pending_update) << "Calling add_pending_update (3)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_messages->pts_,
affected_messages->pts_count_, false, Promise<Unit>(),
"read history query");
@ -2259,6 +2262,7 @@ class DeleteHistoryQuery : public Td::ResultHandler {
CHECK(affected_history->get_id() == telegram_api::messages_affectedHistory::ID);
if (affected_history->pts_count_ > 0) {
VLOG(add_pending_update) << "Calling add_pending_update (4)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_history->pts_,
affected_history->pts_count_, false, Promise<Unit>(),
"delete history query");
@ -2459,6 +2463,7 @@ class ReadAllMentionsQuery : public Td::ResultHandler {
<< dialog_id_;
td->updates_manager_->get_difference("Wrong messages_readMentions result");
} else {
VLOG(add_pending_update) << "Calling add_pending_update (5)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_history->pts_,
affected_history->pts_count_, false, Promise<Unit>(),
"read all mentions query");
@ -2595,6 +2600,7 @@ class SendMessageActor : public NetActorOnce {
return;
}
VLOG(add_pending_update) << "Calling add_pending_update (6)";
td->messages_manager_->add_pending_update(
make_tl_object<updateSentMessage>(random_id_, message_id, sent_message->date_), sent_message->pts_,
sent_message->pts_count_, false, Promise<Unit>(), "send message actor");
@ -3617,6 +3623,7 @@ class DeleteMessagesQuery : public Td::ResultHandler {
CHECK(affected_messages->get_id() == telegram_api::messages_affectedMessages::ID);
if (affected_messages->pts_count_ > 0) {
VLOG(add_pending_update) << "Calling add_pending_update (7)";
td->messages_manager_->add_pending_update(make_tl_object<dummyUpdate>(), affected_messages->pts_,
affected_messages->pts_count_, false, Promise<Unit>(),
"delete messages query");
@ -6378,7 +6385,9 @@ void MessagesManager::add_pending_update(tl_object_ptr<telegram_api::Update> &&u
return promise.set_value(Unit());
}
if (td_->updates_manager_->running_get_difference() || !postponed_pts_updates_.empty()) {
auto old_postponed_pts_updates_behavior
= G()->shared_config().get_option_boolean("experiment_old_postponed_pts_updates_behavior", false);
if (td_->updates_manager_->running_get_difference() || (!old_postponed_pts_updates_behavior && !postponed_pts_updates_.empty())) {
VLOG(messages) << "Save pending update got while running getDifference from " << source;
if (td_->updates_manager_->running_get_difference()) {
CHECK(update->get_id() == dummyUpdate::ID || update->get_id() == updateSentMessage::ID);
@ -8895,7 +8904,7 @@ void MessagesManager::before_get_difference() {
void MessagesManager::after_get_difference() {
CHECK(!td_->updates_manager_->running_get_difference());
if (postponed_pts_updates_.size()) {
if (!postponed_pts_updates_.empty()) {
LOG(INFO) << "Begin to apply postponed pts updates";
auto old_pts = td_->updates_manager_->get_pts();
for (auto &update : postponed_pts_updates_) {
@ -8905,6 +8914,7 @@ void MessagesManager::after_get_difference() {
"after get difference");
update.second.promise.set_value(Unit());
} else {
VLOG(add_pending_update) << "Calling add_pending_update (8)";
add_pending_update(std::move(update.second.update), update.second.pts, update.second.pts_count, false,
std::move(update.second.promise), "after get difference");
}

4
td/telegram/Td.cpp
View File

@ -146,6 +146,7 @@ int VERBOSITY_NAME(td_init) = VERBOSITY_NAME(DEBUG) + 3;
int VERBOSITY_NAME(td_requests) = VERBOSITY_NAME(INFO);
int VERBOSITY_NAME(messages) = VERBOSITY_NAME(INFO);
int VERBOSITY_NAME(postponed_pts_update) = VERBOSITY_NAME(DEBUG);
int VERBOSITY_NAME(add_pending_update) = VERBOSITY_NAME(DEBUG);
void Td::ResultHandler::set_td(Td *new_td) {
CHECK(td == nullptr);
@ -7348,6 +7349,9 @@ void Td::on_request(uint64 id, td_api::setOption &request) {
if (set_boolean_option("experiment_enable_chat_access_hash_cleanup")) {
return;
}
if (set_boolean_option("experiment_old_postponed_pts_updates_behavior")) {
return;
}
break;
case 'i':
if (set_boolean_option("ignore_background_updates")) {

1
td/telegram/Td.h
View File

@ -88,6 +88,7 @@ extern int VERBOSITY_NAME(td_init);
extern int VERBOSITY_NAME(td_requests);
extern int VERBOSITY_NAME(messages);
extern int VERBOSITY_NAME(postponed_pts_update);
extern int VERBOSITY_NAME(add_pending_update);
// Td may start closing after explicit "close" or "destroy" query.
// Or it may start closing by itself, because authorization is lost.