tdlight-team/tdlight
tdlight-team/tdlight
1
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Store unique_ptr instead of a big class in a FlatHashMap.

Browse Source
This commit is contained in:
levlam 2022-02-11 18:26:43 +03:00
parent fc73b94a59
commit e64811ba31
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
td/telegram/GroupCallManager.cpp
View File

@ -883,7 +883,7 @@ struct GroupCallManager::GroupCallParticipants {
vector<DialogId> administrator_dialog_ids; vector<DialogId> administrator_dialog_ids;
struct PendingUpdates { struct PendingUpdates {
FlatHashMap<DialogId, GroupCallParticipant, DialogIdHash> updates; FlatHashMap<DialogId, unique_ptr<GroupCallParticipant>, DialogIdHash> updates;
}; };
std::map<int32, PendingUpdates> pending_version_updates_; std::map<int32, PendingUpdates> pending_version_updates_;
std::map<int32, PendingUpdates> pending_mute_updates_; std::map<int32, PendingUpdates> pending_mute_updates_;
@ -1744,9 +1744,9 @@ void GroupCallManager::on_update_group_call_participants(
} }
if (GroupCallParticipant::is_versioned_update(group_call_participant)) { if (GroupCallParticipant::is_versioned_update(group_call_participant)) {
pending_version_updates[dialog_id] = std::move(participant); pending_version_updates[dialog_id] = td::make_unique<GroupCallParticipant>(std::move(participant));
} else { } else {
pending_mute_updates[dialog_id] = std::move(participant); pending_mute_updates[dialog_id] = td::make_unique<GroupCallParticipant>(std::move(participant));
} }
} }
@ -1783,7 +1783,7 @@ bool GroupCallManager::process_pending_group_call_participant_updates(InputGroup
} }
auto &participants = it->second.updates; auto &participants = it->second.updates;
for (auto &participant_it : participants) { for (auto &participant_it : participants) {
auto &participant = participant_it.second; auto &participant = *participant_it.second;
on_participant_speaking_in_group_call(input_group_call_id, participant); on_participant_speaking_in_group_call(input_group_call_id, participant);
auto mute_diff = process_group_call_participant(input_group_call_id, std::move(participant)); auto mute_diff = process_group_call_participant(input_group_call_id, std::move(participant));
CHECK(mute_diff.first == 0); CHECK(mute_diff.first == 0);
@ -1802,7 +1802,7 @@ bool GroupCallManager::process_pending_group_call_participant_updates(InputGroup
auto &participants = it->second.updates; auto &participants = it->second.updates;
if (version <= group_call->version) { if (version <= group_call->version) {
for (auto &participant_it : participants) { for (auto &participant_it : participants) {
auto &participant = participant_it.second; auto &participant = *participant_it.second;
on_participant_speaking_in_group_call(input_group_call_id, participant); on_participant_speaking_in_group_call(input_group_call_id, participant);
if (participant.is_self || participant.joined_date != 0) { if (participant.is_self || participant.joined_date != 0) {
auto new_diff = process_group_call_participant(input_group_call_id, std::move(participant)); auto new_diff = process_group_call_participant(input_group_call_id, std::move(participant));
@ -1819,7 +1819,7 @@ bool GroupCallManager::process_pending_group_call_participant_updates(InputGroup
if (version == group_call->version + 1) { if (version == group_call->version + 1) {
group_call->version = version; group_call->version = version;
for (auto &participant_it : participants) { for (auto &participant_it : participants) {
auto &participant = participant_it.second; auto &participant = *participant_it.second;
if (participant.is_self && group_call->is_joined && if (participant.is_self && group_call->is_joined &&
(participant.joined_date == 0) == (participant.audio_source == group_call->audio_source)) { (participant.joined_date == 0) == (participant.audio_source == group_call->audio_source)) {
is_left = true; is_left = true;

2
td/telegram/GroupCallParticipant.h
View File

@ -26,10 +26,10 @@ struct GroupCallParticipant {
GroupCallVideoPayload presentation_payload; GroupCallVideoPayload presentation_payload;
int32 audio_source = 0; int32 audio_source = 0;
int32 presentation_audio_source = 0; int32 presentation_audio_source = 0;
int64 raise_hand_rating = 0;
int32 joined_date = 0; int32 joined_date = 0;
int32 active_date = 0; int32 active_date = 0;
int32 volume_level = 10000; int32 volume_level = 10000;
int64 raise_hand_rating = 0;
bool is_volume_level_local = false; bool is_volume_level_local = false;
bool server_is_muted_by_themselves = false; bool server_is_muted_by_themselves = false;
bool server_is_muted_by_admin = false; bool server_is_muted_by_admin = false;