Compare commits

...

2 Commits

Author SHA1 Message Date
Andrea Cavalli 37890ee3cb Always use direct-io for flush and compaction 2023-11-24 01:54:23 +01:00
Andrea Cavalli fe0256dbf9 Update rocksdb, more verbose logs 2023-11-24 01:54:17 +01:00
2 changed files with 3 additions and 5 deletions

View File

@ -14,7 +14,7 @@
<dbengine.ci>false</dbengine.ci> <dbengine.ci>false</dbengine.ci>
<micrometer.version>1.10.4</micrometer.version> <micrometer.version>1.10.4</micrometer.version>
<lucene.version>9.8.0</lucene.version> <lucene.version>9.8.0</lucene.version>
<rocksdb.version>8.6.7</rocksdb.version> <rocksdb.version>8.8.1</rocksdb.version>
<junit.jupiter.version>5.9.0</junit.jupiter.version> <junit.jupiter.version>5.9.0</junit.jupiter.version>
<data.generator.version>1.0.21</data.generator.version> <data.generator.version>1.0.21</data.generator.version>
</properties> </properties>

View File

@ -477,7 +477,7 @@ public class LLLocalKeyValueDatabase extends Backuppable implements LLKeyValueDa
} catch (RocksDBException ex) { } catch (RocksDBException ex) {
switch (ex.getMessage()) { switch (ex.getMessage()) {
case "Direct I/O is not supported by the specified DB." -> { case "Direct I/O is not supported by the specified DB." -> {
logger.warn(ex.getLocalizedMessage()); logger.warn("RocksDB options failed: {}", ex.getLocalizedMessage());
rocksdbOptions rocksdbOptions
.setUseDirectReads(false) .setUseDirectReads(false)
.setUseDirectIoForFlushAndCompaction(false) .setUseDirectIoForFlushAndCompaction(false)
@ -1091,9 +1091,7 @@ public class LLLocalKeyValueDatabase extends Backuppable implements LLKeyValueDa
.setAllowMmapWrites(allowMmapWrites); .setAllowMmapWrites(allowMmapWrites);
} }
if (useDirectIO || !allowMmapWrites) { options.setUseDirectIoForFlushAndCompaction(true);
options.setUseDirectIoForFlushAndCompaction(true);
}
return new OptionsWithCache(options, blockCache); return new OptionsWithCache(options, blockCache);
} catch (IOException e) { } catch (IOException e) {