MarcoBuster/Gadgetbridge
1
0
Fork 0
mirror of https://codeberg.org/Freeyourgadget/Gadgetbridge synced 2024-11-10 20:19:32 +01:00
Code Releases Wiki Activity

notif: sanitize strings set by external apps

Browse Source 
It seems some apps like Telegram add a lot of Unicode Control sequences
for unknown reasons. Because these strings are set by external apps, it
is safer to sanitize them. For the moment, only Unicode control
sequences are stripped.

Fixes: #1344
This commit is contained in:
Matthieu Baerts 2018-11-25 23:13:13 +01:00 committed by Andreas Shimokawa
parent 632f6d86a3
commit d60d10ddb1
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/nodomain/freeyourgadget/gadgetbridge/externalevents/NotificationListener.java
View File

@ -351,6 +351,11 @@ public class NotificationListener extends NotificationListenerService {
GBApplication.deviceService().onNotification(notificationSpec); GBApplication.deviceService().onNotification(notificationSpec);
} }
// Strip Unicode control sequences: some apps like Telegram add a lot of them for unknown reasons
private String sanitizeUnicode(String orig) {
return orig.replaceAll("\\p{C}", "");
}
private void dissectNotificationTo(Notification notification, NotificationSpec notificationSpec, boolean preferBigText) { private void dissectNotificationTo(Notification notification, NotificationSpec notificationSpec, boolean preferBigText) {
Bundle extras = NotificationCompat.getExtras(notification); Bundle extras = NotificationCompat.getExtras(notification);
@ -359,7 +364,7 @@ public class NotificationListener extends NotificationListenerService {
CharSequence title = extras.getCharSequence(Notification.EXTRA_TITLE); CharSequence title = extras.getCharSequence(Notification.EXTRA_TITLE);
if (title != null) { if (title != null) {
notificationSpec.title = title.toString(); notificationSpec.title = sanitizeUnicode(title.toString());
} }
CharSequence contentCS = null; CharSequence contentCS = null;
@ -369,7 +374,7 @@ public class NotificationListener extends NotificationListenerService {
contentCS = extras.getCharSequence(NotificationCompat.EXTRA_TEXT); contentCS = extras.getCharSequence(NotificationCompat.EXTRA_TEXT);
} }
if (contentCS != null) { if (contentCS != null) {
notificationSpec.body = contentCS.toString(); notificationSpec.body = sanitizeUnicode(contentCS.toString());
} }
} }