mirror of
https://github.com/revanced/jadb.git
synced 2025-02-11 01:26:47 +01:00
#84 PackageManager problems: Fixes issue 1 & 2 - after review
This commit is contained in:
parent
b0fbb4b75f
commit
93c9506708
@ -94,10 +94,10 @@ public class PackageManager {
|
||||
private final StringBuilder stringBuilder = new StringBuilder();
|
||||
|
||||
InstallOption(String ... varargs) {
|
||||
String space = "";
|
||||
String suffix = "";
|
||||
for(String str: varargs) {
|
||||
stringBuilder.append(space).append(str);
|
||||
space = " ";
|
||||
stringBuilder.append(suffix).append(str);
|
||||
suffix = " ";
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -9,7 +9,6 @@ import se.vidstige.jadb.managers.Package;
|
||||
import se.vidstige.jadb.managers.PackageManager;
|
||||
import se.vidstige.jadb.test.fakes.FakeAdbServer;
|
||||
|
||||
import java.lang.reflect.Method;
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
@ -91,27 +90,4 @@ public class PackageManagerTest {
|
||||
//Assert
|
||||
assertEquals(expected, actual);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testWithForwardLock() throws Exception {
|
||||
PackageManager.InstallOption withForwardLock = PackageManager.WITH_FORWARD_LOCK;
|
||||
// Letter L not number 1
|
||||
String expected = "-l";
|
||||
Method privateMethod = withForwardLock.getClass().getDeclaredMethod("getStringRepresentation");
|
||||
privateMethod.setAccessible(true);
|
||||
String actual = (String) privateMethod.invoke(withForwardLock);
|
||||
|
||||
assertEquals(expected, actual);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testWithInstallerPackageName() throws Exception {
|
||||
PackageManager.InstallOption withInstallerPackageName = PackageManager.WITH_INSTALLER_PACKAGE_NAME("aaa bbb");
|
||||
String expected = "-t aaa bbb";
|
||||
Method privateMethod = withInstallerPackageName.getClass().getDeclaredMethod("getStringRepresentation");
|
||||
privateMethod.setAccessible(true);
|
||||
String actual = (String) privateMethod.invoke(withInstallerPackageName);
|
||||
|
||||
assertEquals(expected, actual);
|
||||
}
|
||||
}
|
Loading…
x
Reference in New Issue
Block a user