ReVanced-Mirror/jadb
1
0
Fork 0
mirror of https://github.com/revanced/jadb.git synced 2025-02-11 09:36:48 +01:00
Code Issues Projects Releases Wiki Activity

#84 PackageManager problems: Fixes issue 1 & 2 - after review

Browse Source
This commit is contained in:
Mieras Made 2018-09-09 20:22:39 +02:00
parent b0fbb4b75f
commit 93c9506708
2 changed files with 3 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/se/vidstige/jadb/managers/PackageManager.java
View File

@ -94,10 +94,10 @@ public class PackageManager {
private final StringBuilder stringBuilder = new StringBuilder(); private final StringBuilder stringBuilder = new StringBuilder();
InstallOption(String ... varargs) { InstallOption(String ... varargs) {
String space = ""; String suffix = "";
for(String str: varargs) { for(String str: varargs) {
stringBuilder.append(space).append(str); stringBuilder.append(suffix).append(str);
space = " "; suffix = " ";
} }
} }

24
test/se/vidstige/jadb/test/unit/PackageManagerTest.java
View File

@ -9,7 +9,6 @@ import se.vidstige.jadb.managers.Package;
import se.vidstige.jadb.managers.PackageManager; import se.vidstige.jadb.managers.PackageManager;
import se.vidstige.jadb.test.fakes.FakeAdbServer; import se.vidstige.jadb.test.fakes.FakeAdbServer;
import java.lang.reflect.Method;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -91,27 +90,4 @@ public class PackageManagerTest {
//Assert //Assert
assertEquals(expected, actual); assertEquals(expected, actual);
} }
@Test
public void testWithForwardLock() throws Exception {
PackageManager.InstallOption withForwardLock = PackageManager.WITH_FORWARD_LOCK;
// Letter L not number 1
String expected = "-l";
Method privateMethod = withForwardLock.getClass().getDeclaredMethod("getStringRepresentation");
privateMethod.setAccessible(true);
String actual = (String) privateMethod.invoke(withForwardLock);
assertEquals(expected, actual);
}
@Test
public void testWithInstallerPackageName() throws Exception {
PackageManager.InstallOption withInstallerPackageName = PackageManager.WITH_INSTALLER_PACKAGE_NAME("aaa bbb");
String expected = "-t aaa bbb";
Method privateMethod = withInstallerPackageName.getClass().getDeclaredMethod("getStringRepresentation");
privateMethod.setAccessible(true);
String actual = (String) privateMethod.invoke(withInstallerPackageName);
assertEquals(expected, actual);
}
} }