ReVanced-Mirror/jadb
1
0
Fork 0
mirror of https://github.com/revanced/jadb.git synced 2024-06-10 07:07:49 +02:00
Code Issues Projects Releases Wiki Activity

Fix: Try-with-resources should be used (squid:S2093)

Browse Source
This commit is contained in:
Jano Svitok 2018-07-30 14:00:27 +02:00
parent 9cd5f509ae
commit b9a86b85fa
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/se/vidstige/jadb/managers/PackageManager.java
View File

@ -22,10 +22,8 @@ public class PackageManager {
}
public List<Package> getPackages() throws IOException, JadbException {
ArrayList<Package> result = new ArrayList<>();
BufferedReader input = null;
try {
input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8));
try (BufferedReader input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8))) {
ArrayList<Package> result = new ArrayList<>();
String line;
while ((line = input.readLine()) != null) {
final String prefix = "package:";
@ -33,10 +31,8 @@ public class PackageManager {
result.add(new Package(line.substring(prefix.length())));
}
}
} finally {
if (input != null) input.close();
return result;
}
return result;
}
private String getErrorMessage(String operation, String target, String errorMessage) {