Commit Graph

332 Commits

Author SHA1 Message Date
Jari Hämäläinen 8115621587 Close PropertyManager's reader after parsing 2017-01-28 16:57:30 +02:00
Jari Hämäläinen a083481f4a PropertyManager's pattern only needs to be compiled once
According to Pattern docs "Instances of this class are immutable and are
safe for use by multiple concurrent threads."
2017-01-28 16:54:51 +02:00
Jari Hämäläinen 206b9c4352 Allow any character except square brackets in property values
PropertyManager failed to get all properties from certain devices
because it allowed only [a-zA-Z0-9_.-] characters in values but
they can contain other characters too. For example in Nexus 9
ro.product.model is "Nexus 9" (has space).

This commit changes allowed characters in property value to contain
anything except square brackets.
2017-01-28 16:53:13 +02:00
Samuel Carlsson 0cb9550b50 Updating README.md regarding unix domain sockets
- Adding short troubleshooting guide instructing users running with adb server version serving via a unix domain socket.
2016-12-20 09:06:44 +01:00
Giemsa 251b3ac970 fix NullPointerException in test 2016-12-12 08:49:30 +01:00
Giemsa d1af94d257 minor changes to some API 2016-12-12 08:49:30 +01:00
Samuel Carlsson 958e9258d3 Merge pull request #43 from vidstige/release-script
Adding release script
2016-11-10 06:50:02 +01:00
Samuel Carlsson e9de06dc8c Adding release script 2016-11-10 06:46:57 +01:00
Daniel Friederich b4f5083d00 Change AdbFilterInputStream.read not to wait for more data
The previous AdbFilterInputStream.read function was always waiting for
buffer to fill, even if this meant to block for a long time. Now it checks
if the next read will block. The one case it still could block, when
reading a 0xd (carriage return) is not expected to occur for interactive
output (at least as the last character of some input).
This removes the need for a separate executeShellRaw method.
2016-11-07 09:42:06 +01:00
Daniel Friederich f8c9098a7e minor changes to address warnings, etc 2016-11-07 09:42:06 +01:00
Daniel Friederich 22f2442731 Add executeShellRaw method. Avoids buffering issues
The buffering used in executeShell causes issues when using shell:logcat,
the character per character implementation of the InputStream handling in AdbFilterInputStream together with the BufferedInputStream class
cause that the caller only gets result once either the process ends or 8k of output is avilable. The executeShellRaw method bypasses
the custom buffer handling, allowing the caller to receive the output without delay.
Note that the issue is only apparent when using a long running commamd with little output.
2016-11-07 09:42:06 +01:00
Samuel Carlsson c5197eab01 Using java syntax highliter for code snippets. 2016-10-29 07:07:37 +02:00
Giemsa 86ccd4ab42 add unit test for getState 2016-10-26 21:10:26 +02:00
Giemsa 4486bd0a7a remove Thread 2016-10-26 21:10:26 +02:00
Giemsa 706c64d36f change class name 2016-10-26 21:10:26 +02:00
Giemsa abbd2ad228 change var name 2016-10-26 21:10:26 +02:00
Giemsa 46a91334e0 change method name 2016-10-26 21:10:26 +02:00
Giemsa b50590f411 close transport 2016-10-26 21:10:26 +02:00
Giemsa af7b8ec5ab refactoring 2016-10-26 21:10:26 +02:00
Giemsa 76c9045b0c get state by get-state command 2016-10-26 21:10:26 +02:00
Giemsa e324cbe004 indentation 2016-10-26 21:10:26 +02:00
Giemsa fe744a007b typo 2016-10-26 21:10:26 +02:00
Giemsa 7a249c3476 device detection 2016-10-26 21:10:26 +02:00
Samuel Carlsson 70ea021bf0 Merge pull request #39 from SKART1/IMP-38-getprop
Imp 38 getprop
2016-10-03 17:57:17 +02:00
Arthur db5d9e13bc vidstige/jadb#38 some more changes for PR 2016-10-03 15:41:08 +03:00
Arthur f4c44d6e3f vidstige/jadb#38 pull-request fixes 2016-10-03 14:04:49 +03:00
Samuel Carlsson 5b66a90c3b Refactor: Adding dummy test for getprop function.
- The FakeServer can now return a string as stdout.
2016-10-03 13:36:00 +03:00
Samuel Carlsson 46045ce241 Merge pull request #40 from vidstige/shell-stdout
Shell stdout
2016-10-01 17:07:53 +02:00
Samuel Carlsson 6e4e4f948e Removing getprop test again 2016-10-01 17:03:42 +02:00
Samuel Carlsson 24348f806d Refactor: Better names
- serverReady and waitForServer had inverted names for some reason.
2016-10-01 16:36:14 +02:00
Samuel Carlsson 2073817c95 Refactor: Adding dummy test for getprop function.
- The FakeServer can now return a string as stdout.
2016-10-01 16:36:06 +02:00
Arthur dbb83b0ab6 IMP-34-versions-plugin implemented 2016-09-30 19:00:24 +02:00
Arthur b909665aa5 vidstige/jadb#34 implemented 2016-09-30 19:00:24 +02:00
Arthur 9c83f0320c vidstige/jadb#38 added unit tests 2016-09-30 18:30:28 +03:00
Arthur 02f6f6d79d vidstige/jadb#38 skeleton implemented. Need unit-tests 2016-09-30 15:14:02 +03:00
Samuel Carlsson 6ec1a4f9f9 Merge pull request #33 from vidstige/adb-launcher-fixture
Refactor: Adding unit test for `AdbServerLauncher`
2016-09-10 09:20:15 +02:00
Samuel Carlsson 58a370928e Refactor: Adding unit test for `AdbServerLauncher` 2016-09-10 09:13:29 +02:00
Samuel Carlsson a01ce1bb17 Merge pull request #32 from vidstige/race-condition-in-socketserver
Race condition in socketserver
2016-08-02 21:58:42 +02:00
Samuel Carlsson c2acf534ff Refactor: Moving out methods for clarity. 2016-08-02 21:52:34 +02:00
Samuel Carlsson ce6f04bdc7 Fixing a race condition in socket server
- This caused the mocked test cases to sometimes hang.
- Was particularly noticeable when running with code coverage.
2016-08-02 20:32:59 +02:00
Samuel Carlsson a82a850a50 Merge pull request #31 from vidstige/refactor/install-options
Refactor/install options
2016-08-01 19:57:16 +02:00
Samuel Carlsson 72c632001e Refactor: Renaming to `InstallOption`
Removing plural to keep things clear.
2016-08-01 19:45:50 +02:00
Samuel Carlsson 9b8ba8ff52 Refactor: Using functions/fields instead of classes.
Cleaning up PackageManager.
2016-08-01 19:45:49 +02:00
Samuel Carlsson 7371e0a890 Merge pull request #29 from SKART1/IMP-26-maven-for-trabis
Imp 26 maven for travis
2016-08-01 14:39:53 +02:00
Arthur 5da1a5a2de typo fix 2016-07-29 19:57:56 +03:00
Arthur c94d080159 vidstige/jadb#26 separate tests for unit and integration 2016-07-29 19:51:52 +03:00
Arthur ee20300b30 Merge remote-tracking branch 'upstream/master' into develop 2016-07-29 18:51:05 +03:00
Samuel Carlsson f362563e82 Merge pull request #28 from vidstige/contributing
Adding short contributing text and link from README.md
2016-07-28 22:48:53 +02:00
Samuel Carlsson 1c3de5c963 Update README.md 2016-07-28 22:42:58 +02:00
Samuel Carlsson dac19a0696 Cleaning up README.md 2016-07-28 22:29:51 +02:00