Commit Graph

332 Commits

Author SHA1 Message Date
Samuel Carlsson 032a8bd6d9
script to build in docker image 2018-09-17 18:48:24 +02:00
Samuel Carlsson d782a754c7
Merge pull request #102 from smieras/master
#100 Various methods can be made less accessible to increase encapsul…
2018-09-11 20:45:29 +02:00
Mieras Made 93101d290b #100 Various methods can be made less accessible to increase encapsulation 2018-09-11 20:15:06 +02:00
Samuel Carlsson 6c84fe6542
Merge pull request #94 from janosvitok/cleanup
Cleanup
2018-09-10 21:21:02 +02:00
Samuel Carlsson d3bd5c5ba6
Merge pull request #97 from smieras/master
#84 PackageManager problems: Fixes issue 1 & 2
2018-09-10 21:17:08 +02:00
Mieras Made 93c9506708 #84 PackageManager problems: Fixes issue 1 & 2 - after review 2018-09-09 20:22:39 +02:00
Mieras Made b0fbb4b75f #84 PackageManager problems: Fixes issue 1 & 2 2018-09-04 23:08:44 +02:00
Jano Svitok 3db1b31a0c Typos 2018-08-06 13:45:34 +02:00
Jano Svitok e4f4137108 Remove unnecessary escapes from RegExp 2018-08-06 13:45:33 +02:00
Jano Svitok 3fd68d337f Various small fixes found by IDEA inspection 2018-08-06 13:45:33 +02:00
Jano Svitok adb0cca09a Convert to try-with-resources 2018-08-06 13:45:33 +02:00
Jano Svitok bdbb454acb Java 7: collapse catch clauses 2018-08-06 13:45:32 +02:00
Jano Svitok a735c0f693 Java 7: use diamond operator 2018-08-06 13:45:32 +02:00
Jano Svitok 6dd5ad2566 Remove public from interfaces 2018-08-06 13:45:32 +02:00
Jano Svitok 048291c3ca Cleanup: remove unused member 2018-08-06 13:45:31 +02:00
Jano Svitok fef9997edf Performance: Make inner classes static 2018-08-06 13:45:31 +02:00
Jano Svitok 71689e4757 Use StandardCharsets.UTF_8 instead of Charset.forName("utf-8); add charset where needed
Application should always work with utf-8 strings regardless of locale.
2018-08-06 13:45:31 +02:00
Jano Svitok b255b3b618 Use more general DataOutput instead of DataOutputStream where possible 2018-08-06 13:45:30 +02:00
Jano Svitok c39c0d16ee Replace hardcoded method with constant 2018-08-06 13:41:54 +02:00
Jano Svitok eb853f2b01 Remove unused parameter 2018-08-06 13:41:53 +02:00
Jano Svitok 45c67bad0a Use try-with-resources for reading/writing files 2018-08-06 13:41:40 +02:00
Jano Svitok cb989acfa9 Simplify "if"s 2018-08-06 13:40:33 +02:00
Jano Svitok d5e464e52d Convert "if"s to ternary operators 2018-08-06 13:40:14 +02:00
Jano Svitok 1bd60cd946 Use JadbDevice.send() where possible 2018-08-06 13:39:44 +02:00
Samuel Carlsson bad9f11441
Merge pull request #92 from janosvitok/remove-duplicate-code
Extract common code from Host{ConnectTo/DisconnectFrom}RemoteTcpDevice
2018-08-03 22:32:47 +02:00
Jano Svitok 3f8b86d8e5 Extract common code to HostConnectionCommand class 2018-08-02 11:28:03 +02:00
Samuel Carlsson c380a1bcad
Merge pull request #88 from janosvitok/AdbProtocolHandler-cleanup
AdbProtocolHandler cleanup
2018-08-01 13:52:23 +02:00
Jano Svitok 063d7ec1cb AdbProtocolHandler: move try-catch block to sync method 2018-07-31 09:08:08 +02:00
Jano Svitok f679f387eb AdbProtocolHandler: extract command handlers to separate methods 2018-07-31 09:08:08 +02:00
Jano Svitok 4761259137 AdbProtocolHandler: refactor reading command from input stream 2018-07-31 09:08:08 +02:00
Jano Svitok 69695c5a4b AdbProtocolHandler: use try-with-resources 2018-07-31 09:08:08 +02:00
Jano Svitok bc2c76486a AdbProtocolHandler: extract loop body to new method 2018-07-31 09:08:08 +02:00
Jano Svitok ebf5d6b223 AdbProtocolHandler: extract SyncTransport creation 2018-07-31 09:08:08 +02:00
Samuel Carlsson 5750321eaa
Merge pull request #91 from janosvitok/fix-sonar-findings
Fix sonar findings
2018-07-31 08:52:47 +02:00
Samuel Carlsson 3b5d74e82e
Merge pull request #90 from janosvitok/add-Bash-quote-test
Add Bash.quote() test
2018-07-31 08:50:43 +02:00
Jano Svitok b9a86b85fa Fix: Try-with-resources should be used (squid:S2093) 2018-07-30 14:00:27 +02:00
Jano Svitok 9d201a6c83 Add Bash.quote() test 2018-07-30 13:40:35 +02:00
Jano Svitok 9cd5f509ae Fix: "Object.wait(...)" and "Condition.await(...)" should be called inside a "while" loop (squid:S2274) 2018-07-30 13:39:37 +02:00
Jano Svitok 1eeaee1da8 Fix: "notifyAll" should be used (squid:S2446) 2018-07-30 13:39:27 +02:00
Jano Svitok 42f0de589b Fix: Utility classes should not have public constructors (squid:S1118) 2018-07-30 13:39:16 +02:00
Jano Svitok aec31abf1f Fix: String literals should not be duplicated (squid:S1192) 2018-07-30 13:39:07 +02:00
Jano Svitok 9b6074ce2d Fix: String function use should be optimized for single characters (squid:S3027) 2018-07-30 13:38:57 +02:00
Jano Svitok 23b4dd6b4d Fix: Nested blocks of code should not be left empty (squid:S00108) 2018-07-30 13:38:45 +02:00
Jano Svitok 188aec84d6 Fix: Return of boolean expressions should not be wrapped into an "if-then-else" statement (squid:S1126) 2018-07-30 13:38:35 +02:00
Jano Svitok 1a34d13bbb Fix: Empty statements should be removed (squid:EmptyStatementUsageCheck) 2018-07-30 13:38:24 +02:00
Jano Svitok 9b4be76f3e Fix: Local variable and method parameter names should comply with a naming convention (squid:S00117) 2018-07-30 13:38:07 +02:00
Jano Svitok aa245626ab Suppress: Method names should comply with a naming convention (squid:S00100) 2018-07-30 13:37:55 +02:00
Jano Svitok f40d46917b Fix: The diamond operator ("<>") should be used (squid:S2293) 2018-07-30 13:37:45 +02:00
Jano Svitok 17b93cb935 Suppress: Constant names should comply with a naming convention (squid:S00115) 2018-07-30 13:37:37 +02:00
Jano Svitok 70c700a6a1 Fix: Modifiers should be declared in the correct order (squid:ModifiersOrderCheck) 2018-07-30 13:37:23 +02:00