Compare commits

...

3 Commits

Author SHA1 Message Date
DMzS
e724cfa9b0
Merge 22272c3c32 into aab5d4411b 2024-04-27 01:14:23 +05:30
hellidox
aab5d4411b
docs: Remove duplicate section in README (#1879)
[skip ci]
2024-04-23 18:29:06 +02:00
Domenic-MZS
22272c3c32
fix(ui): adjust showSourcesDialog scroll clipping in AlertDialog
This commit resolves the issue of children clipping in `AlertDialog` for the `showSourcesDialog` by adjusting the structure to manage scrolling behavior more efficiently. By doing this, the user experience and readability is greatly improved on small devices and/or devices with large fonts.

- Remove child SingleChildScrollView
- Add parent (dialog) scrollable property to true
2024-03-23 17:19:22 -03:00
2 changed files with 60 additions and 65 deletions

View File

@ -98,10 +98,6 @@ To build a ReVanced Manager, you can follow the [documentation](/docs).
You can find the documentation for ReVanced Manager [here](/docs). You can find the documentation for ReVanced Manager [here](/docs).
### đź‘‹ Contributing
Thank you for considering contributing to ReVanced Manager. You can find the contribution guidelines [here](/CONTRIBUTING.md).
## ⚖️ License ## ⚖️ License
ReVanced Manager is licensed under the GPLv3 license. Please see the [license file](LICENSE) for more information. ReVanced Manager is licensed under the GPLv3 license. Please see the [license file](LICENSE) for more information.

View File

@ -27,6 +27,7 @@ class SManageSources extends BaseViewModel {
return showDialog( return showDialog(
context: context, context: context,
builder: (context) => AlertDialog( builder: (context) => AlertDialog(
scrollable: true,
title: Row( title: Row(
children: <Widget>[ children: <Widget>[
Expanded( Expanded(
@ -39,75 +40,73 @@ class SManageSources extends BaseViewModel {
), ),
], ],
), ),
content: SingleChildScrollView( content: Column(
child: Column( children: <Widget>[
children: <Widget>[ TextField(
TextField( controller: _orgPatSourceController,
controller: _orgPatSourceController, autocorrect: false,
autocorrect: false, onChanged: (value) => notifyListeners(),
onChanged: (value) => notifyListeners(), decoration: InputDecoration(
decoration: InputDecoration( icon: Icon(
icon: Icon( Icons.extension_outlined,
Icons.extension_outlined, color: Theme.of(context).colorScheme.onSurfaceVariant,
color: Theme.of(context).colorScheme.onSurfaceVariant,
),
border: const OutlineInputBorder(),
labelText: t.settingsView.orgPatchesLabel,
hintText: patchesRepo.split('/')[0],
), ),
border: const OutlineInputBorder(),
labelText: t.settingsView.orgPatchesLabel,
hintText: patchesRepo.split('/')[0],
), ),
const SizedBox(height: 8), ),
// Patches repository's name const SizedBox(height: 8),
TextField( // Patches repository's name
controller: _patSourceController, TextField(
autocorrect: false, controller: _patSourceController,
onChanged: (value) => notifyListeners(), autocorrect: false,
decoration: InputDecoration( onChanged: (value) => notifyListeners(),
icon: const Icon( decoration: InputDecoration(
Icons.extension_outlined, icon: const Icon(
color: Colors.transparent, Icons.extension_outlined,
), color: Colors.transparent,
border: const OutlineInputBorder(),
labelText: t.settingsView.sourcesPatchesLabel,
hintText: patchesRepo.split('/')[1],
), ),
border: const OutlineInputBorder(),
labelText: t.settingsView.sourcesPatchesLabel,
hintText: patchesRepo.split('/')[1],
), ),
const SizedBox(height: 8), ),
// Integrations owner's name const SizedBox(height: 8),
TextField( // Integrations owner's name
controller: _orgIntSourceController, TextField(
autocorrect: false, controller: _orgIntSourceController,
onChanged: (value) => notifyListeners(), autocorrect: false,
decoration: InputDecoration( onChanged: (value) => notifyListeners(),
icon: Icon( decoration: InputDecoration(
Icons.merge_outlined, icon: Icon(
color: Theme.of(context).colorScheme.onSurfaceVariant, Icons.merge_outlined,
), color: Theme.of(context).colorScheme.onSurfaceVariant,
border: const OutlineInputBorder(),
labelText: t.settingsView.orgIntegrationsLabel,
hintText: integrationsRepo.split('/')[0],
), ),
border: const OutlineInputBorder(),
labelText: t.settingsView.orgIntegrationsLabel,
hintText: integrationsRepo.split('/')[0],
), ),
const SizedBox(height: 8), ),
// Integrations repository's name const SizedBox(height: 8),
TextField( // Integrations repository's name
controller: _intSourceController, TextField(
autocorrect: false, controller: _intSourceController,
onChanged: (value) => notifyListeners(), autocorrect: false,
decoration: InputDecoration( onChanged: (value) => notifyListeners(),
icon: const Icon( decoration: InputDecoration(
Icons.merge_outlined, icon: const Icon(
color: Colors.transparent, Icons.merge_outlined,
), color: Colors.transparent,
border: const OutlineInputBorder(),
labelText: t.settingsView.sourcesIntegrationsLabel,
hintText: integrationsRepo.split('/')[1],
), ),
border: const OutlineInputBorder(),
labelText: t.settingsView.sourcesIntegrationsLabel,
hintText: integrationsRepo.split('/')[1],
), ),
const SizedBox(height: 20), ),
Text(t.settingsView.sourcesUpdateNote), const SizedBox(height: 20),
], Text(t.settingsView.sourcesUpdateNote),
), ],
), ),
actions: <Widget>[ actions: <Widget>[
TextButton( TextButton(