alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FrameSvgPrivate::generateBackground: generate background also if reqp != p

Browse Source 
Summary:
d8a1a9eb08 changed the condition from
hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix)
but it is not clear why, as the background is generated from the prefix
data & the requestedPrefix is no-where in effect.
As a result sometimes the background is not rendered for a given
not-existing requestedPrefix which was mapped to an empty prefix instead.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21175
This commit is contained in:
Friedrich W. H. Kossebau 2019-05-13 01:56:20 +02:00
parent 1bc1994dfe
commit 6af447a848
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plasma/framesvg.cpp
View File

@ -452,7 +452,7 @@ QSharedPointer<FrameData> FrameSvgPrivate::lookupOrCreateMaskFrame(const QShared
void FrameSvgPrivate::generateBackground(const QSharedPointer<FrameData> &frame) void FrameSvgPrivate::generateBackground(const QSharedPointer<FrameData> &frame)
{ {
if (!frame->cachedBackground.isNull() || !q->hasElementPrefix(frame->requestedPrefix)) { if (!frame->cachedBackground.isNull() || !q->hasElementPrefix(frame->prefix)) {
return; return;
} }