alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't set a window icon in Plasma::Dialog

Browse Source 
Summary:
Setting a window icon is costly enough to be worth avoiding when it's
not actually needed.

This is a resurrection of David's old patch:

https://git.reviewboard.kde.org/r/128484/

The concerns in the old discussion that led to its rejection are no
longer valid today: In the meantime we implemented a way for apps to
announce their .desktop file in a window hint, which KWin (and libtm)
will fall back to to look up an icon if not set. As plasmashell does
this, we can drop the setIcon call here and won't regress.

Test Plan:
The pinned systray popup dialog still gets the Plasma icon in the
Present Windows effect.

Reviewers: #plasma, #frameworks, davidedmundson, graesslin

Subscribers: plasma-devel

Tags: #plasma, #frameworks

Differential Revision: https://phabricator.kde.org/D9209
This commit is contained in:
Eike Hein 2017-12-05 20:43:09 +09:00
parent 71f8f16fea
commit 78f83f5c77
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plasmaquick/dialog.cpp
View File

@ -738,8 +738,6 @@ Dialog::Dialog(QQuickItem *parent)
setColor(QColor(Qt::transparent)); setColor(QColor(Qt::transparent));
setFlags(Qt::FramelessWindowHint | Qt::Dialog); setFlags(Qt::FramelessWindowHint | Qt::Dialog);
setIcon(QIcon::fromTheme(QStringLiteral("plasma")));
connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); }); connect(this, &QWindow::xChanged, [=]() { d->slotWindowPositionChanged(); });
connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); }); connect(this, &QWindow::yChanged, [=]() { d->slotWindowPositionChanged(); });