alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

api review part 1

Browse Source 
removed some dead signals and an unnecessary const

svn path=/trunk/KDE/kdelibs/; revision=1012640
This commit is contained in:
Chani Armitage 2009-08-17 22:30:50 +00:00
parent f0a68d537c
commit 9d2a2e40ba
4 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
applet.h
View File

@ -702,7 +702,7 @@ class PLASMA_EXPORT Applet : public QGraphicsWidget
* Emitted when the immutability changes * Emitted when the immutability changes
* @since 4.4 * @since 4.4
*/ */
void immutabilityChanged(const ImmutabilityType immutable); void immutabilityChanged(ImmutabilityType immutable);
public Q_SLOTS: public Q_SLOTS:
/** /**

4
containment.cpp
View File

@ -258,8 +258,6 @@ void Containment::init()
ContextAction *action = ContextAction::load(defaults.value(trigger)); ContextAction *action = ContextAction::load(defaults.value(trigger));
if (action) { if (action) {
d->contextActions.insert(trigger, action); d->contextActions.insert(trigger, action);
connect(action, SIGNAL(configureRequested()), this, SLOT(requestConfiguration()));
connect(action, SIGNAL(configNeedsSaving()), this, SIGNAL(configNeedsSaving()));
action->setParent(this); action->setParent(this);
} }
} }
@ -1721,8 +1719,6 @@ void Containment::setContextAction(const QString &trigger, const QString &plugin
if (action) { if (action) {
cfg.writeEntry(trigger, pluginName); cfg.writeEntry(trigger, pluginName);
d->contextActions.insert(trigger, action); d->contextActions.insert(trigger, action);
connect(action, SIGNAL(configureRequested()), this, SLOT(requestConfiguration()));
connect(action, SIGNAL(configNeedsSaving()), this, SIGNAL(configNeedsSaving()));
} else { } else {
//bad plugin... gets removed. is this a feature or a bug? //bad plugin... gets removed. is this a feature or a bug?
cfg.deleteEntry(trigger); cfg.deleteEntry(trigger);

1
contextaction.cpp
View File

@ -231,7 +231,6 @@ void ContextAction::setConfigurationRequired(bool needsConfig, const QString &re
} }
d->needsConfig = needsConfig; d->needsConfig = needsConfig;
emit configurationRequired(needsConfig);
} }
} // Plasma namespace } // Plasma namespace

18
contextaction.h
View File

@ -208,24 +208,6 @@ class PLASMA_EXPORT ContextAction : public QObject
*/ */
QAction *configurationAction(); QAction *configurationAction();
Q_SIGNALS:
/**
* Emitted when the user wants to configure/change the contextaction.
*/
void configureRequested();
/**
* Emitted when the state of the contextaction requiring configuration
* changes.
*/
void configurationRequired(bool needsConfig);
/**
* Emitted when the configuration of the contextaction needs to be saved
* to disk.
*/
void configNeedsSaving();
protected: protected:
/** /**
* This constructor is to be used with the plugin loading systems * This constructor is to be used with the plugin loading systems