alecs/plasma-framework
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use the SkipGrouping flag for the "widget deleted" notification

Browse Source 
https://git.reviewboard.kde.org/r/126459/ introduced new
flag that allows to skip the grouping of notifications.

This should fix all bugs caused by checking for appName
being "plasma_workspace" which are all default notifications
from any plasmoid.

CCBUG: 356653
REVIEW: 126461

(this also needs to raise the KF5 dep to 5.18 which is
normally done at release time, but in order to use this
now, it needs to be bumped now, otherwise build failures
will ensue)
This commit is contained in:
Martin Klapetek 2015-12-29 15:08:46 -05:00
parent 46c555838c
commit f639996bec
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -22,7 +22,7 @@ include(ECMQtDeclareLoggingCategory)
include(KDEPackageAppTemplates)
set(KF5_VERSION "5.18.0") # handled by release scripts
set(KF5_DEP_VERSION "5.17.0") # handled by release scripts
set(KF5_DEP_VERSION "5.18.0") # handled by release scripts
ecm_setup_version(${KF5_VERSION}
VARIABLE_PREFIX PLASMA

1
src/plasma/private/applet_p.cpp
View File

@ -254,6 +254,7 @@ void AppletPrivate::askDestroy()
//no parent, but it won't leak, since it will be closed both in case of timeout
//or direct action
deleteNotification = new KNotification("plasmoidDeleted", KNotification::Persistent, 0);
deleteNotification->setFlags(KNotification::SkipGrouping);
deleteNotification->setComponentName("plasma_workspace");
QStringList actions;