Commit Graph

253 Commits

Author SHA1 Message Date
Aaron J. Seigo
659844e273 use the caching (!), don't crash if we get a 0 widget parameter
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821186
2008-06-16 19:10:38 +00:00
Aaron J. Seigo
5c360d7651 just to prove that this doesn't make it any closer. i do like the window affinity though
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821059
2008-06-16 09:01:26 +00:00
Aaron J. Seigo
738d0547a6 * be careful with contents of action lists and guard against null ptrs
* start/stop accepting drops altogether on immutability changes; this makes it a bit more difficult (though not completely impossible) for containment plugins to Get It Wrong

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820251
2008-06-13 16:51:25 +00:00
Aaron J. Seigo
bdb635e3a8 don't accept drops that we don't understand or when we are immutable
CCBUG:163908

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820230
2008-06-13 16:21:59 +00:00
Aaron J. Seigo
2157ab1356 geometry, not boundingRect. fixes the other remaining cause of looping when arranging multiple containments
BUG:163477

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820061
2008-06-13 05:23:02 +00:00
Aaron J. Seigo
f9ac3edde5 get the geometry right
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=818650
2008-06-09 04:09:11 +00:00
Aaron J. Seigo
c9fcf43c43 i wonder if this fixes it; can the reporters test this for me, because it wasn't being triggered here, but i can see how it could be without this patch
CCBUG:163477

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=818638
2008-06-09 03:15:40 +00:00
Aaron J. Seigo
ccadeadaa2 try some slightly smarter arangement concepts
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=817970
2008-06-07 09:34:50 +00:00
Aaron J. Seigo
f1ce0ee124 safety in removing panels, aka "work around the inane requirement to first remove items from the scene before deleting them if they are a QGraphicsWidget and have a layout"
BUG:163205

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816760
2008-06-04 19:04:34 +00:00
Aaron J. Seigo
3d45aae7fb more code clean ups
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816745
2008-06-04 18:20:58 +00:00
Sebastian Sauer
cc80b06826 prevent assert if d->applets is empty and we compiled with debug enabled.
BUG:162742

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816502
2008-06-04 02:44:54 +00:00
Chani Armitage
2048a57f54 *use standard qkeysequences for zooming
*also keep the ctrl-= for zoom-in so that people with US keyboards don't have to press shift

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=815524
2008-06-02 04:26:54 +00:00
Aaron J. Seigo
40e4b3e88e * global keyboard shortcuts for applets
* move the contents of setGeometry to itemChange and resizeEvent for greater reliability

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=815043
2008-06-01 02:13:53 +00:00
Kevin Ottens
402a4ed8b2 Don't use the same name for this slot than in Applet. Otherwise, the
wrong slot will get called when you remove an applet which also happens
to be a containment (like the analog clock for instance)...
In such a case we were simply leaking the applet, and it was still in
the layout.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812153
2008-05-24 17:13:19 +00:00
Kevin Ottens
c3b5446a59 Since we're randomly changing public API, let's be consistent with Qt
instead. Use ToolBox everywhere, also for internals.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812019
2008-05-24 12:25:56 +00:00
Aaron J. Seigo
bea0906806 finish yet another 4.1 feature gap: allow the user to select what to do on drop. the text is a bit lame for icon, it should be "link to file" or something similar but that string doesn't seem to be handy and we're in a string freeze =/ at least it works =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811949
2008-05-24 07:47:20 +00:00
Chani Armitage
e5230a3f3e stop calling it ToolBox - it's Toolbox, and the capitalization inconsistency is driving me nuts :)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811934
2008-05-24 06:34:08 +00:00
Chani Armitage
88260fabd2 'add activity' action returns
I just realised it was never disabled when plasma is locked, though. haven't yet decided what to do about that.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811919
2008-05-24 04:34:27 +00:00
Chani Armitage
3dcf445db4 convert the toolbox to use qactions. this makes the toolbox act a bit more reliably, makes some other bugs more annoying, and makes it easier to fix them.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811914
2008-05-24 01:48:36 +00:00
Marco Martin
bc1688ae41 when the view is not zoomed move the toolbox to avoid the panels
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811374
2008-05-22 20:22:28 +00:00
Aaron J. Seigo
26f7e83a53 give proper control over saving/restoring to the containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811211
2008-05-22 15:53:48 +00:00
Chani Armitage
7f822e8c8c SVN_SILENT: better comment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811016
2008-05-22 02:23:33 +00:00
Chani Armitage
81985d2b00 clicking an available desktop containment sets the view to that containment
now it's much easier to jump to the activity you want :)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810614
2008-05-21 06:16:45 +00:00
Marco Martin
4c36d280c9 (hopefully) fixing the positioning of the desktop toolbox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810501
2008-05-20 21:29:31 +00:00
Chani Armitage
18a50b787d only do containment-style removal if it's *really* a containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810132
2008-05-20 04:26:10 +00:00
Chani Armitage
ccde7ded20 replace Panel::remove() with Containment::destroy()
now I can remove some of the ten desktop containments I accumulated :)
oh, and the code is cleaner too, yay!

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810129
2008-05-20 04:02:36 +00:00
Marco Martin
573f99e978 hides the panel toolbox when the whole desktop is locked
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809993
2008-05-19 20:49:44 +00:00
Rob Scheepmaker
8b20aab3fb Couple of improvements to applet drag&drop:
* Only move applet to toplevel window when overlapping other plasma views, ignoring other windows and such.
* Drag & drop now works reasonably well when using multiple desktop containments ('activities'), both when
  zoomed in as when zoomed out. Only a couple of issues remaining.
* Containment's addApplet function now cleans up the pointer to the applethandle in the preview containment,
  Avoiding some nasty crashes when moving applets between containments.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809841
2008-05-19 16:20:27 +00:00
Chani Armitage
732a7a1d72 opening the desktop toolbox on hover was never going to work perfectly, and would be a bit of a problem for touchscreens (they make the mouse jump instead of moving smoothly) - so it no longer happens.
the toolbox just lights up on hover now, and opens on click. it still closes on the hover leave event, though.
this makes the code a lot less hackish and should produce the least frustrating behaviour possible.
it's also a bit more like the panel cashew behaviour.
BUG:159520

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809497
2008-05-19 00:41:41 +00:00
Chani Armitage
b021102afe update lock icon along with lock text
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809376
2008-05-18 19:58:33 +00:00
Chani Armitage
1d8eb91e89 keyboard shortcuts.
the defaults are kinda lame right now, but I'm planning to do a lot more with this.
applet focus and the shorcut hooks work properly, however.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=808610
2008-05-17 03:39:24 +00:00
Marco Martin
d03f49e72f show the panel toolbox on the left when plasma starts with an RTL layout
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=806621
2008-05-11 20:58:49 +00:00
Dan Meltzer
f57cc1c623 Lotsa little ebn fixes.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805672
2008-05-09 05:32:15 +00:00
Chani Armitage
61ae3df3fc *Applet::destroy() now handles everything needed for removing an applet prettily and safely.
*removed Containment::Private::destroyApplet in favour of just calling Applet::destroy() directly.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805666
2008-05-09 04:43:21 +00:00
Alexis Ménard
987ca211c7 put the remove of the layout if the applet is removed in destroy function, then if we call
it from other place we will be sure the applet will be remove from the layout

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805590
2008-05-08 20:26:56 +00:00
Alexis Ménard
71f1d6f5cb fix our "not really remove applet" when remove applet in the panel/containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805373
2008-05-08 11:13:48 +00:00
Chani Armitage
2a6a5fa6db :%s/NotImmutable/Mutable/g
because double negatives hurt my brain.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=805296
2008-05-08 04:26:52 +00:00
Marco Martin
4c1e5b8e9d New class called PanelController:
is a new QWidget shown when the user clicks on the panel toolbox, it's a
thing that will eventually replace the panel configuration dialog.
at the moment it has an add aplet and remove panel buttons.
it is possible to resize the panel by dragging the upper edge of the
panel controller and in the future will be provided a way to resize the
panel width and changing the position.
at the moment there is the known problem that the resize handle doesn't
work for vertical panel for now.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802932
2008-05-01 09:58:36 +00:00
Aaron J. Seigo
207968b217 resetConfigurationObject()->pimpl
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802892
2008-05-01 03:24:20 +00:00
Aaron J. Seigo
1847d60a1d API REVIEW: launchActivated -> releaseVisualFocus; more generic and a bit more obvious as to its purpose
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802286
2008-04-29 02:28:35 +00:00
Aaron J. Seigo
2dd5891029 with some intriguing grotesqueness internal to the library, we can simplify the API and remove location/formFactor from Containment and just use the ones in Applet; externally this is probably rather safer
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802277
2008-04-29 00:49:10 +00:00
Aaron J. Seigo
69524609a3 remove createLayout from Containment. now each containment will need to implement its own layouting. this is not so big a deal since FreeLayout is no longer needed to make applets behave properly. now panels can do whatever the heck they want.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802255
2008-04-28 23:00:08 +00:00
Aaron J. Seigo
b00807cee8 * containments should never have the applet background by default
* always call updateConstraints, not constraintsEvent directly to avoid unecessary multiple calls

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801817
2008-04-27 20:35:23 +00:00
Aaron J. Seigo
df1ba079e8 go back is isContainment. ActAs is just ugly ugly. i don't think anyone really gets confused over isContainment (e.g. confusing it with IsA ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801792
2008-04-27 19:05:06 +00:00
Davide Bettio
8cd95e4ae7 API REVIEW: updated containment to the new API (constraintsUpdated() -> constraintsEvent() + protected)
CCMAIL: aseigo@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801659
2008-04-27 11:13:43 +00:00
Davide Bettio
ff16201431 API REVIEW: constraintsUpdated() -> constraintsEvent()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801656
2008-04-27 11:04:43 +00:00
Marco Martin
694c822bb0 API reviews:
flushUpdatedConstraints()->flushPendingCostraintEvents()

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801443
2008-04-26 17:13:59 +00:00
Marco Martin
6d8a1752a7 API review:
isContainment(), setIsContainment() -> actAsContainment(),
setActAsContainment()
 set is protected

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801425
2008-04-26 15:52:48 +00:00
Marco Martin
0c283924be API reviews:
killed drawStandardBackground() and shadowShown()
now the two properties are merged in backgroundHints() and
setBackgroundHints() using the combination of BackgroundHints flags

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801282
2008-04-26 09:13:57 +00:00
Aaron J. Seigo
8cdde181c5 signal typos
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801237
2008-04-26 03:33:41 +00:00