Commit Graph

15124 Commits

Author SHA1 Message Date
Marco Martin
067ec2eafc use the right namespace 2019-04-09 15:40:36 +02:00
Nate Graham
7687ffa3da Use more appropriate "Alternatives" icon and text
Summary:
The new icon was just added in D20367. The current icon is semantically and visually incorrect,
and the new one fixes that.

The current text also does not begin with an action verb, and this patch fixes that too.

Test Plan:
Before:
{F6759646, size=full}

After:
{F6759647, size=full}
{F6759649, size=full}

Reviewers: #vdg, #plasma, GB_2, filipf

Reviewed By: #vdg, GB_2, filipf

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20392
2019-04-08 15:04:02 -06:00
Friedrich W. H. Kossebau
f20722fbe1 FrameSvgItem: add "mask" property
Summary:
This property allows e.g. the Plasma shell to query the shape a panel has
when defining the area for BlurBehind.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20202
2019-04-08 15:11:07 +02:00
Marco Martin
c72ee78bbb mov the mobile text actions in own import
this avoids a qml type resolution recurtion which can
in some cases stuck the component to loading forever
this was particularly visible in plasma mobile
2019-04-08 13:32:46 +02:00
l10n daemon script
78a48451b2 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.57.0 release. 2019-04-07 07:21:31 +00:00
Kai Uwe Broulik
c65145bd34 [AppletInterface] Check for corona before accessing it
On plasmashell shutdown when the panels are destroyed, the available screen geometry changes.
When an applet then accesses screenGeometry in response to that change, it crashes because the corona is already gone.

availableScreenRegion() and availableScreenRect() already checked for this but screenGeometry() did not

Differential Revision: https://phabricator.kde.org/D20244
2019-04-05 11:34:07 +02:00
Kai Uwe Broulik
9de0def99f [Dialog] Don't forward hover event when there is nowhere to forward it to
Dialog has this clever way of re-sending a mouse event inside the bounardies of the dialog,
so despite visual padding, the items can be clicked on any corner following Fitt's law.
However, when the mainItem has no size, adjusting the position will adjust it inside the border
since there is no pixel inside the main item, leading to infinite recursion as the event is
processed again and again and again leading to a crash.

Differential Revision: https://phabricator.kde.org/D20200
2019-04-02 14:04:37 +02:00
Kai Uwe Broulik
9aa249e86a [Menu] Fix triggered signal
It casted the QAction to a MenuItem which fails because it isn't such.
Instead, manually find the item with the corresponding action.

Differential Revision: https://phabricator.kde.org/D20199
2019-04-02 14:03:34 +02:00
Aleix Pol
4f132316c5 Reduce the importance of some debug information so actual warnings can be seen.
Reviewers: #plasma, #frameworks, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20095
2019-04-02 01:10:46 +02:00
Aleix Pol
decabe7b67 Fix qml warning 2019-04-01 21:07:46 +02:00
Kai Uwe Broulik
d868804a7f [PlasmaComponents3 ComboBox] Fix textColor
Uses the one from ColorScope rather than Kirigami.
Kirigami.Theme isn't used in any other Plasma Components 3 and the opacity already changes for when it's disabled

Differential Revision: https://phabricator.kde.org/D20070
2019-04-01 10:12:06 +02:00
David Faure
89724dbd8c autotests: don't fail if an unrelated window shows up.
Summary:
Running anything else in parallel to this test would make it fail,
because windowAdded() would be emitted with an unrelated window.
If we couldn't find our dialog when the signal is emitted,
just keep waiting for the signal to be emitted again.

Test Plan: ctest -j 8 .

Reviewers: hein, drosca, broulik, davidedmundson, jtamate

Reviewed By: jtamate

Subscribers: jtamate, kde-frameworks-devel, #plasma

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14724
2019-04-01 09:48:22 +02:00
l10n daemon script
978160d9d9 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-03-25 05:53:54 +01:00
Friedrich W. H. Kossebau
5f4f88ad66 FrameSvgItem: catch margin changes of FrameSvg also outside own methods
Summary:
FrameSvg updates the margins e.g. on a Theme change already in its
internal event handling before the methods of FrameSvgItem are invoked.
Due to that CheckMarginsChange guards before this change could not detect
any changes, and thus missed to trigger an update via the margin objects
to the QtQuick world.

So when changing the theme e.g. in a Plasma shell or in the Plasma Theme
Explorer, existing FrameSvg items are using outdated margins, resulting
in broken display.

By keeping a copy of the last seen margins as part of the item and not only
per method, changes outside the FrameSvgItem items can be properly detected.

Test Plan:
Switch Plasma themes between Air, Breeze & Oxygen, see how different margins
are reflected in the widgets sizes instantly.
Switch Plasma themes in the Plasma Theme Explorer, with "Show Margins"
enabled, see how margins are always correctly updated intead of taking the
value of the last theme used.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19743
2019-03-22 11:32:44 +01:00
Friedrich W. H. Kossebau
fb1a332948 Add Theme::blurBehindEnabled()
Summary:
Allows themes to disable the blurring of what is behind panels,
if they either do not need it (being fully opaque) or by design want
non-blurry transparency.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19907
2019-03-21 19:33:41 +01:00
Aleix Pol
349648c1e6 Fix crash 2019-03-21 19:13:03 +01:00
Friedrich W. H. Kossebau
0ffe183d71 FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0
Summary:
The old logic results in broken rendering if the sample was bigger than the
area to render, due to normalized texture rect being 0 in the respective
dimansion. As well as stretched mapping of the sample for fractional
relationships between the area to render and the sample size.

Test Plan:
Borders of backgrounds of FluffyBunny theme render properly, no other
regressions seen (but unsure what else might rely on that artifact).

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: apol, sitter, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19787
2019-03-20 00:52:13 +01:00
Fabian Vogt
3aba8a7e10 Fix breeze dialog background with Qt 5.12.2
Summary:
style elements without type="text/css" were ignored before, but now they act as
if type was set. Set id and style properly to restore the working behaviour.

BUG: 405548

Test Plan:
Installed new files on a system with Qt 5.12.2, wiped the SVG cache
and it looks fine again.

Reviewers: #plasma, rooty

Reviewed By: rooty

Subscribers: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19821
2019-03-19 14:52:48 +01:00
l10n daemon script
d7e2f921d7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-03-14 05:38:31 +01:00
Laurent Montel
ebae2d6303 Remove crash in plasmashell
Summary: remove bug in plasmashell Bug 405341

Test Plan: can't reproduce bug

Reviewers: dfaure, #frameworks, #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19698
2019-03-12 10:18:41 +01:00
Kai Uwe Broulik
017954185c [Icon Item] Also clear image icon when using Plasma Svg
When changing an IconItem from using a local image (e.g. PNG file) to using a Plasma themed icon,
the implicit size wasn't updated since the old image was still loaded in m_imageIcon.
Clearing it when clearing the other icon stores fixes this.

BUG: 405298

Differential Revision: https://phabricator.kde.org/D19674
2019-03-11 13:27:37 +01:00
l10n daemon script
e77bf0f5d6 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-03-10 05:35:43 +01:00
l10n daemon script
17703508b7 GIT_SILENT Upgrade KF5 version to 5.57.0. 2019-03-09 09:45:26 +00:00
Marco Martin
a2749dc9c7 textfield height based only on clear text
Summary:
as the implicit height could change when switching to password mode,
use a textmetrics which always computes it from the visible text

BUG:399155

Test Plan: height doesn't change

Reviewers: #plasma, ngraham, rooty

Reviewed By: ngraham, rooty

Subscribers: sitter, rooty, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19599
2019-03-08 15:40:47 +01:00
Marco Martin
fa8b766eb0 bind alternateBackgroundColor 2019-03-06 10:55:16 +01:00
Laurent Montel
976d08d09a GIT_SILENT: add gitignore 2019-03-04 07:03:07 +01:00
l10n daemon script
252298e88c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-03-03 05:33:56 +01:00
l10n daemon script
f7bc60a404 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.56.0 release. 2019-03-02 13:31:04 +00:00
l10n daemon script
21e671bee1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-03-01 05:56:28 +01:00
Laurent Montel
9fc663d9f0 Make it compiles without deprecated method
Summary: compile without deprecated method

Test Plan: all autotest ok

Reviewers: dfaure, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19418
2019-02-28 23:01:43 +01:00
Kai Uwe Broulik
b6a6bb8e17 [Icon Item] Block next animation also based on window visibility
Plasma Dialog used to change the item's visiblity but this is no longer the case, so it would animate when a window is shown and
the source has changed in the meantime.

Differential Revision: https://phabricator.kde.org/D19421
2019-02-28 15:59:13 +01:00
Laurent Montel
6e2ac5f9ce it's already defined in KDEFrameworkCompilerSettings 2019-02-28 13:28:00 +01:00
Fabian Vogt
02ec1b77c2 Show a warning if a plugin requires a newer version
Summary: Currently it just fails silently.

Test Plan: Loaded a plasmoid with an incompatible plugin, warning is shown.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel, plasma-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19394
2019-02-27 18:53:23 +01:00
l10n daemon script
0359e25396 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-26 05:31:18 +01:00
l10n daemon script
47b099e148 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-25 05:47:43 +01:00
l10n daemon script
32e16e8c98 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-22 05:35:03 +01:00
l10n daemon script
06ad76df24 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-21 06:28:24 +01:00
l10n daemon script
397f191c41 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-20 05:52:17 +01:00
l10n daemon script
e01e78e9d3 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-19 06:32:54 +01:00
Nate Graham
6081898626 Bump the theme versions because icons changed, to invalidate old caches 2019-02-18 12:29:21 -07:00
Krešimir Čohar
e1248d68c2 [breeze-icons] Revamp system.svgz
Summary: This patch adds new icons for the action buttons modified/added in D18893, and gives the suspend hibernate and switch user icons a makeover.

Test Plan:
{F6621871}

Other..: {F6621331} {F6621867}
List Users: {F6615519} {F6621869}

Reviewers: #vdg, #plasma, ngraham, abetts

Reviewed By: #vdg, ngraham

Subscribers: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19020
2019-02-18 20:32:56 +01:00
l10n daemon script
937f2ccc15 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-02-17 05:32:17 +01:00
Björn Feber
bb643e99c3 Make Breeze theme tooltip texts consistent 2019-02-15 19:53:00 +01:00
l10n daemon script
9a79694009 GIT_SILENT Upgrade KF5 version to 5.56.0. 2019-02-09 13:11:35 +00:00
Noah Davis
054b494bb3 Change glowbar.svgz to smoother style
Summary:
The old style was weird. When the screen edge feature was enabled for the sides of screens, it looked like a bunch of dots smooshed together. Now it's one smooth bar.
BUG: 391343
FIXED-IN: 5.56

Test Plan:
Before {F6599392} {F6599445, size=full}
After {F6599389} {F6599444, size=full}

Reviewers: #vdg, rooty

Reviewed By: rooty

Subscribers: rooty, rapiteanu, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18834
2019-02-08 03:57:03 -05:00
Kai Uwe Broulik
7ca1f01ea9 Do background contrast fallback at runtime
When a theme doesn't supply background contrast values, we take an educated guess based on whether it's a dark or light theme.
We didn't update the values when switching only color schemes at runtime (when theme follows it).
This lead to washed out Plasma popup and panel backgrounds. Instead, compute the fallback value at runtime.
Also, while at it, update complimentary colorscheme as well, which was forgotten here.

BUG: 401142

Differential Revision: https://phabricator.kde.org/D18487
2019-02-07 16:37:55 +01:00
Krešimir Čohar
dda4edcc6e [breeze desktop theme/dialogs] Add rounded corners to dialogs
Summary:
This patch aims to make the corners of the dialog/notification backgrounds (dialogs/background.svgz) more rounded and more in keeping
with the Breeze window decoration theme.

Test Plan:
Before: {F6568854}
After: {F6568855}

Before (Breeze Dark, no //Background contrast effect//): {F6569235}
After (Breeze Dark, no //Background contrast effect//): {F6569236}

Using the Background Contrast Kwin effect adds a weird dark background to all the dialogs and the corners aren't rounded anymore:
{F6568856} and these strange dots appear instead (a rectangle bleeding through?)
{F6568352}

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18545
2019-02-05 16:59:43 +01:00
Aleix Pol
901ae40834 Fix warning
Summary: org/kde/plasma/components.3/TextArea.qml:54:5: Unable to assign [undefined] to QQmlComponent*

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18630
2019-02-04 22:35:25 +01:00
l10n daemon script
46496ccf14 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.55.0 release. 2019-02-02 17:24:58 +00:00
l10n daemon script
543b468be3 GIT_SILENT Upgrade KF5 version to 5.55.0. 2019-02-02 13:21:12 +00:00