Commit Graph

15185 Commits

Author SHA1 Message Date
Aleix Pol
097f0e83e7 Make Plasma::Svg::elementRect a bit leaner
Summary:
Don't double-access maps
Don't construct ids more times than necessary.
Make regular expression static so it's not compiled on every run.
Remove unused code.

Reviewers: #plasma, #frameworks, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: bruns, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21788
2019-06-21 15:25:42 +02:00
Friedrich W. H. Kossebau
eff37abdcb Automatically set version of desktopthemes packages to KF5_VERSION
Summary:
Should ensure that on a new release any existing theme caches are updated
automatically.

Reviewers: #plasma, ltoscano, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21767
2019-06-13 15:38:23 +02:00
Aleix Pol
52124c663e Don't notify about changing to the same state it was at
Summary:
The object tracker was telling me it's notifying the same value it
already got, and reading the code it seems to be already notifying when it
actually changes.

Test Plan: tests pass, plasma runs fine.

Reviewers: #plasma

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21481
2019-06-13 01:04:53 +02:00
l10n daemon script
bfc4ea6853 GIT_SILENT Upgrade KF5 version to 5.60.0. 2019-06-08 09:42:09 +00:00
Dimitris Kardarakos
cd8b6b71ce Fix the alignment of the label of the toolbutton
When only a label exists in a toolbutton, without filling the width of the rowlayout, the label is not properly aligned in the center.

Differential Revision: https://phabricator.kde.org/D21415
2019-06-04 20:45:27 +03:00
Nate Graham
adb9998988 [PlasmaComponents3] Vertically center button text as well
Summary:
The PC3 Button's Label didn't have `Layout.FillHeight: true` set, so button text was not actually
getting vertically centered in certain circumstances. This patch fixes that.

Found while working on D21503.

Test Plan:
Before: {F6860487, size=full}

After: {F6860486, size=full}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21502
2019-06-03 10:06:47 -06:00
l10n daemon script
b3bb412ef3 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.59.0 release. 2019-06-01 16:41:42 +00:00
Aleix Pol
09fa87a7b7 Revert "Pass fully-qualified arguments and return values to moc"
This could break old-style connects. Let's keep it as it was until KF6
as discussed in the channel. Thanks frinring for pointing it out.

This reverts commit f631aec33f.
2019-05-30 16:05:36 +02:00
Aleix Pol
0b18d4f0b3 Don't modify a temporary object
Summary: Instead copy the object, operate it and update it into the object.

Test Plan:
just used plasma shell and ran the tests. I'm not sure who uses this.
Issue found with clazy.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21483
2019-05-30 15:38:35 +02:00
Aleix Pol
f631aec33f Pass fully-qualified arguments and return values to moc
Summary: Otherwise it thinks it's different types.

Test Plan: tests pass, plasmashell works

Reviewers: #plasma, #frameworks, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21480
2019-05-30 15:38:09 +02:00
Noah Davis
fb8f02de76 Make Breeze Light/Dark use more system colors
Summary: Closes T8755

Reviewers: #vdg, #plasma, mart, filipf

Reviewed By: #vdg, filipf

Subscribers: filipf, lavender, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T8755

Differential Revision: https://phabricator.kde.org/D21378
2019-05-29 20:46:08 -04:00
Aleix Pol
756a21a6ff Fix warnings
Don't pass objects to lambdas that get unused.
Don't connect to lambdas without specifying the target object, if an object
reference is passed to the lambda.
2019-05-29 16:23:29 +02:00
David Edmundson
39d1db6e49 Export SortFilterModel sort column to QML
Test Plan: Used in model

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21419
2019-05-27 08:03:28 +01:00
Friedrich W. H. Kossebau
e99f653113 plasmacore: fix qmldir, ToolTip.qml no longer part of module
Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21350
2019-05-24 15:08:48 +02:00
Marco Martin
cb8bdb8edd signal availableScreenRectChanged for all applets
if the connect is done in containmentinterface only contaiments
will be able to see the rect changing, while applet would access it but
not be able to detect changes
2019-05-23 13:18:00 +02:00
Friedrich W. H. Kossebau
b0850b1f6f Use simply configure_file to generate the plasmacomponents3 files
Reviewers: #plasma, mart, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21349
2019-05-23 00:17:52 +02:00
Friedrich W. H. Kossebau
3b950f38cc Update *.qmltypes to current API of QML modules
Reviewers: #plasma, apol, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21001
2019-05-17 18:38:10 +02:00
l10n daemon script
d624218a18 GIT_SILENT Upgrade KF5 version to 5.59.0. 2019-05-15 09:23:33 +00:00
Friedrich W. H. Kossebau
f008615e37 FrameSvg: also clear mask cache on clearCache()
Summary:
It can be unexpected that those are not reset when clearCache() was called.

With the current logic when a theme changes the mask cache not reset also
results in wrong lookups, as the cacheid used as key does not include the
theme name.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21172
2019-05-14 17:08:29 +02:00
Friedrich W. H. Kossebau
8899389c9f FrameSvg: make hasElementPrefix() also handle prefix with trailing -
Summary:
there are a few places which potentially pass a prefix with a trailing -,
e.g. if using directly the value of FrameSvg::prefix() or
FrameSvg::actualPrefix(). Support the assumption in such code, unbreaking
its currently not working behaviour.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21174
2019-05-14 17:08:00 +02:00
Friedrich W. H. Kossebau
6af447a848 FrameSvgPrivate::generateBackground: generate background also if reqp != p
Summary:
d8a1a9eb08 changed the condition from
hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix)
but it is not clear why, as the background is generated from the prefix
data & the requestedPrefix is no-where in effect.
As a result sometimes the background is not rendered for a given
not-existing requestedPrefix which was mapped to an empty prefix instead.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21175
2019-05-14 17:07:24 +02:00
Friedrich W. H. Kossebau
1bc1994dfe FrameSvgItem: emit maskChanged also from geometryChanged()
Summary:
Needed e.g. to fix the missing update of the mask on changing the size of
the Plasma panel if only listening to mask changes.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21201
2019-05-14 15:10:27 +02:00
Friedrich W. H. Kossebau
193775def6 FrameSvg: prevent crash when calling mask() with no frame yet created
Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21200
2019-05-14 15:10:07 +02:00
Friedrich W. H. Kossebau
084ba0f886 FrameSvgItem: emit maskChanged always from doUpdate()
Summary:
In that method we can assue a high chance that the mask is also affected.
Instead of adding complicated additional code to track if the mask
really changed, we rely on the cached value from FrameSvg.
This method is not too often called in a Plasma session, so that
further optimization work to avoid unneccesary emits seems not yet
worth it.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21179
2019-05-13 23:47:25 +02:00
Friedrich W. H. Kossebau
9142155b5a API dox: note for FrameSvg::prefix()/actualPrefix() the trailing '-'
Reviewers: #plasma, dhaumann

Reviewed By: dhaumann

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21173
2019-05-13 23:44:58 +02:00
Marco Martin
4498ba9fb9 a kf6 comment 2019-05-13 11:25:22 +02:00
David Edmundson
0bd2ea178f Add test for buttons with icon height 2019-05-13 09:54:44 +01:00
Friedrich W. H. Kossebau
0f65c95771 API dox: point to Plasma5 versions on techbase if avail 2019-05-13 01:09:26 +02:00
Friedrich W. H. Kossebau
fca08ef241 FrameSvg: l & r borders or t & b don't need to have same height resp. width
Summary:
The specification for FrameSvg does not require that all borders exist
or that left & right and top & bottom borders have samples with the same
size in the scalable dimension.
The old assumption in the code broke e.g. themes which had special
variants per screen side for the panel-background and left out elements
for the border side which would not be rendered anyway, but only set a
margin-hint. So e.g. for a panel on the east screen edge, without the
left border element set, leftHeight would be 0 and as result also the
right border not be painted due to an empty size.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21106
2019-05-10 01:13:23 +02:00
l10n daemon script
ff8ac120cb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-05-08 05:45:12 +02:00
l10n daemon script
9100f847af GIT_SILENT Upgrade ECM and KF5 version requirements for 5.58.0 release. 2019-05-04 22:46:43 +00:00
Friedrich W. H. Kossebau
7f4e171ef7 PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface
Summary: The Q_PLUGIN_METADATA IID should be the one of the implemented interface.

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D21000
2019-05-04 01:48:46 +02:00
Friedrich W. H. Kossebau
c8fe7bc5ac IconItem: remove remaining & unused smooth property bits
Summary: fix-up for 18a2ca50ab

Reviewers: #plasma, davidedmundson, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20999
2019-05-04 01:48:12 +02:00
Kai Uwe Broulik
91024027b0 [Dialog] Add CriticalNotification type
Allows to flag a dialog window as critical notification that should be shown even on top of fullscreen windows

Differential Revision: https://phabricator.kde.org/D20630
2019-05-02 10:15:57 +02:00
l10n daemon script
d82a27d395 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-05-01 05:58:07 +02:00
l10n daemon script
58d8fc6dd5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2019-04-29 05:32:30 +02:00
Noah Davis
176643f48c Fix wrong group names for 22, 32 px in audio.svg
Summary: Before this fix, the system tray audio widget would try to use the 32px icons where 22px icons should be used.

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20825
2019-04-25 14:01:21 -04:00
Kai Uwe Broulik
1b2424879a [Window Thumbnail] Also monitor scene visibility and clean up
Just because the item is visible doesn't mean the window itself is. Keep track of the window it's in.
Use itemChange instead of connects and move the check for starting to startRedirect so we don't have to check the conditions
for that in every change handler (visible && enabled && window->visible). It also saves three connects in the constructor.
Also, don't unredirect if we didn't redirect in the first place to avoid warnings printed on console.

BUG: 406303

Differential Revision: https://phabricator.kde.org/D20805
2019-04-25 15:04:20 +02:00
Marco Martin
9aeaf7cbb5 make the mobile text toolbar appear only on press 2019-04-24 11:54:53 +02:00
Marco Martin
bdb2783b0d use the new Kirigami.WheelHandler 2019-04-23 10:34:08 +02:00
Noah Davis
b5ec56091e Add more icon sizes for audio, configure, distribute
Summary: The tooltip for the audio system tray widget and panel edit mode had blurry versions of these icons because the icons were being scaled to fit.

Test Plan:
audio.svg: {F6783458, size=full}

configure.svg: {F6783423, size=full}

distribute.svg: {F6783424, size=full}

Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20695
2019-04-22 08:42:19 -04:00
Friedrich W. H. Kossebau
170ff5668f [FrameSvgItem] Update filtering on smooth changes
Summary:
When just the smooth property is changed, this also results in a call of
QQuickItem::updatePaintNode reimplementations. So always just set the
filtering flag to match the current value of the smooth property.

Reviewers: #plasma, broulik, mart

Reviewed By: #plasma, broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20579
2019-04-18 13:04:17 +02:00
Friedrich W. H. Kossebau
084edba0db Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"
Summary:
During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3

As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".

Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.

Reviewers: #plasma, #vdg

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20602
2019-04-17 22:16:29 +02:00
Noah Davis
cdad9c38c1 Fix stylesheet support for audio-volume-medium 2019-04-17 14:10:54 -04:00
Noah Davis
bd8264e928 Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons
Test Plan:
media.svg: {F6777018, size=full}

drive.svg: {F6777019, size=full}

plasmavault_error.svg: {F6777022, size=full}

plasmavault: {F6777023, size=full}

list.svg: {F6777025, size=full}

go.svg: {F6777028, size=full}

audio.svg: {F6777029, size=full}

edit.svg: {F6777030, size=full}

Reviewers: #vdg, #plasma, broulik, ngraham

Reviewed By: #vdg, #plasma, broulik, ngraham

Subscribers: broulik, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20623
2019-04-17 13:52:31 -04:00
Noah Davis
0ff81fe4c7 Align z's to pixel grid in system.svg
Summary: This does the same thing as D20586, but for the Breeze desktop theme. The diff shows a lot of changes because I optimized the SVG.

Test Plan: Looks exactly the same as D20586

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20597
2019-04-16 08:46:00 -04:00
Marco Martin
8431223542 use the mobiletextcursor from proper namespace 2019-04-16 11:21:34 +02:00
Kai Uwe Broulik
2a636d6671 [FrameSvgItem] Respect smooth property
This ensures the textures are rendered smoothly, especially when rotated.

Differential Revision: https://phabricator.kde.org/D20570
2019-04-15 12:46:12 +02:00
Friedrich W. H. Kossebau
b9ac83d4d7 Oxygen desktoptheme: add padding to hands, against jagged outline on rotation
Reviewers: #vdg, #plasma, ngraham

Reviewed By: #vdg, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20550
2019-04-15 11:27:29 +02:00
Friedrich W. H. Kossebau
18a2ca50ab SvgItem, IconItem: drop "smooth" property override, update node on change
Summary:
QQuickItem already has a "smooth" property, which was shadowed by the
custom ones with the same name. As the property was not part of public
symbols, but instead is dynamically looked up without the class name part
of the property, we just remove the custom versions and instead switch
all custom code to use the inherited property.

While doing that the code is also fixed to properly update the
textureNodes to the current value of the "smooth" property.
As well as not set the filtering only on the texture, when it is passed
to a texturenode which will set its own filtering state to the texture
right before the bind call and thus wipe any previous direct setting
of the filter mode on the texture.

This also changed the default to smooth=true for SvgItem, though
effectively smooth was always true, as the texturenode was hardcoded
to get a QSGTexture::Linear filtering (which, as said above, is forced
onto its texture, no matter what was otherwise set before).

Reviewers: #plasma, davidedmundson, mart

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D20510
2019-04-15 00:03:28 +02:00