Commit Graph

15496 Commits

Author SHA1 Message Date
Niccolò Venerandi
8b5e093141 Added Page element
Summary: Page element was missing. I added it.

Reviewers: #plasma, ngraham, mart

Reviewed By: #plasma, ngraham, mart

Subscribers: ngraham, davidedmundson, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28466
2020-04-03 17:14:13 +02:00
Nicolas Fella
bc3ccd1782 [pc3/busyindicator] Hide when not running
Summary: When not running the indicator should be invisible. This matches the behaviour of the org.kde.desktop style.

Test Plan: Run KTrip with Plasma style. Open location search page. Indicator is only shown when actually loading things

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28391
2020-03-29 23:37:59 +02:00
l10n daemon script
b7e88d2a11 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-03-29 07:06:26 +02:00
l10n daemon script
f6bb0229b0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2020-03-27 06:24:35 +01:00
David Faure
2e017f501a GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT 2020-03-25 00:55:58 +01:00
Nate Graham
e2a13e9ac7 Revert "Make animation durations consistent with Kirigami values"
This reverts commit 049978008b.

This commit changes existing animation durations, and must be landed
simultaneously with Plasma 5.19's release so that rolling release
users don't suffer from very slow animations for a month. Will
re-land after Plasma 5.59 is tagged so it gets released with Frameworks
5.60, the dependency version for Plasma 5.19.
2020-03-24 08:36:30 -06:00
Noah Davis
f363a06ae6 Update window-pin, Add more sizes, Remove redundant edit-delete
Summary:
16 and 22px sizes added for window-pin and unpin. Style was also updated for window-unpin.

edit-delete is redundant because it's already defined in edit.svg. I don't think it's used anywhere at all. It was actually window-close, but renamed to edit-delete for whatever reason.

Test Plan:
{F8195527, size=full}

1. Install patch to kdesrc-build environment
2. Run `plasmashell --replace &` in kdesrc-build environment
3. Check pin button in systray

Reviewers: #vdg, #plasma, cblack, ngraham

Reviewed By: #vdg, cblack, ngraham

Subscribers: cblack, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28228
2020-03-23 19:10:41 -04:00
Nate Graham
049978008b Make animation durations consistent with Kirigami values
Summary:
Right now longDuration is 120ms and shortDuration is 24ms. This presents three problems:
- The durations are far too fast, especially shortDuration, which is so fast that it seems like there is no animation at all.
- The durations are not consistent with Kirigami, which uses 150 for short and 250 for
 long.
- There is no longer value available, as with the one being added to Kirigami in D28143.

Accordingly, this patch makes the short and long values consistent with Kirigami's values,
and adds a new `veryLongDuration` value to match the one being added to Kirigami in D28143.

Reviewers: #plasma, davidedmundson, mart

Reviewed By: #plasma, mart

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28144
2020-03-20 09:43:45 -06:00
Niccolò Venerandi
7d80f01c31 WIP: Create a new TopArea element using widgets/toparea svg
Summary:
This creates a new component that uses the widgets/toparea svg. First time I try to add something to PlasmaComponents, so I probably got stuff wrong and I probably have to still do thing like adding documentation. I'm creating the diff to get feedback on how to move forward with this.

Depends on D27444

Reviewers: mart, ngraham

Reviewed By: mart, ngraham

Subscribers: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D27695
2020-03-14 19:46:48 +01:00
Niccolò Venerandi
f55f104447 Added plasmoid heading svg
Summary: Adds plasmoid heading for D27189

Reviewers: #vdg, ngraham, ndavis

Reviewed By: #vdg, ngraham

Subscribers: mart, kde-frameworks-devel

Tags: #frameworks

Maniphest Tasks: T10470

Differential Revision: https://phabricator.kde.org/D27444
2020-03-14 19:46:11 +01:00
l10n daemon script
a52b60a58e GIT_SILENT Upgrade KF5 version to 5.69.0. 2020-03-12 10:48:23 +00:00
Marco Martin
6f34838f97 make highlighted property work for roundbutton 2020-03-12 10:09:04 +01:00
l10n daemon script
5a1b7a49d8 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release. 2020-03-07 08:55:32 +00:00
l10n daemon script
efebec9744 GIT_SILENT Upgrade KF5 version to 5.68.0. 2020-03-07 08:43:26 +00:00
l10n daemon script
7387f52ad9 GIT_SILENT Upgrade KF5 version to 5.69.0. 2020-03-06 23:07:59 +00:00
Marco Martin
0b89e7f3f0 Buttons: allow to scale up icons
Summary:
always scale icons unless a size is specified in the api.
this makes icon sizing more in line with plasma components 2

Test Plan:
{F8129062}

{F8129064}

{F8129065}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27628
2020-03-02 14:42:15 +01:00
David Redondo
b7fa6e0e91 Try to apply the colorscheme of the current theme to QIcons
Summary:
Before icons loaded internally with QIcon::fromTheme were being colored with the
colors from the current global color scheme instead of the ones from the current
Plasma Theme. Leading to visual bugs when the two differ. This happened because
KIconLoader uses the global color scheme by default.
A prominent case is the notification send by the network plasmoid when one
successfully connected to a wireless network. It sets the icon
"network-wireless-on" which is not included in Breeze icons (but is included in
Breeze Plasma Theme). If the current icon theme is indeed Breeze, IconItem
resorts to using QIcon::fromTheme and we end up with a wrong colored
"network-wireless" icon.

BUG: 417780

Test Plan:
{F8125752}

{F8125753}

Reviewers: #plasma, cblack, ngraham, mart

Reviewed By: #plasma, cblack, ngraham, mart

Subscribers: mart, wbauer, cblack, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27589
2020-03-02 11:55:35 +01:00
Friedrich W. H. Kossebau
a08449a9a2 templates: Convert license statements to SPDX headers
Summary: Also consistently use LGPL-2.1-or-later as default license

Reviewers: #plasma, cordlandwehr

Reviewed By: cordlandwehr

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27640
2020-02-29 13:25:01 +01:00
Daniel Vrátil
b6213cdd59
Dialog: disconnect from QWindow signals in destructor
Summary:
When Dialog is being destroyed, its QWindow super-class may still emit
some signals from its destructor. Dialog is connected so some of them,
so this leads to Qt invoking slots on Dialog, whose destructor has
already been called, leading to crashes.

This patch disconnects all internal connections in Dialog's destructor.

See https://phabricator.kde.org/D23339 for details.

Test Plan: Plasma no longer crashes when a notification appears

Reviewers: #plasma, nicolasfella, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27671
2020-02-26 10:00:45 +01:00
George Vogiatzis
10c112fccd [PlasmaComponents]Clean up ListItem code
Summary:
Removed two unused lines.
Removed old comments.
Minor style changes to comments.

Test Plan: Everything must stay unchanged visually and function wise for ListItems.

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27296
2020-02-25 21:00:02 +02:00
Daniel Vrátil
1e11099c16
Fix initialization order
Reviewers: #plasma, #frameworks, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27627
2020-02-25 14:32:06 +01:00
Daniel Vrátil
4b93b71a49
Fix memory leak in ConfigView and Dialog
Reviewers: #plasma, #frameworks, apol, davidedmundson

Reviewed By: apol, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D23339
2020-02-25 14:31:28 +01:00
Nate Graham
6b8f114284 Port away from Title and towards level 1 Heading
Summary: `Title` is deprecated.

Test Plan: No visual changes anywhere; level 1 Heading is identical in appearance

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27350
2020-02-21 08:39:25 -07:00
Marco Martin
ba0b637de9 fix layout size hints for button labels
Summary:
icon sizes and label placements tested correct in  several scenarios

* control.icon.width/height is used as maximum size of the icon
* if the button is smaller icons always scale down
* icons stay ccentered regardless of button size when there is no text

Test Plan:
fixes icon sizes without workarounds like D27260
{F8108705}

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27460
2020-02-19 12:12:41 +01:00
Laurent Montel
9f02cf685a Use no deprecated qprocess api 2020-02-17 16:44:25 +01:00
Marco Martin
667dce502a make sure the size hints are integer and even
Summary:
for retrocompatibility with pc2 units.gridUnit * 1.6 is used
a lot as size hint (we have to guarantee buttons and
textfields have the same height by default for perfect
horizontal alignment.
tough we have make sure that size is integer and even otherwise
we'll have a lot of internal misalignments

Reviewers: broulik

Reviewed By: broulik

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27399
2020-02-14 13:55:21 +01:00
Marco Martin
3de1c2462e support icon.width/height
Summary:
support the icon size hint of the control. Reinstate it in ToolButton
and add the support for the other controls
CCBUG:417514

Test Plan:
possible to control buttons icon sizes
mediacontroller taskbar tooltip with icons set to small:
{F8103363}

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27396
2020-02-14 12:37:42 +01:00
Niccol Venerandi
1ed47e7c41 Remove hardcoded colors
Summary:
Fixes https://www.reddit.com/r/kde/comments/f2mxd3/517_seeing_weird_white_corners_on_my_autohiding/

BUG:417511

Reviewers: ndavis

Reviewed By: ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27354
2020-02-13 18:18:09 +01:00
Kai Uwe Broulik
1dc36bc2ce Construct NullEngine with KPluginMetaData()
The deprecated constructor taking a KPluginInfo unconditionally calls toMetaData() and then asserts.

BUG: 417548

Differential Revision: https://phabricator.kde.org/D27366
2020-02-13 15:21:49 +01:00
Marco Martin
97d431270d remove broken references 2020-02-12 18:14:23 +01:00
Marco Martin
655cc40db8 fix TabButton 2020-02-12 17:10:40 +01:00
Nate Graham
a9ea008b8d Slightly reduce level 1 heading size
To match the change agreed to in https://phabricator.kde.org/D27198
2020-02-12 08:04:53 -07:00
Marco Martin
1b1dc79dc4 Revert "Make the attached property a simple QObject"
This reverts commit 68a273aef6.

introduced regressions in several places
2020-02-12 12:00:21 +01:00
Laurent Montel
2961144640 GIT_SILENT: qtcreator created .cmake/ repo. 2020-02-12 07:18:27 +01:00
Friedrich W. H. Kossebau
2e3cc7e8dd Use ecm_qt_install_logging_categories over manual categories file 2020-02-12 04:09:12 +01:00
Nate Graham
9d27675c3b Vertically center tooltip icon/image
Summary:
Right now the widget tooltip's icon/image is top-aligned, which in practice makes it
vertically centered when the tooltip has only one line of text, but not vertically
centered when there are two lines of text.

This patch makes it vertally centered all the time, improving the appearance.

Test Plan:
Before: {F8095695}

After: {F8095696}

{F8095697}

Reviewers: #vdg, #plasma, filipf, ndavis

Reviewed By: #vdg, filipf, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27299
2020-02-10 11:17:30 -07:00
Marco Martin
2b78afd921 support display property for Buttons
tested on buttons, toolbuttons and tabbuttons
2020-02-10 18:42:11 +01:00
Marco Martin
014c3fd104 revert unrelated changes in previous commit
Button and ToolButton were't supposed to be touched by previous commit
2020-02-10 17:00:36 +01:00
Marco Martin
68a273aef6 Make the attached property a simple QObject
Summary:
move all the logic in an attached property QObject
it's a bit less heavy to create so should make things slightly better
when this is used in delegates

Test Plan: Plasmoid background removal (with colors inversion) still works

Reviewers: bshah, #plasma

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27200
2020-02-10 16:49:55 +01:00
David Faure
8e786761fe GIT_SILENT increase KF_DISABLE_DEPRECATED_BEFORE_AND_AT 2020-02-09 20:28:19 +01:00
l10n daemon script
1584a0f234 GIT_SILENT Upgrade KF5 version to 5.68.0. 2020-02-09 11:03:54 +00:00
Nate Graham
b76b908e10 Don't warn for invalid plugin metata
Summary:
See explanation in https://bugs.kde.org/show_bug.cgi?id=412464

BUG: 412464
FIXED-IN: 5.67

Test Plan: restart plasmashell, see way less useless warning spam

Reviewers: #plasma, mart, apol

Reviewed By: apol

Subscribers: apol, alex, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27080
2020-02-07 06:34:07 -07:00
Marco Martin
0c897d8048 tooltips always have normal colorgroup 2020-02-05 12:28:34 +01:00
George Vogiatzis
dccf6c4dd6 [Tests]Make radiobutton3.qml use PC3
Summary: Correct test radiobutton3.qml to use Plasma Components 3 instead of 2.

Test Plan:
Run `qmlscene radiobutton3.qml`
Before:
Misaligned button and big height. (bug in PC2 radiobutton)
After:
Correct height and alignment between button and button's text.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, davidedmundson, ndavis, kde-frameworks-devel

Tags: #frameworks, #plasma

Differential Revision: https://phabricator.kde.org/D27082
2020-02-04 11:14:14 -07:00
Johnny Jazeix
2ea27fb068 fix compilation + remove duplicate in src 2020-02-04 08:32:05 +01:00
Tranter Madi
f8be3ea710 Optimize code when dropping files into the desktop
Summary:
Currently, when you have the desktop in the Desktop layout, if you drop 10 jpg files into the desktop, it creates 10 menus at the same position.
When you have the desktop in the Folder layout, if you drop 10 jpg files into the desktop, it calls `KIO::setApplicationActions()` 10 times.

What does this improve?

- Do not create KIO::MimetypeJob for each file
- Do not call `DropJob::setApplicationActions()` too many times/ create too many menus for each file.

My idea is that, when you drop files into the desktop:
- If they have the same `mimetype` -> we add actions support this `mimetype`.
- If not -> we only show the action from `KIO::DropJob` and only actions support different `mimetypes` at the same time like `Add icon`...

**Require:** D26484
CCBUG: 415917

Reviewers: #plasma, mart, broulik, #vdg, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26691
2020-02-04 12:54:38 +07:00
l10n daemon script
8974252e42 GIT_SILENT Upgrade ECM and KF5 version requirements for 5.67.0 release. 2020-02-01 09:08:38 +00:00
Niccol Venerandi
f7b4bbf861 Fixed tooltip corners and removed useless color attributes
Reviewers: ndavis

Reviewed By: ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27075
2020-01-31 23:17:03 +01:00
Niccolò Venerandi
ffbd186975 Removed hardcoded colors in background SVGs
Summary: Alternative and more basic patch to D26955, this aims to fix the background color without breaking the mask

Reviewers: #vdg, #plasma, ndavis

Reviewed By: #vdg, ndavis

Subscribers: ndavis, ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26968
2020-01-28 11:58:11 -05:00
Noah Davis
ad625f68f3 Fix the size and pixel alignment of checkboxes and radiobuttons
Summary:
The checkboxes and radio buttons in plasmashell were signficantly different from checkboxes and radio buttons in the Breeze QStyle. This patch is needed to make D26271 look nicer.
- Plasmashell checkboxes and radio buttons were much larger.
-- 24x24 for checkboxes and 29x29 for radio buttons (Plasmashell) vs 16x16 (QStyle).
- Pixel alignment was very poor.
-- Checkbox indicator was 14x14, stretched to 24x24.
-- Radio button background was 22x22 or 32x32, adjusted to 29x29.
-- Radio button indicator was 16x16, stretched to 29x29.
- Style was different.
-- Checkbox indicators had sharper corners and less margin around the inner rectangle.
-- Radio buttons had a hardcoded dark gray circular frame and a shadow on the bottom of the inside of the frame.
-- Radio button indicators had less margin around the inner circle.

Test Plan:
{F7891476}

{F7891477}

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, davidedmundson, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D26758
2020-01-28 01:31:07 -05:00