Summary:
We always want the label to have the width managed by the layout to fill
all available space.
Test Plan:
In tests/components/button3.qml the test
"long text but constrained, should be 150px and elided" now is correctly
elided rather than the text spewing past the end of the button. The text
does not overlap the icon.
Reviewers: #plasma, apol, ngraham
Reviewed By: apol, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24909
Summary:
- Move "Panel Options" context menu items out of submenu
- Rename "Configure Panel..." option
See M144, T10047, T10190. This makes the panel customization options much more discoverable.
Test Plan: Open the panel context menu.
Reviewers: #plasma, #vdg, mart
Reviewed By: #plasma, #vdg, mart
Subscribers: davidedmundson, ngraham, #vdg, kde-frameworks-devel, #plasma
Tags: #frameworks
Maniphest Tasks: T10190, T11094, T10402
Differential Revision: https://phabricator.kde.org/D23951
Summary: needed for the context menu entry
Test Plan: with the p-w- portion the action shows in the context menu
Reviewers: #plasma, #vdg, GB_2, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T10190, T11094, T10402
Differential Revision: https://phabricator.kde.org/D24263
Summary:
Allows
* projects linking to Plasma to hide deprecated API up to a
given version or silence deprecation warnings after a given version,
using
* -DPLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DPLASMA_NO_DEPRECATED
* -DPLASMA_DEPRECATED_WARNINGS_SINCE
* -DPLASMA_NO_DEPRECATED_WARNINGS
* -DPLASMAQUICK_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DPLASMAQUICK_NO_DEPRECATED
* -DPLASMAQUICK_DEPRECATED_WARNINGS_SINCE
* -DPLASMAQUICK_NO_DEPRECATED_WARNINGS
or
* -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
* -DKF_NO_DEPRECATED
* -DKF_DEPRECATED_WARNINGS_SINCE
* -DKF_NO_DEPRECATED_WARNINGS
Reviewers: #plasma, mart, davidedmundson, apol, mlaurent
Reviewed By: #plasma, mart, mlaurent
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24678
Summary:
This fixed the background of a checkable PC3 ToolButton not being visible when checked.
The PC3 Button and PC2 ToolButton did not suffer from the issue, but the PC3 one did.
Test Plan:
Checkable PC3 ToolButtons now look checked when checked
No change for non-checkable PC3 ToolButtons
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24402
Summary:
The plans are to switch on/off the whole plasma shell into edit mode.
For this it needs to be a global corona property, rather then just
containmentInterface.
Plasmashell would expose a dbus call to set it from systemsettings
Test Plan: plasmoid.editMode=true still works
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, GB_2, broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24239
Summary:
right now just a subsection of controls are installed under plasmacomponent3
which makes for random missing stuff, especially any new component added.
it was done to avoid to have things like "applicationwindow" which don't make sense
in plasma, tough those are already available anyways as plain qqc2
install the whole folder avoiding many potential headaches
Test Plan: ieverything still works, all the components are available
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D24072
Summary:
Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.
Test Plan:
Empty field
{F7326288}
{F5697017}
{F5697018}
Dolphin
Show hidden files, files are currently hidden
{F5697031}
Hide hidden files, files are currently shown
{F5697032}
Reviewers: #plasma, #vdg, ngraham, broulik, ndavis
Reviewed By: #vdg, ngraham, ndavis
Subscribers: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D10362
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.
I think it is correct that the config might emit a signal just before
closing, and not at fault.
AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.
When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.
This disconnect pattern is already used for guarding self config
changes.
BUG: 411221
Test Plan: kquitapp5 plasmashell, no longer crashes
Reviewers: #plasma, alexeymin
Reviewed By: alexeymin
Subscribers: alexeymin, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23707
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height if those props are set.
Before patch:
{F7274098}
After patch:
{F7274097}
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: broulik, apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23367
Summary:
this makes the toolbutton icons follow a standard size.
Maybe one could make it follow the icon group size props? like icon.width and icon.height if those props are set.
Before patch:
{F7274098}
After patch:
{F7274097}
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23367
Summary:
with the Plasma style buttons which have an icon look wrong. The icon size is too big and in consecuence the whole button is drawn way too big.
With this patch the icon is set to a standard size and drawn in the button layout, in a way it looks consistent with other button with no icons.
example:
Before path:
{F7270612}
{F7270611}
With patch:
{F7270610}
{F7270609}
BUG: 399952
FIXED-IN: 5.62
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23352
Summary:
This is needed so that we don't remove the splash till the wallpaper is
loaded, but also allows doing this in a generic way.
Version 2 of the patch using a normal property.
We need to have the virtual so that the containment waits for the
wallpaper.
Test Plan:
Used with wallpaper patch
Added debug to ensure it happened after the stackview in the wallpaper
is pushed
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22852
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.
BUG: 395390
FIXED-IN: 5.62
Reviewers: #plasma, ngraham, hein
Reviewed By: #plasma, ngraham, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T10047
Differential Revision: https://phabricator.kde.org/D23036
Summary:
This fixes the incorrect initial positioning of the tabs for vertical
tab bars that persisted until the user switched to another tab
manually.
BUG: 395390
FIXED-IN: 5.62
Reviewers: #plasma, ngraham, hein
Reviewed By: #plasma, ngraham, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T10047
Differential Revision: https://phabricator.kde.org/D23036
This is a remnant from when we used a full background on hovered ToolButtons
instead of the frame we have now. It broke icon item appearance when hovered
in a custom ColorScope.
Reviewed-By: notmart
Summary:
Match the duration (2 seconds) that was set in D22630.
This style is mainly used by Plasma Mobile, therefore requesting team review from that project as well.
Reviewers: #vdg, #plasma:_mobile, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22720
Summary: This means they're found by unit tests pre-installation
Test Plan:
Removed installed files
Ran make (but not make install)
ConfigModelTest now passes
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22682
Summary: Changed Highlight to Button focus so that these SVGs wouldn't use the same color as the selection background.
Reviewers: #vdg, #plasma, #breeze, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D22670
