Allows to flag a dialog window as critical notification that should be shown even on top of fullscreen windows
Differential Revision: https://phabricator.kde.org/D20630
Summary: Before this fix, the system tray audio widget would try to use the 32px icons where 22px icons should be used.
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20825
Just because the item is visible doesn't mean the window itself is. Keep track of the window it's in.
Use itemChange instead of connects and move the check for starting to startRedirect so we don't have to check the conditions
for that in every change handler (visible && enabled && window->visible). It also saves three connects in the constructor.
Also, don't unredirect if we didn't redirect in the first place to avoid warnings printed on console.
BUG: 406303
Differential Revision: https://phabricator.kde.org/D20805
Summary: The tooltip for the audio system tray widget and panel edit mode had blurry versions of these icons because the icons were being scaled to fit.
Test Plan:
audio.svg: {F6783458, size=full}
configure.svg: {F6783423, size=full}
distribute.svg: {F6783424, size=full}
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20695
Summary:
When just the smooth property is changed, this also results in a call of
QQuickItem::updatePaintNode reimplementations. So always just set the
filtering flag to match the current value of the smooth property.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20579
Summary:
During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
changed to instead be taken from the theme via the "hint-bar-size":
commit cee9c928e3
As fallback for old themes in absence of the hint the default height
since some time later has been derived from the sum of the heights of
the elements "bar-inactive-top" & "bar-inactive-bottom".
Which though for the Air and Oxygen themes results in the small heights
of respective 10 & 4. As a result the visual appearance of the theme
differs from what people remember of the time when the themes were
designed.
Ideally the theme designer would tune the actual value to something they
prefer. Until then setting the hint to restore the visual appearance over
the currently pretty slim or even too slim one should improve things
already.
Reviewers: #plasma, #vdg
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20602
Summary: This does the same thing as D20586, but for the Breeze desktop theme. The diff shows a lot of changes because I optimized the SVG.
Test Plan: Looks exactly the same as D20586
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20597
Summary:
QQuickItem already has a "smooth" property, which was shadowed by the
custom ones with the same name. As the property was not part of public
symbols, but instead is dynamically looked up without the class name part
of the property, we just remove the custom versions and instead switch
all custom code to use the inherited property.
While doing that the code is also fixed to properly update the
textureNodes to the current value of the "smooth" property.
As well as not set the filtering only on the texture, when it is passed
to a texturenode which will set its own filtering state to the texture
right before the bind call and thus wipe any previous direct setting
of the filter mode on the texture.
This also changed the default to smooth=true for SvgItem, though
effectively smooth was always true, as the texturenode was hardcoded
to get a QSGTexture::Linear filtering (which, as said above, is forced
onto its texture, no matter what was otherwise set before).
Reviewers: #plasma, davidedmundson, mart
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20510
Summary:
The hands of the clocks still relied on the KDE4 times rule that the
position in y-axis relativ to the clock center would define the relative
rotation point for the hands.
With the default in Plasma 5 being (width/2, width/2) from topleft of the
hand shape, using hints of upcoming Plasma 5.16 allows to override that
again to match the original definition, without the need to enlarge
the pixmaps of the hand shapes.
Reviewers: #plasma, mart, ngraham
Reviewed By: ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20496
Summary:
This signal is emitted just before showing the context menu to allow
lazy-loading expensive actions like hasAlternatives.
This emitted by our code whenever we show a context menu from an event
filter, however we want to use this code from a tooltip in D17410
Test Plan:
Hovered over some applets, they correctly enabled/disabled the
alternatives button
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20417
Summary:
The SVG format being based on plain text, storing the SVG in the repository
not as .svgz, but .svg, helps both VCS tools (patching, showing diffs) as
well as allows some developers to edit the SVG directly in any text editor,
not only those which support automatic conversion from/to gzip format.
While most artists will continue (and which shall be okay) to use GUI
editors like inkscape, which might rewrite the complete structure on saving,
using uncompressed format in the repo still allows the occasional direct
edit of the text, .e.g. to change a colour, which then is also easily seen
in the commit diff.
To still keep the svgz format when deployed, a build step is introduced,
which uses gzip to create svgz files in the build dir. This conversion can
be controlled using the option GZIP_DESKTOPTHEME_SVG (default: ON).
Test Plan: Themes are still working (with & without cache removed).
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20166
Summary:
the mobile text selection toolbar uses toolbuttons, which in turn use the
private import. This will make the components loading stuck in dependency
resolution
Test Plan: all loads correctly now
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: hein, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20428
This reverts commit c72ee78bbb.
Broke PlasmaComponents3. Missing files? Error example:
MenuRepresentation.qml:172:5: Type PlasmaComponents3.TextField unavailable
file:///home/eike/devel/install/lib64/qml/org/kde/plasma/components.3/TextField.qml:27:1: "mobiletextselection": no such directory
CCMAIL:notmart@gmail.com
Summary:
The new icon was just added in D20367. The current icon is semantically and visually incorrect,
and the new one fixes that.
The current text also does not begin with an action verb, and this patch fixes that too.
Test Plan:
Before:
{F6759646, size=full}
After:
{F6759647, size=full}
{F6759649, size=full}
Reviewers: #vdg, #plasma, GB_2, filipf
Reviewed By: #vdg, GB_2, filipf
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20392
Summary:
This property allows e.g. the Plasma shell to query the shape a panel has
when defining the area for BlurBehind.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20202
this avoids a qml type resolution recurtion which can
in some cases stuck the component to loading forever
this was particularly visible in plasma mobile
On plasmashell shutdown when the panels are destroyed, the available screen geometry changes.
When an applet then accesses screenGeometry in response to that change, it crashes because the corona is already gone.
availableScreenRegion() and availableScreenRect() already checked for this but screenGeometry() did not
Differential Revision: https://phabricator.kde.org/D20244
Dialog has this clever way of re-sending a mouse event inside the bounardies of the dialog,
so despite visual padding, the items can be clicked on any corner following Fitt's law.
However, when the mainItem has no size, adjusting the position will adjust it inside the border
since there is no pixel inside the main item, leading to infinite recursion as the event is
processed again and again and again leading to a crash.
Differential Revision: https://phabricator.kde.org/D20200
It casted the QAction to a MenuItem which fails because it isn't such.
Instead, manually find the item with the corresponding action.
Differential Revision: https://phabricator.kde.org/D20199
Uses the one from ColorScope rather than Kirigami.
Kirigami.Theme isn't used in any other Plasma Components 3 and the opacity already changes for when it's disabled
Differential Revision: https://phabricator.kde.org/D20070
Summary:
FrameSvg updates the margins e.g. on a Theme change already in its
internal event handling before the methods of FrameSvgItem are invoked.
Due to that CheckMarginsChange guards before this change could not detect
any changes, and thus missed to trigger an update via the margin objects
to the QtQuick world.
So when changing the theme e.g. in a Plasma shell or in the Plasma Theme
Explorer, existing FrameSvg items are using outdated margins, resulting
in broken display.
By keeping a copy of the last seen margins as part of the item and not only
per method, changes outside the FrameSvgItem items can be properly detected.
Test Plan:
Switch Plasma themes between Air, Breeze & Oxygen, see how different margins
are reflected in the widgets sizes instantly.
Switch Plasma themes in the Plasma Theme Explorer, with "Show Margins"
enabled, see how margins are always correctly updated intead of taking the
value of the last theme used.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19743
Summary:
Allows themes to disable the blurring of what is behind panels,
if they either do not need it (being fully opaque) or by design want
non-blurry transparency.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19907
Summary:
The old logic results in broken rendering if the sample was bigger than the
area to render, due to normalized texture rect being 0 in the respective
dimansion. As well as stretched mapping of the sample for fractional
relationships between the area to render and the sample size.
Test Plan:
Borders of backgrounds of FluffyBunny theme render properly, no other
regressions seen (but unsure what else might rely on that artifact).
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: apol, sitter, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19787
Summary:
style elements without type="text/css" were ignored before, but now they act as
if type was set. Set id and style properly to restore the working behaviour.
BUG: 405548
Test Plan:
Installed new files on a system with Qt 5.12.2, wiped the SVG cache
and it looks fine again.
Reviewers: #plasma, rooty
Reviewed By: rooty
Subscribers: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19821
When changing an IconItem from using a local image (e.g. PNG file) to using a Plasma themed icon,
the implicit size wasn't updated since the old image was still loaded in m_imageIcon.
Clearing it when clearing the other icon stores fixes this.
BUG: 405298
Differential Revision: https://phabricator.kde.org/D19674
Summary:
as the implicit height could change when switching to password mode,
use a textmetrics which always computes it from the visible text
BUG:399155
Test Plan: height doesn't change
Reviewers: #plasma, ngraham, rooty
Reviewed By: ngraham, rooty
Subscribers: sitter, rooty, ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19599
Plasma Dialog used to change the item's visiblity but this is no longer the case, so it would animate when a window is shown and
the source has changed in the meantime.
Differential Revision: https://phabricator.kde.org/D19421
Summary: Currently it just fails silently.
Test Plan: Loaded a plasmoid with an incompatible plugin, warning is shown.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel, plasma-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19394
Summary: This patch adds new icons for the action buttons modified/added in D18893, and gives the suspend hibernate and switch user icons a makeover.
Test Plan:
{F6621871}
Other..: {F6621331} {F6621867}
List Users: {F6615519} {F6621869}
Reviewers: #vdg, #plasma, ngraham, abetts
Reviewed By: #vdg, ngraham
Subscribers: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19020
Summary:
The old style was weird. When the screen edge feature was enabled for the sides of screens, it looked like a bunch of dots smooshed together. Now it's one smooth bar.
BUG: 391343
FIXED-IN: 5.56
Test Plan:
Before {F6599392} {F6599445, size=full}
After {F6599389} {F6599444, size=full}
Reviewers: #vdg, rooty
Reviewed By: rooty
Subscribers: rooty, rapiteanu, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D18834
When a theme doesn't supply background contrast values, we take an educated guess based on whether it's a dark or light theme.
We didn't update the values when switching only color schemes at runtime (when theme follows it).
This lead to washed out Plasma popup and panel backgrounds. Instead, compute the fallback value at runtime.
Also, while at it, update complimentary colorscheme as well, which was forgotten here.
BUG: 401142
Differential Revision: https://phabricator.kde.org/D18487
Summary:
This patch aims to make the corners of the dialog/notification backgrounds (dialogs/background.svgz) more rounded and more in keeping
with the Breeze window decoration theme.
Test Plan:
Before: {F6568854}
After: {F6568855}
Before (Breeze Dark, no //Background contrast effect//): {F6569235}
After (Breeze Dark, no //Background contrast effect//): {F6569236}
Using the Background Contrast Kwin effect adds a weird dark background to all the dialogs and the corners aren't rounded anymore:
{F6568856} and these strange dots appear instead (a rectangle bleeding through?)
{F6568352}
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D18545
Especially since the Theme isn't modified in any way but just used to read some data.
While the Private part of Theme is already shared, creating a Theme instance still has some setup cost.
Differential Revision: https://phabricator.kde.org/D18149
Summary:
This patch gives the clock's hour hand a shadow for the spindle too, since the shadow model we're using should logically have the spindle casting a shadow.
It also also increases the height of the minute hand shadow since its current length is short enough that it sometimes doesn't connect to anything.
CCBUG: 396612
Test Plan:
Before: {F6551256}
After: {F6551257}
There are no visual changes whatsoever because the hour hand shadow is not currently displayed (See D17751 for background)
Reviewers: #vdg, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D18288
Summary:
This patch turns off light font styles for some headings because they cause visual and legibility issues, as explained in the respective bug report.
BUG: 402730
FIXED-IN: 5.54
Test Plan:
**//Worst case scenario testing//** - font does not have a "light" variant and falls back to using a thinner one such as "hairline"
**Before:**
{F6520036}
{F6520035}
{F6520034}
**After:**
{F6520039}
{F6520038}
{F6520037}
**//Plasma defaults testing//**
**Before**:
{F6520778}
{F6520777}
{F6520776}
**After:**
{F6520781}
{F6520780}
{F6520779}
Reviewers: ngraham, #plasma, #vdg, #frameworks
Reviewed By: ngraham, #vdg
Subscribers: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17905
The item's visible property is independent of the window visibility, which can be checked using Window.visible.
Differential Revision: https://phabricator.kde.org/D17543
Otherwise we'll keep piling up custom tooltip items in the dialog. They're invisible but they're still there.
Differential Revision: https://phabricator.kde.org/D17542
This allows for calendar widgets to override the Locale. Users may
want to start the week on a Sunday, Saturday, or Monday without
changing their locale's date formatting.
CCBUG: 390330
Differential Revision: https://phabricator.kde.org/D15321
Summary: It's exactly the same as the regular 32px bluetooth icon in this file, but D17346 needs it.
Reviewers: #vdg, #plasma, broulik, ngraham
Reviewed By: #vdg, #plasma, broulik, ngraham
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17505
Summary:
Leverages QSharedPointer for the reference counting.
Keeps the last value of the cacheId, as it can change sometimes and crash
the system.
Reviewers: #plasma, #frameworks, zzag
Reviewed By: #plasma, zzag
Subscribers: mart, zzag, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D17052
KPackagePrivate::internalPackage already existed, the re-assignment to a
new value causes a memory leak.
Trace:
Indirect leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/install/kf5/bin/plasmashell+0x544cc0)
#1 0x7f905829163f in KPackage::Package::Package(KPackage::PackageStructure*) /home/kfunk/devel/src/kf5/kpackage/src/kpackage/package.cpp:51:9
#2 0x7f9058fad786 in Plasma::Package::Package(Plasma::PackageStructure*) /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/package.cpp:66:34
#3 0x7f9058f14dee in Plasma::Corona::package() const /home/kfunk/devel/src/kf5/plasma-framework/src/plasma/corona.cpp:78:13
#4 0x5d9eb9 in ShellCorona::ShellCorona(QObject*) /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellcorona.cpp:132:70
#5 0x65c31d in ShellManager::loadHandlers() /home/kfunk/devel/src/kf5/plasma-workspace/shell/shellmanager.cpp:93:21
When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute
plasmoid infrastructure these days and didn't work.
Differential Revision: https://phabricator.kde.org/D16301
Without this, ToolButton.qml (Plasma Components 3) is not installed and
applets like the mediacontroller do not load because they can't find it.
The line has been removed in 6126954816,
and it looks like an unrelated change.
Marco, feel free to revert if the proper solution is different.
CCMAIL: notmart@gmail.com
Summary:
in QQC2 the text selection controls depend upon the style, which has to
implement it by itself
this adds touch based draggable cursor and text selection handles,
alongside a tiny toolbar for cut/copy/paste
the desktop style will need the exact same thing
T10023
Test Plan:
works correctly when in tablet mode, none of this is visible
when in desktop mode where the text fields behave normally
Reviewers: #plasma, bshah
Reviewed By: #plasma, bshah
Subscribers: ngraham, abetts, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D16841
Summary: The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not match the Breeze and BreezeDark colorschemes in the breeze repo. For instance, the breeze-dark Plasma theme used an ugly yellow-green for ForegroundNeutral instead of Beware Orange like in the Breeze and BreezeDark colorschemes. It also used a much harsher red that looked inconsistent with BreezeDark. I've been using the new colorschemes for the past month and the most noticeable changes are just the new orange and red colors.
Test Plan:
Old:
{F6411526, size=full}
{F6411527, size=full}
{F6411875, size=full}
{F6411889, size=full}
New:
{F6411523, size=full}
{F6411525, size=full}
{F6411883, size=full}
{F6411898, size=full}
Reviewers: #vdg, #breeze, #plasma, mart, ngraham
Reviewed By: #vdg, #breeze, #plasma, mart, ngraham
Subscribers: ngraham, mart, broulik, #vdg, kde-frameworks-devel
Tags: #frameworks, #vdg, #breeze, #plasma
Differential Revision: https://phabricator.kde.org/D16810
It is a remnant of the Plasma Active days and didn't even compile.
This patch only removes those ifdefs, it doesn't fix any issues I found during (e.g. double lookups or the fact
that KRun::autoDelete is the default now)
Differential Revision: https://phabricator.kde.org/D16295
Summary:
At the moment we always look at the first fallback and load the original
theme again, rendering moot the fallback look-up.
Reviewers: #plasma, davidedmundson, hein
Reviewed By: #plasma, davidedmundson, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15970
Summary:
Move the icons from D10937 to plasma-frameworks and combine all the sizes
BUG: 395714
Test Plan: "osd-shutd-screen.svg" does not display correctly for me. I can't find any difference between it and the rest of the icons. Help appreciated.
Reviewers: ngraham, #vdg, broulik
Reviewed By: ngraham, #vdg, broulik
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14971
Summary:
support button icons.
if there is no icon or is Qt 5.9, the iconItem will stay invisible
Test Plan: tested with ported mediacontroller to PlasmaComponents3
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15164
Otherwise when the week starts on a day other than Sunday or Monday we access invalid day names.
CHANGELOG: Fixed week names not showing properly in calendar when week starts with a day other than Monday or Sunday
BUG: 390330
Differential Revision: https://phabricator.kde.org/D15309
Summary:
On Wayland, DialogShadows doesn't attach empty tiles for disabled
borders. Yet, it sets offset of 1 for them. This results in visual
artifacts like this
{F6206088, layout=center, size=full}
//KWin thinks that there is 1px tall shadow in the bottom.//
In general we don't need to pass empty shadow tiles for disabled
borders. Thus, that's fine to set 0 offset for them.
Test Plan:
* Started kwin_wayland:
dbus-launch kwin_wayland --windowed --xwayland
* Launched latte-dock and kate:
unset DISPLAY
QT_QPA_PLATFORM=wayland latte-dock &
QT_QPA_PLATFORM=wayland kate
* Opened calendar popup:
{F6206090, layout=center, size=full}
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14946
Summary:
Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138
with a potential patch for upstream.
With native rendering the alpha is pointlessly also set in the
glBlendFunc despite also being used in the uniform of the shader.
Resulting in a visual bug when used on a window with alpha (such as
Dialog)
It sucks, but we were starting to see people work round it by copying
more invasive workarounds everywhere else which I want to avoid.
BUG: 396813
Test Plan: Looked at a text field
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15021
QIcon is rendered through KIconLoader instead of e.g. Plasma::Svg.
This means we need to recreate the pixmap when the icon theme changes.
CCBUG: 397109
Differential Revision: https://phabricator.kde.org/D14990
Turns out this icon had a hardcoded color in it which wasn't the case for the
full size icon used on my high dpi system.
Thanks Sandro Knauß for helping investigate this
BUG: 397441
Summary: This patch makes the text for removal and configuration actions consistent with one another.
Test Plan: {F6191533}
Reviewers: #plasma, #vdg, abetts
Reviewed By: #plasma, #vdg, abetts
Subscribers: abetts, broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14810
