Commit Graph

81 Commits

Author SHA1 Message Date
Aaron J. Seigo
e1f9f6739a catch when items are scheduled for deletion and are in the next items up in the animation cycle. certainy a potential problem, and possibly/likely the cause of 198338
CCBUG:198338

svn path=/trunk/KDE/kdelibs/; revision=990658
2009-07-02 22:30:47 +00:00
Aaron J. Seigo
df45adfbe9 fix my fix: we can't add items more than once otherwise we double delete them.
BUG:195943

svn path=/trunk/KDE/kdelibs/; revision=979973
2009-06-10 20:31:15 +00:00
Aaron J. Seigo
c250642e44 always remove the item we're going to delete from the main collection, however
svn path=/trunk/KDE/kdelibs/; revision=979140
2009-06-09 03:39:37 +00:00
Aaron J. Seigo
74a6212595 don't delete states when we're running animations: we call into other objects which may decide to stop or start other animations, which would cause double deletes. this one's bugged me (and our users; it's bee reported at least 18 times!) for a good long while, and finally tonight i figured it out :)
BUG:192066

svn path=/trunk/KDE/kdelibs/; revision=979139
2009-06-09 03:37:22 +00:00
Aaron J. Seigo
6804f6fe65 ensure frameInterval isn't zero, prevents div-by-zero
BUG:190218

svn path=/trunk/KDE/kdelibs/; revision=957201
2009-04-21 15:19:43 +00:00
Aaron J. Seigo
18211150b2 update using the real frame interval to get a proper distribution across the frame range of custom animations
svn path=/trunk/KDE/kdelibs/; revision=950439
2009-04-07 07:43:24 +00:00
Aaron J. Seigo
599fcdd138 ignore timer id's that aren't ours
svn path=/trunk/KDE/kdelibs/; revision=944581
2009-03-25 19:10:02 +00:00
Frederik Schwarzer
83f2503169 global typo fix
svn path=/trunk/KDE/kdelibs/; revision=922431
2009-02-07 01:12:28 +00:00
Laurent Montel
eebb6178a5 Fix iterator
svn path=/trunk/KDE/kdelibs/; revision=906617
2009-01-06 13:09:05 +00:00
Aaron J. Seigo
25b3937022 wow, that was massively broken!
svn path=/trunk/KDE/kdelibs/; revision=893519
2008-12-06 18:58:32 +00:00
Michel Hermier
69a3b53112 Don't leak the animator driver of the animator instance.
svn path=/trunk/KDE/kdelibs/; revision=883002
2008-11-11 21:14:32 +00:00
Dmitry Suzdalev
4de7d13a16 Qt docs for qstrdup() say:
"Ownership is passed to the caller, so the returned string must be deleted using delete[]"

Thanks go to valgrind for helping to find this nasty crash! :)

svn path=/trunk/KDE/kdelibs/; revision=881260
2008-11-07 16:09:52 +00:00
Aaron J. Seigo
4b08c03726 change KDE includes to use the .h style now that we're in libs
svn path=/trunk/KDE/kdelibs/; revision=879795
2008-11-04 02:04:34 +00:00
Aaron J. Seigo
1b523b9054 ok, this time JUST the plasma dir ;)
svn path=/trunk/KDE/kdelibs/; revision=879759
2008-11-03 23:08:39 +00:00
Aaron J. Seigo
fa5a2d87d9 bum-de-dum! plasma to kdelibs.
svn path=/trunk/KDE/kdelibs/; revision=879757
2008-11-03 23:03:26 +00:00
Allen Winter
214ac5f91f clean up some kDebugs and kWarnings.
shorten some extra long lines.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870290
2008-10-12 10:20:02 +00:00
Allen Winter
a7aebfa60a a bunch more coding style fixes. still some lines longer than 100 chars.
this is definitely helping me find false positives in the Krazy style checker.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870161
2008-10-11 22:48:38 +00:00
Aaron J. Seigo
a680170b8f * fix div-by-zero
* based frame count on the animation duration

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=863639
2008-09-22 18:34:58 +00:00
Aaron J. Seigo
2753276dbb increase quality of anims
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=862847
2008-09-20 05:46:45 +00:00
Aaron J. Seigo
88ac98fdb0 fix up the rest of the math here, now anims are appropriately smooth according to the AnimationDriver settings
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=862832
2008-09-20 01:02:20 +00:00
Aaron J. Seigo
12443b7d98 curves ... no longer just a place for women to work out.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=859643
2008-09-10 20:51:53 +00:00
Aaron J. Seigo
8b3510bf7e * fix a math error in the movement framerate calc
* increase the quality of movements (more frames)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=859588
2008-09-10 18:42:11 +00:00
Dirk Mueller
754b000b42 also implement the plugin version checks for the other plugin types
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=833940
2008-07-17 16:26:29 +00:00
Marco Martin
a1ff7b38f4 redraw the parent item when the animation updates
to be backported

BUG: 166347
CCMAIL:panel-devel@kde.org

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=831975
2008-07-13 18:38:56 +00:00
Marijn Kruisselbrink
21b148b963 change all ClassName::Private classes to ClassNamePrivate, and adjust friends accordingly; this makes plasma compilable with gcc < 4.2
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826893
2008-07-01 18:56:43 +00:00
Aaron J. Seigo
a02a089e67 fix math in here; the other types are also going to be wrong, but i haven't fixed those yet
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810605
2008-05-21 05:12:40 +00:00
Marco Martin
aadef48088 new optional (so retrocompatible) parameter in the slot called by the custom animation:
the slot can be something like
void animationUpdate(qreal progress, int animId)
it's useful to keep track of multiple animations with a single slot

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=808853
2008-05-17 17:27:18 +00:00
Aaron J. Seigo
5482bad2ce protected slots -> Q_PRIVATE_SLOT
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802610
2008-04-29 23:27:17 +00:00
Aaron J. Seigo
67f44e6f0a * constructor + destructor private
* init -> pimpl

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802607
2008-04-29 23:24:09 +00:00
Aaron J. Seigo
0c2b74e11d * animateItem, moveItem return int
* add stopItemAnimation and stopItemMovement

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=802605
2008-04-29 23:16:33 +00:00
Davide Bettio
7e5915f398 API REVIEW: FPS -> Fps
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801635
2008-04-27 09:02:18 +00:00
Aaron J. Seigo
72db181c7c Phase -> Animator
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800875
2008-04-25 03:23:31 +00:00
Aaron J. Seigo
202e01e44d move animator.[c|cpp] -> animationdriver.[h|cpp]
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800872
2008-04-25 03:17:00 +00:00
Aaron J. Seigo
6e80fe4354 Phase becomes Animator
Animator becomes AnimationDriver

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800870
2008-04-25 03:11:59 +00:00
Davide Bettio
aa5f747305 API REVIEW: Phase -> AnimatorDriver
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800840
2008-04-24 23:21:17 +00:00
Davide Bettio
3bfaf57014 API REVIEW: Animation merges with ElementAnimation.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800825
2008-04-24 22:30:53 +00:00
Davide Bettio
84aa9fb8b0 FramesPerSecond -> FPS.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800816
2008-04-24 21:47:25 +00:00
Davide Bettio
eba58a193d API REVIEW: *Slide* -> *Slide*Movement
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800796
2008-04-24 21:06:08 +00:00
Davide Bettio
ba4beb2835 API REVIEW: curve(element) -> elementAnimationCurve(element)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800750
2008-04-24 19:28:04 +00:00
Davide Bettio
0dc5009d81 API REVIEW: curve(movement) -> movementAnimationCurve(movement)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800747
2008-04-24 19:22:44 +00:00
Davide Bettio
921afdb3db API REVIEW: curve(animation) -> animationCurve(animation)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800745
2008-04-24 19:18:28 +00:00
Davide Bettio
b1da29061c API REVIEW: duration(element) -> elementAnimationDuration(element)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800743
2008-04-24 19:11:12 +00:00
Davide Bettio
2c169f97ff API REVIEW: duration(movement) -> movementAnimationDuration(movement)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800740
2008-04-24 19:05:51 +00:00
Davide Bettio
eb378c78fd animationFramesPerSecond(element) -> elementAnimationFramesPerSecond(element)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800735
2008-04-24 18:45:47 +00:00
Davide Bettio
27954bc347 API REVIEW: animationFramesPerSecond(movement) -> movementAnimationFramesPerSecond(movement)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800733
2008-04-24 18:41:47 +00:00
Davide Bettio
ab377f4f18 API REVIEW: duration(animation) -> animationDuration(animation)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800723
2008-04-24 18:20:58 +00:00
Davide Bettio
aa31688da7 API REVIEW: framesPerSecond(element) -> animationFramesPerSecond(element)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800720
2008-04-24 18:15:57 +00:00
Davide Bettio
714755631d API REVIEW: framesPerSecond(movement) -> animationFramesPerSecond(movement)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800715
2008-04-24 18:11:48 +00:00
Davide Bettio
16ef3e589c API REVIEW: FramesPerSecond() -> animationFramesPerSecond()
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800711
2008-04-24 18:06:26 +00:00
Davide Bettio
b74b254741 API REVIEW: element*(qreal frame, ...) -> element*(qreal progress, ...)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800707
2008-04-24 17:57:56 +00:00