Remember to document ALL parameters to methods. They may seem obvious to you, but I had to look at the code for at least two of the methods in order to document their parameters correctly.
*waves stick of EBN-ness*
svn path=/trunk/KDE/kdelibs/; revision=908604
these were found while testing the Krazy style checker, which I'm adapting
for the kdelibs style.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=870051
is in quite nice shape and basides a couple of bugs, it basically works. So what are you
still doing reading this? Port your favourite applet to extenders today! ;)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=840978
* accept bad config objectsin Applet::save and Containment::save
* move some initialization code around to be more robust with external use (will make more sense in next commit to workspace/plasma/plasma)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828940
* select the correct containment for removal when zoomed out (will have isses on multi-screen; see FIXME)
* move containment destruction logic out of Corona; it really doesn't belong there
* remove the hack to not set focus on a containment when clicked as that doesn't seem to reliably trigger it for me here and it doesn't address the issue of a new containment still messing things up, so we really ought to have a generic solution instead of a slightly ugly hack
BUG:id=165670
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828906
* signal when the config is sync'd, so the host app (or whomever else cares to) can hook into these syncs as well.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820383
assContainment() is not a slot, and now there is a public version
without containment id and delayed init params (always assumed as 0 and
false in the public version) and a private version in Private with these
two params used only when restoring the configuration
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=801100
the protected slots containmentDestroyed(QObject*) and syncConfig()
are now private and in the private implementation
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800755
removing launchActivated() signal from Corona.
it was not used here, but still needed in Containment and Applet
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800751
isImmutable(), setIsImmutable() and isKioskImmutable() of applet and
corona are merged in one property so they becamed
immutability() and setImmutability() using the new type
ImmutabilityType defined in plasma.h as:
NotImmutable: normal behaviour
UserImmutable: the user locked the desktop, can unlock it
SystemImmutable: the system locked the desktop and the user can't unlock
it
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=800724
* don't delete applet config groups because nobody actually bothers to implement saveState (*grrrr*) but that's somewhat ok now as we destroy the group on applet destruction. this does mean that dragging applets between containments is probably broken now, but i'll fix that next
* don't recreate the config file on every saveApplets but use the existing shared config ptr whenever possible
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=755635
* remove addApplet, as it breaks the corona->containment->applet concept and leads to easily to subtle bugs (c.f. r750746)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=750747
it all happens from one file now using nested groups. this has two major effects:
- one file to rule them all for any given corona; this makes things even nicer for use in other apps, btw.
- the ability to easily save, send/share and restore corona configuration layouts; something i've wanted from the start
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=741158
