Commit Graph

13404 Commits

Author SHA1 Message Date
David Edmundson
94c4bff3da Merge "Add component tests" 2014-09-26 17:20:33 +02:00
David Edmundson
56e1c9c48a warnings--
Change-Id: If41d2ebcec822002edb5282dd401b84fc2d40a10
2014-09-26 17:05:30 +02:00
David Edmundson
f5b8b164c3 Warnings--
Change-Id: I97e12f614c677914306594170435a7d3ddac102a
2014-09-26 17:03:45 +02:00
David Edmundson
0d209f9d2a Make KWindowSystem a public dependency of plasmaquick
Dialog.h uses netwm_def.h in the header so it should be included by apps
that use plasmaquick implicitly

Change-Id: I55507f552025468dde32e4830a78e34dc35c03af
2014-09-26 16:47:46 +02:00
David Edmundson
d9bf760c14 warnings--
Change-Id: Ide6d4301162f617ae0846df8ea2ef938982f9a7f
2014-09-26 16:34:09 +02:00
David Edmundson
62d240b7d6 Only update real visibility when component has finished completion
We only want to toggle our visibility until after all window flags have
been set, as some flags can only be set before the window is shown.

This patch caches and proxies the visibility flag and only update the
real visibility when the component is complete.

Change-Id: I4ce7744dc48afecf35db6679ca0991b7042e45a2
2014-09-26 16:17:33 +02:00
David Edmundson
9bafdb6ed6 Dialog auto tests
Add a test that checks all dialog flags are set when a dialog becomes
visible.

Renamed existing dialog test for clarity

Change-Id: I3677816877860cab3303122e81f9ee30fc563e39
2014-09-26 16:17:28 +02:00
Marco Martin
87e3240f72 don't make the progressbar smaller than its borders
BUG:338225
Change-Id: Ia5926206b9185c82bcdf96956bc7f586c3b2d50e
2014-09-25 18:31:19 +02:00
Marco Martin
5b50373b37 if rootObject exists, component is here and ready
Change-Id: I37deb527a04dde9ce458c5aea8e178b3d08b1b46
2014-09-25 18:02:59 +02:00
Marco Martin
a71697e68d the qquickitem con be resized before qml is created
AppletQuickItemPrivate::compactRepresentationCheck() must not be executed before
the qml parse is over and rootObject is here: the creation of the full or compact representation
would go very wrong in that case

Change-Id: Ib72f7d25f570a1ae34ada3330080350384d5c1e8
CCBUG:339329
2014-09-25 17:57:14 +02:00
Marco Martin
09e30e5f31 Merge "share icon rounding code between Units/IconItem" 2014-09-25 14:52:27 +02:00
Marco Martin
8aab4ac9c7 share icon rounding code between Units/IconItem
it should ensure both share the same behavior

Change-Id: I2de37f5fb43bdcdd482ede9252c68fc207efbe39
2014-09-25 14:48:45 +02:00
David Edmundson
565cc50ca2 Remove rather outdated .svn install exclusion
Change-Id: Ia5c5fca18e3ca0d18a272cd641569d5ed50594a4
2014-09-25 13:16:28 +02:00
David Edmundson
71e9de7ce4 Don't install developer notes in plasma_install_package
In the SDDM theme (and a few other places) I leave some notes for other
developers; I need to add one to the workspace components too.

As plasma_package blindly copies everything it seems to annoy packagers.

Change-Id: I77765f96f1a5fb24a7788f69eae1bbffaf14210b
2014-09-25 13:15:04 +02:00
David Edmundson
40fbd5f13c Add component tests
The rationale is to build simple tests which cover most combos of
components

Change-Id: I771a511eb3589c3815600697a800d4250e50175d
2014-09-25 12:37:44 +02:00
Marco Martin
18b57ffc29 fix tooltips
use adjustSize in updateMinimumWidth et al.
changing tooltip content updates sizeHints
using setGeometry is immediate, and will kill the animations.
for dialogs other than tooltips there is no change since adjustGeometry
is just setGeometry

Change-Id: I3e6310f12f76e400f2663b8409a2bbc7e7398f39
2014-09-24 14:07:30 +02:00
Marco Martin
e3fd010166 don't update the minimum size when not visible
since when is not visible the dialog doesn't update its size
from the mainItem size, the minimum size should not be
updated as well, or the initial mainitem size will get lost
and the dialog will be initialized to a wrong size

Patch by: Vishesh Handa <vhanda@kde.org>

Change-Id: I272727fb4732474b102de64c9bfdddb7fc3906c8
2014-09-23 17:05:09 +02:00
Marco Martin
d28871cb65 Merge "fix availableScreenGeometryForPosition()" 2014-09-23 12:50:55 +02:00
David Edmundson
8a70067e8c Don't duplicate background resizing to contents
The code in Button is
panel.implicitWidth: max(label+borders, backgroundImplicitSize)

by setting the background implicitSize to be max(size, labels+borders)
we just duplicate the functionality.

This worked, but icon only buttons became smaller because we weren't
setting the implicitHeight of the label properly.

(two wrongs were making a right)

We need to move the RowLayout inside an Item as we are modiyfing the
preferredHeight of RowLayout, but this doesn't sync back to updating the
implicitHeight which Button.qml uses.

This fixes all binding loops and the rather broken icon only flat
button.

Change-Id: Id2f9c2ab37b2280ee69dc1473f388fe686e3327e
2014-09-23 10:22:35 +02:00
David Edmundson
b2a5ebc926 Update hover effect to match QtQuickControls port
Change-Id: Ib3ad938f24d2a7c9e5d8c6cdd5d6717b3574351a
2014-09-22 19:01:31 +02:00
l10n daemon script
88ccf7be3d SVN_SILENT made messages (.desktop file) 2014-09-22 08:34:39 +00:00
Marco Martin
b98fdd7753 introduce roundToIconSize(int size)
return a size rounded tothe nearest inferior standard icon size.
sizes larger than iconSizes.huge, it will be returned unmodified
Reviewed by: Kai Uwe Broulik <kde@privat.broulik.de>

Change-Id: I85c575ea1cc7965ae9bede9e5a8b7b4cb342580e
2014-09-19 16:38:22 +02:00
Marco Martin
cd8c134578 increase version number
systray icons have changed, increase the version number
(correct and will force a cahce drop)

Change-Id: I46bd169e1e221daf16d7c45ab12370437b74688d
2014-09-19 14:38:31 +02:00
l10n daemon script
f12eb638f0 SVN_SILENT made messages (.desktop file) 2014-09-19 09:02:03 +00:00
Marco Martin
60a7419746 fix availableScreenGeometryForPosition()
when we check if a position is in a screen, we need
the whole screen geometry, panels included, otherwise if we pass
a coordinate under a panel, it will think no screen is there

Change-Id: I802a2bec4ae44b583eafdc309934e67b620cc463
2014-09-18 17:35:18 +02:00
Marco Martin
dff792a86b Update the size in two ways
A dialog can be resized for two reasons: the mainItem size changes, or the dialog size changes.

the first can happen programmatically, caused by the Layout, or just by assigning the width.

the second can be caused either programmatically, assigning the size of the dialog or externally by the windowmanager, that is the only one theat in the end has the only final control of the window size

Change-Id: Ifc5c7f683039f83d13a5046c10d6dd0227169542
REVIEW:120235
2014-09-18 17:25:48 +02:00
David Edmundson
4a95748249 Don't redeclare QQuickItem properties for implicitSizes
Change-Id: I96a8e6acd23cdee77048bc064963c7735b6615db
2014-09-17 23:23:15 +02:00
Marco Martin
ac0c457b65 partly revert last commit
revert part of
306e353fe6

if a framesvgitem has an implicitsize explicitly set, it shouldn't be overwritten

Change-Id: I931ca8acafdc2f6908945d03fca97487ced22988
2014-09-17 20:21:34 +02:00
Marco Martin
306e353fe6 take into account device pixel ratio
make sure framesvgitem returns the proper implicitWidth/height

Change-Id: I6d756e474c69bb32d2abef1a34d989c339d28ef9
2014-09-17 20:04:17 +02:00
Marco Martin
a393284338 get rid of internal ShellPackage
ShellPackage is a plugin in plasma-workspace now, don't duplicate

Change-Id: I77edf63acf6c99314f6062d7ef2f55a129727013
2014-09-17 14:47:13 +02:00
Marco Martin
0ec9ea7d04 make sure applets are sorted by id
As with containment, make sure Containment::applets()
is always sorted by id, to have the least sursprises possible

it adds a test

Change-Id: Ib1aeeff7c70bb6969b32b2fef8557889a43edf09
2014-09-17 14:47:13 +02:00
Marco Martin
9957652d15 Ensure corona::containments() is ordered
the order in which containments were restored used to be quite random:
ensure that's ordered by id this makes the shell startups be more reproduceable
from one to another, if a new containment arrives, ensure it's inserted
maintaining id order

containment::appelts() will need the same treatment

adds a test as well that checks the order is right

Change-Id: Ie1b278e5b83d7e3645f7293bf6d030aa7f43a221
2014-09-17 14:47:13 +02:00
Marco Martin
edef5c1dc1 base on screen() to see what containment is loading
if a containment's lastScreen is not -1 (and a valid screen)
*and* its activity() is not the current one, its QML
will *not* be loaded, therefore it would dangle blocking
corona::startupCompleted until the activity is selected

Change-Id: I6757d29240a012377e9ff0a22fe16541ea712ee6
2014-09-17 14:47:13 +02:00
Marco Martin
6993ecf9f7 Revert "fix enabled borders management"
This reverts commit aaa1a6315e.
2014-09-16 17:35:22 +02:00
Marco Martin
aaa1a6315e fix enabled borders management
* never enable all the borders just to take margins, there is fixedMargins for that
* redo ResizeOrigin: Dialog needs to sync from both sides: when the mainItem gets resized, *and* when the window gets resized (syncing mainItem)
* don't crash when there is no Layout: not all mainItems export one
* fix availableScreenGeometryForPosition()

Change-Id: I09370e33a3e8d03675b60f14c6c5754f8491d52c
2014-09-16 16:04:35 +02:00
Vishesh Handa
d59e005da3 Dialog: Add a manual test for tooltips 2014-09-16 15:47:35 +02:00
Vishesh Handa
188df2daad Dialog: Correct typo. '+' should be '-' 2014-09-16 15:45:55 +02:00
Vishesh Handa
6f2c46807e Dialog: updateLayoutParameters after calling syncToMainItemSize
updateLayoutParameters's uses the borders in order to set the max and
minimum size, and therefore syncToMainItemSize should always be called
before it is ever called.

Also added code to not do anything if we are not completely initialized.
2014-09-16 15:26:50 +02:00
Marco Martin
919694a1de get rid of internal ShellPackage
ShellPackage is a plugin in plasma-workspace now, don't duplicate

Change-Id: I77edf63acf6c99314f6062d7ef2f55a129727013
2014-09-15 18:20:34 +02:00
Marco Martin
37b34711d8 make sure applets are sorted by id
As with containment, make sure Containment::applets()
is always sorted by id, to have the least sursprises possible

it adds a test

Change-Id: Ib1aeeff7c70bb6969b32b2fef8557889a43edf09
2014-09-15 17:55:36 +02:00
Marco Martin
a159208d54 Ensure corona::containments() is ordered
the order in which containments were restored used to be quite random:
ensure that's ordered by id this makes the shell startups be more reproduceable
from one to another, if a new containment arrives, ensure it's inserted
maintaining id order

containment::appelts() will need the same treatment

adds a test as well that checks the order is right

Change-Id: Ie1b278e5b83d7e3645f7293bf6d030aa7f43a221
2014-09-15 17:28:38 +02:00
Vishesh Handa
18a6a7302b Merge branch 'master' into vhanda/dialogRefactor 2014-09-15 14:50:49 +02:00
Marco Martin
052a0c32ae base on screen() to see what containment is loading
if a containment's lastScreen is not -1 (and a valid screen)
*and* its activity() is not the current one, its QML
will *not* be loaded, therefore it would dangle blocking
corona::startupCompleted until the activity is selected

Change-Id: I6757d29240a012377e9ff0a22fe16541ea712ee6
2014-09-15 14:49:18 +02:00
Marco Martin
0b0daa2318 ensure empty containment emit uiReady()
Containments with no applets will emit uiReady now

It adds a test as well that checks if this is the case.

There is still a case where the corona doesn't emit startupCompleted()
that's when there is more than one activity, but that, as well the test
will be adressed by another patch on a different part.

Change-Id: I4d83aa612c29fb0f441d11681bc5aba241370bc3
2014-09-13 12:41:24 +02:00
Marco Martin
72caf0b9f0 Merge "Fix binding loop in Toolbuttonstyle" 2014-09-13 12:28:50 +02:00
David Edmundson
26620812a2 Don't include configmodel in doxygen
Change-Id: I7e4db3c81f4e67deec788932225026fc048fd128
2014-09-13 11:47:00 +02:00
David Edmundson
4ee2d5ca22 Fix binding loop in Toolbuttonstyle
Setting the implcit width to be the same as the current height is very
easy to end up looping.

actual height of the background is set by the base style, which is based
on the implicit sizes anyway.

BUG: 338750
Change-Id: Ic7606588cec09c6ff16515c208efe576466d31d6
2014-09-12 18:50:00 +02:00
David Edmundson
8bf612f9af Put QML Components at the top
They're more useful than the C++ lib which will be used by only shell
writers. The QML bits will be used by all applet writers.

Change-Id: Ib6d1bef0676fdac054db52e876cf9a89056e591b
2014-09-12 14:00:32 +02:00
David Edmundson
0b92063aff Add link to appletinterface documentation
Change-Id: I3a0bce2ec7ecc18c2efe9d5759eabd2c11a0acba
2014-09-12 13:53:00 +02:00
David Edmundson
13ddfd71e9 Sync documentation from wiki to dialog
Change-Id: I2c3f623ef3dce33025b3e6a6233a6f3da8dd2691
2014-09-12 13:05:23 +02:00