Commit Graph

6779 Commits

Author SHA1 Message Date
Aaron Seigo
abd1d9ddba make shortcuts and sharing settings enable Apply; use a QWeakPointer forthe shortcuts widget 2011-12-06 17:36:39 +01:00
Aaron Seigo
57f9668bd1 config changed is not only called by config dialogs anymore, so more the script forwarding into the public API implementation 2011-12-05 00:16:53 +01:00
Aaron Seigo
3948cfb8cf use d->setWidget which notes that it's not a palette customization 2011-12-04 14:00:32 +01:00
Aaron Seigo
e34c70415e git rid of the native member, it's redundant; use d->setWidget which notes that it's not a palette customization 2011-12-04 14:00:32 +01:00
Aaron Seigo
27531a3173 the palette gets updated by all sorts of events on the scene now (incl. reparenting!), so make sure the palette is _really_ changing before marking it as custom
this fixes widget colours not updating with theme changes -> if, for instance, an offscreen widget is created, this results in a reparenting (to null)
and that in turn creates a palette changed event ... which was being intepretted as a custom palette being set and that would disable future updates
due to theme changes.

this also introduces a small helper which computes the palettes once for use by all widgets as a small performance improvement.

BUG:261967
2011-12-04 14:00:32 +01:00
Jaime Torres
4aa690ccc8 return a double usind qMin
qMin is a template, use the right datatype for it.
part of review 103323
2011-12-04 12:28:04 +01:00
Jaime Torres
2c5ec1a56a change return by break and then add a common return
removing dead code (part of review 103323)
2011-12-04 12:27:01 +01:00
Jaime Torres
be08974bfe remove dead code
remove dead code (see review 103323)
2011-12-04 12:25:46 +01:00
Jaime Torres
ab8e956d57 remove a break; after a return
there is no need for a break; after a return (dead code)

REVIEW: 103323
2011-12-04 12:24:35 +01:00
Aaron Seigo
97e4bd53d3 don't delete the kns3 dialog on application shutdown
BUG:288153
2011-12-03 21:22:45 +01:00
Aaron Seigo
b7e335265f catch another possible mimetype identification
BUG:252612
2011-12-03 17:46:20 +01:00
Script Kiddy
66f3acefb9 SVN_SILENT made messages (.desktop file) 2011-12-03 14:30:23 +01:00
Aaron Seigo
1ba3ec0d04 use the default corona in case the widget doesn't provide one
we need a different solution for libplasma2, however.

BUG:281759
2011-12-02 19:01:46 +01:00
Aaron Seigo
e0cd24f83a constrained square makes sense for vertical but not horizontal panels
BUG:282706
2011-12-02 17:30:59 +01:00
Aaron Seigo
c3cb35739c containmentType() .. NOT type()!
and now we know the source of the "panel covers the entire screen" bug

BUG:259704
2011-12-02 17:00:29 +01:00
Aaron Seigo
f0498a9973 fix spinboxes
BUG:285224
2011-12-02 10:45:47 +01:00
Aaron Seigo
dd15c33c2b while properties are cool and all, let's not take the slow path just because we can. 2011-12-02 10:45:47 +01:00
Aaron Seigo
a97d486876 animate transitions when an svg is used as well. 2011-12-02 10:45:47 +01:00
Jeremy Whiting
2313cc258b KTar already supports xz and lzma files, also support them in Plasma::Package.
BUG:287193
2011-12-01 15:52:44 -07:00
Aaron Seigo
ed31f2aaee set the parent of the config skeleton object to be the dialog
BUG:287324
2011-12-01 17:13:30 +01:00
Aaron Seigo
822243288d get rid of the text halos
they are (relatively) expensive and should be unnecessary now:
we have blur, it works well, and when we don't blur we use different backgrounds.

one more "take one thing off" while i'm futzing around in tooltips
2011-11-30 15:44:29 +01:00
Aaron Seigo
7e4883f3bb handle titles a little nicer: centered, no wrap for short titles 2011-11-30 15:39:29 +01:00
Aaron Seigo
3c401cd360 force of habit :) 2011-11-30 15:19:58 +01:00
Aaron Seigo
3bf1d0d63d hide the label completely when no image is set. makes sure there isn't layout().spacing() extra padding 2011-11-30 15:19:29 +01:00
Aaron Seigo
7498fe207a don't allocate 1k chunks of memory for a few longs here and there 2011-11-30 13:43:52 +01:00
Aaron Seigo
6cd33ae4a0 grab the source name before removing the iterator
the previous fix, which i accidentally reverted while cleaning up this code,
was actually wrong (so in a way i'm glad i caught it): the signal MUST be emitted
AFTER the item is removed from the collection otherwise any code that checks to
see if that source exists will see that it does still exist even though it was
just signaled as being removed. order sometimes really matters :)

CCMAIL:kde@rusu.info
BUG:287795
2011-11-30 09:23:03 +01:00
Marco Martin
58b6cc3e43 remove the iterator after accessing it 2011-11-29 15:53:17 +01:00
Aaron Seigo
e7ffcacf1f emit sourceRemoved when the container is deleted outside of removeSource 2011-11-28 10:42:40 +01:00
Aaron Seigo
e500cd4bd7 make removeAllSources match removeSource closer 2011-11-28 10:37:21 +01:00
Aaron Seigo
2f5d8e4e7f the graphics widget may not have been into a layout, or may be null
BUG:287548
2011-11-28 09:43:22 +01:00
Script Kiddy
b71636fb5b SVN_SILENT made messages (.desktop file) 2011-11-22 21:19:16 +01:00
Aaron Seigo
7ed45afaaf if the graphicswidget isn't on a corona, use the applet's scene 2011-11-22 13:56:35 +01:00
Aaron Seigo
9775682bef use a QWeakPointer with the graphics widget handed in as we don't own it 2011-11-22 13:29:02 +01:00
Aaron Seigo
d47a6bf33b constify 2011-11-22 12:20:14 +01:00
Aaron Seigo
f6f8d8b2ee when setAllowedRunners is called, call loadRunners, which now also allows for being called while a search is in progress
loadRunners intelligently only unloads those runners with are no longer to be loaded, so this is a performance win.
it now also checks to see if there are pending jobs for the runners to be deleted (if any) and if so it creates a delayed
deleter for them -> no crashes
2011-11-22 12:17:06 +01:00
Ben Cooksley
7f0e9fb3b2 Don't crash on exit.
BUG:284989
REVIEW:103202
2011-11-22 21:18:04 +13:00
Aaron Seigo
2bcc53419e don't count custom panel contaiments (e.g. the grouping desktop) the same as a desktop containment
from the "useful things missing from bug reports" and "wondering wtf is wrong with people
while trying to get the useful bits out of a bug report" files ...

BUG:260360
2011-11-20 18:56:06 +01:00
Aaron Seigo
67651e12bb git rid of the shortcuts dialog on reduced functionality builds 2011-11-14 21:20:18 +01:00
Valentin Rusu
da386deb15 Merge branch 'KDE/4.7' into ksecretsservice 2011-11-08 21:27:31 +01:00
Marco Martin
71ad31df23 add the import paths right into libkdeclarative 2011-11-08 17:19:47 +01:00
Marco Martin
a70c17bc59 fix drawing of focusindicator of spinbox and combobox
use the proper prefix for drawing the combobox focusindicator
2011-11-08 12:57:46 +01:00
Marco Martin
4fad696891 possibility to put the focus over the frame
fixes the wrong shading of the lineedits, but staying retrocompatible with the old themes designed to have an highlight outside
2011-11-07 23:22:11 +01:00
Valentin Rusu
36bb121f93 Merge branch 'KDE/4.7' into ksecretsservice 2011-11-06 12:35:55 +01:00
Aaron Seigo
f38425761a a missing include 2011-11-03 12:15:52 +01:00
Aaron Seigo
ee75cfc1c8 add the variable to the c++ env 2011-11-03 12:15:27 +01:00
Aaron Seigo
58bbbb5fe6 make kutils linking properly conditional, use proper libs vars for other libraries too 2011-11-03 11:06:54 +01:00
Valentin Rusu
f4d5df71f9 Merge branch 'KDE/4.7' into ksecretsservice 2011-11-02 22:23:01 +01:00
Aaron Seigo
9a4825380f improve loading of system kcms
* don't use libkutils on reduced footprint profile builds
* load the kcms even if there isn't a configLoader for the package
2011-11-02 17:24:25 +01:00
Aaron Seigo
ebbf1bbc32 profile controled use of libkutils 2011-11-02 17:22:36 +01:00
Marco Martin
02eeddf931 correct type dekstop->desktop
please test before committing ;)
CCMAIL:viranch.mehta@gmail.com
2011-11-01 20:33:13 +01:00