QAction::trigger does not check enablement. File manager's undo action
gets enabled/disabled depending on whether we have anything to undo.
If we unconditionally invoke the method we can crash.
As an aside, the comment about QQuickItem and shortcut looks very
outdated.
When using a non-integer baseLine, the height can be non-integer, resulting
in non-exact pixel alignments which generate artifacts on the screen.
This happened in Kickoff's LeaveView in Plasma 5.18 (currently used in
openSUSE Leap 15.3) where the focus outline was painted with a different
width in the top and bottom borders due to this pixel misalignment.
--when an applet is updating its constraintHints
a signal must be triggered in order for everyone
to be informed. This way applets we can support
applets that update their constraintHints dynamically or
based on user demand.
Typically ExpandableListItem expands when you click on it or its
expander arrow, and shows a list of contextual actions. However there
may occasionally arise cirsumstances under which an item has no actions.
An example would be in the Disks & Devices applet when a device doesn't
match any of the Solid predicates and therefore gets no contextual
actions. In this case, we should hide the expander arrow and now let the
user try to expand it, because there would just be a little empty list
stub.
This reverts commit 3701b184d8 and allows
the new higher Plasma transparancy to be shipped with Frameworks 5.83,
right around the same time when Plasma 5.22 will be released.
This commit replaces the existing triangular event indicator on calendar
days with colored dots; one per event, up to five events per day. The dots
will use the color of the event, if it has one.
SystemPaletteSingleton was a QQC1.Private import. Not sure why it's in
a QQC2 theme. Nothing in Plasma uses this GroupBox so it makes sense
why it wasn't noticed before.
The actions added by plugins or applets can contain actions that are
menues. This causes a problem for the panel because it doesn't take
focus when right clicked. Since the menues had no transientParent, they
were created as new toplevels.
BUG:417378
* Visually this removes the lines between the day delegates in the calendar
and make it use the correct highlighting component
* Use a SwipeView for switching between the month, year, and decade view
* Makes the header optional
* Improves the documentation of the MonthView
This patch is explicitely licensed under LGPL-2.0-or-later
The pinned popups need to act as a "panel extension". Easiest way to
achieve this on Wayland is to just make sure they end up on the panel
layer. This is simply done by changing the role on their corresponding
surface so that KWin treat them properly (as in like a panel but with
windows able to go under).
Neat way of doing it like this is that it will work wherever the popup
parent is coming from (a panel or the desktop).
BUG: 400317
This fixes the problem of the default list item not being rendered with
bold text as intended, which was caused by checking the count property
of the wrong thing and causing a condition to always evaluate to false.
The old code forgot to launch some signal by directly assigning todat to
the displayed date. Using the setter make sure everything is displayed
visually.
Prior to a45bd75800, label alignment was
controlled by its Layout properties. However that commit made the label
fill width to fix elision, which means that the Layout.Alignment property
no longer has any effect anymore. Therefore, we need to use the
horizontalAlignment property to position the text within its
now-width-filling box.
We ported units to use the PlasmaCore.Units singleton earlier; now it's
time to do the same thing for PlasmaCore.Theme.
There are no UI changes or regressions detected.
The viewBox wasn't right, which made the values reported by naturalSize.width and naturalSize.height extremely small.
If you start an SVG from certain templates in Inkscape and then convert the units to px, the viewBox gets messed up. It won't look messed up in Inkscape because everything will appear scaled correctly, but it's actually roughly 26% of the size it should be. In order to fix this, you need to set the document scale to 1.0 which will cause all of the elements in the SVG to shrink to the size they really were. Then, you need to scale all the elements back up to their original sizes.
This dead code was found during investigation of KDE bug 433907.
"ok" is always "false", thus next condition is always "false"
and m_localRectCache is never filled from cache.
It looks like "ok" should be set to "true" if "key" contains a valid integer value.
Time in milliseconds equivalent to the theoretical human moment, which can be used
to determine whether how long to wait until the user should be informed of something,
or can be used as the limit for how long something should wait before being
automatically initiated.
Some examples:
- When the user types text in a search field, wait no longer than this duration after
the user completes typing before starting the search
- When loading data which would commonly arrive rapidly enough to not require interaction,
wait this long before showing a spinner
This might seem an arbitrary number, but given the psychological effect that three
seconds seems to be what humans consider a moment (and in the case of waiting for
something to happen, a moment is that time when you think "this is taking a bit long,
isn't it?"), the idea is to postpone for just before such a conceptual moment. The reason
for the two seconds, rather than three, is to function as a middle ground: Not long enough
that the user would think that something has taken too long, for also not so fast as to
happen too soon.
See also
https://www.psychologytoday.com/blog/all-about-addiction/201101/tick-tock-tick-hugs-and-life-in-3-second-intervals
(the actual paper is hidden behind an academic paywall and consequently not readily
available to us, so the source will have to be the blog entry above)
see also https://invent.kde.org/frameworks/kirigami/-/merge_requests/268
