Commit Graph

176 Commits

Author SHA1 Message Date
Marco Martin
b353f6e7fb remove a couple of sizes 2012-11-26 11:35:53 +01:00
Marco Martin
171c795ac2 bind standard icon sizes (desktop, toolbar etc)
they should be preferred over smallIconSize, mediumIconSize etc
2012-11-26 11:24:09 +01:00
Allen Winter
78848d5d50 initialize m_left, m_top, m_right and m_bottom to make valgrind happy. 2012-11-12 19:01:55 -05:00
Sebastian Kügler
74b0e0bd98 debug-- 2012-11-12 01:44:51 +01:00
Aaron Seigo
554f0b9909 ensure margins update in all cases
setElementPrefix does not trigger repaintNeeded() from the svg object;
repaintNeeded() is for internal changes. if you change the svg from your
own application code, the app code needs to react to those changes in its
own time and way.

so margins was never seeing that it was getting changed when setElementPrefix
was called -> pixel imperfections in layouts.
2012-11-07 12:43:11 +01:00
Dmitry Ashkadov
46e7b8065f Support of QIcon and QPixmap for QML item PlasmaCore.Tooltip 2012-10-23 20:58:50 +04:00
Aaron Seigo
c42d979a56 turns out we have to set the role names constantly to make sorting actually work
even just setting the sort/filter roles is not enough. role names must also be set again!
gaaaah. thankfully this seems to be very fast, though would still be nice to avoid it if
possible somehow.

CCBUG:308101
2012-10-09 11:30:32 +02:00
Aaron Seigo
19a7d82ed9 dataengine based models set their roles when setting the data, so respond to that
syncRoleNames is fast (and faster now that we check that the role names actually changed)
but it may be nicer to find a more efficient way in future than checking the role names
on all / any data changes. in fact, the documentation for QAbstractItemModel::setRoleNames says:

"This function must be called before the model is used.
 Modifying the role names after the model has been set may result in undefined behaviour."

BUG:308101
2012-10-09 11:21:14 +02:00
Aaron Seigo
f5275fc57a the model can be null, be careful with that (and use emit for signals!) 2012-10-08 14:28:39 +02:00
Aaron Seigo
4e78f327bb actually sync the roles and only sort when we have an actual model already 2012-10-08 14:16:16 +02:00
Marco Martin
cbd6bc5758 Label and Icon roles 2012-10-08 13:53:16 +02:00
Marco Martin
0dc3b067d7 revert use of display and decoration
there can be only one name per role
2012-10-08 13:42:08 +02:00
Jacopo De Simoi
7a1f75af9b Remove noop check in setSortRole
The noop check m_sortRole == role has to be removed
because the hash table m_roleIds can change between two calls to
setSortRole (as it actually happens when resync the hash table).

Possibly one could perform a more clever check (i.e. adding some
m_invalidated flag which would override the check), but I am not sure it is
really worth it.

This fixes sorting issues in the Plasma Device Notifier

CCMAIL:notmart@gmail.com
2012-10-04 12:22:29 +02:00
Marco Martin
d4d6f11a8a imap also decoration/display to be consistent 2012-10-03 16:03:47 +02:00
Marco Martin
43846dde0e bind runnermodel in core 2012-10-03 15:55:11 +02:00
Marco Martin
95e5431610 move the runnermodel in core
the old plugin is still there for compatibility, however is discouraged to be used
2012-10-03 15:40:55 +02:00
Marco Martin
af189dff04 ensure the dialog is not out of workarea 2012-09-20 14:59:26 +02:00
Marco Martin
9d92b822aa support minimum/maximum/preferred sizes 2012-09-20 14:22:40 +02:00
Marco Martin
0e1021feb1 if is a dock, is on all desktops 2012-09-20 14:22:15 +02:00
Marco Martin
f4638e3438 avoid a first resize when a declarative item is assigned 2012-09-20 12:52:06 +02:00
Aleix Pol
24f7593788 Improve QAbstractItemModel integration in Plasma.Core QML components
Introduces QAbstractItemModel to QDeclarative when setting up
the plasma core components.

This way we don't have to cast to the type ourselves and produce proper
QML errors if the type is not correct. This happened with Plasma::SortProxyModel.

REVIEW: 106267
2012-08-29 17:35:56 +02:00
Aurélien Gâteau
5220782be1 Add unit tests for SortFilterModel 2012-08-28 18:11:06 +02:00
Aurélien Gâteau
ea427e54c2 Check if filter and model needs to be updated in setters 2012-08-28 18:10:35 +02:00
Aurélien Gâteau
bfcc27e01d Allow model to be set to 0 2012-08-28 18:09:19 +02:00
Aurélien Gâteau
91313b5eb5 Add notify signals for SortFilterModel.sourceModel and filterRegExp 2012-08-28 11:42:56 +02:00
Luís Gabriel Lima
db1096edce FrameSvgItem: Add notify signals
REVIEW: 105987
2012-08-12 15:12:44 -03:00
Marco Martin
d2f729d000 modify the hack that doesn't break in some cases 2012-07-13 10:50:07 +02:00
Marco Martin
8a04030fdf less ugly workaround for disappearing Qt::Popup
still a workaround but slightly less ugly and works on Qt 4.8 too
2012-07-12 17:51:28 +02:00
Marco Martin
daa3c78241 use pointSizeF
BUG:296117
FIXED-IN:4.9
2012-06-25 11:18:59 +02:00
Marco Martin
ed1e691b2d avoid repaints when the same id is set again
CCBUG:301903
2012-06-20 14:06:23 +02:00
Viranch Mehta
a60d6db013 Fix sourceFilter in QML DataModel to actually
filter the sources of the dataengine

The sources were not getting filtered due to an
error in the loop that added all the sources
in any case

REVIEW: 105267
2012-06-16 20:10:08 +05:30
Aurélien Gâteau
5c1e49fa76 SortFilterModel: Do not sort by default
It seems QML sets properties to their default value at startup and thus
calls setSortRole(QString()), which causes SortFilterModel to sort by
default.

CCMAIL: mart@kde.org
2012-06-13 23:56:31 +02:00
Aurélien Gâteau
bb8eef7db1 Introduct mapRowToSource and mapRowFromSource
REVIEW: 105044
2012-05-29 17:42:11 +02:00
Aurélien Gâteau
0ddb12cf96 Do not reset model while changing the regexp
There is no need to do so, QSortFilterProxyModel correctly adjust rows

REVIEW: 105042
2012-05-29 17:42:11 +02:00
Luís Gabriel Lima
999dd60721 Adding notify signals to SvgItem
These signals are being added in order to keep track of property
changes in the QML side.

Signed-off-by: Luís Gabriel Lima <lampih@gmail.com>
2012-05-28 08:51:32 -03:00
Lamarque V. Souza
4f670c149b Update all CMakeLists.txt to use KDeclarativeConfig.cmake.
rebuild kdelibs from KDE/4.8 branch to install KDeclarativeConfig.cmake.
2012-05-14 12:40:02 -03:00
Stephen Kelly
73dc4f9a0c Simplify QtGui module includes. 2012-04-10 00:22:13 +02:00
Marco Martin
531031f753 can't use windowId in QML on Windows 2012-04-06 13:09:32 +02:00
Martin Gräßlin
e195c1d01f Export WindowId on Plasma Dialog
Exporting the window Id allows to use it in declarative KWin scripts
to embedd window thumbnails on the dialog.

REVIEW: 104393
2012-03-24 10:51:12 +01:00
Marco Martin
86908c9c31 avoid a model reset in certain conditions
should be slightly faster and avoid some of the flickering (items deletion and recreation) in ListView
2012-02-29 14:38:14 +01:00
Marco Martin
7da705ba8a export defaultIconSize
kept in sync with the kglobal desktop icon size
2012-02-20 15:09:26 +01:00
Marco Martin
0b17c0227a document 2012-01-10 12:29:35 +01:00
Marco Martin
ed7f5e630a document 2012-01-10 12:06:59 +01:00
Marco Martin
fc0b0b8ed1 guard against no scene 2012-01-01 20:04:35 +01:00
Marco Martin
53a4c9df61 document the Font property object 2011-12-23 16:30:04 +01:00
Marco Martin
2f2ce9ac34 document Dialog 2011-12-23 16:30:04 +01:00
Marco Martin
922029e27b document DataSource 2011-12-23 13:28:02 +01:00
Marco Martin
f75cef4f87 document DataModel 2011-12-23 12:17:48 +01:00
Marco Martin
f9c777c0ca ignore mouse presses
BUG: 288827
2011-12-16 11:53:07 +01:00
Marco Martin
7988a4a7e4 don't try to set the main widget multiple times 2011-12-01 19:55:09 +01:00