Summary: Otherwise the flat property is ignored
Test Plan: Tested on KDE Connect port to use PlasmaComponents
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: mart, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11652
Summary:
add a version of containmentForScreen which it has the activity.
which is correct as the activity id of containments in in libplasma side.
this ensure the correctness of shellCorona createContainmentForActivity
as now it works also for activities different from the current one.
to make multimonitor a tad safer with it, when creating containments for an activity, initialize their lastScreen to the asked screen.
Test Plan: tried with an old plasmashell and is perfectly retrocompatible
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11361
Summary:
The original owner of a graphics item is the declarative applet script which
is owned and deleted by the applet.
Reparenting the containmentquickitem to the containment doesn't really
solve anything useful, we were originally effectively owned by the
containment(an applet subclass) not the view anyway.
This code also accidentally moves the destruction of the applet from being in
::~Applet to being in ::~QObject of the relevant containment. This
causes a big problem if the AppletQuickItem tries to access the applet
in it's own destructor. The applet object still exists, but use of
Applet member variables is not valid.
The new preloading code does this, leading to a crash.
BUG: 391642
Test Plan:
Changed desktop to folder twice
Changed activities twice
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: rikmills, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12064
Summary:
To avoid black text on black background and thus confusion if things are
working after the initial generation from the template and first test build
and installation, also set an background with themed color.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11922
Summary:
Allows to quickly start a new wallpaper which also wants to use a custom QML
extension.
Reviewers: mart
Reviewed By: mart
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D10849
This is emitted just before the tooltip is shown and allows the user to defer heavy lifting to when the dialog is actually shown.
Differential Revision: https://phabricator.kde.org/D10381
Blit the contents of the TFP texture to a separate mipmap texture,
and (re)generate the mipmaps on each damage event.
This commit also fixes ARGB thumbnails being rendered as opaque.
Note that this commit only modifies the GLX path.
BUG: 390457
Summary:
Having an anchor is undefined, and emits a warning in Qt5.11
Mostly it's used to vertically centre items. Some cases already had a
Layout.alignment property. In some cases it was added.
Reviewers: #plasma
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11557
Summary:
Third part of https://phabricator.kde.org/D10627
According to the documentation at http://doc.qt.io/qt-5/qabstractnativeeventfilter.html
The type of event eventType is specific to the platform plugin chosen
at run-time, and can be used to cast message to the right type.
On X11, eventType is set to "xcb_generic_event_t", and the message can
be casted to a xcb_generic_event_t pointer.
The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent".
No other eventType starts with an 'x'.
Reviewers: #frameworks, #plasma, mwolff, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mwolff, plasma-devel, davidedmundson
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D10670
Summary:
Avoids all the explicit boilerplate needed and allows
code reusing.
Depends on D10749
Test Plan:
Still builds, generated and installed CMake Config file works
as before.
Reviewers: #plasma, #frameworks
Subscribers: apol
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11295
Summary:
use the new package install macro to install them as
as rcc files
Test Plan:
plasmashell starts and most plasmoids seem to work,
still needed a more thorough test
Reviewers: #plasma
Subscribers: davidedmundson, apol, plasma-devel, #frameworks
Tags: #plasma, #frameworks
Differential Revision: https://phabricator.kde.org/D9400
Summary:
https://cgit.kde.org/plasma-framework.git/commit/?id=a21bc11fe11651f6d211489ebfc8435cef877194 erroneously added `renderType` properties to PlasmaComponents3 ComboBoxes, but QML ComboBoxes don't have this property, which broke Latte Dock's settings. This patch removes it.
BUG: 392026
Test Plan:
- Deployed, added Latte Dock, ran Plasmashell with and without `PLASMA_USE_QT_SCALING=1`, and with and without a HiDPI scale factor
- Opened Latte Dock's settings window. In all cases, Latte Dock's settings window appeared normally and all comboboxes rendered properly
- Opened Folder View settings and verified that all ComboBoxes there looked and worked fine, too
Reviewers: broulik, #plasma, mvourlakos, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11484
Summary:
When `PLASMA_USE_QT_SCALING=1` is set, Plasma uses native Qt scaling. This works fine for integer scale factors, and fixes a lot of bugs (see [[https://bugs.kde.org/show_bug.cgi?id=356446|Bug 356446]]) but it introduces a new one: with non-integer scale factors, text becomes blurry and pixellated because of a bug in `Text.NativeRendering`: https://bugreports.qt.io/browse/QTBUG-67007
QQC2-desktop-style forces the use of `Text.QtRendering` rendering for non-integer scale factors, successfully working around the problem. But PlasmaComponents QML objects don't implement the same workaround, so we see the issue in Plasma. This patch fixes that, and gets us one step closer to being able to use Qt scaling in Plasmashell.
There is no effect when `PLASMA_USE_QT_SCALING=1` is not being used.
FIXED-IN 5.13
BUG: 391691
BUG: 384031
CCBUG: 386216
CCBUG: 391695
CCBUG: 391694
CCBUG: 385547
CCBUG: 391692
CCBUG: 356446
Test Plan:
Before: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks awful:
{F5749797}
After: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks amazing!
{F5749798}
Note that we still get sub-pixel anti-aliasing and good kerning. There appear to be no layout regressions.
Without both `PLASMA_USE_QT_SCALING=1` and a non-integer scale factor set, there is no visual change compared to the status quo.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: mart, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11244
Summary:
there were some icons which conveyed meaning solely by color
which is discouraged by the hig
https://community.kde.org/KDE_Visual_Design_Group/HIG/Color
this makes use of the little x corner icons that are already
used somewhere in breeze (like muted microphone)
the exception is wireless off that has a bar, so a stronger
this is disabled message than wireless-disconnected
Depends on D10243
...which should go in asap
Test Plan: they all look readable at 100% zoom
Reviewers: #plasma, #vdg, andreask
Reviewed By: andreask
Subscribers: andreask, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11390
I don't see why this would be silently discarded.
The input shape has nothing to do with the window mask (e.g. rounded border depending on theme).
Differential Revision: https://phabricator.kde.org/D11102
KDirWatch::self() is a singleton so we would get change events also for other files like plasma-appletsrc needlessly reloading plasmarc all the time.
Differential Revision: https://phabricator.kde.org/D11326
Summary:
Using a private flag just added for plasma_install_package, until
there is a new official replacement for kpackage_install_package for
its needs
Test Plan: kdeplasma-addons & Co still build and now have clean cmake log again.
Reviewers: mart, apol
Reviewed By: mart
Subscribers: #frameworks
Tags: #frameworks, #plasma
Differential Revision: https://phabricator.kde.org/D11130
Summary:
We were inconsistent on that and it can get in way with placement on buttons.
Mirrors a change in Breeze icons.
{F5740901}
Reviewers: #frameworks, #plasma, ngraham
Reviewed By: #frameworks, ngraham
Subscribers: ngraham, mart
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11050
Summary:
Previously IconItem would create icons in new textures for animating. By
keeping them in the atlas not only do we avoid that, but we should
implicitly share the QSGTexture used for non-animating item.
Test Plan:
Moused over icon, it changed correctly
Set core profile, moused over an icon it changed correctly
Reviewers: #plasma
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11091
Summary:
Currently it asserts. I'm sure it worked at some point.
Fixed to match shaders shipped with Qt.
Test Plan:
Set Core profile
Did crash
Now doesn't
Reviewers: #plasma
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D11090
