It is a remnant of the Plasma Active days and didn't even compile.
This patch only removes those ifdefs, it doesn't fix any issues I found during (e.g. double lookups or the fact
that KRun::autoDelete is the default now)
Differential Revision: https://phabricator.kde.org/D16295
Summary:
At the moment we always look at the first fallback and load the original
theme again, rendering moot the fallback look-up.
Reviewers: #plasma, davidedmundson, hein
Reviewed By: #plasma, davidedmundson, hein
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15970
Summary:
Move the icons from D10937 to plasma-frameworks and combine all the sizes
BUG: 395714
Test Plan: "osd-shutd-screen.svg" does not display correctly for me. I can't find any difference between it and the rest of the icons. Help appreciated.
Reviewers: ngraham, #vdg, broulik
Reviewed By: ngraham, #vdg, broulik
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14971
Summary:
support button icons.
if there is no icon or is Qt 5.9, the iconItem will stay invisible
Test Plan: tested with ported mediacontroller to PlasmaComponents3
Reviewers: #plasma
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15164
Otherwise when the week starts on a day other than Sunday or Monday we access invalid day names.
CHANGELOG: Fixed week names not showing properly in calendar when week starts with a day other than Monday or Sunday
BUG: 390330
Differential Revision: https://phabricator.kde.org/D15309
Summary:
On Wayland, DialogShadows doesn't attach empty tiles for disabled
borders. Yet, it sets offset of 1 for them. This results in visual
artifacts like this
{F6206088, layout=center, size=full}
//KWin thinks that there is 1px tall shadow in the bottom.//
In general we don't need to pass empty shadow tiles for disabled
borders. Thus, that's fine to set 0 offset for them.
Test Plan:
* Started kwin_wayland:
dbus-launch kwin_wayland --windowed --xwayland
* Launched latte-dock and kate:
unset DISPLAY
QT_QPA_PLATFORM=wayland latte-dock &
QT_QPA_PLATFORM=wayland kate
* Opened calendar popup:
{F6206090, layout=center, size=full}
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14946
Summary:
Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138
with a potential patch for upstream.
With native rendering the alpha is pointlessly also set in the
glBlendFunc despite also being used in the uniform of the shader.
Resulting in a visual bug when used on a window with alpha (such as
Dialog)
It sucks, but we were starting to see people work round it by copying
more invasive workarounds everywhere else which I want to avoid.
BUG: 396813
Test Plan: Looked at a text field
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D15021
QIcon is rendered through KIconLoader instead of e.g. Plasma::Svg.
This means we need to recreate the pixmap when the icon theme changes.
CCBUG: 397109
Differential Revision: https://phabricator.kde.org/D14990
Turns out this icon had a hardcoded color in it which wasn't the case for the
full size icon used on my high dpi system.
Thanks Sandro Knauß for helping investigate this
BUG: 397441
Summary: This patch makes the text for removal and configuration actions consistent with one another.
Test Plan: {F6191533}
Reviewers: #plasma, #vdg, abetts
Reviewed By: #plasma, #vdg, abetts
Subscribers: abetts, broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14810
This way tests pass before installation.
Test Plan:
Before patch
Created a broken env by unsetting QML2_IMPORT_PATH
Ran test. It failed
It passes.
Reviewers: #plasma, dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D14743
