Commit Graph

15908 Commits

Author SHA1 Message Date
Noah Davis
f7f74d2fe4 PlasmoidHeader: re-add backgroundMetrics
accidentally removed in previous commit
2021-07-10 14:33:16 -04:00
Noah Davis
65360e9841 PlasmoidHeader: Make it based on T.ToolBar, deprecate location
PlasmoidHeader was probably based on T.Frame because of a mistake. T.Frame doesn't do anything different from T.Pane and PlasmoidHeader was duplicating the function of T.ToolBar's position property with the location property.
2021-07-10 10:10:16 -04:00
David Edmundson
815ddd3fc3 Port from QExposeEvent::region
This gets deprecated in Qt6.

See also https://codereview.qt-project.org/c/qt/qtwayland/+/349335
2021-07-09 14:35:21 +00:00
Friedrich W. H. Kossebau
aba253217d Avoid intermediate variable, pass sources directly to ecm_add_test
NO_CHANGELOG
2021-07-06 13:59:02 +02:00
Friedrich W. H. Kossebau
2c23dc0123 Use more target-centric cmake code
NO_CHANGELOG
2021-07-06 13:58:19 +02:00
Friedrich W. H. Kossebau
5a5ce88faa Drop outdated KDE_DEFAULT_DEBUG_AREA
No more usage of KDebug

NO_CHANGELOG
2021-07-06 13:24:44 +02:00
Ismael Asensio
2ad8174b46 [PC3/ScrollView] Fix assignation of Scrollbars
The assignation of the property `active` was flipped for vertical
and horizontal scrollbars.
2021-07-02 22:59:22 +02:00
Alexander Lohnau
599f24e0b6
Download missing LicenseRef-KDE-Accepted-LGPL license 2021-07-02 20:24:58 +02:00
l10n daemon script
76d533df90 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2021-07-02 01:11:12 +00:00
Aleix Pol
d809e9e4dc Remove container 2x lookups
Instead of checking for existance and then getting the value. Look it up
once and use the value if avaliable.
This saves us one hash look-up per execution which can be considerable,
especially in the case of findElementRect.
2021-07-01 17:35:53 +00:00
Friedrich W. H. Kossebau
53d1bf4577 Use include matching the used class instead of a subclass
NO_CHANGELOG
2021-07-01 16:47:59 +02:00
Nicolas Fella
3caea941aa Avoid deprecated QVariant ctor
Instead of passing the datastream at construction use the stream operator as recommended
2021-07-01 00:23:34 +02:00
Nicolas Fella
01e93a20cf Add missing includes
And remove an unneeded one
2021-06-30 23:57:54 +02:00
Aleix Pol
198c884b85 No need to explicitly disable the cache when using currentThemeHasImage
We have mechanisms to clear the cache as the current theme changes and
it only makes us access the disk repeatedly for no reason.
2021-06-28 17:02:42 +02:00
Aleix Pol
cd4ab21dd8 No need to check that a file exists if we know it's modified date 2021-06-28 16:55:19 +02:00
Aleix Pol
c3e0ba8ff5 Remove unused local variables 2021-06-28 15:56:43 +02:00
Noah Davis
9fd111d867 PC3 Page: Improve implicit size calculation
Also remove unnecessary code for contentWidth/contentHeight. It's already handled the exact same way in the C++ of QQC2 Page.
2021-06-28 09:00:51 -04:00
David Redondo
52b95888d5 Add function to hide tooltip immediately
The built in delay causes trouble on wayland where it can cause
closing of other popups.
2021-06-28 09:54:53 +00:00
l10n daemon script
ce39def7d1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2021-06-28 01:23:35 +00:00
Aleix Pol
27cc45c8be Remove unused local variable 2021-06-28 01:52:02 +02:00
Andreas Cord-Landwehr
8953e77ec2 Add compatibility code when GLVND is not available
CMake's FindOpenGL internally handles EGL only correctly when GLVND is
available. This might not the case on embedded systems and actually it
is not necessary when EGL::EGL is found.

BUG: 438444
2021-06-24 20:11:44 +00:00
Alexander Lohnau
784f530af5 KF5PlasmaMacros: Only include ECM manually if config vars are missing 2021-06-22 13:11:13 +00:00
David Edmundson
b2f821ad21 [Calendar] Store plugin manager as QPointer
EventPluginsManager is created externally and managed by QML. We cannot
assume the lifespan outlives our Calendar class.

BUG: 385011
2021-06-22 03:27:11 +00:00
David Redondo
3e006a0c42 Connect to global shortcut changes
The intent behind this code seemingly was that KGlobalAccel would
update the shortcut of the QAction but that is not the case. This
leads to our config going out of sync when global shortcuts are
changed from the oustide (the kcm) and resetting on next start
since we set shortcuts with NoAutoLoading.
BUG:438662
FIXED-IN:5.84
2021-06-20 08:01:53 +00:00
l10n daemon script
03c3df109a SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2021-06-20 01:17:58 +00:00
Alexander Lohnau
8df168592b package structures: Use K_PLUGIN_CLASS_WITH_JSON directly
Task: https://phabricator.kde.org/T14542
2021-06-19 16:53:14 +00:00
Alexander Lohnau
3063e43abd dataengine examples: Use K_PLUGIN_CLASS_WITH_JSON directly
Task: https://phabricator.kde.org/T14542
2021-06-19 16:53:14 +00:00
Alexander Lohnau
094f82f9b4 templates: Use K_PLUGIN_CLASS_WITH_JSON directly
Task: https://phabricator.kde.org/T14542
2021-06-19 16:53:14 +00:00
l10n daemon script
3c84e6ae81 GIT_SILENT Upgrade ECM and KF version requirements for 5.84.0 release. 2021-06-19 16:04:14 +00:00
Aleix Pol
b0f8bff4ca SvgRectsCache: do not query elements twice
I was looking into why there is so much time spent here for the logout
greeter that only has buttons. It seems like we were querying the cache
file every time even though we already have separate code that checks
whether our information is valid.

As I started looking into it, ::loadImageFromCache was %25 of the CPU
time. After this patch it's short of 1%.
2021-06-19 02:57:52 +02:00
Alexander Lohnau
44a8e6c1ee Remove unneeded K_EXPORT_PLUGIN_VERSION macro usage 2021-06-14 19:54:40 +00:00
Alexander Lohnau
b63335d10a pluginloader: Remove deprecated version checks
Task: https://phabricator.kde.org/T14302

The explicit version checks are not needed anymore, the plugins are
installed into a specific namespace for each major version. Also the
plasma-frameworks API is stable during the lifetime of a major version.
2021-06-14 19:54:40 +00:00
Adriaan de Groot
a81a78becd CMake: do not expand variables beforehand
In **general**, variables in `if()` commands should not be expanded
"by hand" before use, because substitution occurs before the `if()`
command is parsed: in practice that means that a command like

	if(${A} STREQUAL "A")

can expand to (depending on the value of A being empty, "B" or "A")

	if( STREQUAL "A")
	if(B STREQUAL "A")
	if(A STREQUAL "A")

Then the `if()` command is processed, leading to:

 - a syntax error
 - comparing the value of variable B against string "A"
 - comparing the value of variable A (it's "A" because that
   is what `${A}` expanded to) against string "A"

This is explained in section *Variable Expansion* of the documentation
of the `if()` command, but keeps tripping people up.
2021-06-14 14:47:53 +00:00
Nate Graham
06747e5924 Add KF6 TODO to investigate setting focusPolicy: Qt.TabFocus by default
GIT_SILENT
2021-06-14 08:04:23 -06:00
Marco Martin
19c8c7dc2e fix graphics of tooltips
* proper margins for shadows
* use solid instead of opaque, which is pixelated

BUG:438121
2021-06-14 08:58:40 +00:00
Ismael Asensio
7b726cffb4 [DaysCalendar] Port to new Connections syntax 2021-06-13 00:26:06 +02:00
l10n daemon script
2c6c29064d GIT_SILENT Upgrade KF version to 5.84.0. 2021-06-12 19:37:49 +00:00
Aleix Pol
b93b75d79b theme -> PlasmaCore.Theme 2021-06-11 17:26:14 +02:00
Alexander Lohnau
e54f5b793e Remove defunct test dataengine
The K_EXPORT_PLASMA_DATAENGINE_WITH_JSON expects a JSON file. But
considering that nobody complained about this and it has been broken for
years we can get rid of it.
2021-06-11 09:39:23 +00:00
Alexander Lohnau
6e53dcc2d2
KF5PlasmaMacros: Only try to install desktop files if they exist
The mechanism was used to make those files accessible to
KServiceTypeTrader, but that is not used anymore by KPackage.

KPackage can already handle JSON files for all its functionality,
consequently there is no reason to enforce having desktop files.
2021-06-08 21:46:43 +02:00
Kai Uwe Broulik
6b932130a2 Revert "Fix Label having non-integer sizes"
It messes with QtQuick Layouts in various ways and experience from
PlasmaComponents 2 has shown that giving `Label` any kind of explicit
size is just asking for trouble.

This reverts commit a4e4156a47.
2021-06-05 21:15:16 +00:00
l10n daemon script
33eb00127a GIT_SILENT Upgrade ECM and KF version requirements for 5.83.0 release. 2021-06-05 09:01:25 +00:00
Carl Schwan
c1517f728e Fix crash when there is already exactly 5 events displayed
And simplify code:
* Add constant for the max number of events that can be displayed at the
same time
* Use std::min to simplify a bit the code
* Rename nextIndex to addedEventCount
2021-06-03 15:32:20 +02:00
Ahmad Samir
6ca69fb7ca Clean up some cmake code
GIT_SILENT
2021-06-01 23:20:03 +02:00
Nicolas Fella
0889def484 Remove call to setClearBeforeRendering
It's on by default and the method is gone in Qt6
2021-06-01 09:29:29 +00:00
Ömer Fadıl Usta
acdb1eef51 Fix missing definition of HAVE_X11 2021-06-01 00:38:49 +00:00
Ahmad Samir
661c652e65 Fix FreeBSD build on the CI
GIT_SILENT
2021-06-01 00:19:51 +02:00
Ahmad Samir
a70957d96c Fix build with CMake 3.16
Use FindOpenGL from CMake upstream which finds both OpenGL and EGL.

Fix linking by using OpenGL::GLX (instead of ${OPENGL_gl_LIBRARY} which is
set to an empty string when GLVND is used). Thanks to Ömer Fadıl Usta for
mentioning that in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/264

NO_CHANGELOG
2021-05-31 22:21:11 +02:00
Ahmad Samir
606144182c Remove CMAKE_AUTOMOC_RELAXED_MODE, deprecated since CMake 3.15
NO_CHANGELOG
2021-05-31 17:28:38 +02:00
Ahmad Samir
38d24bfac0 Bump required CMake version to 3.16
KF6 task: https://phabricator.kde.org/T14467

Bump cmake_minimum_required to 3.16 in templates too.
2021-05-31 17:28:31 +02:00