Commit Graph

274 Commits

Author SHA1 Message Date
Aaron J. Seigo
adbf92d5dc disconnect before deleting; we don't want to get informed of any changes from this point forward.
perhaps the cause of the "crash on lock" bug?
CCBUG:166802

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=833582
2008-07-17 05:56:52 +00:00
Aaron J. Seigo
92c7ffc9df * a const fix
* BIG WARNINGS TO AVOID FUTURE ERRORS

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=833500
2008-07-16 21:58:36 +00:00
Aaron J. Seigo
9fa78a4688 thought i committed this yesterday; apparently not.. safer handle clearing.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=833352
2008-07-16 17:51:58 +00:00
Alex Merry
cffda2ec3f Clear handles when we go immutable. Also remove an out-of-date TODO.
BUG: 166004

CCMAIL: panel-devel@kde.org
Should be backported.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=832059
2008-07-14 00:22:11 +00:00
Aaron J. Seigo
f81134ff97 correct save point for applets; now they don't get saved with a 0,0,0,0,0,1 matrix
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=830604
2008-07-10 20:20:37 +00:00
Aaron J. Seigo
6d5e0b18f5 fix various handle regressions, including:
* move applet or resize it then move with handle and it pops to a new location
* handles unhover too soon
* handles don't show on the correct side always
* handles are not visually associated well enough with the target applet
* icons are hard to see
BUG:166149

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=830264
2008-07-10 01:35:51 +00:00
Aaron J. Seigo
0e5f15dc50 * add Corona::addContainmentDelayed for more control on the Corona subclass side during default layout loading
* accept bad config objectsin Applet::save and Containment::save
* move some initialization code around to be more robust with external use (will make more sense in next commit to workspace/plasma/plasma)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828940
2008-07-07 02:16:08 +00:00
Aaron J. Seigo
9ccc9336a5 * prevent removing active containments (brute force mechanism: just ignore the request totally)
* select the correct containment for removal when zoomed out (will have isses on multi-screen; see FIXME)
* move containment destruction logic out of Corona; it really doesn't belong there
* remove the hack to not set focus on a containment when clicked as that doesn't seem to reliably trigger it for me here and it doesn't address the issue of a new containment still messing things up, so we really ought to have a generic solution instead of a slightly ugly hack

BUG:id=165670

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828906
2008-07-06 22:43:53 +00:00
Aaron J. Seigo
762be363ec rework the toolbox creation, containment type setting and isContainment setting code to make it resilient against when and where those properties are set
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828636
2008-07-06 10:03:10 +00:00
Aaron J. Seigo
6230340508 allow for customized panels; we only touch them for geometry management and nothing else
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828634
2008-07-06 09:49:23 +00:00
Aaron J. Seigo
be453f062b type and version setting so qstyleoption_cast works
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828146
2008-07-04 19:24:45 +00:00
Aaron J. Seigo
9e8629645a always connect the toolbox toggle signal to the containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=828085
2008-07-04 16:45:34 +00:00
Aaron J. Seigo
92ee66d578 be extra sure that the applet has an entry in the config on being added so when we config sync we're guaranteed they are in there
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=827479
2008-07-03 05:46:25 +00:00
Marijn Kruisselbrink
21b148b963 change all ClassName::Private classes to ClassNamePrivate, and adjust friends accordingly; this makes plasma compilable with gcc < 4.2
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826893
2008-07-01 18:56:43 +00:00
Aaron J. Seigo
5a7eaf2ca9 consintency in action naming, spotted by Richard Moore
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826881
2008-07-01 18:23:39 +00:00
Aaron J. Seigo
09dcefccf8 add the zoom actions to all non-panel containments, but only add them to the toolbox by default for desktop containments
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=826349
2008-06-30 14:41:31 +00:00
Aaron J. Seigo
bd4c5669a8 respect immutability on panel creation; there's no way to add panels at runtime anymore, but at least this way the locking is respected if somehow one manages to do so.
BUG:165139

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=825672
2008-06-28 23:50:43 +00:00
Aaron J. Seigo
8a974f0f46 small changes that make the code more readable
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=823769
2008-06-24 03:16:33 +00:00
Aaron J. Seigo
b114545f24 don't accept drops hovered not right on us (how silly is it to have graphicsitems transparent to rejected drops?!)
BUG:164469

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=823313
2008-06-23 00:13:03 +00:00
Aaron J. Seigo
aa733dd6ee support multiple drag from applet browser and multiple drop on containment
someone went to all the trouble to make the pixmap painting cute for the multiple situation, but didn't do the actual drag bit =P
BUG:164342

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821594
2008-06-17 22:20:14 +00:00
Aaron J. Seigo
9e1a1a0ed3 emit appletRemoved when moving an applet, too.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821589
2008-06-17 21:54:43 +00:00
Aaron J. Seigo
659844e273 use the caching (!), don't crash if we get a 0 widget parameter
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821186
2008-06-16 19:10:38 +00:00
Aaron J. Seigo
5c360d7651 just to prove that this doesn't make it any closer. i do like the window affinity though
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=821059
2008-06-16 09:01:26 +00:00
Aaron J. Seigo
738d0547a6 * be careful with contents of action lists and guard against null ptrs
* start/stop accepting drops altogether on immutability changes; this makes it a bit more difficult (though not completely impossible) for containment plugins to Get It Wrong

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820251
2008-06-13 16:51:25 +00:00
Aaron J. Seigo
bdb635e3a8 don't accept drops that we don't understand or when we are immutable
CCBUG:163908

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820230
2008-06-13 16:21:59 +00:00
Aaron J. Seigo
2157ab1356 geometry, not boundingRect. fixes the other remaining cause of looping when arranging multiple containments
BUG:163477

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=820061
2008-06-13 05:23:02 +00:00
Aaron J. Seigo
f9ac3edde5 get the geometry right
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=818650
2008-06-09 04:09:11 +00:00
Aaron J. Seigo
c9fcf43c43 i wonder if this fixes it; can the reporters test this for me, because it wasn't being triggered here, but i can see how it could be without this patch
CCBUG:163477

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=818638
2008-06-09 03:15:40 +00:00
Aaron J. Seigo
ccadeadaa2 try some slightly smarter arangement concepts
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=817970
2008-06-07 09:34:50 +00:00
Aaron J. Seigo
f1ce0ee124 safety in removing panels, aka "work around the inane requirement to first remove items from the scene before deleting them if they are a QGraphicsWidget and have a layout"
BUG:163205

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816760
2008-06-04 19:04:34 +00:00
Aaron J. Seigo
3d45aae7fb more code clean ups
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816745
2008-06-04 18:20:58 +00:00
Sebastian Sauer
cc80b06826 prevent assert if d->applets is empty and we compiled with debug enabled.
BUG:162742

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=816502
2008-06-04 02:44:54 +00:00
Chani Armitage
2048a57f54 *use standard qkeysequences for zooming
*also keep the ctrl-= for zoom-in so that people with US keyboards don't have to press shift

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=815524
2008-06-02 04:26:54 +00:00
Aaron J. Seigo
40e4b3e88e * global keyboard shortcuts for applets
* move the contents of setGeometry to itemChange and resizeEvent for greater reliability

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=815043
2008-06-01 02:13:53 +00:00
Kevin Ottens
402a4ed8b2 Don't use the same name for this slot than in Applet. Otherwise, the
wrong slot will get called when you remove an applet which also happens
to be a containment (like the analog clock for instance)...
In such a case we were simply leaking the applet, and it was still in
the layout.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812153
2008-05-24 17:13:19 +00:00
Kevin Ottens
c3b5446a59 Since we're randomly changing public API, let's be consistent with Qt
instead. Use ToolBox everywhere, also for internals.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=812019
2008-05-24 12:25:56 +00:00
Aaron J. Seigo
bea0906806 finish yet another 4.1 feature gap: allow the user to select what to do on drop. the text is a bit lame for icon, it should be "link to file" or something similar but that string doesn't seem to be handy and we're in a string freeze =/ at least it works =)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811949
2008-05-24 07:47:20 +00:00
Chani Armitage
e5230a3f3e stop calling it ToolBox - it's Toolbox, and the capitalization inconsistency is driving me nuts :)
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811934
2008-05-24 06:34:08 +00:00
Chani Armitage
88260fabd2 'add activity' action returns
I just realised it was never disabled when plasma is locked, though. haven't yet decided what to do about that.

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811919
2008-05-24 04:34:27 +00:00
Chani Armitage
3dcf445db4 convert the toolbox to use qactions. this makes the toolbox act a bit more reliably, makes some other bugs more annoying, and makes it easier to fix them.
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811914
2008-05-24 01:48:36 +00:00
Marco Martin
bc1688ae41 when the view is not zoomed move the toolbox to avoid the panels
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811374
2008-05-22 20:22:28 +00:00
Aaron J. Seigo
26f7e83a53 give proper control over saving/restoring to the containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811211
2008-05-22 15:53:48 +00:00
Chani Armitage
7f822e8c8c SVN_SILENT: better comment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=811016
2008-05-22 02:23:33 +00:00
Chani Armitage
81985d2b00 clicking an available desktop containment sets the view to that containment
now it's much easier to jump to the activity you want :)

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810614
2008-05-21 06:16:45 +00:00
Marco Martin
4c36d280c9 (hopefully) fixing the positioning of the desktop toolbox
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810501
2008-05-20 21:29:31 +00:00
Chani Armitage
18a50b787d only do containment-style removal if it's *really* a containment
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810132
2008-05-20 04:26:10 +00:00
Chani Armitage
ccde7ded20 replace Panel::remove() with Containment::destroy()
now I can remove some of the ten desktop containments I accumulated :)
oh, and the code is cleaner too, yay!

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=810129
2008-05-20 04:02:36 +00:00
Marco Martin
573f99e978 hides the panel toolbox when the whole desktop is locked
svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809993
2008-05-19 20:49:44 +00:00
Rob Scheepmaker
8b20aab3fb Couple of improvements to applet drag&drop:
* Only move applet to toplevel window when overlapping other plasma views, ignoring other windows and such.
* Drag & drop now works reasonably well when using multiple desktop containments ('activities'), both when
  zoomed in as when zoomed out. Only a couple of issues remaining.
* Containment's addApplet function now cleans up the pointer to the applethandle in the preview containment,
  Avoiding some nasty crashes when moving applets between containments.


svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809841
2008-05-19 16:20:27 +00:00
Chani Armitage
732a7a1d72 opening the desktop toolbox on hover was never going to work perfectly, and would be a bit of a problem for touchscreens (they make the mouse jump instead of moving smoothly) - so it no longer happens.
the toolbox just lights up on hover now, and opens on click. it still closes on the hover leave event, though.
this makes the code a lot less hackish and should produce the least frustrating behaviour possible.
it's also a bit more like the panel cashew behaviour.
BUG:159520

svn path=/trunk/KDE/kdebase/workspace/libs/plasma/; revision=809497
2008-05-19 00:41:41 +00:00