andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove the unreachable checking code

Browse Source 
Motivation:
'length2 == 0' is not reachable because length1 and length2 are same at this point.

Motification:
Removed 'length2 == 0'.

Result:
Cleaner code.
This commit is contained in:
JongYoon Lim 2015-04-30 14:02:32 +09:00 committed by Norman Maurer
parent ad9bec4d9d
commit 05f9593352
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/src/main/java/io/netty/util/AsciiString.java
View File

@ -959,9 +959,7 @@ public final class AsciiString extends ByteString implements CharSequence, Compa
int length2 = cs.length(); int length2 = cs.length();
if (length1 != length2) { if (length1 != length2) {
return false; return false;
} } else if (length1 == 0) {
if (length1 == 0 && length2 == 0) {
return true; // since both are empty strings return true; // since both are empty strings
} }