andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Dereference when calling PooledByteBuf.deallocate()

Browse Source 
Motivation:

We missed to dereference the chunk and tmpNioBuf when calling deallocate(). This means the GC can not collect these as we still hold a reference while have the PooledByteBuf in the recycler stack.

Modifications:

Dereference chunk and tmpNioBuf.

Result:

GC can collect things.
This commit is contained in:
Norman Maurer 2015-04-10 15:46:53 +02:00
parent 675b5641f4
commit 326d57f0c3
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
View File

@ -143,10 +143,14 @@ abstract class PooledByteBuf<T> extends AbstractReferenceCountedByteBuf {
if (handle >= 0) { if (handle >= 0) {
final long handle = this.handle; final long handle = this.handle;
this.handle = -1; this.handle = -1;
memory = null;
boolean sameThread = initThread == Thread.currentThread(); boolean sameThread = initThread == Thread.currentThread();
initThread = null;
chunk.arena.free(chunk, handle, maxLength, sameThread); chunk.arena.free(chunk, handle, maxLength, sameThread);
// Dereference everything so GC can do it's work.
chunk = null;
tmpNioBuf = null;
initThread = null;
memory = null;
recycle(); recycle();
} }
} }