Github Actions dawidd6/action-download-artifact set workflow_conclusion (#11096)
Motivation: Newer versions of dawidd6/action-download-artifact changed the default workflow_conclusion from "completed" to "completed, success" which can result in download failures if the associated job fails, which is expected when tests fail. Modifications: - Explicitly set the workflow_conclusion to "completed" Result: Test failures which result in build failures will still download test data and generate reports after updating dawidd6/action-download-artifact.
This commit is contained in:
parent
163b2b659c
commit
5deaf94bfe
1
.github/workflows/ci-pr-reports.yml
vendored
1
.github/workflows/ci-pr-reports.yml
vendored
@ -19,6 +19,7 @@ jobs:
|
||||
with:
|
||||
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||
workflow: ${{ github.event.workflow_run.workflow_id }}
|
||||
workflow_conclusion: completed
|
||||
commit: ${{ github.event.workflow_run.head_commit.id }}
|
||||
# File location set in ci-pr.yml and must be coordinated.
|
||||
name: test-results-${{ matrix.setup }}
|
||||
|
2
.github/workflows/codeql-analysis.yml
vendored
2
.github/workflows/codeql-analysis.yml
vendored
@ -58,7 +58,7 @@ jobs:
|
||||
with:
|
||||
languages: ${{ matrix.language }}
|
||||
# If you wish to specify custom queries, you can do so here or in a config file.
|
||||
# By default, queries listed here will override any specified in a config file.
|
||||
# By default, queries listed here will override any specified in a config file.
|
||||
# Prefix the list here with "+" to use these queries and those in the config file.
|
||||
# queries: ./path/to/local/query, your-org/your-repo/queries@main
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user