andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Http2FrameLogger should not extend ChannelHandlerAdapter (#9002)

Browse Source 
Motivation:

For what-ever reason Http2FrameLogger did extend ChannelHandlerAdapter but not override any of its methods. We should not extend it at all as it is not a ChannelHandler.

Modifications:

Remove extends

Result:

Less confusing / more correct / clear code.
This commit is contained in:
Norman Maurer 2019-04-02 20:51:11 +02:00 committed by GitHub
parent 6b8a0ed374
commit 6491f359c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java
View File

@ -17,7 +17,6 @@ package io.netty.handler.codec.http2;
import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufUtil; import io.netty.buffer.ByteBufUtil;
import io.netty.channel.ChannelHandlerAdapter;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.logging.LogLevel; import io.netty.handler.logging.LogLevel;
import io.netty.util.internal.UnstableApi; import io.netty.util.internal.UnstableApi;
@ -31,7 +30,7 @@ import static java.util.Objects.requireNonNull;
* Logs HTTP2 frames for debugging purposes. * Logs HTTP2 frames for debugging purposes.
*/ */
@UnstableApi @UnstableApi
public class Http2FrameLogger extends ChannelHandlerAdapter { public class Http2FrameLogger {
public enum Direction { public enum Direction {
INBOUND, INBOUND,