andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

HTTP/2 Warnings Cleanup

Browse Source 
Motiviation:
There are a few spots in the HTTP/2 codec where warnings were generated and can be avoided.

Modifications:
Clean up the cause of the warnings.

Result:
Less warnings.
This commit is contained in:
Scott Mitchell 2015-04-29 11:10:36 -07:00
parent ba0f920fee
commit 694eab76eb
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
View File

@ -1177,13 +1177,12 @@ public class DefaultHttp2Connection implements Http2Connection {
/** /**
* A registry of all stream property keys known by this connection. * A registry of all stream property keys known by this connection.
*/ */
private class PropertyKeyRegistry { private final class PropertyKeyRegistry {
final List<DefaultPropertyKey> keys = new ArrayList<DefaultPropertyKey>(4); final List<DefaultPropertyKey> keys = new ArrayList<DefaultPropertyKey>(4);
/** /**
* Registers a new property key. * Registers a new property key.
*/ */
@SuppressWarnings("unchecked")
DefaultPropertyKey newKey() { DefaultPropertyKey newKey() {
DefaultPropertyKey key = new DefaultPropertyKey(keys.size()); DefaultPropertyKey key = new DefaultPropertyKey(keys.size());
keys.add(key); keys.add(key);

2
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerUpgradeCodec.java
View File

@ -24,13 +24,11 @@ import static io.netty.handler.codec.http2.Http2FrameTypes.SETTINGS;
import static io.netty.util.internal.ObjectUtil.checkNotNull; import static io.netty.util.internal.ObjectUtil.checkNotNull;
import io.netty.buffer.ByteBuf; import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufUtil; import io.netty.buffer.ByteBufUtil;
import io.netty.buffer.Unpooled;
import io.netty.channel.ChannelHandlerContext; import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.base64.Base64; import io.netty.handler.codec.base64.Base64;
import io.netty.handler.codec.http.FullHttpRequest; import io.netty.handler.codec.http.FullHttpRequest;
import io.netty.handler.codec.http.FullHttpResponse; import io.netty.handler.codec.http.FullHttpResponse;
import io.netty.handler.codec.http.HttpServerUpgradeHandler; import io.netty.handler.codec.http.HttpServerUpgradeHandler;
import io.netty.util.ByteString;
import io.netty.util.CharsetUtil; import io.netty.util.CharsetUtil;
import java.nio.CharBuffer; import java.nio.CharBuffer;