andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

SocketGatheringWriteTest increase timeouts

Browse Source 
Motivation:
EpollDomainSocketGatheringWriteTest. testGatheringWriteBig takes on average about 20-25 seconds on the CI servers, but there is a 30 second timeout being applied which leads to what maybe false positive test failures.

Modifications:
- Increase the test timeout to 120 seconds globally and 60 seconds to wait for all writes per test

Result:
Higher timeout for potentially less false positive test failures.
This commit is contained in:
Scott Mitchell 2017-08-11 00:12:21 -07:00
parent d0c43c9e42
commit 8cb5d0fa8c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketGatheringWriteTest.java
View File

@ -47,7 +47,7 @@ import static org.junit.Assert.assertTrue;
public class SocketGatheringWriteTest extends AbstractSocketTest {
@Rule
public final Timeout globalTimeout = new Timeout(60000);
public final Timeout globalTimeout = new Timeout(120000);
private static final Random random = new Random();
static final byte[] data = new byte[1048576];
@ -141,7 +141,7 @@ public class SocketGatheringWriteTest extends AbstractSocketTest {
ChannelFuture cf = cc.writeAndFlush(Unpooled.EMPTY_BUFFER);
assertNotEquals(cc.voidPromise(), cf);
try {
assertTrue(cf.await(30000));
assertTrue(cf.await(60000));
cf.sync();
} catch (Throwable t) {
// TODO: Remove this once we fix this test.