andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Better variable naming / Fixed potential stall

Browse Source
This commit is contained in:
Trustin Lee 2011-03-02 19:58:28 +09:00
parent 4144b43735
commit a5e9f633ef
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/main/java/org/jboss/netty/handler/stream/ChunkedWriteHandler.java
View File

@ -205,16 +205,17 @@ public class ChunkedWriteHandler implements ChannelUpstreamHandler, ChannelDowns
ChunkedInput chunks = (ChunkedInput) m;
Object chunk;
boolean endOfInput;
boolean later;
boolean suspend;
try {
chunk = chunks.nextChunk();
endOfInput = chunks.isEndOfInput();
if (chunk == null) {
chunk = ChannelBuffers.EMPTY_BUFFER;
later = true;
// No need to suspend when reached at the end.
suspend = !endOfInput;
} else {
later = false;
suspend = false;
}
endOfInput = chunks.isEndOfInput();
} catch (Throwable t) {
this.currentEvent = null;
@ -248,9 +249,10 @@ public class ChunkedWriteHandler implements ChannelUpstreamHandler, ChannelDowns
ctx, writeFuture, chunk,
currentEvent.getRemoteAddress());
if (later) {
// ChunkedInput.nextChunk() returned null.
// Let's wait until more chunks arrive.
if (suspend) {
// ChunkedInput.nextChunk() returned null and it has
// not reached at the end of input. Let's wait until
// more chunks arrive.
break;
}
} else {