andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Java 8 migration. Replace Collection.newSetFromMap with ConcurrentHashMap.newKeySet (#8756)

Browse Source 
Motivation:

Simplify code with newer Java API. It also reduce levels of indirection, but I don't
think we can gain any visible performance improvements out of this.

Modifications:

Replace Collection.newSetFromMap(new ConcurrentHashMap()) with ConcurrentHashMap.newKeySet().

Result:

Use Java8 APIs.
This commit is contained in:
Oleksii Kachaiev 2019-01-22 17:41:15 +02:00 committed by Norman Maurer
parent 9d62deeb6f
commit b3500f50a6
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/src/main/java/io/netty/util/ResourceLeakDetector.java
View File

@ -26,7 +26,6 @@ import java.lang.ref.WeakReference;
import java.lang.ref.ReferenceQueue; import java.lang.ref.ReferenceQueue;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet; import java.util.HashSet;
import java.util.Set; import java.util.Set;
import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentHashMap;
@ -164,8 +163,7 @@ public class ResourceLeakDetector<T> {
} }
/** the collection of active resources */ /** the collection of active resources */
private final Set<DefaultResourceLeak<?>> allLeaks = private final Set<DefaultResourceLeak<?>> allLeaks = ConcurrentHashMap.newKeySet();
Collections.newSetFromMap(new ConcurrentHashMap<>());
private final ReferenceQueue<Object> refQueue = new ReferenceQueue<>(); private final ReferenceQueue<Object> refQueue = new ReferenceQueue<>();
private final ConcurrentMap<String, Boolean> reportedLeaks = PlatformDependent.newConcurrentHashMap(); private final ConcurrentMap<String, Boolean> reportedLeaks = PlatformDependent.newConcurrentHashMap();