andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[#1524] Fix resource leak in HttpContentEncoder

Browse Source
This commit is contained in:
Norman Maurer 2013-07-05 06:27:25 +02:00
parent 2bda1b530a
commit d900f8c21d
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
View File

@ -256,7 +256,18 @@ public abstract class HttpContentEncoder extends MessageToMessageCodec<HttpReque
private void cleanup() {
if (encoder != null) {
// Clean-up the previous encoder if not cleaned up correctly.
finishEncode(Unpooled.buffer());
if (encoder.finish()) {
for (;;) {
ByteBuf buf = (ByteBuf) encoder.readOutbound();
if (buf == null) {
break;
}
// Release the buffer
// https://github.com/netty/netty/issues/1524
buf.release();
}
}
encoder = null;
}
}
@ -280,6 +291,10 @@ public abstract class HttpContentEncoder extends MessageToMessageCodec<HttpReque
break;
}
out.writeBytes(buf);
// Need to release the buffer after write it
// See https://github.com/netty/netty/issues/1524
buf.release();
}
}