andreacavalli/netty5
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't set HTTP/2 flow controller ctx to null

Browse Source 
Motivation:

We currently set the flow controller ChannelHandlerContexts to null when the channel becomes inactive. This is bad :)

Modifications:

Just remove that code in Http2ConnectionHandler

Result:

Fixes #4240
This commit is contained in:
nmittler 2015-09-21 16:21:23 -07:00
parent 6241bb059c
commit ec20902613
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
View File

@ -428,8 +428,6 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
// Call super class first, as this may result in decode being called. // Call super class first, as this may result in decode being called.
super.channelInactive(ctx); super.channelInactive(ctx);
if (byteDecoder != null) { if (byteDecoder != null) {
encoder.flowController().channelHandlerContext(null);
decoder.flowController().channelHandlerContext(null);
byteDecoder.channelInactive(ctx); byteDecoder.channelInactive(ctx);
byteDecoder = null; byteDecoder = null;
} }